[FIX] survey_record_generation: unblock survey edition after a line without field #31

Open
vlab wants to merge 1 commits from vlab/fix-allowed-question-ids AGit into 16.0
Owner

When a record creation has a field value line whose field is not chosen yet,
_compute_allowed_question_ids returned instead of moving on to the next
line. The lines computed after it were left without a value, and Odoo raised
Compute method failed to assign ... allowed_question_ids on every onchange
of the survey form, so no field of the survey could be edited or deleted any
more.

Skip to the next line instead, as already done on 18.0 (94d3bd7).

When a record creation has a field value line whose field is not chosen yet, ``_compute_allowed_question_ids`` returned instead of moving on to the next line. The lines computed after it were left without a value, and Odoo raised ``Compute method failed to assign ... allowed_question_ids`` on every onchange of the survey form, so no field of the survey could be edited or deleted any more. Skip to the next line instead, as already done on 18.0 (94d3bd7).
vlab added 1 commit 2026-11-16 15:54:52 +00:00
[FIX] survey_record_generation: unblock survey edition after a line without field
Some checks failed
tests / test (pull_request) Successful in 2m1s
pre-commit / pre-commit (pull_request) Failing after 2m14s
87b42837ec
When a record creation has a field value line whose field is not chosen yet,
``_compute_allowed_question_ids`` returned instead of moving on to the next
line. The lines computed after it were left without a value, and Odoo raised
``Compute method failed to assign ... allowed_question_ids`` on every onchange
of the survey form, so no field of the survey could be edited or deleted any
more.

Skip to the next line instead, as already done on 18.0 (94d3bd7).
Owner

Le fix me convient mais je ne trouve pas le test explicite.

Peut-on reproduire le use case réel d'un point de vue utilisateur qu'on vient corriger ici ?

Le fix me convient mais je ne trouve pas le test explicite. Peut-on reproduire le use case réel d'un point de vue utilisateur qu'on vient corriger ici ?
Some checks failed
tests / test (pull_request) Successful in 2m1s
pre-commit / pre-commit (pull_request) Failing after 2m14s
This pull request has changes conflicting with the target branch.
  • survey_record_generation/tests/test_survey_record_creation.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin refs/pull/31/head:vlab/fix-allowed-question-ids
git checkout vlab/fix-allowed-question-ids
Sign in to join this conversation.
No description provided.