Elabore/partner-tools
8
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Releases Activity

12.0 improve profiles management #4

Merged
stephansainleger merged 28 commits from 12.0-improve_profiles_management into 12.0 2023-06-27 15:31:24 +00:00
Conversation 3 Commits 28 Files Changed 35 +2941 -770
stephansainleger commented 2023-05-02 14:29:24 +00:00 (Migrated from github.com)
Copy Link

Hide the public/position profile useless fields in partner form views.
Hide the public/position profile logic for portal user.

Hide the public/position profile useless fields in partner form views. Hide the public/position profile logic for portal user.
clementelabore (Migrated from github.com) reviewed 2023-06-20 14:05:22 +00:00
partner_profiles/models/res_partner.py
clementelabore (Migrated from github.com) commented 2023-06-20 13:30:31 +00:00
Copy Link

tu vérifie si active = True ou si active = False ?? pourquoi ?

tu vérifie si active = True ou si active = False ?? pourquoi ?
stephansainleger (Migrated from github.com) reviewed 2023-06-20 14:10:53 +00:00
partner_profiles/models/res_partner.py
stephansainleger (Migrated from github.com) commented 2023-06-20 14:10:52 +00:00
Copy Link

C'est une façon certainement maladroite de juste vérifier la présence d'une clef active dans vals, pour détecter s'il y a un changement sur ce champs. Mais en relisant, effectivement, il y a surement une manière plus propre de faire ça..

C'est une façon certainement maladroite de juste vérifier la présence d'une clef `active` dans `vals`, pour détecter s'il y a un changement sur ce champs. Mais en relisant, effectivement, il y a surement une manière plus propre de faire ça..
clementelabore (Migrated from github.com) reviewed 2023-06-20 14:18:26 +00:00
partner_profiles/models/res_partner.py
clementelabore (Migrated from github.com) commented 2023-06-20 14:18:26 +00:00
Copy Link

tu peux ecrire :
if 'active' in vals:

tu peux ecrire : `if 'active' in vals:`
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
admin borisgallet elabore_bot jorisscampucci laetitiadacosta mathieusarrasin mondot stephansainleger
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Elabore/partner-tools#4
No description provided.
Delete Branch "12.0-improve_profiles_management"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?