mondot
0 Followers · 0 Following
  • Joined on 2025-09-15
Repositories Projects Packages Public Activity Starred Repositories
1
7183ff6f54 [IMP] survey_record_generation : add param ignore_if_mandatory_field_is_missing
mondot commented on pull request Elabore/hr-tools#13 2025-11-13 15:38:33 +00:00
16.0-negative-leaves-and-allocation

on pourrait ajouter

mondot commented on pull request Elabore/hr-tools#13 2025-11-13 15:27:59 +00:00
16.0-negative-leaves-and-allocation

Vu ensemble, remaining_leaves_allowing_negative à supprimer.

mondot commented on pull request Elabore/hr-tools#13 2025-11-13 15:27:40 +00:00
16.0-negative-leaves-and-allocation

Vu ensemble : mettre un petit commentaire qui explique que has_valid_allocation n'a plus de sens si on accepte les congés négatifs

mondot commented on pull request Elabore/hr-tools#13 2025-11-13 15:25:55 +00:00
16.0-negative-leaves-and-allocation 
                                    ###########################################
mondot commented on pull request Elabore/hr-tools#13 2025-11-12 16:18:29 +00:00
16.0-negative-leaves-and-allocation

en faisant ça tu mets sous le tapis toute cette condition

mondot suggested changes for Elabore/hr-tools#13 2025-11-12 16:18:29 +00:00
16.0-negative-leaves-and-allocation

Ce qui est rassurant c'est que les tests de hr_holidays passent :)

mondot commented on pull request Elabore/hr-tools#13 2025-11-12 16:18:29 +00:00
16.0-negative-leaves-and-allocation

J'ai du mal à comprendre cette maxi fonction. Je veux bien qu'on voit ça ensemble.

mondot commented on pull request Elabore/hr-tools#13 2025-11-12 16:18:29 +00:00
16.0-negative-leaves-and-allocation

Tu peux ajouter des tests pour ce compute please ?

mondot commented on pull request Elabore/hr-tools#13 2025-11-12 15:55:48 +00:00
16.0-negative-leaves-and-allocation

Coverage de 78% pour hr_leave_type.py, c'est plutôt cool :)

Je te mets des captures d'écran pour voir les parties non couvertes :

<img width="698" alt="image.png" src="attachments/18f41faa-…

mondot merged pull request Elabore/survey-tools#10 2025-11-12 09:18:40 +00:00
[IMP] survey_record_generation : hotfix when creating a record depending on an other existing record
mondot deleted branch survey_record_generation-hotfix-when-updating-existing-record from Elabore/survey-tools 2025-11-12 09:18:40 +00:00
mondot pushed to 16.0 at Elabore/survey-tools 2025-11-12 09:18:40 +00:00
c35bb33284 [IMP] survey_record_generation : hotfix when creating a record depending on an other existing record
mondot created pull request Elabore/survey-tools#10 2025-11-12 09:18:28 +00:00
[IMP] survey_record_generation : hotfix when creating a record depending on an other existing record
c35bb33284 [IMP] survey_record_generation : hotfix when creating a record depending on an other existing record
mondot pushed to 16.0 at Elabore/survey-tools 2025-11-04 09:06:47 +00:00
f709adbcec [IMP] survey_record_generation: feature be able to update existing record
mondot deleted branch survey_record_generation-be-able-to-update-existing-record from Elabore/survey-tools 2025-11-04 09:06:47 +00:00
mondot merged pull request Elabore/survey-tools#9 2025-11-04 09:06:46 +00:00
[IMP] survey_record_generation: feature be able to update existing record