[FIX] survey_record_generation: link to already created record at creation #29

Merged
mondot merged 2 commits from survey_record_generation-fix-other-record-overriding-computed-values into 18.0 2026-10-23 08:54:49 +00:00

2 Commits

Author SHA1 Message Date
3c8976d51b [FIX] survey_record_generation: questions without answer no longer empty fields
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m36s
tests / test (pull_request) Successful in 1m15s
When a question was not displayed (conditional question) or skipped, its
field was still given to create() with a None value. The field was then
emptied instead of keeping its default or computed value.

Since the link to an already created record is given at creation, this
also made sale.subscription.line price_unit equal to 0 when the "free
amount" question was not displayed, instead of the product price.

Fields without value are now left out of the values, which also allows
several conditional questions to fill up the same field (e.g. one list
of amounts per periodicity).

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 18:40:21 +02:00
48381c6869 [FIX] survey_record_generation: link to already created record at creation
A NOT required "other_record" field was always set after the loop with a
write(), even when the linked record was already created. This late write
triggers the recomputation of stored computed fields depending on the
relation, overriding the values answered by the user.

E.g. with subscription_oca, sale.subscription.line price_unit depends on
sale_subscription_id.partner_id/pricelist_id: a free amount typed in a
numerical_box question (33) was replaced by the product price (20) when
the line was linked to its subscription.

Now the relation is given to create() when the linked record already
exists, so that the user's values are protected from recomputation. The
deferred write is kept for records created later.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 18:40:21 +02:00