Elabore/survey-tools
9
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Releases Activity

[ADD] survey_record_generation : migrate from 16 to 18 #17

Merged
mondot merged 3 commits from migration-v18-survey_record_generation into 18.0 2026-03-26 14:20:56 +00:00
Conversation 2 Commits 3 Files Changed 28 +3142
mondot commented 2026-03-24 16:31:27 +00:00
Owner
Copy Link

cf https://elabore.coop/web#id=5925&cids=1&menu_id=198&action=1420&active_id=5890&model=project.task&view_type=form

Voici le récapitulatif des changements effectués :

  ---                                                                                                                                                         
  views/survey_survey_views.xml
                                                                                                                                                              
  - Suppression de <field name="survey_record_creation_field_values_id" invisible="1" /> dans le sous-tree de fixed_value_many2many — v18 validait ce champ 
  dans le mauvais contexte de modèle                                                                                                                          
  - Migration de toute la syntaxe attrs="{'invisible': ...}" vers invisible="..." (syntaxe v17+)
  - Renommage des balises <tree> → <list> dans les vues inline                                                                                                
                                                                                                                                                              
  views/survey_question_views.xml                                                                                                                             
                                                                                                                                                              
  - Migration de tous les attrs vers la syntaxe v18                                                                                                         
  - XPath //field[@name='suggested_answer_ids']/tree → /list
  - Remplacement de active_id par id dans le context du champ — v18 valide que tous les identifiants référencés existent comme champs du modèle               
                                                                                                                                                              
  views/survey_generated_record_views.xml                                                                                                                     
                                                                                                                                                              
  - Renommage <tree> → <list> et view_mode tree → list                                                                                                        
                                                                                                                                                              
  models/survey_record_creation_field_values.py                                                                                                               
   
  - return → continue dans _compute_allowed_question_ids — corrige un bug qui stoppait la boucle entière dès le premier enregistrement sans survey_id

J'ai aussi adapté légèrement les tests (il suffisait de retirer le test sur le champs date de res.partner dans test_all_types_of_question).

cf https://elabore.coop/web#id=5925&cids=1&menu_id=198&action=1420&active_id=5890&model=project.task&view_type=form Voici le récapitulatif des changements effectués : ``` --- views/survey_survey_views.xml - Suppression de <field name="survey_record_creation_field_values_id" invisible="1" /> dans le sous-tree de fixed_value_many2many — v18 validait ce champ dans le mauvais contexte de modèle - Migration de toute la syntaxe attrs="{'invisible': ...}" vers invisible="..." (syntaxe v17+) - Renommage des balises <tree> → <list> dans les vues inline views/survey_question_views.xml - Migration de tous les attrs vers la syntaxe v18 - XPath //field[@name='suggested_answer_ids']/tree → /list - Remplacement de active_id par id dans le context du champ — v18 valide que tous les identifiants référencés existent comme champs du modèle views/survey_generated_record_views.xml - Renommage <tree> → <list> et view_mode tree → list models/survey_record_creation_field_values.py - return → continue dans _compute_allowed_question_ids — corrige un bug qui stoppait la boucle entière dès le premier enregistrement sans survey_id ``` J'ai aussi adapté légèrement les tests (il suffisait de retirer le test sur le champs `date` de res.partner dans `test_all_types_of_question`).
mondot changed target branch from 16.0 to 18.0 2026-03-24 16:33:58 +00:00
mondot added 1 commit 2026-03-24 16:33:58 +00:00
[ADD] survey_record_generation : migrate from 16 to 18 6f663674d2
mondot changed title from migration-v18-survey_record_generation to [ADD] survey_record_generation : migrate from 16 to 18 2026-03-24 16:52:12 +00:00
mondot added 2 commits 2026-03-25 16:56:36 +00:00
[ADD] survey_record_generation : migrate from 16 to 18 6f663674d2
[ADD] survey_record_generation : migrate from 16 to 18
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m30s
Details
94d3bd72b1
mondot added 1 commit 2026-03-25 17:04:43 +00:00
[IMP] survey_record_generation: added _rec_name for some models without name fields
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m39s
Details
8ccf19d01b
mondot added 2 commits 2026-03-25 17:06:06 +00:00
[IMP] survey_record_generation: added _rec_name for some models without name fields
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m39s
Details
8ccf19d01b
[IMP] survey_record_generation: added _rec_name for some models without name fields and corrected use of self in _compute_warning_message
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m33s
Details
4b66618686
mondot added 1 commit 2026-03-26 10:16:25 +00:00
[IMP] survey_record_generation: add default filter on survey id and active user_input for generated records
Some checks failed
pre-commit / pre-commit (pull_request) Failing after 1m32s
Details
0d1866ace3
mondot commented 2026-03-26 10:20:36 +00:00
Author
Owner
Copy Link

TODO, modifs à apporter aussi à la v16 :

  • return → continue dans _compute_allowed_question_ids — corrige un bug qui stoppait la boucle entière dès le premier enregistrement sans survey_id
  • les 2 commits [IMP] de la présente PR
TODO, modifs à apporter aussi à la v16 : - [ ] return → continue dans _compute_allowed_question_ids — corrige un bug qui stoppait la boucle entière dès le premier enregistrement sans survey_id - [ ] les 2 commits [IMP] de la présente PR
stephansainleger approved these changes 2026-03-26 10:20:56 +00:00
mondot merged commit 0d1866ace3 into 18.0 2026-03-26 14:20:56 +00:00
mondot deleted branch migration-v18-survey_record_generation 2026-03-26 14:20:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
stephansainleger
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
admin borisgallet elabore_bot elabore_vps laetitiadacosta mathieusarrasin mondot stephansainleger vlab
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Elabore/survey-tools#17
No description provided.
Delete Branch "migration-v18-survey_record_generation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?