[IMP] survey_record_generation : allow readonly fields for record creation

survey_record_generation/models/survey_record_creation.py

@@ -22,7 +22,7 @@ class SurveyRecordCreation(models.Model):
     )
     field_to_retrieve_existing_records = fields.Many2one(
         "ir.model.fields",
-        domain="[('id', 'in', allowed_field_ids), ('readonly', '=', False)]",
+        domain="[('id', 'in', allowed_field_ids)]",
         ondelete="cascade",
         help="Choose the field you want to use to retrieve the existing record. "
         "WARNING: We update only the first record found.",

survey_record_generation/models/survey_record_creation_field_values.py

@@ -33,10 +33,8 @@ class SurveyRecordCreationFieldValues(models.Model):
 
     field_id = fields.Many2one(
         'ir.model.fields',
-        domain="[('model_id','=',model_id),('readonly','=',False),('ttype','in',['char','selection','text','html','integer','float','date','datetime','many2one','many2many', 'boolean'])]",
-        ondelete="cascade",
-        required=True
-    )
+        domain="[('model_id','=',model_id),('ttype','in',['char','selection','text','html','integer','float','date','datetime','many2one','many2many', 'boolean'])]",
+        ondelete="cascade")
     field_relation = fields.Char(related='field_id.relation')
     field_type = fields.Selection(related="field_id.ttype")
     field_help = fields.Html('Help', compute="_compute_field_help")
@@ -84,7 +82,7 @@ class SurveyRecordCreationFieldValues(models.Model):
         for record_creation_field_values in self:
             if not record_creation_field_values.survey_id or not record_creation_field_values.field_id:
                 record_creation_field_values.allowed_question_ids = None
-                continue
+                return
             question_domain = [('survey_id','=',record_creation_field_values.survey_id.id)]
 
             if record_creation_field_values.field_id.ttype in ['many2one','many2many']:

survey_record_generation/models/survey_user_input.py

@@ -34,9 +34,7 @@ class SurveyUserInput(models.Model):
 
         return action
 
-    def _mark_done(
-        self, ignore_when_res_partner_mandatory_fields_are_missing: bool = False
-    ):
+    def _mark_done(self):
         # generate records
         for user_input in self:
             created_records = {}