[FIX] project_task_portal_form: fix access right error when portal user send support request

change chatter message behaviour when change assignees

project_assignees/__manifest__.py

@@ -78,6 +78,7 @@ This module is maintained by Elabore.
     },
     # always loaded
     "data": [
+        "data/project_assignees_data.xml",
         "views/project_task.xml",
         "views/portal_template.xml",
     ],

project_assignees/data/project_assignees_data.xml

@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <data noupdate="1">
+        <record id="mt_task_assignees" model="mail.message.subtype">
+            <field name="name">Assignees change</field>
+            <field name="res_model">project.task</field>
+            <field name="default" eval="False"/>
+            <field name="description">Assignees changed</field>
+        </record>
+
+        <record id="mt_project_task_assignees" model="mail.message.subtype">
+            <field name="name">Task Assignees Changed</field>
+            <field name="sequence">13</field>
+            <field name="res_model">project.project</field>
+            <field name="default" eval="False"/>
+            <field name="parent_id" eval="ref('mt_task_assignees')"/>
+            <field name="relation_field">project_id</field>
+        </record>
+    </data>
+
+    <!-- Template email user assigned to a task -->
+    <data>
+        <template id="message_user_assigned">
+            <p style="margin: 0px;">
+                <span>Dear <t t-esc="partner_name"/>,</span><br />
+                <span style="margin-top: 8px;">You have been assigned to the <t t-esc="model_description or 'document'"/> <t t-esc="object.name_get()[0][1]"/>.</span>
+            </p>
+            <p style="margin-top: 24px; margin-bottom: 16px;">
+                <a t-att-href="'/mail/view?model=%s&amp;res_id=%s' % (object._name, object.id)" style="background-color:#875A7B; padding: 10px; text-decoration: none; color: #fff; border-radius: 5px;">
+                        View <t t-esc="model_description or 'document'"/>
+                </a>
+            </p>
+        </template>
+    </data>
+</odoo>

project_assignees/i18n/fr.po

@@ -6,8 +6,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 12.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2022-08-25 15:14+0000\n"
+"POT-Creation-Date: 2023-04-12 11:37+0000\n"
-"PO-Revision-Date: 2022-08-25 15:14+0000\n"
+"PO-Revision-Date: 2023-04-12 11:37+0000\n"
 "Last-Translator: <>\n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -18,15 +18,66 @@ msgstr ""
 #. module: project_assignees
 #: model_terms:ir.ui.view,arch_db:project_assignees.portal_my_task_assignees
 msgid "<strong>Other assignees</strong>"
-msgstr "<strong>Autres intervenants</strong>"
+msgstr "<strong>Assigné à</strong>"
+
+#. module: project_assignees
+#: model:mail.message.subtype,name:project_assignees.mt_task_assignees
+msgid "Assignees change"
+msgstr "Changement d'assignation"
+
+#. module: project_assignees
+#: model:mail.message.subtype,description:project_assignees.mt_task_assignees
+msgid "Assignees changed"
+msgstr "Changement d'assignation"
+
+#. module: project_assignees
+#: model_terms:ir.ui.view,arch_db:project_assignees.portal_my_task_assignees
+msgid "Contact"
+msgstr ""
+
+#. module: project_assignees
+#: model_terms:ir.ui.view,arch_db:project_assignees.message_user_assigned
+msgid "Dear"
+msgstr "Cher"
+
+#. module: project_assignees
+#: model:ir.model,name:project_assignees.model_mail_thread
+msgid "Email Thread"
+msgstr "Discussion par courriel"
+
+#. module: project_assignees
+#: model:ir.model,name:project_assignees.model_mail_tracking_value
+msgid "Mail Tracking Value"
+msgstr "Valeur de suivi des courriers"
 
 #. module: project_assignees
 #: model:ir.model.fields,field_description:project_assignees.field_project_task__assignee_ids
 msgid "Other Assignees"
-msgstr "Autres intervenants"
+msgstr "Assigné à"
 
 #. module: project_assignees
 #: model:ir.model,name:project_assignees.model_project_task
 msgid "Task"
 msgstr "Tâche"
 
+#. module: project_assignees
+#: model:mail.message.subtype,name:project_assignees.mt_project_task_assignees
+msgid "Task Assignees Changed"
+msgstr "Changement d'assignation pour la tâche"
+
+#. module: project_assignees
+#: model_terms:ir.ui.view,arch_db:project_assignees.message_user_assigned
+msgid "View"
+msgstr "Vue"
+
+#. module: project_assignees
+#: code:addons/project_assignees/models/project_task.py:57
+#, python-format
+msgid "You have been assigned to %s"
+msgstr ""
+
+#. module: project_assignees
+#: model_terms:ir.ui.view,arch_db:project_assignees.message_user_assigned
+msgid "You have been assigned to the"
+msgstr "Vous avez été assigné à "
+

project_assignees/models/project_task.py

@@ -1,9 +1,106 @@
 
-from odoo import models, fields, _
+from odoo import models, fields, _, api
 
         
+
+
+class MailTracking(models.Model):
+    _inherit = 'mail.tracking.value'
+
+    @api.model
+    def create_tracking_values(self, initial_value, new_value, col_name, col_info, track_sequence):
+        """
+        Track values of assignees changes in chatter
+        """
+        if col_name == 'assignee_ids':
+            values = {'field': col_name, 'field_desc': col_info['string'], 'field_type': col_info['type'], 'track_sequence': track_sequence}
+            if initial_value:
+                values.update({
+                    'old_value_char': ', '.join([i.name for i in initial_value]),                
+                })
+            else:
+                values.update({
+                    'old_value_char': '',
+                })
+            values.update({
+                'new_value_char': ', '.join([i.name for i in new_value])
+            })
+            return values
+        return super(MailTracking, self).create_tracking_values(initial_value, new_value, col_name, col_info, track_sequence)
+
 class Task(models.Model):
     _inherit = "project.task"
 
-    assignee_ids = fields.Many2many('res.users', 'assignee_ids_rel', string='Other Assignees')
+    assignee_ids = fields.Many2many('res.users', 'assignee_ids_rel', string='Other Assignees', track_visibility='change')
 
+    @api.multi
+    def subscribe_and_notify_assignees(self, new_assignee_ids=None):
+        for task in self:
+            # Use assignees on parameter if exists
+            if new_assignee_ids:
+                assignees = self.env['res.users'].browse(new_assignee_ids)
+            else:
+                assignees = task.assignee_ids
+
+            # Subscribe partners
+            partner_ids = [a.partner_id.id for a in assignees]            
+            task.message_subscribe(partner_ids)
+            
+            # Send notification to assignees
+            view = self.env['ir.ui.view'].browse(self.env['ir.model.data'].xmlid_to_res_id('project_assignees.message_user_assigned'))
+            model_description = self.env['ir.model']._get(task._name).display_name
+            
+            for assignee in assignees:
+                values = {
+                    'object': task,
+                    'model_description': model_description,
+                    'partner_name':assignee.name_get()[0][1]
+                }
+                assignation_msg = view.render(values, engine='ir.qweb', minimal_qcontext=True)
+                assignation_msg = self.env['mail.thread']._replace_local_links(assignation_msg)
+
+                
+                task.message_notify(
+                    subject=_('You have been assigned to %s') % task.display_name,
+                    body=assignation_msg,
+                    partner_ids=[(4, assignee.partner_id.id)],
+                    record_name=task.display_name,
+                    notif_layout='mail.mail_notification_light',
+                    model_description=model_description,
+                )
+
+
+
+    @api.multi
+    def write(self, vals):
+        # Notify only new assignees
+        if 'assignee_ids' in vals:
+            new_assignee_ids = vals['assignee_ids'][0][2].copy()               
+            for a in self.assignee_ids:
+                if a.id in new_assignee_ids:
+                    new_assignee_ids.remove(a.id)
+            self.subscribe_and_notify_assignees(new_assignee_ids)
+        
+        result = super(Task, self).write(vals)
+        
+        return result
+    
+    @api.model
+    def create(self, vals):
+        task = super(Task, self).create(vals)
+        task.subscribe_and_notify_assignees()
+        return task
+    
+    
+    @api.multi
+    def _track_subtype(self, init_values):
+        self.ensure_one()
+        # keep notification of new task when creating a new task
+        res = super(Task, self)._track_subtype(init_values)
+        if res == 'project.mt_task_new':
+            return res
+        # if assignees change, notify it
+        if len(init_values) == 1 and 'assignee_ids' in init_values:
+            return 'project_assignees.mt_task_assignees'
+        
+        return super(Task, self)._track_subtype(init_values)

project_average_acceptable_time/README.rst

@@ -0,0 +1,45 @@
+=================
+project_assignees
+=================
+
+Add multiple assignees field to project task
+
+Installation
+============
+
+Use Odoo normal procedure to install add-ons to install
+``project_assignees``.
+
+Known issues / Roadmap
+======================
+
+Bug Tracker
+===========
+
+Bugs are tracked on `our issues website
+<https://github.com/elabore-coop/project-tools/issues>`_. In case of
+trouble, please check there if your issue has already been
+reported. If you spotted it first, help us smashing it by providing a
+detailed and welcomed feedback.
+
+Credits
+=======
+
+Images
+------
+* Elabore: `Icon <https://elabore.coop/web/image/res.company/1/logo?unique=f3db262>`_.
+
+Contributors
+------------
+* Stéphan Sainléger <https://github.com/stephansainleger>
+
+Funders
+-------
+The development of this module has been financially supported by:
+* Elabore (https://elabore.coop)
+
+
+Maintainer
+----------
+
+This module is maintained by Elabore.

project_average_acceptable_time/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-
+
+from . import models, controllers

project_average_acceptable_time/__manifest__.py

@@ -0,0 +1,93 @@
+# Copyright 2022 Stéphan Sainléger (Elabore)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "project_average_acceptable_time",
+    "version": "12.0.1.0.0",
+    "author": "Elabore",
+    "website": "https://github.com/elabore-coop/project-tools",
+    "maintainer": "Clément Thomas",
+    "license": "AGPL-3",
+    "category": "Tools",
+    "summary": "Task validation without customer agreement",
+    "description": """
+   :image: https://img.shields.io/badge/licence-AGPL--3-blue.svg
+   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+   :alt: License: AGPL-3
+=================
+project_average_acceptable_time
+=================
+
+
+
+Installation
+============
+
+Install ``project_average_acceptable_time``, all dependencies will be installed by default.
+
+Known issues / Roadmap
+======================
+
+None yet.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `our issues website
+<https://github.com/elabore-coop/project-tools/issues>`_. In case of
+trouble, please check there if your issue has already been
+reported. If you spotted it first, help us smashing it by providing a
+detailed and welcomed feedback.
+
+Credits
+=======
+
+Images
+------
+
+* Elabore: `Icon <https://elabore.coop/web/image/res.company/1/logo?unique=f3db262>`_.
+
+Contributors
+------------
+
+* Clément Thomas
+
+Funders
+-------
+
+The development of this module has been financially supported by:
+* Elabore (https://elabore.coop)
+
+
+Maintainer
+----------
+This module is maintained by Elabore.
+
+""",
+    # any module necessary for this one to work correctly
+    "depends": [
+        "base",
+        "project",
+        "project_user_default_project"
+    ],
+    "qweb": [
+        # "static/src/xml/*.xml",
+    ],
+    "external_dependencies": {
+        "python": [],
+    },
+    # always loaded
+    "data": [
+        "views/project_project.xml",
+        "views/portal_home_template.xml"
+    ],
+    # only loaded in demonstration mode
+    "demo": [],
+    "js": [],
+    "css": [],
+    "installable": True,
+    # Install this module automatically if all dependency have been previously
+    # and independently installed.  Used for synergetic or glue modules.
+    "auto_install": False,
+    "application": False,
+}

project_average_acceptable_time/controllers/__init__.py

@@ -0,0 +1,2 @@
+
+from . import custom_portal

project_average_acceptable_time/controllers/custom_portal.py

@@ -0,0 +1,21 @@
+# Copyright 2020 Lokavaluto ()
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+from odoo.http import request, route
+from odoo.addons.portal.controllers.portal import CustomerPortal
+
+
+class CustomCustomerPortal(CustomerPortal):
+    @route(["/my/account"], type="http", auth="user", website=True)
+    def account(self, redirect=None, **post):
+        self.OPTIONAL_BILLING_FIELDS.append("average_acceptable_time")
+
+        response = super(CustomCustomerPortal, self).account(redirect, **post)
+        
+        if post and request.httprequest.method == "POST":
+            error, error_message = self.details_form_validate(post)
+            if not error:
+                user = request.env.user
+                if user.default_project_id and post["average_acceptable_time"]:
+                    user.default_project_id.average_acceptable_time = post["average_acceptable_time"]
+                    
+        return response

project_average_acceptable_time/i18n/README

@@ -0,0 +1 @@
+This directory should contain the *.po for Odoo translation.

project_average_acceptable_time/i18n/fr.po

@@ -0,0 +1,46 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+#	* project_average_acceptable_time
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2023-03-31 09:33+0000\n"
+"PO-Revision-Date: 2023-03-31 09:33+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: project_average_acceptable_time
+#: model_terms:ir.ui.view,arch_db:project_average_acceptable_time.portal_my_home_average_acceptable_time
+msgid "<b>Average acceptable time</b>:"
+msgstr "<b>Temps moyen acceptable</b>:"
+
+#. module: project_average_acceptable_time
+#: model_terms:ir.ui.view,arch_db:project_average_acceptable_time.portal_my_home_average_acceptable_time
+msgid "Average acceptable time"
+msgstr "Temps moyen acceptable"
+
+#. module: project_average_acceptable_time
+#: model_terms:ir.ui.view,arch_db:project_average_acceptable_time.project_project_view_kanban_inherit_average_acceptable_time
+msgid "<span>Average acceptable time:&amp;nbsp;</span>"
+msgstr "<span>Temps moyen acceptable&amp;nbsp;:&amp;nbsp;</span>"
+
+#. module: project_average_acceptable_time
+#: model:ir.model.fields,field_description:project_average_acceptable_time.field_project_project__average_acceptable_time
+msgid "Average acceptable time"
+msgstr "Temps moyen acceptable"
+
+#. module: project_average_acceptable_time
+#: model_terms:ir.ui.view,arch_db:project_average_acceptable_time.portal_my_details_average_acceptable_time
+msgid "Average acceptable time (h)"
+msgstr "Temps moyen acceptable (h)"
+
+#. module: project_average_acceptable_time
+#: model:ir.model,name:project_average_acceptable_time.model_project_project
+msgid "Project"
+msgstr "Projet"

project_average_acceptable_time/models/__init__.py

@@ -0,0 +1,2 @@
+
+from . import project_project

project_average_acceptable_time/models/project_project.py

@@ -0,0 +1,10 @@
+
+from odoo import models, fields, _, api
+
+
+class Project(models.Model):
+    _inherit = "project.project"
+
+    average_acceptable_time = fields.Float('Average acceptable time')
+
+    

project_average_acceptable_time/views/portal_home_template.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <!-- Template /my/home -->
+    <template id="portal_my_home_average_acceptable_time" name="Portal My Home: Average acceptable time" inherit_id="portal.portal_layout" priority="40">
+        <xpath expr="//div[hasclass('o_portal_my_details')]" position="inside">
+            <hr class="mt-1 mb-0"/>
+            <b>Average acceptable time</b>: <t t-esc="user_id.default_project_id.average_acceptable_time" t-options="{'widget': 'float_time'}"/>
+        </xpath>
+    </template>
+
+    <!-- Template /my/account -->
+    <template id="portal_my_details_average_acceptable_time" name="Portal My details: Average acceptable time" inherit_id="portal.portal_my_details">
+        <xpath expr="//input[@name='redirect']" position="before">
+            <div t-attf-class="form-group #{error.get('average_acceptable_time') and 'o_has_error' or ''} col-xl-6">
+                <label class="col-form-label" for="average_acceptable_time">Average acceptable time (h)</label>
+                <input 
+                    type="text" 
+                    name="average_acceptable_time" 
+                    t-attf-class="form-control #{error.get('average_acceptable_time') and 'is-invalid' or ''}" 
+                    t-att-value="average_acceptable_time or user_id.default_project_id.average_acceptable_time" 
+                    t-options="{'widget': 'float_time'}"
+                    />
+            </div>
+        </xpath>
+    </template>
+</odoo>

project_average_acceptable_time/views/project_project.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+
+    <!--Project KANBAN -->
+   <record id="project_project_view_kanban_inherit_average_acceptable_time" model="ir.ui.view">
+        <field name="name">project.project.kanban.inherit.average.acceptable.time</field>
+        <field name="model">project.project</field>
+        <field name="inherit_id" ref="project.view_project_kanban"/>
+        <field name="priority">999</field>
+        <field name="arch" type="xml">
+            <xpath expr="//div[@class='o_project_kanban_main']" position="inside">
+                <div class="o_project_kanban_boxes">
+                    <span>Average acceptable time:<![CDATA[&nbsp;]]></span>
+                    <field name="average_acceptable_time" widget="float_time"/>
+                </div>
+            </xpath>
+        </field>
+    </record>
+
+    <!-- Project FORM -->
+    <record id="project_project_form_inherit_average_acceptable_time" model="ir.ui.view">
+        <field name="name">project.project.form.inherit.average.acceptable.time</field>
+        <field name="model">project.project</field>
+        <field name="inherit_id" ref="project.edit_project"/>
+        <field name="arch" type="xml">
+            <field name="subtask_project_id" position="after">
+                <field name="average_acceptable_time" widget="float_time"/>
+            </field>
+        </field>
+    </record>
+</odoo>

project_task_portal_form/controllers/portal_task_creation.py

@@ -84,12 +84,7 @@ class PortalTaskCreation(CustomerPortal):
         if values.get("bug_report", False):
             description = description + "<br/><br/><b>BUG REPORT:</b><br/>" + values["bug_report"]
         values["description"] = description
-        values["attachments"] = []
+        values["attachments"] = request.httprequest.files.getlist("attachment")        
-        for field_name, field_value in request.params.items():
-            # If the value of the field if a file
-            if field_name == 'attachment' and field_value != "":
-                field_value.field_name = field_name
-                values["attachments"].append(field_value)
         return values
 
     @http.route(
@@ -105,10 +100,10 @@ class PortalTaskCreation(CustomerPortal):
         values = self._compute_form_data(kwargs)
         values["project_id"] = user.default_project_id.id
         values["partner_id"] = user.partner_id.id
-        values["user_id"] = None
+        values["user_id"] = user.id
 
         # Create task
-        task_id = request.env["project.task"].create(values)
+        task_id = request.env["project.task"].sudo().create(values) #use sudo to avoid access error on resource calendar when user_id is set
 
         # Add attachments
         for file in values.get("attachments", False):

project_task_portal_form/views/portal_task_creation_form.xml

@@ -4,7 +4,16 @@
         <t t-call="portal.portal_layout">
             <!-- <div id="wrap" class="col-lg-6 container"></div> -->
             <t t-set="additional_title">Task creation form</t>
-            <form action="/task/create" method="post" accept-charset="UTF-8" class="s_website_form col-md-12 mt32" data-model_name="project.task" data-force_action="" data-success_page="" enctype="multipart/form-data">
+            <form 
+                action="/task/create" 
+                method="post" 
+                accept-charset="UTF-8" 
+                class="s_website_form col-md-12 mt32" 
+                data-model_name="project.task" 
+                data-force_action="" 
+                data-success_page="" 
+                enctype="multipart/form-data">
+                
                 <div class="oe_structure" id="oe_structure_portal_task_creation_form_1" />
                 <input type="hidden" name="csrf_token" t-att-value="request.csrf_token()" />
                 <div class="row">