[IMP] pre-commit: first run on whole repo

Prepare port of mass_mailing_usability... but no real port for the moment

.copier-answers.yml

@@ -0,0 +1,14 @@
+# Do NOT update manually; changes here will be overwritten by Copier
+_commit: v1.3.6
+_src_path: https://github.com/OCA/oca-addons-repo-template.git
+ci: Travis
+dependency_installation_mode: OCA
+generate_requirements_txt: true
+include_wkhtmltopdf: false
+odoo_version: 14.0
+rebel_module_groups: []
+repo_description: Modules that improve UX sensibly
+repo_name: Odoo Usability modules
+repo_slug: odoo-usability
+travis_apt_packages: []
+travis_apt_sources: []

.editorconfig

@@ -0,0 +1,20 @@
+# Configuration for known file extensions
+[*.{css,js,json,less,md,py,rst,sass,scss,xml,yaml,yml}]
+charset = utf-8
+end_of_line = lf
+indent_size = 4
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.{json,yml,yaml,rst,md}]
+indent_size = 2
+
+# Do not configure editor for libs and autogenerated content
+[{*/static/{lib,src/lib}/**,*/static/description/index.html,*/readme/../README.rst}]
+charset = unset
+end_of_line = unset
+indent_size = unset
+indent_style = unset
+insert_final_newline = false
+trim_trailing_whitespace = false

.eslintrc.yml

@@ -0,0 +1,187 @@
+env:
+  browser: true
+  es6: true
+
+# See https://github.com/OCA/odoo-community.org/issues/37#issuecomment-470686449
+parserOptions:
+  ecmaVersion: 2017
+
+overrides:
+  - files:
+      - "**/*.esm.js"
+    parserOptions:
+      sourceType: module
+
+# Globals available in Odoo that shouldn't produce errorings
+globals:
+  _: readonly
+  $: readonly
+  fuzzy: readonly
+  jQuery: readonly
+  moment: readonly
+  odoo: readonly
+  openerp: readonly
+  owl: readonly
+
+# Styling is handled by Prettier, so we only need to enable AST rules;
+# see https://github.com/OCA/maintainer-quality-tools/pull/618#issuecomment-558576890
+rules:
+  accessor-pairs: warn
+  array-callback-return: warn
+  callback-return: warn
+  capitalized-comments:
+    - warn
+    - always
+    - ignoreConsecutiveComments: true
+      ignoreInlineComments: true
+  complexity:
+    - warn
+    - 15
+  constructor-super: warn
+  dot-notation: warn
+  eqeqeq: warn
+  global-require: warn
+  handle-callback-err: warn
+  id-blacklist: warn
+  id-match: warn
+  init-declarations: error
+  max-depth: warn
+  max-nested-callbacks: warn
+  max-statements-per-line: warn
+  no-alert: warn
+  no-array-constructor: warn
+  no-caller: warn
+  no-case-declarations: warn
+  no-class-assign: warn
+  no-cond-assign: error
+  no-const-assign: error
+  no-constant-condition: warn
+  no-control-regex: warn
+  no-debugger: error
+  no-delete-var: warn
+  no-div-regex: warn
+  no-dupe-args: error
+  no-dupe-class-members: error
+  no-dupe-keys: error
+  no-duplicate-case: error
+  no-duplicate-imports: error
+  no-else-return: warn
+  no-empty-character-class: warn
+  no-empty-function: error
+  no-empty-pattern: error
+  no-empty: warn
+  no-eq-null: error
+  no-eval: error
+  no-ex-assign: error
+  no-extend-native: warn
+  no-extra-bind: warn
+  no-extra-boolean-cast: warn
+  no-extra-label: warn
+  no-fallthrough: warn
+  no-func-assign: error
+  no-global-assign: error
+  no-implicit-coercion:
+    - warn
+    - allow: ["~"]
+  no-implicit-globals: warn
+  no-implied-eval: warn
+  no-inline-comments: warn
+  no-inner-declarations: warn
+  no-invalid-regexp: warn
+  no-irregular-whitespace: warn
+  no-iterator: warn
+  no-label-var: warn
+  no-labels: warn
+  no-lone-blocks: warn
+  no-lonely-if: error
+  no-mixed-requires: error
+  no-multi-str: warn
+  no-native-reassign: error
+  no-negated-condition: warn
+  no-negated-in-lhs: error
+  no-new-func: warn
+  no-new-object: warn
+  no-new-require: warn
+  no-new-symbol: warn
+  no-new-wrappers: warn
+  no-new: warn
+  no-obj-calls: warn
+  no-octal-escape: warn
+  no-octal: warn
+  no-param-reassign: warn
+  no-path-concat: warn
+  no-process-env: warn
+  no-process-exit: warn
+  no-proto: warn
+  no-prototype-builtins: warn
+  no-redeclare: warn
+  no-regex-spaces: warn
+  no-restricted-globals: warn
+  no-restricted-imports: warn
+  no-restricted-modules: warn
+  no-restricted-syntax: warn
+  no-return-assign: error
+  no-script-url: warn
+  no-self-assign: warn
+  no-self-compare: warn
+  no-sequences: warn
+  no-shadow-restricted-names: warn
+  no-shadow: warn
+  no-sparse-arrays: warn
+  no-sync: warn
+  no-this-before-super: warn
+  no-throw-literal: warn
+  no-undef-init: warn
+  no-undef: error
+  no-unmodified-loop-condition: warn
+  no-unneeded-ternary: error
+  no-unreachable: error
+  no-unsafe-finally: error
+  no-unused-expressions: error
+  no-unused-labels: error
+  no-unused-vars: error
+  no-use-before-define: error
+  no-useless-call: warn
+  no-useless-computed-key: warn
+  no-useless-concat: warn
+  no-useless-constructor: warn
+  no-useless-escape: warn
+  no-useless-rename: warn
+  no-void: warn
+  no-with: warn
+  operator-assignment: [error, always]
+  prefer-const: warn
+  radix: warn
+  require-yield: warn
+  sort-imports: warn
+  spaced-comment: [error, always]
+  strict: [error, function]
+  use-isnan: error
+  valid-jsdoc:
+    - warn
+    - prefer:
+        arg: param
+        argument: param
+        augments: extends
+        constructor: class
+        exception: throws
+        func: function
+        method: function
+        prop: property
+        return: returns
+        virtual: abstract
+        yield: yields
+      preferType:
+        array: Array
+        bool: Boolean
+        boolean: Boolean
+        number: Number
+        object: Object
+        str: String
+        string: String
+      requireParamDescription: false
+      requireReturn: false
+      requireReturnDescription: false
+      requireReturnType: false
+  valid-typeof: warn
+  yoda: warn

.flake8

@@ -0,0 +1,12 @@
+[flake8]
+max-line-length = 88
+max-complexity = 16
+# B = bugbear
+# B9 = bugbear opinionated (incl line length)
+select = C,E,F,W,B,B9
+# E203: whitespace before ':' (black behaviour)
+# E501: flake8 line length (covered by bugbear B950)
+# W503: line break before binary operator (black behaviour)
+ignore = E203,E501,W503
+per-file-ignores=
+    __init__.py:F401

.github/workflows/pre-commit.yml

@@ -0,0 +1,20 @@
+name: pre-commit
+
+on:
+  pull_request:
+  push:
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          # The pylint-odoo version we use here does not support python 3.10
+          # https://github.com/OCA/oca-addons-repo-template/issues/80
+          # We also need to pin to an older version of python for older odoo versions
+          # where we are not using black > 21. Older black versions won't work with
+          # Python 3.9.8+, and we can't bump black without reformatting.
+          python-version: "3.9.7"
+      - uses: pre-commit/action@v2.0.0

.github/workflows/stale.yml

@@ -0,0 +1,69 @@
+name: Mark stale issues and pull requests
+
+on:
+  schedule:
+    - cron: "0 12 * * 0"
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Stale PRs and issues policy
+        uses: actions/stale@v4
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          # General settings.
+          ascending: true
+          remove-stale-when-updated: true
+          # Pull Requests settings.
+          # 120+30 day stale policy for PRs
+          # * Except PRs marked as "no stale"
+          days-before-pr-stale: 120
+          days-before-pr-close: 30
+          exempt-pr-labels: "no stale"
+          stale-pr-label: "stale"
+          stale-pr-message: >
+            There hasn't been any activity on this pull request in the past 4 months, so
+            it has been marked as stale and it will be closed automatically if no
+            further activity occurs in the next 30 days.
+
+            If you want this PR to never become stale, please ask a PSC member to apply
+            the "no stale" label.
+          # Issues settings.
+          # 180+30 day stale policy for open issues
+          # * Except Issues marked as "no stale"
+          days-before-issue-stale: 180
+          days-before-issue-close: 30
+          exempt-issue-labels: "no stale,needs more information"
+          stale-issue-label: "stale"
+          stale-issue-message: >
+            There hasn't been any activity on this issue in the past 6 months, so it has
+            been marked as stale and it will be closed automatically if no further
+            activity occurs in the next 30 days.
+
+            If you want this issue to never become stale, please ask a PSC member to
+            apply the "no stale" label.
+
+      # 15+30 day stale policy for issues pending more information
+      # * Issues that are pending more information
+      # * Except Issues marked as "no stale"
+      - name: Needs more information stale issues policy
+        uses: actions/stale@v4
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          ascending: true
+          only-labels: "needs more information"
+          exempt-issue-labels: "no stale"
+          days-before-stale: 15
+          days-before-close: 30
+          days-before-pr-stale: -1
+          days-before-pr-close: -1
+          remove-stale-when-updated: true
+          stale-issue-label: "stale"
+          stale-issue-message: >
+            This issue needs more information and there hasn't been any activity
+            recently, so it has been marked as stale and it will be closed automatically
+            if no further activity occurs in the next 30 days.
+
+            If you think this is a mistake, please ask a PSC member to remove the "needs
+            more information" label.

.gitignore

@@ -1,6 +1,8 @@
 # Byte-compiled / optimized / DLL files
 __pycache__/
 *.py[cod]
+/.venv
+/.pytest_cache
 
 # C extensions
 *.so
@@ -21,6 +23,7 @@ var/
 *.egg-info/
 .installed.cfg
 *.egg
+*.eggs
 
 # Installer logs
 pip-log.txt
@@ -40,6 +43,19 @@ coverage.xml
 # Pycharm
 .idea
 
+# Eclipse
+.settings
+
+# Visual Studio cache/options directory
+.vs/
+.vscode
+
+# OSX Files
+.DS_Store
+
+# Django stuff:
+*.log
+
 # Mr Developer
 .mr.developer.cfg
 .project
@@ -54,3 +70,6 @@ docs/_build/
 # Backup files
 *~
 *.swp
+
+# OCA rules
+!static/lib/

.isort.cfg

@@ -0,0 +1,13 @@
+[settings]
+; see https://github.com/psf/black
+multi_line_output=3
+include_trailing_comma=True
+force_grid_wrap=0
+combine_as_imports=True
+use_parentheses=True
+line_length=88
+known_odoo=odoo
+known_odoo_addons=odoo.addons
+sections=FUTURE,STDLIB,THIRDPARTY,ODOO,ODOO_ADDONS,FIRSTPARTY,LOCALFOLDER
+default_section=THIRDPARTY
+ensure_newline_before_comments = True

.pre-commit-config.yaml

@@ -0,0 +1,160 @@
+exclude: |
+  (?x)
+  # NOT INSTALLABLE ADDONS
+  ^account_fiscal_position_payable_receivable/|
+  ^account_invoice_margin/|
+  ^account_invoice_update_wizard/|
+  ^company_code/|
+  ^developer_menu/|
+  ^intrastat_product_type/|
+  ^mass_mailing_usability/|
+  ^mrp_average_cost/|
+  ^mrp_no_product_template_menu/|
+  ^mrp_product_tree_default/|
+  ^sale_down_payment/|
+  ^sale_margin_no_onchange/|
+  ^sale_no_configurator_button/|
+  ^sale_quotation_title/|
+  ^service_line_qty_update_base/|
+  ^service_line_qty_update_purchase/|
+  ^service_line_qty_update_sale/|
+  ^stock_no_product_template_menu/|
+  ^stock_user_default_warehouse_base/|
+  ^stock_user_default_warehouse_mrp/|
+  ^stock_user_default_warehouse_purchase/|
+  ^stock_user_default_warehouse_sale/|
+  ^volume_precision/|
+  # END NOT INSTALLABLE ADDONS
+  # Files and folders generated by bots, to avoid loops
+  ^setup/|/static/description/index\.html$|
+  # We don't want to mess with tool-generated files
+  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
+  # Maybe reactivate this when all README files include prettier ignore tags?
+  ^README\.md$|
+  # Library files can have extraneous formatting (even minimized)
+  /static/(src/)?lib/|
+  # Repos using Sphinx to generate docs don't need prettying
+  ^docs/_templates/.*\.html$|
+  # You don't usually want a bot to modify your legal texts
+  (LICENSE.*|COPYING.*)
+default_language_version:
+  python: python3
+  node: "14.13.0"
+repos:
+  - repo: local
+    hooks:
+      # These files are most likely copier diff rejection junks; if found,
+      # review them manually, fix the problem (if needed) and remove them
+      - id: forbidden-files
+        name: forbidden files
+        entry: found forbidden files; remove them
+        language: fail
+        files: "\\.rej$"
+  - repo: https://github.com/oca/maintainer-tools
+    rev: ab1d7f6
+    hooks:
+      # update the NOT INSTALLABLE ADDONS section above
+      - id: oca-update-pre-commit-excluded-addons
+      - id: oca-fix-manifest-website
+        args: ["https://github.com/OCA/odoo-usability"]
+  - repo: https://github.com/myint/autoflake
+    rev: v1.4
+    hooks:
+      - id: autoflake
+        args:
+          - --expand-star-imports
+          - --ignore-init-module-imports
+          - --in-place
+          - --remove-all-unused-imports
+          - --remove-duplicate-keys
+          - --remove-unused-variables
+  - repo: https://github.com/psf/black
+    rev: 20.8b1
+    hooks:
+      - id: black
+  - repo: https://github.com/pre-commit/mirrors-prettier
+    rev: v2.1.2
+    hooks:
+      - id: prettier
+        name: prettier (with plugin-xml)
+        additional_dependencies:
+          - "prettier@2.1.2"
+          - "@prettier/plugin-xml@0.12.0"
+        args:
+          - --plugin=@prettier/plugin-xml
+        files: \.(css|htm|html|js|json|jsx|less|md|scss|toml|ts|xml|yaml|yml)$
+  - repo: https://github.com/pre-commit/mirrors-eslint
+    rev: v7.8.1
+    hooks:
+      - id: eslint
+        verbose: true
+        args:
+          - --color
+          - --fix
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.2.0
+    hooks:
+      - id: trailing-whitespace
+        # exclude autogenerated files
+        exclude: /README\.rst$|\.pot?$
+      - id: end-of-file-fixer
+        # exclude autogenerated files
+        exclude: /README\.rst$|\.pot?$
+      - id: debug-statements
+      - id: fix-encoding-pragma
+        args: ["--remove"]
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-executables-have-shebangs
+      - id: check-merge-conflict
+        # exclude files where underlines are not distinguishable from merge conflicts
+        exclude: /README\.rst$|^docs/.*\.rst$
+      - id: check-symlinks
+      - id: check-xml
+      - id: mixed-line-ending
+        args: ["--fix=lf"]
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v2.7.2
+    hooks:
+      - id: pyupgrade
+        args: ["--keep-percent-format"]
+  - repo: https://github.com/PyCQA/isort
+    rev: 5.5.1
+    hooks:
+      - id: isort
+        name: isort except __init__.py
+        args:
+          - --settings=.
+        exclude: /__init__\.py$
+  - repo: https://github.com/acsone/setuptools-odoo
+    rev: 2.6.0
+    hooks:
+      - id: setuptools-odoo-make-default
+      - id: setuptools-odoo-get-requirements
+        args:
+          - --output
+          - requirements.txt
+          - --header
+          - "# generated from manifests external_dependencies"
+  - repo: https://gitlab.com/PyCQA/flake8
+    rev: 3.8.3
+    hooks:
+      - id: flake8
+        name: flake8
+        additional_dependencies: ["flake8-bugbear==20.1.4"]
+  - repo: https://github.com/PyCQA/pylint
+    rev: pylint-2.5.3
+    hooks:
+      - id: pylint
+        name: pylint with optional checks
+        args:
+          - --rcfile=.pylintrc
+          - --exit-zero
+        verbose: true
+        additional_dependencies: &pylint_deps
+          - pylint-odoo==3.5.0
+      - id: pylint
+        name: pylint with mandatory checks
+        args:
+          - --rcfile=.pylintrc-mandatory
+        additional_dependencies: *pylint_deps

.prettierrc.yml

@@ -0,0 +1,8 @@
+# Defaults for all prettier-supported languages.
+# Prettier will complete this with settings from .editorconfig file.
+bracketSpacing: false
+printWidth: 88
+proseWrap: always
+semi: true
+trailingComma: "es5"
+xmlWhitespaceSensitivity: "strict"

.pylintrc

@@ -0,0 +1,86 @@
+[MASTER]
+load-plugins=pylint_odoo
+score=n
+
+[ODOOLINT]
+readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
+manifest_required_authors=Odoo Community Association (OCA)
+manifest_required_keys=license
+manifest_deprecated_keys=description,active
+license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
+valid_odoo_versions=14.0
+
+[MESSAGES CONTROL]
+disable=all
+
+# This .pylintrc contains optional AND mandatory checks and is meant to be
+# loaded in an IDE to have it check everything, in the hope this will make
+# optional checks more visible to contributors who otherwise never look at a
+# green travis to see optional checks that failed.
+# .pylintrc-mandatory containing only mandatory checks is used the pre-commit
+# config as a blocking check.
+
+enable=anomalous-backslash-in-string,
+    api-one-deprecated,
+    api-one-multi-together,
+    assignment-from-none,
+    attribute-deprecated,
+    class-camelcase,
+    dangerous-default-value,
+    dangerous-view-replace-wo-priority,
+    development-status-allowed,
+    duplicate-id-csv,
+    duplicate-key,
+    duplicate-xml-fields,
+    duplicate-xml-record-id,
+    eval-referenced,
+    eval-used,
+    incoherent-interpreter-exec-perm,
+    license-allowed,
+    manifest-author-string,
+    manifest-deprecated-key,
+    manifest-required-key,
+    method-compute,
+    method-inverse,
+    method-required-super,
+    method-search,
+    openerp-exception-warning,
+    pointless-statement,
+    pointless-string-statement,
+    print-used,
+    redundant-keyword-arg,
+    redundant-modulename-xml,
+    reimported,
+    relative-import,
+    return-in-init,
+    rst-syntax-error,
+    sql-injection,
+    too-few-format-args,
+    translation-field,
+    translation-required,
+    unreachable,
+    use-vim-comment,
+    wrong-tabs-instead-of-spaces,
+    xml-syntax-error,
+    # messages that do not cause the lint step to fail
+    consider-merging-classes-inherited,
+    create-user-wo-reset-password,
+    dangerous-filter-wo-user,
+    deprecated-module,
+    file-not-used,
+    invalid-commit,
+    missing-manifest-dependency,
+    missing-newline-extrafiles,
+    missing-readme,
+    no-utf8-coding-comment,
+    odoo-addons-relative-import,
+    old-api7-method-defined,
+    redefined-builtin,
+    too-complex,
+    unnecessary-utf8-coding-comment
+
+
+[REPORTS]
+msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}
+output-format=colorized
+reports=no

.pylintrc-mandatory

@@ -0,0 +1,62 @@
+[MASTER]
+load-plugins=pylint_odoo
+score=n
+
+[ODOOLINT]
+readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
+manifest_required_authors=Odoo Community Association (OCA)
+manifest_required_keys=license
+manifest_deprecated_keys=description,active
+license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
+valid_odoo_versions=14.0
+
+[MESSAGES CONTROL]
+disable=all
+
+enable=anomalous-backslash-in-string,
+    api-one-deprecated,
+    api-one-multi-together,
+    assignment-from-none,
+    attribute-deprecated,
+    class-camelcase,
+    dangerous-default-value,
+    dangerous-view-replace-wo-priority,
+    development-status-allowed,
+    duplicate-id-csv,
+    duplicate-key,
+    duplicate-xml-fields,
+    duplicate-xml-record-id,
+    eval-referenced,
+    eval-used,
+    incoherent-interpreter-exec-perm,
+    license-allowed,
+    manifest-author-string,
+    manifest-deprecated-key,
+    manifest-required-key,
+    method-compute,
+    method-inverse,
+    method-required-super,
+    method-search,
+    openerp-exception-warning,
+    pointless-statement,
+    pointless-string-statement,
+    print-used,
+    redundant-keyword-arg,
+    redundant-modulename-xml,
+    reimported,
+    relative-import,
+    return-in-init,
+    rst-syntax-error,
+    sql-injection,
+    too-few-format-args,
+    translation-field,
+    translation-required,
+    unreachable,
+    use-vim-comment,
+    wrong-tabs-instead-of-spaces,
+    xml-syntax-error
+
+[REPORTS]
+msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}
+output-format=colorized
+reports=no

.travis.yml

@@ -0,0 +1,41 @@
+language: python
+cache:
+  directories:
+    - $HOME/.cache/pip
+    - $HOME/.cache/pre-commit
+
+python:
+  - "3.6"
+
+addons:
+  postgresql: "9.6"
+  apt:
+    packages:
+      - expect-dev # provides unbuffer utility
+
+stages:
+  - test
+
+jobs:
+  include:
+    - stage: test
+      env:
+        - TESTS=1 ODOO_REPO="odoo/odoo" MAKEPOT="1"
+    - stage: test
+      env:
+        - TESTS=1 ODOO_REPO="OCA/OCB"
+env:
+  global:
+    - VERSION="14.0" TESTS="0" LINT_CHECK="0" MAKEPOT="0"
+
+install:
+  - git clone --depth=1 https://github.com/OCA/maintainer-quality-tools.git
+    ${HOME}/maintainer-quality-tools
+  - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH}
+  - travis_install_nightly
+
+script:
+  - travis_run_tests
+
+after_success:
+  - travis_after_tests_success

LICENSE

@@ -0,0 +1,661 @@
+                    GNU AFFERO GENERAL PUBLIC LICENSE
+                       Version 3, 19 November 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+                            Preamble
+
+  The GNU Affero General Public License is a free, copyleft license for
+software and other kinds of works, specifically designed to ensure
+cooperation with the community in the case of network server software.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+our General Public Licenses are intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  Developers that use our General Public Licenses protect your rights
+with two steps: (1) assert copyright on the software, and (2) offer
+you this License which gives you legal permission to copy, distribute
+and/or modify the software.
+
+  A secondary benefit of defending all users' freedom is that
+improvements made in alternate versions of the program, if they
+receive widespread use, become available for other developers to
+incorporate.  Many developers of free software are heartened and
+encouraged by the resulting cooperation.  However, in the case of
+software used on network servers, this result may fail to come about.
+The GNU General Public License permits making a modified version and
+letting the public access it on a server without ever releasing its
+source code to the public.
+
+  The GNU Affero General Public License is designed specifically to
+ensure that, in such cases, the modified source code becomes available
+to the community.  It requires the operator of a network server to
+provide the source code of the modified version running there to the
+users of that server.  Therefore, public use of a modified version, on
+a publicly accessible server, gives the public access to the source
+code of the modified version.
+
+  An older license, called the Affero General Public License and
+published by Affero, was designed to accomplish similar goals.  This is
+a different license, not a version of the Affero GPL, but Affero has
+released a new version of the Affero GPL which permits relicensing under
+this license.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+                       TERMS AND CONDITIONS
+
+  0. Definitions.
+
+  "This License" refers to version 3 of the GNU Affero General Public License.
+
+  "Copyright" also means copyright-like laws that apply to other kinds of
+works, such as semiconductor masks.
+
+  "The Program" refers to any copyrightable work licensed under this
+License.  Each licensee is addressed as "you".  "Licensees" and
+"recipients" may be individuals or organizations.
+
+  To "modify" a work means to copy from or adapt all or part of the work
+in a fashion requiring copyright permission, other than the making of an
+exact copy.  The resulting work is called a "modified version" of the
+earlier work or a work "based on" the earlier work.
+
+  A "covered work" means either the unmodified Program or a work based
+on the Program.
+
+  To "propagate" a work means to do anything with it that, without
+permission, would make you directly or secondarily liable for
+infringement under applicable copyright law, except executing it on a
+computer or modifying a private copy.  Propagation includes copying,
+distribution (with or without modification), making available to the
+public, and in some countries other activities as well.
+
+  To "convey" a work means any kind of propagation that enables other
+parties to make or receive copies.  Mere interaction with a user through
+a computer network, with no transfer of a copy, is not conveying.
+
+  An interactive user interface displays "Appropriate Legal Notices"
+to the extent that it includes a convenient and prominently visible
+feature that (1) displays an appropriate copyright notice, and (2)
+tells the user that there is no warranty for the work (except to the
+extent that warranties are provided), that licensees may convey the
+work under this License, and how to view a copy of this License.  If
+the interface presents a list of user commands or options, such as a
+menu, a prominent item in the list meets this criterion.
+
+  1. Source Code.
+
+  The "source code" for a work means the preferred form of the work
+for making modifications to it.  "Object code" means any non-source
+form of a work.
+
+  A "Standard Interface" means an interface that either is an official
+standard defined by a recognized standards body, or, in the case of
+interfaces specified for a particular programming language, one that
+is widely used among developers working in that language.
+
+  The "System Libraries" of an executable work include anything, other
+than the work as a whole, that (a) is included in the normal form of
+packaging a Major Component, but which is not part of that Major
+Component, and (b) serves only to enable use of the work with that
+Major Component, or to implement a Standard Interface for which an
+implementation is available to the public in source code form.  A
+"Major Component", in this context, means a major essential component
+(kernel, window system, and so on) of the specific operating system
+(if any) on which the executable work runs, or a compiler used to
+produce the work, or an object code interpreter used to run it.
+
+  The "Corresponding Source" for a work in object code form means all
+the source code needed to generate, install, and (for an executable
+work) run the object code and to modify the work, including scripts to
+control those activities.  However, it does not include the work's
+System Libraries, or general-purpose tools or generally available free
+programs which are used unmodified in performing those activities but
+which are not part of the work.  For example, Corresponding Source
+includes interface definition files associated with source files for
+the work, and the source code for shared libraries and dynamically
+linked subprograms that the work is specifically designed to require,
+such as by intimate data communication or control flow between those
+subprograms and other parts of the work.
+
+  The Corresponding Source need not include anything that users
+can regenerate automatically from other parts of the Corresponding
+Source.
+
+  The Corresponding Source for a work in source code form is that
+same work.
+
+  2. Basic Permissions.
+
+  All rights granted under this License are granted for the term of
+copyright on the Program, and are irrevocable provided the stated
+conditions are met.  This License explicitly affirms your unlimited
+permission to run the unmodified Program.  The output from running a
+covered work is covered by this License only if the output, given its
+content, constitutes a covered work.  This License acknowledges your
+rights of fair use or other equivalent, as provided by copyright law.
+
+  You may make, run and propagate covered works that you do not
+convey, without conditions so long as your license otherwise remains
+in force.  You may convey covered works to others for the sole purpose
+of having them make modifications exclusively for you, or provide you
+with facilities for running those works, provided that you comply with
+the terms of this License in conveying all material for which you do
+not control copyright.  Those thus making or running the covered works
+for you must do so exclusively on your behalf, under your direction
+and control, on terms that prohibit them from making any copies of
+your copyrighted material outside their relationship with you.
+
+  Conveying under any other circumstances is permitted solely under
+the conditions stated below.  Sublicensing is not allowed; section 10
+makes it unnecessary.
+
+  3. Protecting Users' Legal Rights From Anti-Circumvention Law.
+
+  No covered work shall be deemed part of an effective technological
+measure under any applicable law fulfilling obligations under article
+11 of the WIPO copyright treaty adopted on 20 December 1996, or
+similar laws prohibiting or restricting circumvention of such
+measures.
+
+  When you convey a covered work, you waive any legal power to forbid
+circumvention of technological measures to the extent such circumvention
+is effected by exercising rights under this License with respect to
+the covered work, and you disclaim any intention to limit operation or
+modification of the work as a means of enforcing, against the work's
+users, your or third parties' legal rights to forbid circumvention of
+technological measures.
+
+  4. Conveying Verbatim Copies.
+
+  You may convey verbatim copies of the Program's source code as you
+receive it, in any medium, provided that you conspicuously and
+appropriately publish on each copy an appropriate copyright notice;
+keep intact all notices stating that this License and any
+non-permissive terms added in accord with section 7 apply to the code;
+keep intact all notices of the absence of any warranty; and give all
+recipients a copy of this License along with the Program.
+
+  You may charge any price or no price for each copy that you convey,
+and you may offer support or warranty protection for a fee.
+
+  5. Conveying Modified Source Versions.
+
+  You may convey a work based on the Program, or the modifications to
+produce it from the Program, in the form of source code under the
+terms of section 4, provided that you also meet all of these conditions:
+
+    a) The work must carry prominent notices stating that you modified
+    it, and giving a relevant date.
+
+    b) The work must carry prominent notices stating that it is
+    released under this License and any conditions added under section
+    7.  This requirement modifies the requirement in section 4 to
+    "keep intact all notices".
+
+    c) You must license the entire work, as a whole, under this
+    License to anyone who comes into possession of a copy.  This
+    License will therefore apply, along with any applicable section 7
+    additional terms, to the whole of the work, and all its parts,
+    regardless of how they are packaged.  This License gives no
+    permission to license the work in any other way, but it does not
+    invalidate such permission if you have separately received it.
+
+    d) If the work has interactive user interfaces, each must display
+    Appropriate Legal Notices; however, if the Program has interactive
+    interfaces that do not display Appropriate Legal Notices, your
+    work need not make them do so.
+
+  A compilation of a covered work with other separate and independent
+works, which are not by their nature extensions of the covered work,
+and which are not combined with it such as to form a larger program,
+in or on a volume of a storage or distribution medium, is called an
+"aggregate" if the compilation and its resulting copyright are not
+used to limit the access or legal rights of the compilation's users
+beyond what the individual works permit.  Inclusion of a covered work
+in an aggregate does not cause this License to apply to the other
+parts of the aggregate.
+
+  6. Conveying Non-Source Forms.
+
+  You may convey a covered work in object code form under the terms
+of sections 4 and 5, provided that you also convey the
+machine-readable Corresponding Source under the terms of this License,
+in one of these ways:
+
+    a) Convey the object code in, or embodied in, a physical product
+    (including a physical distribution medium), accompanied by the
+    Corresponding Source fixed on a durable physical medium
+    customarily used for software interchange.
+
+    b) Convey the object code in, or embodied in, a physical product
+    (including a physical distribution medium), accompanied by a
+    written offer, valid for at least three years and valid for as
+    long as you offer spare parts or customer support for that product
+    model, to give anyone who possesses the object code either (1) a
+    copy of the Corresponding Source for all the software in the
+    product that is covered by this License, on a durable physical
+    medium customarily used for software interchange, for a price no
+    more than your reasonable cost of physically performing this
+    conveying of source, or (2) access to copy the
+    Corresponding Source from a network server at no charge.
+
+    c) Convey individual copies of the object code with a copy of the
+    written offer to provide the Corresponding Source.  This
+    alternative is allowed only occasionally and noncommercially, and
+    only if you received the object code with such an offer, in accord
+    with subsection 6b.
+
+    d) Convey the object code by offering access from a designated
+    place (gratis or for a charge), and offer equivalent access to the
+    Corresponding Source in the same way through the same place at no
+    further charge.  You need not require recipients to copy the
+    Corresponding Source along with the object code.  If the place to
+    copy the object code is a network server, the Corresponding Source
+    may be on a different server (operated by you or a third party)
+    that supports equivalent copying facilities, provided you maintain
+    clear directions next to the object code saying where to find the
+    Corresponding Source.  Regardless of what server hosts the
+    Corresponding Source, you remain obligated to ensure that it is
+    available for as long as needed to satisfy these requirements.
+
+    e) Convey the object code using peer-to-peer transmission, provided
+    you inform other peers where the object code and Corresponding
+    Source of the work are being offered to the general public at no
+    charge under subsection 6d.
+
+  A separable portion of the object code, whose source code is excluded
+from the Corresponding Source as a System Library, need not be
+included in conveying the object code work.
+
+  A "User Product" is either (1) a "consumer product", which means any
+tangible personal property which is normally used for personal, family,
+or household purposes, or (2) anything designed or sold for incorporation
+into a dwelling.  In determining whether a product is a consumer product,
+doubtful cases shall be resolved in favor of coverage.  For a particular
+product received by a particular user, "normally used" refers to a
+typical or common use of that class of product, regardless of the status
+of the particular user or of the way in which the particular user
+actually uses, or expects or is expected to use, the product.  A product
+is a consumer product regardless of whether the product has substantial
+commercial, industrial or non-consumer uses, unless such uses represent
+the only significant mode of use of the product.
+
+  "Installation Information" for a User Product means any methods,
+procedures, authorization keys, or other information required to install
+and execute modified versions of a covered work in that User Product from
+a modified version of its Corresponding Source.  The information must
+suffice to ensure that the continued functioning of the modified object
+code is in no case prevented or interfered with solely because
+modification has been made.
+
+  If you convey an object code work under this section in, or with, or
+specifically for use in, a User Product, and the conveying occurs as
+part of a transaction in which the right of possession and use of the
+User Product is transferred to the recipient in perpetuity or for a
+fixed term (regardless of how the transaction is characterized), the
+Corresponding Source conveyed under this section must be accompanied
+by the Installation Information.  But this requirement does not apply
+if neither you nor any third party retains the ability to install
+modified object code on the User Product (for example, the work has
+been installed in ROM).
+
+  The requirement to provide Installation Information does not include a
+requirement to continue to provide support service, warranty, or updates
+for a work that has been modified or installed by the recipient, or for
+the User Product in which it has been modified or installed.  Access to a
+network may be denied when the modification itself materially and
+adversely affects the operation of the network or violates the rules and
+protocols for communication across the network.
+
+  Corresponding Source conveyed, and Installation Information provided,
+in accord with this section must be in a format that is publicly
+documented (and with an implementation available to the public in
+source code form), and must require no special password or key for
+unpacking, reading or copying.
+
+  7. Additional Terms.
+
+  "Additional permissions" are terms that supplement the terms of this
+License by making exceptions from one or more of its conditions.
+Additional permissions that are applicable to the entire Program shall
+be treated as though they were included in this License, to the extent
+that they are valid under applicable law.  If additional permissions
+apply only to part of the Program, that part may be used separately
+under those permissions, but the entire Program remains governed by
+this License without regard to the additional permissions.
+
+  When you convey a copy of a covered work, you may at your option
+remove any additional permissions from that copy, or from any part of
+it.  (Additional permissions may be written to require their own
+removal in certain cases when you modify the work.)  You may place
+additional permissions on material, added by you to a covered work,
+for which you have or can give appropriate copyright permission.
+
+  Notwithstanding any other provision of this License, for material you
+add to a covered work, you may (if authorized by the copyright holders of
+that material) supplement the terms of this License with terms:
+
+    a) Disclaiming warranty or limiting liability differently from the
+    terms of sections 15 and 16 of this License; or
+
+    b) Requiring preservation of specified reasonable legal notices or
+    author attributions in that material or in the Appropriate Legal
+    Notices displayed by works containing it; or
+
+    c) Prohibiting misrepresentation of the origin of that material, or
+    requiring that modified versions of such material be marked in
+    reasonable ways as different from the original version; or
+
+    d) Limiting the use for publicity purposes of names of licensors or
+    authors of the material; or
+
+    e) Declining to grant rights under trademark law for use of some
+    trade names, trademarks, or service marks; or
+
+    f) Requiring indemnification of licensors and authors of that
+    material by anyone who conveys the material (or modified versions of
+    it) with contractual assumptions of liability to the recipient, for
+    any liability that these contractual assumptions directly impose on
+    those licensors and authors.
+
+  All other non-permissive additional terms are considered "further
+restrictions" within the meaning of section 10.  If the Program as you
+received it, or any part of it, contains a notice stating that it is
+governed by this License along with a term that is a further
+restriction, you may remove that term.  If a license document contains
+a further restriction but permits relicensing or conveying under this
+License, you may add to a covered work material governed by the terms
+of that license document, provided that the further restriction does
+not survive such relicensing or conveying.
+
+  If you add terms to a covered work in accord with this section, you
+must place, in the relevant source files, a statement of the
+additional terms that apply to those files, or a notice indicating
+where to find the applicable terms.
+
+  Additional terms, permissive or non-permissive, may be stated in the
+form of a separately written license, or stated as exceptions;
+the above requirements apply either way.
+
+  8. Termination.
+
+  You may not propagate or modify a covered work except as expressly
+provided under this License.  Any attempt otherwise to propagate or
+modify it is void, and will automatically terminate your rights under
+this License (including any patent licenses granted under the third
+paragraph of section 11).
+
+  However, if you cease all violation of this License, then your
+license from a particular copyright holder is reinstated (a)
+provisionally, unless and until the copyright holder explicitly and
+finally terminates your license, and (b) permanently, if the copyright
+holder fails to notify you of the violation by some reasonable means
+prior to 60 days after the cessation.
+
+  Moreover, your license from a particular copyright holder is
+reinstated permanently if the copyright holder notifies you of the
+violation by some reasonable means, this is the first time you have
+received notice of violation of this License (for any work) from that
+copyright holder, and you cure the violation prior to 30 days after
+your receipt of the notice.
+
+  Termination of your rights under this section does not terminate the
+licenses of parties who have received copies or rights from you under
+this License.  If your rights have been terminated and not permanently
+reinstated, you do not qualify to receive new licenses for the same
+material under section 10.
+
+  9. Acceptance Not Required for Having Copies.
+
+  You are not required to accept this License in order to receive or
+run a copy of the Program.  Ancillary propagation of a covered work
+occurring solely as a consequence of using peer-to-peer transmission
+to receive a copy likewise does not require acceptance.  However,
+nothing other than this License grants you permission to propagate or
+modify any covered work.  These actions infringe copyright if you do
+not accept this License.  Therefore, by modifying or propagating a
+covered work, you indicate your acceptance of this License to do so.
+
+  10. Automatic Licensing of Downstream Recipients.
+
+  Each time you convey a covered work, the recipient automatically
+receives a license from the original licensors, to run, modify and
+propagate that work, subject to this License.  You are not responsible
+for enforcing compliance by third parties with this License.
+
+  An "entity transaction" is a transaction transferring control of an
+organization, or substantially all assets of one, or subdividing an
+organization, or merging organizations.  If propagation of a covered
+work results from an entity transaction, each party to that
+transaction who receives a copy of the work also receives whatever
+licenses to the work the party's predecessor in interest had or could
+give under the previous paragraph, plus a right to possession of the
+Corresponding Source of the work from the predecessor in interest, if
+the predecessor has it or can get it with reasonable efforts.
+
+  You may not impose any further restrictions on the exercise of the
+rights granted or affirmed under this License.  For example, you may
+not impose a license fee, royalty, or other charge for exercise of
+rights granted under this License, and you may not initiate litigation
+(including a cross-claim or counterclaim in a lawsuit) alleging that
+any patent claim is infringed by making, using, selling, offering for
+sale, or importing the Program or any portion of it.
+
+  11. Patents.
+
+  A "contributor" is a copyright holder who authorizes use under this
+License of the Program or a work on which the Program is based.  The
+work thus licensed is called the contributor's "contributor version".
+
+  A contributor's "essential patent claims" are all patent claims
+owned or controlled by the contributor, whether already acquired or
+hereafter acquired, that would be infringed by some manner, permitted
+by this License, of making, using, or selling its contributor version,
+but do not include claims that would be infringed only as a
+consequence of further modification of the contributor version.  For
+purposes of this definition, "control" includes the right to grant
+patent sublicenses in a manner consistent with the requirements of
+this License.
+
+  Each contributor grants you a non-exclusive, worldwide, royalty-free
+patent license under the contributor's essential patent claims, to
+make, use, sell, offer for sale, import and otherwise run, modify and
+propagate the contents of its contributor version.
+
+  In the following three paragraphs, a "patent license" is any express
+agreement or commitment, however denominated, not to enforce a patent
+(such as an express permission to practice a patent or covenant not to
+sue for patent infringement).  To "grant" such a patent license to a
+party means to make such an agreement or commitment not to enforce a
+patent against the party.
+
+  If you convey a covered work, knowingly relying on a patent license,
+and the Corresponding Source of the work is not available for anyone
+to copy, free of charge and under the terms of this License, through a
+publicly available network server or other readily accessible means,
+then you must either (1) cause the Corresponding Source to be so
+available, or (2) arrange to deprive yourself of the benefit of the
+patent license for this particular work, or (3) arrange, in a manner
+consistent with the requirements of this License, to extend the patent
+license to downstream recipients.  "Knowingly relying" means you have
+actual knowledge that, but for the patent license, your conveying the
+covered work in a country, or your recipient's use of the covered work
+in a country, would infringe one or more identifiable patents in that
+country that you have reason to believe are valid.
+
+  If, pursuant to or in connection with a single transaction or
+arrangement, you convey, or propagate by procuring conveyance of, a
+covered work, and grant a patent license to some of the parties
+receiving the covered work authorizing them to use, propagate, modify
+or convey a specific copy of the covered work, then the patent license
+you grant is automatically extended to all recipients of the covered
+work and works based on it.
+
+  A patent license is "discriminatory" if it does not include within
+the scope of its coverage, prohibits the exercise of, or is
+conditioned on the non-exercise of one or more of the rights that are
+specifically granted under this License.  You may not convey a covered
+work if you are a party to an arrangement with a third party that is
+in the business of distributing software, under which you make payment
+to the third party based on the extent of your activity of conveying
+the work, and under which the third party grants, to any of the
+parties who would receive the covered work from you, a discriminatory
+patent license (a) in connection with copies of the covered work
+conveyed by you (or copies made from those copies), or (b) primarily
+for and in connection with specific products or compilations that
+contain the covered work, unless you entered into that arrangement,
+or that patent license was granted, prior to 28 March 2007.
+
+  Nothing in this License shall be construed as excluding or limiting
+any implied license or other defenses to infringement that may
+otherwise be available to you under applicable patent law.
+
+  12. No Surrender of Others' Freedom.
+
+  If conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot convey a
+covered work so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you may
+not convey it at all.  For example, if you agree to terms that obligate you
+to collect a royalty for further conveying from those to whom you convey
+the Program, the only way you could satisfy both those terms and this
+License would be to refrain entirely from conveying the Program.
+
+  13. Remote Network Interaction; Use with the GNU General Public License.
+
+  Notwithstanding any other provision of this License, if you modify the
+Program, your modified version must prominently offer all users
+interacting with it remotely through a computer network (if your version
+supports such interaction) an opportunity to receive the Corresponding
+Source of your version by providing access to the Corresponding Source
+from a network server at no charge, through some standard or customary
+means of facilitating copying of software.  This Corresponding Source
+shall include the Corresponding Source for any work covered by version 3
+of the GNU General Public License that is incorporated pursuant to the
+following paragraph.
+
+  Notwithstanding any other provision of this License, you have
+permission to link or combine any covered work with a work licensed
+under version 3 of the GNU General Public License into a single
+combined work, and to convey the resulting work.  The terms of this
+License will continue to apply to the part which is the covered work,
+but the work with which it is combined will remain governed by version
+3 of the GNU General Public License.
+
+  14. Revised Versions of this License.
+
+  The Free Software Foundation may publish revised and/or new versions of
+the GNU Affero General Public License from time to time.  Such new versions
+will be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+  Each version is given a distinguishing version number.  If the
+Program specifies that a certain numbered version of the GNU Affero General
+Public License "or any later version" applies to it, you have the
+option of following the terms and conditions either of that numbered
+version or of any later version published by the Free Software
+Foundation.  If the Program does not specify a version number of the
+GNU Affero General Public License, you may choose any version ever published
+by the Free Software Foundation.
+
+  If the Program specifies that a proxy can decide which future
+versions of the GNU Affero General Public License can be used, that proxy's
+public statement of acceptance of a version permanently authorizes you
+to choose that version for the Program.
+
+  Later license versions may give you additional or different
+permissions.  However, no additional obligations are imposed on any
+author or copyright holder as a result of your choosing to follow a
+later version.
+
+  15. Disclaimer of Warranty.
+
+  THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
+APPLICABLE LAW.  EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
+HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
+OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
+THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
+IS WITH YOU.  SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
+ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+  16. Limitation of Liability.
+
+  IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
+THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
+GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
+USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
+DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
+PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
+EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
+SUCH DAMAGES.
+
+  17. Interpretation of Sections 15 and 16.
+
+  If the disclaimer of warranty and limitation of liability provided
+above cannot be given local legal effect according to their terms,
+reviewing courts shall apply local law that most closely approximates
+an absolute waiver of all civil liability in connection with the
+Program, unless a warranty or assumption of liability accompanies a
+copy of the Program in return for a fee.
+
+                     END OF TERMS AND CONDITIONS
+
+            How to Apply These Terms to Your New Programs
+
+  If you develop a new program, and you want it to be of the greatest
+possible use to the public, the best way to achieve this is to make it
+free software which everyone can redistribute and change under these terms.
+
+  To do so, attach the following notices to the program.  It is safest
+to attach them to the start of each source file to most effectively
+state the exclusion of warranty; and each file should have at least
+the "copyright" line and a pointer to where the full notice is found.
+
+    <one line to give the program's name and a brief idea of what it does.>
+    Copyright (C) <year>  <name of author>
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License as published by
+    the Free Software Foundation, either version 3 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+Also add information on how to contact you by electronic and paper mail.
+
+  If your software can interact with users remotely through a computer
+network, you should also make sure that it provides a way for users to
+get its source.  For example, if your program is a web application, its
+interface could display a "Source" link that leads users to an archive
+of the code.  There are many ways you could offer source, and different
+solutions will be better for different programs; see section 13 for the
+specific requirements.
+
+  You should also get your employer (if you work as a programmer) or school,
+if any, to sign a "copyright disclaimer" for the program, if necessary.
+For more information on this, and how to apply and follow the GNU AGPL, see
+<https://www.gnu.org/licenses/>.

README.md

@@ -0,0 +1,36 @@
+[![Runbot Status](https://runbot.odoo-community.org/runbot/badge/flat//14.0.svg)](https://runbot.odoo-community.org/runbot/repo/github-com-oca-odoo-usability-)
+[![Build Status](https://travis-ci.com/OCA/odoo-usability.svg?branch=14.0)](https://travis-ci.com/OCA/odoo-usability)
+[![codecov](https://codecov.io/gh/OCA/odoo-usability/branch/14.0/graph/badge.svg)](https://codecov.io/gh/OCA/odoo-usability)
+[![Translation Status](https://translation.odoo-community.org/widgets/odoo-usability-14-0/-/svg-badge.svg)](https://translation.odoo-community.org/engage/odoo-usability-14-0/?utm_source=widget)
+
+<!-- /!\ do not modify above this line -->
+
+# Odoo Usability modules
+
+Modules that improve UX sensibly
+
+<!-- /!\ do not modify below this line -->
+
+<!-- prettier-ignore-start -->
+
+[//]: # (addons)
+
+This part will be replaced when running the oca-gen-addons-table script from OCA/maintainer-tools.
+
+[//]: # (end addons)
+
+<!-- prettier-ignore-end -->
+
+## Licenses
+
+This repository is licensed under [AGPL-3.0](LICENSE).
+
+However, each module can have a totally different license, as long as they adhere to OCA
+policy. Consult each module's `__manifest__.py` file, which contains a `license` key
+that explains its license.
+
+----
+
+OCA, or the [Odoo Community Association](http://odoo-community.org/), is a nonprofit
+organization whose mission is to support the collaborative development of Odoo features
+and promote its widespread use.

account_banking_payment_transfer_simple/__init__.py

@@ -1 +0,0 @@
-from . import model

account_banking_payment_transfer_simple/__openerp__.py

@@ -1,47 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>).
-#              (C) 2011 - 2013 Therp BV (<http://therp.nl>).
-#              (C) 2014 ACSONE SA/NV (<http://acsone.eu>).
-#
-#    All other contributions are (C) by their respective contributors
-#
-#    All Rights Reserved
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-{
-    'name': 'Account Banking - Payments Transfer Account (simple)',
-    'version': '0.2',
-    'license': 'AGPL-3',
-    'author': "Akretion,Odoo Community Association (OCA)",
-    'website': 'http://www.akretion.com',
-    'category': 'Banking addons',
-    'depends': [
-        'account_banking_payment_export',
-    ],
-    'data': [
-        'view/payment_mode.xml',
-        'workflow/account_payment_workflow.xml',
-    ],
-    'description': '''
-This is a simple equivalent for Odoo v7 of the module *account_banking_payment_transfer* for v8.0.
-
-I developped this module to be able to make some SEPA direct debits / credit transfer with transfer move on Odoo v7, without installing the module account_banking (I can't install account_banking because I used the OCA modules from https://github.com/OCA/bank-statement-reconcile)
-    ''',
-    'installable': True,
-}

account_banking_payment_transfer_simple/model/account_move_line.py

@@ -1,45 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>).
-#              (C) 2011 - 2013 Therp BV (<http://therp.nl>).
-#
-#    All other contributions are (C) by their respective contributors
-#
-#    All Rights Reserved
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm
-
-
-class account_move_line(orm.Model):
-    _inherit = "account.move.line"
-
-    def get_balance(self, cr, uid, ids, context=None):
-        """
-        Return the balance of any set of move lines.
-
-        Not to be confused with the 'balance' field on this model, which
-        returns the account balance that the move line applies to.
-        """
-        total = 0.0
-        if not ids:
-            return total
-        for line in self.read(
-                cr, uid, ids, ['debit', 'credit'], context=context):
-            total += (line['debit'] or 0.0) - (line['credit'] or 0.0)
-        return total

account_banking_payment_transfer_simple/model/account_payment.py

@@ -1,246 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>).
-#              (C) 2011 - 2013 Therp BV (<http://therp.nl>).
-#              (C) 2014 ACSONE SA (<http://acsone.eu>).
-#              (C) 2014 Akretion (www.akretion.com)
-#
-#    All other contributions are (C) by their respective contributors
-#
-#    All Rights Reserved
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm, fields
-from openerp.tools.translate import _
-
-
-class PaymentOrder(orm.Model):
-    _inherit = 'payment.order'
-
-#    @api.multi
-#    def get_partial_reconcile_ids(self):
-#        self.ensure_one()
-#        reconcile_partial_ids = [line.move_line_id.reconcile_partial_id.id
-#                                 for line in self.line_ids if
-#                                 line.move_line_id.reconcile_partial_id.id]
-#        return reconcile_partial_ids
-
-#    @api.one
-#    def get_partial_reconcile_count(self):
-#        self.partial_reconcile_count = len(self.get_partial_reconcile_ids())
-
-    def action_rejected(self, cr, uid, ids, context=None):
-        return True
-
-#    @api.multi
-#    def action_done(self):
-#        for line in self.line_ids:
-#            line.date_done = fields.Date.context_today(self)
-#        self.date_done = fields.Date.context_today(self)
-        # state is written in workflow definition
-#        return True
-
-#    @api.multi
-#    def _get_transfer_move_lines(self):
-#        """
-#        Get the transfer move lines (on the transfer account).
-#        """
-#        res = []
-#        for order in self:
-#            for order_line in order.line_ids:
-#                move_line = order_line.transfer_move_line_id
-#                if move_line:
-#                    res.append(move_line)
-#        return res
-
-#    @api.multi
-#    def get_transfer_move_line_ids(self, *args):
-#        '''Used in the workflow for trigger_expr_id'''
-#        return [move_line.id for move_line in self._get_transfer_move_lines()]
-
-#    @api.multi
-#    def test_done(self):
-#        """
-#        Test if all moves on the transfer account are reconciled.
-#
-#        Called from the workflow to move to the done state when
-#        all transfer move have been reconciled through bank statements.
-#        """
-#        return all([move_line.reconcile_id for move_line in
-#                    self._get_transfer_move_lines()])
-
-#    @api.multi
-#    def test_undo_done(self):
-#        return not self.test_done()
-
-    def _prepare_transfer_move(self, cr, uid, order, context=None):
-        # TODO question : can I use self.mode.xxx in an @api.model ??
-        # It works, but I'm not sure we are supposed to do that !
-        # I didn't want to use api.one to avoid having to
-        # do self._prepare_transfer_move()[0] in action_sent
-        # I prefer to just have to do self._prepare_transfer_move()
-        vals = {
-            'journal_id': order.mode.transfer_journal_id.id,
-            'ref': '%s %s' % (
-                order.payment_order_type[:3].upper(), order.reference)
-            }
-        return vals
-
-    def _prepare_move_line_transfer_account(
-            self, cr, uid, order, amount, move_id, payment_lines, labels,
-            context=None):
-        payment_order_type = order.payment_order_type
-        if len(payment_lines) == 1:
-            partner_id = payment_lines[0].partner_id.id
-            name = _('%s line %s') % (
-                labels[payment_order_type], payment_lines[0].name)
-        else:
-            partner_id = False
-            name = '%s %s' % (
-                labels[payment_order_type], order.reference)
-        vals = {
-            'name': name,
-            'move_id': move_id,
-            'partner_id': partner_id,
-            'account_id': order.mode.transfer_account_id.id,
-            'credit': (payment_order_type == 'payment' and
-                       amount or 0.0),
-            'debit': (payment_order_type == 'debit' and
-                      amount or 0.0),
-            }
-        return vals
-
-    def _prepare_move_line_partner_account(
-            self, cr, uid, line, move_id, labels, context=None):
-        payment_order_type = line.order_id.payment_order_type
-        if line.move_line_id:
-            account_id = line.move_line_id.account_id.id
-        else:
-            if payment_order_type == 'debit':
-                account_id = line.partner_id.property_account_receivable.id
-            else:
-                account_id = line.partner_id.property_account_payable.id
-        vals = {
-            'name': _('%s line %s') % (
-                labels[payment_order_type], line.name),
-            'move_id': move_id,
-            'partner_id': line.partner_id.id,
-            'account_id': account_id,
-            'credit': (payment_order_type == 'debit' and
-                       line.amount or 0.0),
-            'debit': (payment_order_type == 'payment' and
-                      line.amount or 0.0),
-            }
-        return vals
-
-#    @api.model
-#    def action_sent_no_move_line_hook(self, pay_line):
-#        """This function is designed to be inherited"""
-#        return
-
-    def action_done(self, cr, uid, ids, context=None):
-        """
-        Create the moves that pay off the move lines from
-        the debit order. This happens when the debit order file is
-        generated.
-        """
-        am_obj = self.pool['account.move']
-        aml_obj = self.pool['account.move.line']
-        pl_obj = self.pool['payment.line']
-        labels = {
-            'payment': _('Payment order'),
-            'debit': _('Direct debit order'),
-            }
-        for order in self.browse(cr, uid, ids, context=context):
-            if order.mode.transfer_journal_id and order.mode.transfer_account_id:
-                # prepare a dict "trfmoves" that can be used when
-                # self.mode.transfer_move_option = date or line
-                # key = unique identifier (date or True or line.id)
-                # value = [pay_line1, pay_line2, ...]
-                trfmoves = {}
-                if order.mode.transfer_move_option == 'line':
-                    for line in order.line_ids:
-                        trfmoves[line.id] = [line]
-                else:
-                    if order.date_prefered in ('now', 'fixed'):
-                        trfmoves[True] = []
-                        for line in order.line_ids:
-                            trfmoves[True].append(line)
-                    else:  # date_prefered == due
-                        for line in order.line_ids:
-                            if line.date in trfmoves:
-                                trfmoves[line.date].append(line)
-                            else:
-                                trfmoves[line.date] = [line]
-
-                for identifier, lines in trfmoves.iteritems():
-                    mvals = self._prepare_transfer_move(
-                        cr, uid, order, context=context)
-                    move_id = am_obj.create(cr, uid, mvals, context=context)
-                    total_amount = 0
-                    for line in lines:
-                        # TODO: take multicurrency into account
-
-                        # create the payment/debit counterpart move line
-                        # on the partner account
-                        partner_ml_vals = self._prepare_move_line_partner_account(
-                            cr, uid, line, move_id, labels, context=context)
-                        partner_move_line_id = aml_obj.create(
-                            cr, uid, partner_ml_vals, context=context)
-                        total_amount += line.amount
-
-                        # register the payment/debit move line
-                        # on the payment line and call reconciliation on it
-                        line.write({'transit_move_line_id': partner_move_line_id})
-
-                        if line.move_line_id:
-                            pl_obj.debit_reconcile(cr, uid, line.id, context=context)
-                        #else:
-                        #    self.action_sent_no_move_line_hook(line)
-
-                    # create the payment/debit move line on the transfer account
-                    trf_ml_vals = self._prepare_move_line_transfer_account(
-                        cr, uid, order, total_amount, move_id, lines, labels,
-                        context=context)
-                    aml_obj.create(cr, uid, trf_ml_vals, context=context)
-
-                    # post account move
-                    am_obj.post(cr, uid, [move_id], context=context)
-
-            # State field is written by act_sent_wait
-            order.write({'state': 'done'})
-        return True
-
-#    @api.multi
-#    def partial(self):
-#        self.ensure_one()
-#        view_id = self.env.ref('account.view_move_line_tree').id
-#        reconcile_partial_ids = self.get_partial_reconcile_ids()
-#        reconcile_partial_domain = [('reconcile_partial_id', 'in',
-#                                     reconcile_partial_ids)]
-#        return {
-#            'name': _('Partial Reconcile Moves Line'),
-#            'context': self.env.context,
-#            'domain': reconcile_partial_domain,
-#            'view_type': 'form',
-#            'view_mode': 'tree,form',
-#            'res_model': 'account.move.line',
-#            'views': [(view_id, 'tree')],
-#            'type': 'ir.actions.act_window',
-#            'target': 'current',
-#        }

account_banking_payment_transfer_simple/model/payment_line.py

@@ -1,195 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>).
-#              (C) 2011 - 2013 Therp BV (<http://therp.nl>).
-#
-#    All other contributions are (C) by their respective contributors
-#
-#    All Rights Reserved
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm, fields
-from openerp import netsvc
-from openerp.tools.translate import _
-
-
-class PaymentLine(orm.Model):
-    '''
-    Add some fields; make destination bank account
-    mandatory, as it makes no sense to send payments into thin air.
-    Edit: Payments can be by cash too, which is prohibited by mandatory bank
-    accounts.
-    '''
-    _inherit = 'payment.line'
-
-    def _get_transfer_move_line(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        for order_line in self.browse(cr, uid, ids, context=context):
-            if order_line.transit_move_line_id:
-                order_type = order_line.order_id.payment_order_type
-                trf_lines = order_line.transit_move_line_id.move_id.line_id
-                for move_line in trf_lines:
-                    if order_type == 'debit' and move_line.debit > 0:
-                        res[order_line.id] = move_line.id
-                    elif order_type == 'payment' and move_line.credit > 0:
-                        res[order_line.id] = move_line.id
-            else:
-                res[order_line.id] = False
-        return res
-
-    _columns = {
-        'msg': fields.char('Message', size=255, required=False, readonly=True),
-        'date_done': fields.date(
-            'Date Confirmed', select=True, readonly=True),
-        'transit_move_line_id': fields.many2one(
-            'account.move.line', 'Transfer move line',
-            readonly=True,
-            help="Move line through which the payment/debit order "
-                 "pays the invoice",
-            ),
-        'transfer_move_line_id': fields.function(
-            _get_transfer_move_line,
-            type='many2one',
-            relation='account.move.line',
-            string='Transfer move line counterpart',
-            readonly=True,
-            help="Counterpart move line on the transfer account",
-            ),
-        }
-
-    _defaults = {
-        'msg': '',
-        }
-
-    """
-    Hooks for processing direct debit orders, such as implemented in
-    account_direct_debit module.
-    """
-    def get_storno_account_id(self, cr, uid, payment_line_id, amount,
-                              currency_id, context=None):
-        """
-        Hook for verifying a match of the payment line with the amount.
-        Return the account associated with the storno.
-        Used in account_banking interactive mode
-        :param payment_line_id: the single payment line id
-        :param amount: the (signed) amount debited from the bank account
-        :param currency: the bank account's currency *browse object*
-        :return: an account if there is a full match, False otherwise
-        :rtype: database id of an account.account resource.
-        """
-
-        return False
-
-    def debit_storno(self, cr, uid, payment_line_id, amount,
-                     currency_id, storno_retry=True, context=None):
-        """
-        Hook for handling a canceled item of a direct debit order.
-        Presumably called from a bank statement import routine.
-
-        Decide on the direction that the invoice's workflow needs to take.
-        You may optionally return an incomplete reconcile for the caller
-        to reconcile the now void payment.
-
-        :param payment_line_id: the single payment line id
-        :param amount: the (negative) amount debited from the bank account
-        :param currency: the bank account's currency *browse object*
-        :param boolean storno_retry: whether the storno is considered fatal \
-        or not.
-        :return: an incomplete reconcile for the caller to fill
-        :rtype: database id of an account.move.reconcile resource.
-        """
-
-        return False
-
-    def debit_reconcile(self, cr, uid, payment_line_id, context=None):
-        """
-        Reconcile a debit order's payment line with the the move line
-        that it is based on. Called from payment_order.action_sent().
-        As the amount is derived directly from the counterpart move line,
-        we do not expect a write off. Take partial reconciliations into
-        account though.
-
-        :param payment_line_id: the single id of the canceled payment line
-        """
-
-        if isinstance(payment_line_id, (list, tuple)):
-            payment_line_id = payment_line_id[0]
-        reconcile_obj = self.pool.get('account.move.reconcile')
-        move_line_obj = self.pool.get('account.move.line')
-        payment_line = self.browse(cr, uid, payment_line_id, context=context)
-
-        transit_move_line = payment_line.transit_move_line_id
-        torec_move_line = payment_line.move_line_id
-
-        if (not transit_move_line or not torec_move_line):
-            raise orm.except_orm(
-                _('Can not reconcile'),
-                _('No move line for line %s') % payment_line.name
-            )
-        if torec_move_line.reconcile_id:
-            raise orm.except_orm(
-                _('Error'),
-                _('Move line %s has already been reconciled') %
-                torec_move_line.name
-                )
-        if (transit_move_line.reconcile_id or
-                transit_move_line.reconcile_partial_id):
-            raise orm.except_orm(
-                _('Error'),
-                _('Move line %s has already been reconciled') %
-                transit_move_line.name
-            )
-
-        def is_zero(total):
-            return self.pool.get('res.currency').is_zero(
-                cr, uid, transit_move_line.company_id.currency_id, total)
-
-        line_ids = [transit_move_line.id, torec_move_line.id]
-        if torec_move_line.reconcile_partial_id:
-            line_ids = [
-                x.id for x in
-                torec_move_line.reconcile_partial_id.line_partial_ids
-                ] + [transit_move_line.id]
-
-        total = move_line_obj.get_balance(cr, uid, line_ids)
-        vals = {
-            'type': 'auto',
-            'line_id': is_zero(total) and [(6, 0, line_ids)] or [(6, 0, [])],
-            'line_partial_ids': (is_zero(total) and
-                                 [(6, 0, [])] or
-                                 [(6, 0, line_ids)]),
-            }
-
-        if torec_move_line.reconcile_partial_id:
-            reconcile_obj.write(
-                cr, uid, [torec_move_line.reconcile_partial_id.id],
-                vals, context=context)
-        else:
-            reconcile_obj.create(
-                cr, uid, vals, context=context)
-        workflow = netsvc.LocalService("workflow")
-        for line_id in line_ids:
-            workflow.trg_trigger(
-                uid, 'account.move.line', line_id, cr)
-
-        # If a bank transaction of a storno was first confirmed
-        # and now canceled (the invoice is now in state 'debit_denied'
-        if torec_move_line.invoice:
-            workflow.trg_validate(
-                uid, 'account.invoice', torec_move_line.invoice.id,
-                'undo_debit_denied', cr)

account_banking_payment_transfer_simple/model/payment_mode.py

@@ -1,52 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>).
-#              (C) 2011 - 2013 Therp BV (<http://therp.nl>).
-#              (C) 2014 Akretion (www.akretion.com)
-#
-#    All other contributions are (C) by their respective contributors
-#
-#    All Rights Reserved
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm, fields
-
-
-class PaymentMode(orm.Model):
-    _inherit = "payment.mode"
-
-    _columns = {
-        'transfer_account_id': fields.many2one(
-            'account.account', 'Transfer account',
-            domain=[('type', '=', 'other'), ('reconcile', '=', True)],
-            help='Pay off lines in sent orders with a move on this '
-            'account. You can only select accounts of type regular '
-            'that are marked for reconciliation'),
-        'transfer_journal_id': fields.many2one(
-            'account.journal', 'Transfer journal',
-            help='Journal to write payment entries when confirming '
-            'a debit order of this mode'),
-        'transfer_move_option': fields.selection([
-            ('date', 'One move per payment date'),
-            ('line', 'One move per payment line'),
-            ], 'Transfer move option')
-    }
-
-    _defaults = {
-        'transfer_move_option': 'date',
-    }

account_banking_payment_transfer_simple/view/payment_mode.xml

@@ -1,34 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<openerp>
-    <data>
-
-        <!-- 
-             Add the payment mode transfer account settings
-        -->
-        <record id="view_payment_mode_form_inherit" model="ir.ui.view">
-            <field name="name">payment.mode.form.inherit</field>
-            <field name="model">payment.mode</field>
-            <field name="inherit_id" ref="account_banking_payment_export.view_payment_mode_form_inherit"/>
-            <field name="arch" type="xml">
-                <xpath expr="/form/group[@col='4']" position="inside">
-                    <group name="trf-move-config" string="Transfer move settings" colspan="2">
-                        <field name="transfer_account_id"
-                               domain="[('type', '=', 'other'),
-                                       ('reconcile', '=', True),
-                                       ('company_id', '=', company_id)]"
-                               context="{
-                                   'default_type': 'other',
-                                   'default_reconcile': True,
-                                   'default_company_id': company_id}"
-                               />
-                        <field name="transfer_journal_id"
-                               domain="[('company_id', '=', company_id)]"
-                               />
-                        <field name="transfer_move_option"/>
-                    </group>
-                </xpath>
-            </field>
-        </record>
-
-    </data>
-</openerp>

account_banking_payment_transfer_simple/workflow/account_payment_workflow.xml

@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<openerp>
-<data>
-
-<record id="account_payment.act_done" model="workflow.activity">
-    <field name="action">action_done()</field>
-</record>
-
-</data>
-</openerp>

account_fiscal_position_payable_receivable/__init__.py

@@ -0,0 +1 @@
+from . import models

account_fiscal_position_payable_receivable/__manifest__.py

@@ -0,0 +1,23 @@
+# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Account Fiscal Position Payable Receivable",
+    "version": "12.0.1.0.0",
+    "category": "Accounting & Finance",
+    "license": "AGPL-3",
+    "summary": "Configure payable/receivable accounts on fiscal positions",
+    "description": """
+Account Fiscal Position Payable Receivable
+==========================================
+
+This module allows to configure a special *Partner Receivable Account* and a special *Partner Payable Account* on fiscal positions. This is used in the onchange of the fiscal position of partners.
+
+This module has been written by Alexis de Lattre from Akretion <alexis.delattre@akretion.com>.
+    """,
+    "author": "Akretion",
+    "website": "https://github.com/OCA/odoo-usability",
+    "depends": ["account"],
+    "data": ["views/account_fiscal_position_view.xml"],
+    "installable": False,
+}

account_fiscal_position_payable_receivable/models/__init__.py

@@ -0,0 +1,2 @@
+from . import account_fiscal_position
+from . import res_partner

account_fiscal_position_payable_receivable/models/account_fiscal_position.py

@@ -0,0 +1,21 @@
+# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import fields, models
+
+
+class AccountFiscalPosition(models.Model):
+    _inherit = "account.fiscal.position"
+
+    receivable_account_id = fields.Many2one(
+        "account.account",
+        string="Partner Receivable Account",
+        company_dependent=True,
+        domain=[("internal_type", "=", "receivable")],
+    )
+    payable_account_id = fields.Many2one(
+        "account.account",
+        string="Partner Payable Account",
+        company_dependent=True,
+        domain=[("internal_type", "=", "payable")],
+    )

account_fiscal_position_payable_receivable/models/res_partner.py

@@ -0,0 +1,25 @@
+# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, models
+
+
+class ResPartner(models.Model):
+    _inherit = "res.partner"
+
+    @api.onchange("property_account_position_id")
+    def fiscal_position_receivable_payable_change(self):
+        fp = self.property_account_position_id
+        ipo = self.env["ir.property"]
+        if fp.receivable_account_id:
+            self.property_account_receivable_id = fp.receivable_account_id
+        else:
+            self.property_account_receivable_id = ipo.get(
+                "property_account_receivable_id", "res.partner"
+            )
+        if fp.payable_account_id:
+            self.property_account_payable_id = fp.payable_account_id
+        else:
+            self.property_account_payable_id = ipo.get(
+                "property_account_payable_id", "res.partner"
+            )

account_fiscal_position_payable_receivable/views/account_fiscal_position_view.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  © 2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+
+<record id="view_account_position_form" model="ir.ui.view">
+    <field name="name">receivable_payable.fiscal_position_form</field>
+    <field name="model">account.fiscal.position</field>
+    <field name="inherit_id" ref="account.view_account_position_form" />
+    <field name="arch" type="xml">
+        <field name="company_id" position="after">
+            <field name="receivable_account_id" />
+            <field name="payable_account_id" />
+        </field>
+    </field>
+</record>
+
+
+</odoo>

account_invoice_del_attachment_cancel/__init__.py

@@ -1,23 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Del Attachment Cancel module for OpenERP
-#    Copyright (C) 2015 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from . import account_invoice

account_invoice_del_attachment_cancel/__openerp__.py

@@ -1,45 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Del Attachment Cancel module for OpenERP
-#    Copyright (C) 2015 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Invoice Delete Attachment on Cancel',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Delete the attachment on the invoice when it is cancelled',
-    'description': """
-Account Invoice Delete Attachment on Cancel
-===========================================
-
-When an invoice is validated, on the first generation of the invoice report, a copy of the report is stored as attachment on the invoice. After that, every time you a user asks for the Invoice report, it will be taken from the attachment.
-
-With this module, when an invoice is cancelled, the attachment is deleted.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['account'],
-    'data': [],
-    'installable': True,
-}

account_invoice_del_attachment_cancel/account_invoice.py

@@ -1,53 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Del Attachment Cancel module for OpenERP
-#    Copyright (C) 2015 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm
-from openerp.tools.translate import _
-
-
-class AccountInvoice(orm.Model):
-    _inherit = 'account.invoice'
-
-    def action_cancel(self, cr, uid, ids, context=None):
-        res = super(AccountInvoice, self).action_cancel(
-            cr, uid, ids, context=context)
-        iao = self.pool['ir.attachment']
-        for invoice in self.browse(cr, uid, ids, context=context):
-            # search for attachments
-            if 'out' in invoice.type:
-                attach_ids = iao.search(
-                    cr, uid, [
-                        ('res_id', '=', invoice.id),
-                        ('res_model', '=', self._name),
-                        ('type', '=', 'binary'),
-                        ('datas_fname', '=like', 'INV%.pdf'),
-                        ], context=context)
-                if len(attach_ids) == 1:
-                    # delete attachment
-                    attach = iao.browse(
-                        cr, uid, attach_ids[0], context=context)
-                    attach_name = attach.name
-                    iao.unlink(cr, uid, attach_ids, context=context)
-                    self.message_post(
-                        cr, uid, invoice.id,
-                        _('Attachement %s has been deleted') % attach_name)
-        return res

account_invoice_margin/__init__.py

@@ -1,3 +1,2 @@
-# -*- coding: utf-8 -*-
-
 from . import account_invoice
+from . import account_invoice_report

account_invoice_margin/__manifest__.py

@@ -0,0 +1,24 @@
+# Copyright 2015-2019 Akretion France (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Account Invoice Margin",
+    "version": "12.0.1.0.0",
+    "category": "Invoicing Management",
+    "license": "AGPL-3",
+    "summary": "Copy standard price on invoice line and compute margins",
+    "description": """
+This module copies the field *standard_price* of the product on the invoice line when the invoice line is created. The allows the computation of the margin of the invoice.
+
+This module has been written by Alexis de Lattre from Akretion
+<alexis.delattre@akretion.com>.
+    """,
+    "author": "Akretion",
+    "website": "https://github.com/OCA/odoo-usability",
+    "depends": ["account"],
+    "data": [
+        "account_invoice_view.xml",
+    ],
+    "installable": False,
+}

account_invoice_margin/__openerp__.py

@@ -1,43 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Margin module for Odoo
-#    Copyright (C) 2015 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Invoice Margin',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Copy standard price on invoice line and compute margins',
-    'description': """
-This module copies the field *standard_price* of the product on the invoice line when the invoice line is created. The allows the computation of the margin of the invoice.
-
-This module has been written by Alexis de Lattre from Akretion
-<alexis.delattre@akretion.com>.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['account'],
-    'data': [
-        'account_invoice_view.xml',
-    ],
-    'installable': True,
-}

account_invoice_margin/account_invoice.py

@@ -1,171 +1,98 @@
-# -*- coding: utf-8 -*-
+# Copyright 2015-2019 Akretion France (http://www.akretion.com)
-##############################################################################
-#
-#    Account Invoice Margin module for Odoo
-#    Copyright (C) 2015-2016 Akretion (http://www.akretion.com)
 # @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
 
-from openerp.osv import orm, fields
+from odoo import api, fields, models
-import openerp.addons.decimal_precision as dp
+
+import odoo.addons.decimal_precision as dp
 
 
-class AccountInvoiceLine(orm.Model):
+class AccountInvoiceLine(models.Model):
-    _inherit = 'account.invoice.line'
+    _inherit = "account.invoice.line"
 
-    def _compute_margin(self, cr, uid, ids, name, arg, context=None):
+    standard_price_company_currency = fields.Float(
-        if context is None:
+        string="Cost Price in Company Currency",
-            context = {}
+        readonly=True,
-        res = {}
+        digits=dp.get_precision("Product Price"),
-        # we need an up-to-date price_subtotal
+        help="Cost price in company currency in the unit of measure "
-        # We cannot read il.price_subtotal, because it may be out-of-date
+        "of the invoice line (which may be different from the unit "
-        # (I saw that with invoices in foreign currency)
+        "of measure of the product).",
-        price_subtotal = self._amount_line(cr, uid, ids, name, arg, context)
+    )
-        for il in self.browse(cr, uid, ids, context=context):
+    standard_price_invoice_currency = fields.Float(
+        string="Cost Price in Invoice Currency",
+        readonly=True,
+        compute="_compute_margin",
+        store=True,
+        digits=dp.get_precision("Product Price"),
+        help="Cost price in invoice currency in the unit of measure "
+        "of the invoice line",
+    )
+    margin_invoice_currency = fields.Monetary(
+        string="Margin in Invoice Currency",
+        readonly=True,
+        store=True,
+        compute="_compute_margin",
+        currency_field="currency_id",
+    )
+    margin_company_currency = fields.Monetary(
+        string="Margin in Company Currency",
+        readonly=True,
+        store=True,
+        compute="_compute_margin",
+        currency_field="company_currency_id",
+    )
+    margin_rate = fields.Float(
+        string="Margin Rate",
+        readonly=True,
+        store=True,
+        compute="_compute_margin",
+        digits=(16, 2),
+        help="Margin rate in percentage of the sale price",
+    )
+
+    @api.depends(
+        "standard_price_company_currency",
+        "invoice_id.currency_id",
+        "invoice_id.type",
+        "invoice_id.company_id",
+        "invoice_id.date_invoice",
+        "quantity",
+        "price_subtotal",
+    )
+    def _compute_margin(self):
+        for il in self:
             standard_price_inv_cur = 0.0
             margin_inv_cur = 0.0
             margin_comp_cur = 0.0
             margin_rate = 0.0
-            if (
+            inv = il.invoice_id
-                    il.invoice_id and
+            if inv and inv.type in ("out_invoice", "out_refund"):
-                    il.invoice_id.type in ('out_invoice', 'out_refund')):
                 # it works in _get_current_rate
                 # even if we set date = False in context
                 # standard_price_inv_cur is in the UoM of the invoice line
-
+                date = inv._get_currency_rate_date() or fields.Date.context_today(self)
-                rco = self.pool['res.currency']
+                company = inv.company_id
-                ctx_currency = context.copy()
+                company_currency = company.currency_id
-                if il.invoice_id.date_invoice:
+                standard_price_inv_cur = company_currency._convert(
-                    ctx_currency['date'] = il.invoice_id.date_invoice
+                    il.standard_price_company_currency, inv.currency_id, company, date
-                standard_price_inv_cur =\
+                )
-                    rco.compute(
+                margin_inv_cur = (
-                        cr, uid, il.invoice_id.company_id.currency_id.id,
+                    il.price_subtotal - il.quantity * standard_price_inv_cur
-                        il.invoice_id.currency_id.id,
+                )
-                        il.standard_price_company_currency,
+                margin_comp_cur = inv.currency_id._convert(
-                        context=ctx_currency)
+                    margin_inv_cur, company_currency, company, date
-                margin_inv_cur =\
+                )
-                    price_subtotal[il.id] - il.quantity * standard_price_inv_cur
+                if il.price_subtotal:
-                margin_comp_cur = rco.compute(
+                    margin_rate = 100 * margin_inv_cur / il.price_subtotal
-                    cr, uid, il.invoice_id.currency_id.id,
-                    il.invoice_id.company_id.currency_id.id,
-                    margin_inv_cur, context=ctx_currency)
-                if price_subtotal[il.id]:
-                    margin_rate = 100 * margin_inv_cur / price_subtotal[il.id]
                 # for a refund, margin should be negative
                 # but margin rate should stay positive
-                if il.invoice_id.type == 'out_refund':
+                if inv.type == "out_refund":
                     margin_inv_cur *= -1
                     margin_comp_cur *= -1
-            res[il.id] = {
+            il.standard_price_invoice_currency = standard_price_inv_cur
-                'standard_price_invoice_currency': standard_price_inv_cur,
+            il.margin_invoice_currency = margin_inv_cur
-                'margin_invoice_currency': margin_inv_cur,
+            il.margin_company_currency = margin_comp_cur
-                'margin_company_currency': margin_comp_cur,
+            il.margin_rate = margin_rate
-                'margin_rate': margin_rate,
-                }
-        return res
-
-    def _get_lines_from_invoices(self, cr, uid, ids, context=None):
-        return self.pool['account.invoice.line'].search(
-            cr, uid, [('invoice_id', 'in', ids)], context=context)
-
-    _columns = {
-        'standard_price_company_currency': fields.float(
-            'Cost Price per Unit in Company Currency', readonly=True,
-            digits_compute=dp.get_precision('Product Price'),
-            help="Cost price in company currency in the unit of measure "
-            "of the invoice line (which may be different from the unit "
-            "of measure of the product)."),
-        'standard_price_invoice_currency': fields.function(
-            _compute_margin, string='Cost Price per Unit in Invoice Currency',
-            type='float', readonly=True, multi='il-margin', store={
-                'account.invoice.line': (
-                    lambda self, cr, uid, ids, c={}: ids, [
-                        'standard_price_company_currency',
-                        'quantity',
-                        'price_unit',
-                        'discount',
-                        'invoice_line_tax_id'], 10),
-                'account.invoice': (
-                    _get_lines_from_invoices, [
-                        'type',
-                        'currency_id',
-                        'date_invoice',
-                        'company_id'], 20),
-                },
-            digits_compute=dp.get_precision('Product Price'),
-            help="Cost price in invoice currency in the unit of measure "
-            "of the invoice line"),
-        'margin_invoice_currency': fields.function(
-            _compute_margin, string='Margin in Invoice Currency',
-            type='float', readonly=True, multi='il-margin', store={
-                'account.invoice.line': (
-                    lambda self, cr, uid, ids, c={}: ids, [
-                        'standard_price_company_currency',
-                        'quantity',
-                        'price_unit',
-                        'discount',
-                        'invoice_line_tax_id'], 10),
-                'account.invoice': (
-                    _get_lines_from_invoices, [
-                        'type',
-                        'currency_id',
-                        'date_invoice',
-                        'company_id'], 20),
-                },
-            digits_compute=dp.get_precision('Account')),
-        'margin_company_currency': fields.function(
-            _compute_margin, type='float',
-            string='Margin in Company Currency', readonly=True,
-            multi='il-margin', store={
-                'account.invoice.line': (
-                    lambda self, cr, uid, ids, c={}: ids, [
-                        'standard_price_company_currency',
-                        'quantity',
-                        'price_unit',
-                        'discount',
-                        'invoice_line_tax_id'], 10),
-                'account.invoice': (
-                    _get_lines_from_invoices, [
-                        'type',
-                        'currency_id',
-                        'date_invoice',
-                        'company_id'], 20),
-                },
-            digits_compute=dp.get_precision('Account')),
-        'margin_rate': fields.function(
-            _compute_margin, type='float',
-            string="Margin Rate", readonly=True, multi='il-margin', store={
-                'account.invoice.line': (
-                    lambda self, cr, uid, ids, c={}: ids, [
-                        'standard_price_company_currency',
-                        'quantity',
-                        'price_unit',
-                        'discount',
-                        'invoice_line_tax_id'], 10),
-                'account.invoice': (
-                    _get_lines_from_invoices, [
-                        'type',
-                        'currency_id',
-                        'date_invoice',
-                        'company_id'], 20),
-                },
-            digits=(16, 2),
-            help="Margin rate in percentage of the sale price"),
-        }
 
     # We want to copy standard_price on invoice line for customer
     # invoice/refunds. We can't do that via on_change of product_id,
@@ -173,114 +100,79 @@ class AccountInvoiceLine(orm.Model):
     # => we inherit write/create
     # We write standard_price_company_currency even on supplier invoice/refunds
     # because we don't have access to the 'type' of the invoice
-    def create(self, cr, uid, vals, context=None):
+    @api.model
-        if (
+    def create(self, vals):
-                vals.get('product_id') and
+        if vals.get("product_id"):
-                'standard_price_company_currency' not in vals):
+            pp = self.env["product.product"].browse(vals["product_id"])
-            pp = self.pool['product.product'].browse(
-                cr, uid, vals['product_id'], context=context)
             std_price = pp.standard_price
-            inv_uom_id = vals.get('uos_id')
+            inv_uom_id = vals.get("uom_id")
             if inv_uom_id and inv_uom_id != pp.uom_id.id:
-                std_price = self.pool['product.uom']._compute_price(
+                inv_uom = self.env["uom.uom"].browse(inv_uom_id)
-                    cr, uid, pp.uom_id.id, std_price, inv_uom_id)
+                std_price = pp.uom_id._compute_price(std_price, inv_uom)
-            vals['standard_price_company_currency'] = std_price
+            vals["standard_price_company_currency"] = std_price
-        return super(AccountInvoiceLine, self).create(
+        return super(AccountInvoiceLine, self).create(vals)
-            cr, uid, vals, context=context)
 
-    def write(self, cr, uid, ids, vals, context=None):
+    def write(self, vals):
-        """This code can seem a bit strange with the super() inside
-        the loop, but it is required if we want to support all scenarios,
-        including very strange scenarios where you write a uos_id on
-        several lines with different products, etc...
-        OK, these scenarios will probably never happen, but I prefer
-        to make sure that the code is right and works in all
-        scenarios
-        """
         if not vals:
             vals = {}
-        if isinstance(ids, (int, long)):
+        if "product_id" in vals or "uom_id" in vals:
-            ids = [ids]
+            for il in self:
-        if 'product_id' in vals or 'uos_id' in vals:
+                if "product_id" in vals:
-            for il in self.browse(cr, uid, ids, context=context):
+                    if vals.get("product_id"):
-                if 'product_id' in vals:
+                        pp = self.env["product.product"].browse(vals["product_id"])
-                    if vals.get('product_id'):
-                        pp = self.pool['product.product'].browse(
-                            cr, uid, vals['product_id'], context=context)
                     else:
                         pp = False
                 else:
                     pp = il.product_id or False
-                # uos_id is NOT a required field
+                # uom_id is NOT a required field
-                if 'uos_id' in vals:
+                if "uom_id" in vals:
-                    if vals.get('uos_id'):
+                    if vals.get("uom_id"):
-                        inv_uom = self.pool['product.uom'].browse(
+                        inv_uom = self.env["uom.uom"].browse(vals["uom_id"])
-                            cr, uid, vals['uos_id'], context=context)
                     else:
                         inv_uom = False
                 else:
-                    inv_uom = il.uos_id or False
+                    inv_uom = il.uom_id or False
                 std_price = 0.0
                 if pp:
                     std_price = pp.standard_price
                     if inv_uom and inv_uom != pp.uom_id:
-                        std_price = self.pool['product.uom']._compute_price(
+                        std_price = pp.uom_id._compute_price(std_price, inv_uom)
-                            cr, uid, pp.uom_id.id, std_price, inv_uom.id)
+                il.write({"standard_price_company_currency": std_price})
-                vals_line = vals.copy()
+        return super(AccountInvoiceLine, self).write(vals)
-                vals_line['standard_price_company_currency'] = std_price
-                super(AccountInvoiceLine, self).write(
-                    cr, uid, [il.id], vals_line, context=context)
-                return True
-        else:
-            return super(AccountInvoiceLine, self).write(
-                cr, uid, ids, vals, context=context)
 
 
-class AccountInvoice(orm.Model):
+class AccountInvoice(models.Model):
-    _inherit = 'account.invoice'
+    _inherit = "account.invoice"
 
-    def _compute_margin(self, cr, uid, ids, name, arg, context=None):
+    margin_invoice_currency = fields.Monetary(
-        res = {}
+        string="Margin in Invoice Currency",
-        for inv in self.browse(cr, uid, ids, context=context):
+        compute="_compute_margin",
-            margin_inv_cur = 0.0
+        store=True,
-            margin_comp_cur = 0.0
+        readonly=True,
-            if inv.type in ('out_invoice', 'out_refund'):
+        currency_field="currency_id",
-                for il in inv.invoice_line:
+    )
-                    margin_inv_cur += il.margin_invoice_currency
+    margin_company_currency = fields.Monetary(
-                    margin_comp_cur += il.margin_company_currency
+        string="Margin in Company Currency",
-            res[inv.id] = {
+        compute="_compute_margin",
-                'margin_invoice_currency': margin_inv_cur,
+        store=True,
-                'margin_company_currency': margin_comp_cur,
+        readonly=True,
-                }
+        currency_field="company_currency_id",
-        return res
+    )
 
-    def _get_invoices_from_inv_lines(self, cr, uid, ids, context=None):
+    @api.depends(
-        return self.pool['account.invoice'].search(
+        "type",
-            cr, uid, [('invoice_line', 'in', ids)], context=context)
+        "invoice_line_ids.margin_invoice_currency",
-
+        "invoice_line_ids.margin_company_currency",
-    _columns = {
+    )
-        'margin_invoice_currency': fields.function(
+    def _compute_margin(self):
-            _compute_margin, type='float',
+        res = self.env["account.invoice.line"].read_group(
-            string='Margin in Invoice Currency',
+            [("invoice_id", "in", self.ids)],
-            readonly=True, multi='inv-margin',
+            ["invoice_id", "margin_invoice_currency", "margin_company_currency"],
-            digits_compute=dp.get_precision('Account'), store={
+            ["invoice_id"],
-                'account.invoice': (
+        )
-                    lambda self, cr, uid, ids, c={}: ids, [
+        for re in res:
-                        'type', 'currency_id'], 10),
+            if re["invoice_id"]:
-                'account.invoice.line': (
+                inv = self.browse(re["invoice_id"][0])
-                    _get_invoices_from_inv_lines, [
+                if inv.type in ("out_invoice", "out_refund"):
-                        'margin_company_currency'], 20),
+                    inv.margin_invoice_currency = re["margin_invoice_currency"]
-                }),
+                    inv.margin_company_currency = re["margin_company_currency"]
-        'margin_company_currency': fields.function(
-            _compute_margin, type='float',
-            string='Margin in Company Currency',
-            readonly=True, multi='inv-margin',
-            digits_compute=dp.get_precision('Account'), store={
-                'account.invoice': (
-                    lambda self, cr, uid, ids, c={}: ids, [
-                        'type', 'currency_id'], 10),
-                'account.invoice.line': (
-                    _get_invoices_from_inv_lines, [
-                        'margin_company_currency'], 20),
-                }),
-        }

account_invoice_margin/account_invoice_report.py

@@ -0,0 +1,83 @@
+# Copyright 2018-2019 Akretion France (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+
+
+class AccountInvoiceReport(models.Model):
+    _inherit = "account.invoice.report"
+
+    margin = fields.Float(string="Margin", readonly=True)
+    # why digits=0 ??? Why is it like that in the native "account" module
+    user_currency_margin = fields.Float(
+        string="Margin", compute="_compute_user_currency_margin", digits=0
+    )
+
+    _depends = {
+        "account.invoice": [
+            "account_id",
+            "amount_total_company_signed",
+            "commercial_partner_id",
+            "company_id",
+            "currency_id",
+            "date_due",
+            "date_invoice",
+            "fiscal_position_id",
+            "journal_id",
+            "number",
+            "partner_bank_id",
+            "partner_id",
+            "payment_term_id",
+            "residual",
+            "state",
+            "type",
+            "user_id",
+        ],
+        "account.invoice.line": [
+            "account_id",
+            "invoice_id",
+            "price_subtotal",
+            "product_id",
+            "quantity",
+            "uom_id",
+            "account_analytic_id",
+            "margin_company_currency",
+        ],
+        "product.product": ["product_tmpl_id"],
+        "product.template": ["categ_id"],
+        "uom.uom": ["category_id", "factor", "name", "uom_type"],
+        "res.currency.rate": ["currency_id", "name"],
+        "res.partner": ["country_id"],
+    }
+
+    @api.depends("currency_id", "date", "margin")
+    def _compute_user_currency_margin(self):
+        user_currency = self.env.user.company_id.currency_id
+        currency_rate = self.env["res.currency.rate"].search(
+            [
+                ("rate", "=", 1),
+                "|",
+                ("company_id", "=", self.env.user.company_id.id),
+                ("company_id", "=", False),
+            ],
+            limit=1,
+        )
+        base_currency = currency_rate.currency_id
+        for record in self:
+            date = record.date or fields.Date.today()
+            company = record.company_id
+            record.user_currency_margin = base_currency._convert(
+                record.margin, user_currency, company, date
+            )
+
+    # TODO check for refunds
+    def _sub_select(self):
+        select_str = super(AccountInvoiceReport, self)._sub_select()
+        select_str += ", SUM(ail.margin_company_currency) AS margin"
+        return select_str
+
+    def _select(self):
+        select_str = super(AccountInvoiceReport, self)._select()
+        select_str += ", sub.margin AS margin"
+        return select_str

account_invoice_margin/account_invoice_view.xml

@@ -1,32 +1,42 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <!--
-   Copyright (C) 2015 Akretion (http://www.akretion.com/)
+  © 2015-2017 Akretion (http://www.akretion.com/)
   @author: Alexis de Lattre <alexis.delattre@akretion.com>
-   The licence is in the file __openerp__.py
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
-
+<odoo>
-<openerp>
-<data>
 
 <record id="view_invoice_line_form" model="ir.ui.view">
     <field name="name">margin.account.invoice.line.form</field>
     <field name="model">account.invoice.line</field>
     <field name="inherit_id" ref="account.view_invoice_line_form" />
     <field name="arch" type="xml">
-        <field name="discount" position="after">
+        <xpath expr="//field[@name='analytic_tag_ids']/.." position="inside">
-            <field name="standard_price_company_currency"
+            <field
-                groups="account.group_account_user"/>
+                    name="standard_price_company_currency"
-            <field name="standard_price_invoice_currency"
+                    string="Cost Price in Comp. Cur."
-                widget="monetary"
+                    groups="base.group_no_one"
-                options="{'currency_field': 'currency_id'}"
+                />
-                groups="account.group_account_user"/>
+            <field
-            <field name="margin_invoice_currency"
+                    name="standard_price_invoice_currency"
-                widget="monetary"
+                    string="Cost Price in Inv. Cur."
-                options="{'currency_field': 'currency_id'}"
+                    groups="base.group_no_one"
-                groups="account.group_account_user"/>
+                />
-            <field name="margin_company_currency"
+            <field
-                groups="account.group_account_user"/>
+                    name="margin_invoice_currency"
-        </field>
+                    string="Margin in Inv. Cur."
+                    groups="base.group_no_one"
+                />
+            <field
+                    name="margin_company_currency"
+                    string="Margin in Comp. Cur."
+                    groups="base.group_no_one"
+                />
+            <label for="margin_rate" groups="base.group_no_one" />
+            <div name="margin_rate" groups="base.group_no_one">
+                <field name="margin_rate" class="oe_inline" /> %
+            </div>
+        </xpath>
     </field>
 </record>
 
@@ -36,24 +46,19 @@
     <field name="inherit_id" ref="account.invoice_form" />
     <field name="arch" type="xml">
         <field name="move_id" position="after">
-            <field name="margin_invoice_currency"
+            <field
-                string="Margin"
+                    name="margin_invoice_currency"
-                widget="monetary"
+                    string="Margin in Inv. Cur."
-                options="{'currency_field': 'currency_id'}"
+                    groups="base.group_no_one"
-                groups="account.group_account_user"/>
+                />
-            <field name="margin_company_currency"
+            <field
-                groups="account.group_account_user"/>
+                    name="margin_company_currency"
+                    string="Margin in Comp. Cur."
+                    groups="base.group_no_one"
+                />
         </field>
-        <xpath expr="//field[@name='invoice_line']/tree/field[@name='price_subtotal']" position="after">
-            <field name="standard_price_invoice_currency" groups="account.group_account_user"/>
-            <field name="standard_price_company_currency" groups="base.group_no_one"/>
-            <field name="margin_invoice_currency" groups="account.group_account_user"/>
-            <field name="margin_company_currency" groups="base.group_no_one"/>
-            <field name="margin_rate" groups="base.group_no_one"/>
-        </xpath>
     </field>
 </record>
 
 
-</data>
+</odoo>
-</openerp>

account_invoice_overdue_filter/__init__.py

@@ -1,21 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Overdue Filter module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################

account_invoice_overdue_filter/__openerp__.py

@@ -1,43 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Overdue Filter module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Invoice Overdue Filter',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Add an Overdue filter in the invoice search view',
-    'description': """
-Account Invoice Overdue Filter
-==============================
-
-This module adds a filter *Overdue* in the invoice search view.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['account'],
-    'data': ['account_invoice_view.xml'],
-    'installable': True,
-}

account_invoice_overdue_filter/account_invoice_view.xml

@@ -1,24 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-   Copyright (C) 2014 Akretion (http://www.akretion.com/)
-   @author: Alexis de Lattre <alexis.delattre@akretion.com>
-   The licence is in the file __openerp__.py
--->
-
-<openerp>
-<data>
-
-<record id="view_account_invoice_filter" model="ir.ui.view">
-    <field name="name">filter.overdue.account.invoice.search</field>
-    <field name="model">account.invoice</field>
-    <field name="inherit_id" ref="account.view_account_invoice_filter"/>
-    <field name="arch" type="xml">
-        <filter name="unpaid" position="after">
-            <filter name="overdue" string="Overdue"
-                domain="[('state', '=', 'open'), ('date_due', '&lt;', current_date)]"/>
-        </filter>
-    </field>
-</record>
-
-</data>
-</openerp>

account_invoice_partner_bank_usability/__init__.py

@@ -1,23 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Partner Bank Usability module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from . import account_invoice

account_invoice_partner_bank_usability/__openerp__.py

@@ -1,45 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Partner Bank Usability module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Invoice Partner Bank Usability',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'If the company has a single bank account, get the first one on the customer invoice',
-    'description': """
-Account Invoice Partner Bank Usability
-======================================
-
-If the company has a single bank account, we set this single bank account by default on the customer invoice.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['account'],
-    'data': [],
-    'images': [],
-    'installable': True,
-    'active': False,
-}

account_invoice_partner_bank_usability/account_invoice.py

@@ -1,46 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Partner Bank Usability module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm
-
-
-class account_invoice(orm.Model):
-    _inherit = "account.invoice"
-
-    def invoice_out_get_first_partner_bank(self, cr, uid, context=None):
-        '''Get the first bank account of your company on customer invoice
-        if your company only has one bank account'''
-        if context is None:
-            context = {}
-        res_partner_bank_id = False
-        if context.get('type') == 'out_invoice' or \
-                context.get('inv_type') == 'out_invoice':
-            cur_user = self.pool['res.users'].browse(
-                cr, uid, uid, context=context)
-            partner_banks = cur_user.company_id.partner_id.bank_ids
-            if partner_banks and len(partner_banks) == 1:
-                res_partner_bank_id = partner_banks[0].id
-        return res_partner_bank_id
-
-    _defaults = {
-        'partner_bank_id': invoice_out_get_first_partner_bank,
-    }

account_invoice_sale_link/__init__.py

@@ -1,23 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Sale Link module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from . import account_invoice

account_invoice_sale_link/__openerp__.py

@@ -1,44 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Sale Link module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Invoice Sale Link',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Add the reverse link from invoices to sale orders',
-    'description': """
-Account Invoice Sale Link
-=========================
-
-On the customer invoice report, you usually need to display the customer order number. For that, you need to have the link from invoices to sale orders, and this link is not available in the official addons.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['sale'],
-    'data': [],
-    'installable': True,
-    'active': False,
-}

account_invoice_sale_link/account_invoice.py

@@ -1,36 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Invoice Sale Link module for OpenERP
-#    Copyright (C) 2013 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import orm, fields
-
-
-class account_invoice(orm.Model):
-    _inherit = 'account.invoice'
-
-    _columns = {
-        # This is the reverse link of the field 'invoice_ids' of sale.order
-        # defined in addons/sale/sale.py
-        'sale_ids': fields.many2many(
-            'sale.order', 'sale_order_invoice_rel', 'invoice_id',
-            'order_id', 'Sale Orders', readonly=True,
-            help="This is the list of sale orders related to this invoice."),
-        }

account_invoice_update_wizard/README.rst

@@ -0,0 +1,39 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
+   :target: https://www.gnu.org/licenses/agpl-3.0-standalone.html
+   :alt: License: AGPL-3
+
+Account Invoice Update Wizard
+=============================
+
+This module adds a button *Update Invoice* on Customer and Supplier invoices in
+Open or Paid state. This button starts a wizard which allows the user to update
+non-legal fields of the invoice:
+
+* Source Document
+* Reference/Description
+* Payment terms (update allowed only to a payment term with same number of terms
+  of the same amount and on invoices without any payment)
+* Bank Account
+* Salesman
+* Notes
+* Description of invoice lines
+* Analytic account
+* Analytic tags
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues
+<https://github.com/akretion/odoo-usability/issues>`_. In case of trouble, please
+check there if your issue has already been reported. If you spotted it first,
+help us smash it by providing detailed and welcomed feedback.
+
+Contributors
+------------
+
+* Alexis de Lattre <alexis.delattre@akretion.com>
+* Florian da Costa <florian.dacosta@akretion.com>
+* Matthieu Dietrich <matthieu.dietrich@camptocamp.com>
+* Yannick Vaucher <yannick.vaucher@camptocamp.com>
+* Mykhailo Panarin <m.panarin@mobilunity.com>
+* Artem Kostyuk <a.kostyuk@mobilunity.com>

account_invoice_update_wizard/__init__.py

@@ -0,0 +1,2 @@
+from . import models
+from . import wizard

account_invoice_update_wizard/__manifest__.py

@@ -0,0 +1,21 @@
+# Copyright 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# Copyright 2018-2019 Camptocamp
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Account Invoice Update Wizard",
+    "version": "12.0.1.0.0",
+    "category": "Accounting & Finance",
+    "license": "AGPL-3",
+    "summary": "Wizard to update non-legal fields of an open/paid invoice",
+    "author": "Akretion",
+    "website": "https://github.com/OCA/odoo-usability",
+    "depends": [
+        "account",
+    ],
+    "data": [
+        "wizard/account_invoice_update_view.xml",
+        "views/account_invoice.xml",
+    ],
+    "installable": False,
+}

account_invoice_update_wizard/models/__init__.py

@@ -0,0 +1 @@
+from . import account_invoice

account_invoice_update_wizard/models/account_invoice.py

@@ -0,0 +1,19 @@
+# Copyright 2019 Camptocamp
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import models
+
+
+class AccountInvoice(models.Model):
+    _inherit = "account.invoice"
+
+    def prepare_update_wizard(self):
+        self.ensure_one()
+        wizard = self.env["account.invoice.update"]
+        res = wizard._prepare_default_get(self)
+        action = self.env.ref(
+            "account_invoice_update_wizard.account_invoice_update_action"
+        ).read()[0]
+        action["name"] = "Update Wizard"
+        action["res_id"] = wizard.create(res).id
+        return action

account_invoice_update_wizard/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_account_invoice_update_wizard

account_invoice_update_wizard/tests/test_account_invoice_update_wizard.py

@@ -0,0 +1,215 @@
+# Copyright 2018-2019 Camptocamp
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo.exceptions import UserError
+from odoo.tests.common import SavepointCase
+
+
+class TestAccountInvoiceUpdateWizard(SavepointCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.customer12 = cls.env.ref("base.res_partner_12")
+        cls.product16 = cls.env.ref("product.product_product_16")
+        cls.product24 = cls.env.ref("product.product_product_24")
+        uom_unit = cls.env.ref("uom.product_uom_categ_unit")
+
+        cls.invoice1 = cls.env["account.invoice"].create(
+            {
+                "name": "Test invoice",
+                "partner_id": cls.customer12.id,
+            }
+        )
+        cls.inv_line1 = cls.env["account.invoice.line"].create(
+            {
+                "invoice_id": cls.invoice1.id,
+                "name": "Line1",
+                "product_id": cls.product16.id,
+                "product_uom_id": uom_unit.id,
+                "account_id": cls.invoice1.account_id.id,
+                "price_unit": 42.0,
+            }
+        )
+        cls.inv_line2 = cls.env["account.invoice.line"].create(
+            {
+                "invoice_id": cls.invoice1.id,
+                "name": "Line2",
+                "product_id": cls.product24.id,
+                "product_uom_id": uom_unit.id,
+                "account_id": cls.invoice1.account_id.id,
+                "price_unit": 1111.1,
+            }
+        )
+
+        cls.aa1 = cls.env.ref("analytic.analytic_partners_camp_to_camp")
+        cls.aa2 = cls.env.ref("analytic.analytic_nebula")
+        cls.atag1 = cls.env.ref("analytic.tag_contract")
+        cls.atag2 = cls.env["account.analytic.tag"].create(
+            {
+                "name": "の",
+            }
+        )
+
+    def create_wizard(self, invoice):
+        res = self.invoice1.prepare_update_wizard()
+        self.wiz = self.env["account.invoice.update"].browse(res["res_id"])
+
+    def test_add_analytic_account_line1(self):
+        """Add analytic account on an invoice line
+        after the invoice has been approved.
+
+        This will:
+            - update the move line
+            - create a new analytic line.
+        """
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.account_analytic_id = self.aa1
+        self.wiz.run()
+
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertEqual(related_ml.analytic_account_id, self.aa1)
+        self.assertEqual(related_ml.analytic_line_ids.account_id, self.aa1)
+
+    def test_change_analytic_account_line1(self):
+        """Change analytic account on an invoice line
+        after the invoice has been approved.
+
+        This will:
+            - update the move line
+            - update the existing analytic line."""
+        self.inv_line1.account_analytic_id = self.aa2
+
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.account_analytic_id = self.aa1
+        self.wiz.run()
+
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertEqual(related_ml.analytic_account_id, self.aa1)
+        self.assertEqual(related_ml.analytic_line_ids.account_id, self.aa1)
+
+    def test_error_grouped_move_lines(self):
+        """Change analytic account on an invoice line
+        after the invoice has been approved where both
+        lines were grouped in the same move line.
+
+        This will raise an error.
+        """
+        self.invoice1.journal_id.group_invoice_lines = True
+
+        self.inv_line2.product_id = self.product16
+        self.inv_line2.unit_price = 42.0
+
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        line1 = self.wiz.line_ids[0]
+        line1.account_analytic_id = self.aa1
+        with self.assertRaises(UserError):
+            self.wiz.run()
+
+    def test_add_analytic_tags_line1(self):
+        """Add analytic tags on an invoice line
+        after the invoice has been approved.
+
+        This will update move line.
+        """
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.analytic_tag_ids = self.atag2
+        self.wiz.run()
+
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertEqual(related_ml.analytic_tag_ids, self.atag2)
+        self.assertFalse(related_ml.analytic_line_ids)
+
+    def test_change_analytic_tags_line1(self):
+        """Change analytic tags on an invoice line
+        after the invoice has been approved.
+
+        It will update move line and analytic line
+        """
+        self.inv_line1.account_analytic_id = self.aa2
+        self.inv_line1.analytic_tag_ids = self.atag1
+
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.analytic_tag_ids = self.atag2
+        self.wiz.run()
+
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertEqual(related_ml.analytic_tag_ids, self.atag2)
+        self.assertEqual(related_ml.analytic_line_ids.tag_ids, self.atag2)
+
+    def test_add_analytic_info_line1(self):
+        """Add analytic account and tags on an invoice line
+        after the invoice has been approved.
+
+        This will:
+            - update move line
+            - create an analytic line
+        """
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.account_analytic_id = self.aa1
+        wiz_line.analytic_tag_ids = self.atag2
+        self.wiz.run()
+
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertEqual(related_ml.analytic_account_id, self.aa1)
+        self.assertEqual(related_ml.analytic_tag_ids, self.atag2)
+        self.assertEqual(related_ml.analytic_line_ids.account_id, self.aa1)
+        self.assertEqual(related_ml.analytic_line_ids.tag_ids, self.atag2)
+
+    def test_empty_analytic_account_line1(self):
+        """Remove analytic account
+        after the invoice has been approved.
+
+        This will raise an error as it is not implemented.
+        """
+        self.inv_line1.account_analytic_id = self.aa2
+
+        self.invoice1.action_invoice_open()
+        self.create_wizard(self.invoice1)
+
+        wiz_line = self.wiz.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == self.inv_line1
+        )
+        wiz_line.account_analytic_id = False
+        self.wiz.run()
+        related_ml = self.invoice1.move_id.line_ids.filtered(
+            lambda rec: rec.product_id == self.product16
+        )
+        self.assertFalse(related_ml.analytic_account_id)
+        self.assertFalse(related_ml.analytic_line_ids)

account_invoice_update_wizard/views/account_invoice.xml

@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="invoice_supplier_form" model="ir.ui.view">
+    <field name="model">account.invoice</field>
+    <field name="inherit_id" ref="account.invoice_supplier_form" />
+    <field name="arch" type="xml">
+        <button name="action_invoice_draft" position="before">
+            <button
+                    name="prepare_update_wizard"
+                    type="object"
+                    string="Update Invoice"
+                    states="open,paid"
+                    groups="account.group_account_invoice"
+                />
+        </button>
+    </field>
+</record>
+
+<record id="invoice_form" model="ir.ui.view">
+    <field name="model">account.invoice</field>
+    <field name="inherit_id" ref="account.invoice_form" />
+    <field name="arch" type="xml">
+        <button name="action_invoice_draft" position="before">
+            <button
+                    name="prepare_update_wizard"
+                    type="object"
+                    string="Update Invoice"
+                    states="open,paid"
+                    groups="account.group_account_invoice"
+                />
+        </button>
+    </field>
+</record>
+
+</odoo>

account_invoice_update_wizard/wizard/__init__.py

@@ -0,0 +1 @@
+from . import account_invoice_update

account_invoice_update_wizard/wizard/account_invoice_update.py

@@ -0,0 +1,334 @@
+# Copyright 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# Copyright 2018-2019 Camptocamp
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
+
+import odoo.addons.decimal_precision as dp
+
+
+class AccountInvoiceUpdate(models.TransientModel):
+    _name = "account.invoice.update"
+    _description = "Wizard to update non-legal fields of invoice"
+
+    invoice_id = fields.Many2one(
+        "account.invoice", string="Invoice", required=True, readonly=True
+    )
+    type = fields.Selection(related="invoice_id.type", readonly=True)
+    company_id = fields.Many2one(related="invoice_id.company_id", readonly=True)
+    partner_id = fields.Many2one(related="invoice_id.partner_id", readonly=True)
+    user_id = fields.Many2one("res.users", string="Salesperson")
+    payment_term_id = fields.Many2one("account.payment.term", string="Payment Term")
+    reference = fields.Char(string="Invoice Reference")
+    name = fields.Char(string="Reference/Description")
+    origin = fields.Char(string="Source Document")
+    comment = fields.Text("Additional Information")
+    partner_bank_id = fields.Many2one("res.partner.bank", string="Bank Account")
+    line_ids = fields.One2many(
+        "account.invoice.line.update", "parent_id", string="Invoice Lines"
+    )
+
+    @api.model
+    def _simple_fields2update(self):
+        """List boolean, date, datetime, char, text fields"""
+        return ["reference", "name", "origin", "comment"]
+
+    @api.model
+    def _m2o_fields2update(self):
+        return ["payment_term_id", "user_id", "partner_bank_id"]
+
+    @api.model
+    def _prepare_default_get(self, invoice):
+        res = {"invoice_id": invoice.id, "line_ids": []}
+        for sfield in self._simple_fields2update():
+            res[sfield] = invoice[sfield]
+        for m2ofield in self._m2o_fields2update():
+            res[m2ofield] = invoice[m2ofield].id or False
+        for line in invoice.invoice_line_ids:
+            aa_tags = line.analytic_tag_ids
+            aa_tags = [(6, 0, aa_tags.ids)] if aa_tags else False
+            res["line_ids"].append(
+                [
+                    0,
+                    0,
+                    {
+                        "invoice_line_id": line.id,
+                        "name": line.name,
+                        "quantity": line.quantity,
+                        "price_subtotal": line.price_subtotal,
+                        "account_analytic_id": line.account_analytic_id.id,
+                        "analytic_tag_ids": aa_tags,
+                        "display_type": line.display_type,
+                    },
+                ]
+            )
+        return res
+
+    @api.onchange("type")
+    def type_on_change(self):
+        res = {"domain": {}}
+        if self.type in ("out_invoice", "out_refund"):
+            res["domain"][
+                "partner_bank_id"
+            ] = "[('partner_id.ref_company_ids', 'in', [company_id])]"
+        else:
+            res["domain"]["partner_bank_id"] = "[('partner_id', '=', partner_id)]"
+        return res
+
+    @api.multi
+    def _prepare_invoice(self):
+        vals = {}
+        inv = self.invoice_id
+        for sfield in self._simple_fields2update():
+            if self[sfield] != inv[sfield]:
+                vals[sfield] = self[sfield]
+        for m2ofield in self._m2o_fields2update():
+            if self[m2ofield] != inv[m2ofield]:
+                vals[m2ofield] = self[m2ofield].id or False
+        if "payment_term_id" in vals:
+            pterm_list = self.payment_term_id.compute(
+                value=1, date_ref=inv.date_invoice
+            )[0]
+            if pterm_list:
+                vals["date_due"] = max(line[0] for line in pterm_list)
+        return vals
+
+    @api.model
+    def _line_simple_fields2update(self):
+        return [
+            "name",
+        ]
+
+    @api.model
+    def _line_m2o_fields2update(self):
+        return [
+            "account_analytic_id",
+        ]
+
+    @api.model
+    def _line_m2m_fields2update(self):
+        return [
+            "analytic_tag_ids",
+        ]
+
+    @api.model
+    def _prepare_invoice_line(self, line):
+        vals = {}
+        for field in self._line_simple_fields2update():
+            if line[field] != line.invoice_line_id[field]:
+                vals[field] = line[field]
+        for field in self._line_m2o_fields2update():
+            if line[field] != line.invoice_line_id[field]:
+                vals[field] = line[field].id
+        for field in self._line_m2m_fields2update():
+            if line[field] != line.invoice_line_id[field]:
+                vals[field] = [(6, 0, line[field].ids)]
+        return vals
+
+    @api.multi
+    def _prepare_move(self):
+        mvals = {}
+        inv = self.invoice_id
+        ini_ref = inv.move_id.ref
+        ref = inv.reference or inv.name
+        if ini_ref != ref:
+            mvals["ref"] = ref
+        return mvals
+
+    @api.multi
+    def _get_matching_inv_line(self, move_line):
+        """ Find matching invoice line by product """
+        # TODO make it accept more case as lines won't
+        # be grouped unless journal.group_invoice_line is True
+        inv_line = self.invoice_id.invoice_line_ids.filtered(
+            lambda rec: rec.product_id == move_line.product_id
+        )
+        if len(inv_line) != 1:
+            raise UserError(
+                "Cannot match a single invoice line to move line %s" % move_line.name
+            )
+        return inv_line
+
+    @api.multi
+    def _prepare_move_line(self, inv_line):
+        mlvals = {}
+        inv_line_upd = self.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == inv_line
+        )
+
+        ini_aa = inv_line.account_analytic_id
+        new_aa = inv_line_upd.account_analytic_id
+
+        if ini_aa != new_aa:
+            mlvals["analytic_account_id"] = new_aa.id
+
+        ini_aa_tags = inv_line.analytic_tag_ids
+        new_aa_tags = inv_line_upd.analytic_tag_ids
+
+        if ini_aa_tags != new_aa_tags:
+            mlvals["analytic_tag_ids"] = [(6, None, new_aa_tags.ids)]
+        return mlvals
+
+    @api.multi
+    def _prepare_analytic_line(self, inv_line):
+        alvals = {}
+        inv_line_upd = self.line_ids.filtered(
+            lambda rec: rec.invoice_line_id == inv_line
+        )
+
+        ini_aa = inv_line.account_analytic_id
+        new_aa = inv_line_upd.account_analytic_id
+
+        if ini_aa != new_aa:
+            alvals["account_id"] = new_aa.id
+
+        ini_aa_tags = inv_line.analytic_tag_ids
+        new_aa_tags = inv_line_upd.analytic_tag_ids
+
+        if ini_aa_tags != new_aa_tags:
+            alvals["tag_ids"] = [(6, None, new_aa_tags.ids)]
+        return alvals
+
+    @api.multi
+    def _update_payment_term_move(self):
+        self.ensure_one()
+        inv = self.invoice_id
+        if (
+            self.payment_term_id
+            and self.payment_term_id != inv.payment_term_id
+            and inv.move_id
+        ):
+            # I don't update pay term when the invoice is partially (or fully)
+            # paid because if you have a payment term with several lines
+            # of the same amount, you would also have to take into account
+            # the reconcile marks to put the new maturity date on the right
+            # lines
+            if inv.payment_ids:
+                raise UserError(
+                    _(
+                        "This wizard doesn't support the update of payment "
+                        "terms on an invoice which is partially or fully "
+                        "paid."
+                    )
+                )
+            prec = self.env["decimal.precision"].precision_get("Account")
+            term_res = self.payment_term_id.compute(inv.amount_total, inv.date_invoice)[
+                0
+            ]
+            new_pterm = {}  # key = int(amount * 100), value = [date1, date2]
+            for entry in term_res:
+                amount = int(entry[1] * 10 * prec)
+                if amount in new_pterm:
+                    new_pterm[amount].append(entry[0])
+                else:
+                    new_pterm[amount] = [entry[0]]
+            mlines = {}  # key = int(amount * 100), value : [line1, line2]
+            for line in inv.move_id.line_ids:
+                if line.account_id == inv.account_id:
+                    amount = int(abs(line.credit - line.debit) * 10 * prec)
+                    if amount in mlines:
+                        mlines[amount].append(line)
+                    else:
+                        mlines[amount] = [line]
+            for iamount, lines in mlines.items():
+                if len(lines) != len(new_pterm.get(iamount, [])):
+                    raise UserError(
+                        _(
+                            "The original payment term '%s' doesn't have the "
+                            "same terms (number of terms and/or amount) as the "
+                            "new payment term '%s'. You can only switch to a "
+                            "payment term that has the same number of terms "
+                            "with the same amount."
+                        )
+                        % (inv.payment_term_id.name, self.payment_term_id.name)
+                    )
+                for line in lines:
+                    line.date_maturity = new_pterm[iamount].pop()
+
+    @api.multi
+    def run(self):
+        self.ensure_one()
+        inv = self.invoice_id
+        updated = False
+        # re-write date_maturity on move line
+        self._update_payment_term_move()
+        ivals = self._prepare_invoice()
+        if ivals:
+            updated = True
+            inv.write(ivals)
+        if inv.move_id:
+            mvals = self._prepare_move()
+            if mvals:
+                inv.move_id.write(mvals)
+            for ml in inv.move_id.line_ids.filtered(
+                # we are only interested in invoice lines, not tax lines
+                lambda rec: bool(rec.product_id)
+            ):
+                if ml.credit == 0.0:
+                    continue
+                inv_line = self._get_matching_inv_line(ml)
+                mlvals = self._prepare_move_line(inv_line)
+                if mlvals:
+                    updated = True
+                    ml.write(mlvals)
+                aalines = ml.analytic_line_ids
+                alvals = self._prepare_analytic_line(inv_line)
+                if aalines and alvals:
+                    updated = True
+                    if "account_id" in alvals and alvals["account_id"] is False:
+                        former_aa = inv_line.account_analytic_id
+                        to_remove_aalines = aalines.filtered(
+                            lambda rec: rec.account_id == former_aa
+                        )
+                        # remove existing analytic line
+                        to_remove_aalines.unlink()
+                    else:
+                        aalines.write(alvals)
+                elif "account_id" in alvals:
+                    # Create analytic lines if analytic account
+                    # is added later
+                    ml.create_analytic_lines()
+        for line in self.line_ids:
+            ilvals = self._prepare_invoice_line(line)
+            if ilvals:
+                updated = True
+                line.invoice_line_id.write(ilvals)
+        if updated:
+            inv.message_post(
+                body=_(
+                    "Non-legal fields of invoice updated via the Invoice Update "
+                    "wizard."
+                )
+            )
+        return True
+
+
+class AccountInvoiceLineUpdate(models.TransientModel):
+    _name = "account.invoice.line.update"
+    _description = "Update non-legal fields of invoice lines"
+
+    parent_id = fields.Many2one(
+        "account.invoice.update", string="Wizard", ondelete="cascade"
+    )
+    invoice_line_id = fields.Many2one(
+        "account.invoice.line", string="Invoice Line", readonly=True
+    )
+    name = fields.Text(string="Description", required=True)
+    display_type = fields.Selection(
+        [("line_section", "Section"), ("line_note", "Note")],
+        default=False,
+        help="Technical field for UX purpose.",
+    )
+    quantity = fields.Float(
+        string="Quantity",
+        digits=dp.get_precision("Product Unit of Measure"),
+        readonly=True,
+    )
+    price_subtotal = fields.Float(
+        string="Amount", readonly=True, digits=dp.get_precision("Account")
+    )
+    account_analytic_id = fields.Many2one(
+        "account.analytic.account", string="Analytic Account"
+    )
+    analytic_tag_ids = fields.Many2many("account.analytic.tag", string="Analytic Tags")

account_invoice_update_wizard/wizard/account_invoice_update_view.xml

@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+    <record id="account_invoice_update_form" model="ir.ui.view">
+        <field name="model">account.invoice.update</field>
+        <field name="arch" type="xml">
+            <form string="Update Invoice Wizard">
+                <group name="main">
+                    <field name="invoice_id" invisible="1" />
+                    <field name="type" invisible="1" />
+                    <field name="company_id" invisible="1" />
+                    <field name="partner_id" invisible="1" />
+                    <field
+                        name="reference"
+                        attrs="{'invisible': [('type', 'not in', ('in_invoice', 'in_refund'))]}"
+                    />
+                    <field name="origin" />
+                    <field name="name" />
+                    <field name="payment_term_id" widget="selection" />
+                    <field name="partner_bank_id" />
+                    <field name="user_id" />
+                    <field name="comment" />
+                </group>
+                <group name="lines">
+                    <field name="line_ids" nolabel="1">
+                        <tree
+                            editable="bottom"
+                            create="false"
+                            delete="false"
+                            edit="true"
+                        >
+                            <field name="invoice_line_id" invisible="1" />
+                            <field name="display_type" invisible="1" />
+                            <field name="name" />
+                            <field
+                                name="quantity"
+                                attrs="{'invisible': [('display_type', '!=', False)]}"
+                            />
+                            <field
+                                name="price_subtotal"
+                                attrs="{'invisible': [('display_type', '!=', False)]}"
+                            />
+                            <field
+                                name="account_analytic_id"
+                                attrs="{'invisible': [('display_type', '!=', False)]}"
+                                groups="analytic.group_analytic_accounting"
+                            />
+                            <field
+                                name="analytic_tag_ids"
+                                attrs="{'invisible': [('display_type', '!=', False)]}"
+                                groups="analytic.group_analytic_accounting"
+                                widget="many2many_tags"
+                            />
+                    </tree>
+                    </field>
+                </group>
+                <footer>
+                    <button
+                        name="run"
+                        type="object"
+                        class="oe_highlight"
+                        string="Update"
+                    />
+                    <button special="cancel" string="Cancel" class="oe_link" />
+                </footer>
+            </form>
+        </field>
+    </record>
+
+    <record id="account_invoice_update_action" model="ir.actions.act_window">
+        <field name="name">Invoice Update Wizard</field>
+        <field name="res_model">account.invoice.update</field>
+        <field name="view_mode">form</field>
+        <field name="target">new</field>
+    </record>
+
+</odoo>

account_move_line_start_end_dates_xls/__init__.py

@@ -1,23 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Move Line Start End Dates XLS module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com/)
-#    @author: Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from . import account_move_line

account_move_line_start_end_dates_xls/__openerp__.py

@@ -1,43 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Account Move Line Start End Dates XLS module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com/)
-#    @author: Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Account Move Line Start End Dates XLS',
-    'version': '0.1',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Adds start and end dates in the XLS export of the move lines',
-    'description': """
-Account Move Line Start End Dates XLS
-=====================================
-
-This module adds *Start Date* and *End Date* in the XLS export of the account move lines.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-""",
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com/',
-    'depends': ['account_cutoff_prepaid', 'account_move_line_report_xls'],
-    'data': [],
-    'active': False,
-}

account_move_line_start_end_dates_xls/account_move_line.py

@@ -1,61 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Move Line Start End Dates XLS module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com/)
-#    @author: Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-import xlwt
-from openerp.osv import orm
-from openerp.addons.report_xls.utils import _render
-from openerp.addons.report_xls.report_xls import report_xls
-
-
-class account_move_line(orm.Model):
-    _inherit = 'account.move.line'
-
-    def _report_xls_template(self, cr, uid, context=None):
-        res = super(account_move_line, self)._report_xls_template(
-            cr, uid, context=context)
-        bc = '22'
-        aml_cell_style_date = xlwt.easyxf(
-            'borders: left thin, right thin, top thin, bottom thin, '
-            'left_colour %s, right_colour %s, top_colour %s, '
-            'bottom_colour %s; align: horz left;'
-            % (bc, bc, bc, bc), num_format_str=report_xls.date_format)
-        res.update({
-            'start_date': {
-                'header': [1, 13, 'text', _render("_('Start Date')")],
-                'lines': [1, 0, _render(
-                    "line.start_date and line.start_date != 'False' and "
-                    "'date' or 'text'"), _render(
-                    "line.start_date and line.start_date != 'False' and "
-                    "datetime.strptime(line.start_date, '%Y-%m-%d') or None"),
-                    None, aml_cell_style_date],
-                'totals': [1, 0, 'text', None]},
-            'end_date': {
-                'header': [1, 13, 'text', _render("_('End Date')")],
-                'lines': [1, 0, _render(
-                    "line.end_date and line.end_date != 'False' and "
-                    "'date' or 'text'"), _render(
-                    "line.end_date and line.end_date != 'False' and "
-                    "datetime.strptime(line.end_date, '%Y-%m-%d') or None"),
-                    None, aml_cell_style_date],
-                'totals': [1, 0, 'text', None]},
-            })
-        return res

account_payment_hide_communication2/__init__.py

@@ -1,21 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Payment Hide Communication2 module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################

account_payment_hide_communication2/__openerp__.py

@@ -1,43 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Payment Hide Communication2 module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-{
-    'name': 'Account Payment Hide Communication2',
-    'version': '1.0',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Hide the field Communication2 on Payment Lines',
-    'description': """
-Account Payment Hide Communication2
-===================================
-
-This module hides the field 'Communication2' on the form view of Payment Lines. I consider that is field is useless and tend to confuse users.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-""",
-    'author': 'Akretion',
-    'depends': ['account_payment'],
-    'data': [
-        'payment_view.xml',
-        ],
-    'active': False,
-}

account_payment_hide_communication2/payment_view.xml

@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-   Copyright (C) 2014 Akretion (http://www.akretion.com/)
-   @author: Alexis de Lattre <alexis.delattre@akretion.com>
-   The licence is in the file __openerp__.py
--->
-
-<openerp>
-<data>
-
-<record id="view_payment_order_form" model="ir.ui.view">
-    <field name="name">hide.communication2.on.payment.line.form</field>
-    <field name="model">payment.order</field>
-    <field name="inherit_id" ref="account_payment.view_payment_order_form"/>
-    <field name="arch" type="xml">
-        <xpath expr="//field[@name='line_ids']/form//field[@name='communication2']" position="replace" />
-    </field>
-</record>
-
-</data>
-</openerp>

account_payment_security/__init__.py

@@ -1,21 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Payment Security module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################

account_payment_security/__openerp__.py

@@ -1,46 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    Account Payment Security module for OpenERP
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-{
-    'name': 'Account Payment Security',
-    'version': '1.0',
-    'category': 'Accounting & Finance',
-    'license': 'AGPL-3',
-    'summary': 'Only members of Account Payment can create/write on bank accounts',
-    'description': """
-Account Payment Security
-========================
-
-By default in OpenERP, members of the group *Contact Creation* can create and modify bank accounts ; this can be a risk, as explained in this mail : https://lists.launchpad.net/openerp-community/msg01035.html
-
-With this module, only the members of the group *Accounting / Payments* can create and modify bank accounts. Also, some rights on the configuration of bank accounts (res.partner.bank.type and res.partner.bank.type.field) are moved from the group *Contact Creation* to *Financial Manager*.
-
-Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
-""",
-    'author': 'Akretion',
-    'depends': ['account_payment'],
-    'data': [
-        'security/ir.model.access.csv',
-        'security/payment_security.xml',
-        ],
-    'active': False,
-}

account_payment_security/security/ir.model.access.csv

@@ -1,5 +0,0 @@
-id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_res_partner_bank_account_payment,Full access on res.partner.bank to Account Payment,base.model_res_partner_bank,account_payment.group_account_payment,1,1,1,1
-access_res_bank_account_payment,Full access on res.bank to Account Payment,base.model_res_bank,account_payment.group_account_payment,1,1,1,1
-access_res_partner_bank_type_account_manager,Full access on res.partner.bank.type to Financial Manager,base.model_res_partner_bank_type,account.group_account_manager,1,1,1,1
-access_res_partner_bank_type_field_account_manager,Full access on res.partner.bank.type.field to Financial Manager,base.model_res_partner_bank_type_field,account.group_account_manager,1,1,1,1

account_payment_security/security/payment_security.xml

@@ -1,22 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<!--
-    Copyright (C) 2014 Akretion (http://www.akretion.com/)
-    @author Alexis de Lattre <alexis.delattre@akretion.com>
-    The licence is in the file __openerp__.py
--->
-
-<openerp>
-<data>
-
-<delete model="ir.model.access"
-        id="base.access_res_bank_group_partner_manager"/>
-<delete model="ir.model.access"
-        id="base.access_res_partner_bank_group_partner_manager"/>
-<delete model="ir.model.access"
-        id="base.access_res_partner_bank_type_group_partner_manager"/>
-<delete model="ir.model.access"
-        id="base.access_res_partner_bank_type_field_group_partner_manager"/>
-
-</data>
-</openerp>

account_usability/README.rst

@@ -0,0 +1,96 @@
+=================
+Account Usability
+=================
+
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github
+    :target: https://github.com/akretion/odoo-usability/tree/12.0/account_usability
+    :alt: akretion/odoo-usability
+
+|badge1| |badge2| |badge3| 
+
+This modules adds the following functions:
+
+* Add an *Overdue* filter on invoice search view (this feature was previously 
+  located in te module *account_invoice_overdue_filter*)
+* Increase the default limit of 80 lines in account move and account move line view.
+* disable reconciliation "guessing"
+* fast search on *Reconcile Ref* for account move line.
+* add sale dates to invoice report to be compliant with
+  https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808
+* Sale date on qweb invoices
+* A wizard to mark several invoices as sent at once (forward from v8)
+* Default date for Account Move Reversal is now D+1 instead of today
+* Track more fields on invoice (see details in account.py)
+* Add boolean fields `has_discount` and `has_attachment` on invoice
+* Add button "Delete line qty = 0" on supplier invoice
+* Cut name_get() of invoice if too long
+* A script for if Odoo screws up invoice attachment filename
+* help functions for py3o reports
+* Show code on name_get of journal
+* add direct search of journal using code
+* add copy=False on some fields
+* Add unicity constraint on analytic codes per company
+* Better default values on account move
+* Add link from account move line to invoice
+* Add start_date and end_date on bank statements
+* Add transfer_account_id to invoicing config page
+* Improve domain reconciliation widget
+* account.reconcile.model don't copy name to label via onchange
+* Add method to get fiscal position without partner_id
+* Restore drill-through on sale and invoice reports
+* don't attach PDF upon invoice report generation on supplier invoices/refunds
+* Add filter on debit and credit amount for Move Lines
+* Add supplier invoice number in invoice tree view
+
+Together with this module, I recommend the use of the following modules:
+
+* account_invoice_supplier_ref_unique (OCA project account-invoicing)
+* account_move_line_no_default_search (OCA project account-financial-tools)
+* invoice_fiscal_position_update (OCA project account-invoicing)
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/akretion/odoo-usability/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+`feedback <https://github.com/akretion/odoo-usability/issues/new?body=module:%20account_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+~~~~~~~
+
+* Akretion
+
+Contributors
+~~~~~~~~~~~~
+
+* Alexis de Lattre <alexis.delattre@akretion.com>
+* David Beal <david.beal@akretion.com>
+
+Maintainers
+~~~~~~~~~~~
+
+This module is part of the `akretion/odoo-usability <https://github.com/akretion/odoo-usability/tree/12.0/account_usability>`_ project on GitHub.
+
+You are welcome to contribute.

account_usability/__init__.py

@@ -0,0 +1,2 @@
+from . import models
+from . import wizard

account_usability/__manifest__.py

@@ -0,0 +1,38 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Account Usability",
+    "version": "14.0.1.0.0",
+    "category": "Accounting & Finance",
+    "license": "AGPL-3",
+    "summary": "Small usability enhancements in account module",
+    "author": "Akretion",
+    "website": "https://github.com/OCA/odoo-usability",
+    "depends": [
+        "account",
+        "base_view_inheritance_extension",
+        "base_usability",  # needed only to access base_usability.group_nobody
+        # in v12, I may create a module only for group_nobody
+    ],
+    "data": [
+        "views/account_account_type.xml",
+        "views/account_account.xml",
+        "views/account_bank_statement.xml",
+        "views/account_invoice_report.xml",
+        "views/account_journal.xml",
+        "views/account_move.xml",
+        "views/account_menu.xml",
+        "views/account_tax.xml",
+        "views/product.xml",
+        "views/res_config_settings.xml",
+        "views/res_partner.xml",
+        "views/account_report.xml",
+        "wizard/account_invoice_mark_sent_view.xml",
+        "wizard/account_group_generate_view.xml",
+        "wizard/account_payment_register_views.xml",
+        "security/ir.model.access.csv",
+    ],
+    "installable": True,
+}

account_usability/invoice_register_payment_writeoff_analytic.diff

@@ -0,0 +1,55 @@
+diff --git a/addons/account/models/account_payment.py b/addons/account/models/account_payment.py
+index 2dd1f9cef83..62275fca65e 100644
+--- a/addons/account/models/account_payment.py
++++ b/addons/account/models/account_payment.py
+@@ -262,6 +262,7 @@ class AccountPayment(models.Model):
+                 'credit': write_off_balance > 0.0 and write_off_balance or 0.0,
+                 'partner_id': self.partner_id.id,
+                 'account_id': write_off_line_vals.get('account_id'),
++                'analytic_account_id': write_off_line_vals.get('analytic_account_id'),
+             })
+         return line_vals_list
+
+@@ -699,6 +700,7 @@ class AccountPayment(models.Model):
+                     'name': writeoff_lines[0].name,
+                     'amount': writeoff_amount * sign,
+                     'account_id': writeoff_lines[0].account_id.id,
++                    'analytic_account_id': writeoff_lines[0].analytic_account_id.id,
+                 }
+             else:
+                 write_off_line_vals = {}
+diff --git a/addons/account/wizard/account_payment_register.py b/addons/account/wizard/account_payment_register.py
+index 3fc91f716ad..35636774c7e 100644
+--- a/addons/account/wizard/account_payment_register.py
++++ b/addons/account/wizard/account_payment_register.py
+@@ -93,6 +93,7 @@ class AccountPaymentRegister(models.TransientModel):
+     ], default='open', string="Payment Difference Handling")
+     writeoff_account_id = fields.Many2one('account.account', string="Difference Account", copy=False,
+         domain="[('deprecated', '=', False), ('company_id', '=', company_id)]")
++    writeoff_analytic_account_id = fields.Many2one('account.analytic.account', string="Difference Analytic Account", copy=False, domain="[('company_id', '=', company_id)]")
+     writeoff_label = fields.Char(string='Journal Item Label', default='Write-Off',
+         help='Change label of the counterpart that will hold the payment difference')
+
+@@ -422,6 +423,7 @@ class AccountPaymentRegister(models.TransientModel):
+                 'name': self.writeoff_label,
+                 'amount': self.payment_difference,
+                 'account_id': self.writeoff_account_id.id,
++                'analytic_account_id': self.writeoff_analytic_account_id.id or False,
+             }
+         return payment_vals
+
+diff --git a/addons/account/wizard/account_payment_register_views.xml b/addons/account/wizard/account_payment_register_views.xml
+index 16eec30e265..b9386567baa 100644
+--- a/addons/account/wizard/account_payment_register_views.xml
++++ b/addons/account/wizard/account_payment_register_views.xml
+@@ -65,6 +65,10 @@
+                                            string="Post Difference In"
+                                            options="{'no_create': True}"
+                                            attrs="{'required': [('payment_difference_handling', '=', 'reconcile')]}"/>
++                                    <label for="writeoff_analytic_account_id" class="oe_edit_only" string="Analytic Account" groups="analytic.group_analytic_accounting"/>
++                                    <field name="writeoff_analytic_account_id"
++                                           groups="analytic.group_analytic_accounting"
++                                           options="{'no_create': True}" />
+                                     <label for="writeoff_label" class="oe_edit_only" string="Label"/>
+                                     <field name="writeoff_label" attrs="{'required': [('payment_difference_handling', '=', 'reconcile')]}"/>
+                                 </div>

account_usability/models/__init__.py

@@ -0,0 +1,9 @@
+from . import account_account
+from . import account_analytic_account
+from . import account_bank_statement
+from . import account_incoterms
+from . import account_journal
+from . import account_move
+from . import account_partial_reconcile
+from . import res_partner
+from . import product

account_usability/models/account_account.py

@@ -0,0 +1,66 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+import logging
+
+from odoo import api, models
+
+logger = logging.getLogger(__name__)
+
+
+class AccountAccount(models.Model):
+    _inherit = "account.account"
+
+    @api.depends("name", "code")
+    def name_get(self):
+        if self._context.get("account_account_show_code_only"):
+            res = []
+            for record in self:
+                res.append((record.id, record.code))
+            return res
+        else:
+            return super().name_get()
+
+    # https://github.com/odoo/odoo/issues/23040
+    # TODO mig to v14 ?
+    def fix_bank_account_types(self):
+        aao = self.env["account.account"]
+        companies = self.env["res.company"].search([])
+        if len(companies) > 1:
+            self = self.sudo()
+        logger.info("START the script 'fix bank and cash account types'")
+        bank_type = self.env.ref("account.data_account_type_liquidity")
+        asset_type = self.env.ref("account.data_account_type_current_assets")
+        journals = self.env["account.journal"].search(
+            [("type", "in", ("bank", "cash"))], order="company_id"
+        )
+        journal_accounts_bank_type = aao
+        for journal in journals:
+            for account in [
+                journal.default_credit_account_id,
+                journal.default_debit_account_id,
+            ]:
+                if account:
+                    if account.user_type_id != bank_type:
+                        account.user_type_id = bank_type.id
+                        logger.info(
+                            "Company %s: Account %s updated to Bank " "and Cash type",
+                            account.company_id.display_name,
+                            account.code,
+                        )
+                    if account not in journal_accounts_bank_type:
+                        journal_accounts_bank_type += account
+        accounts = aao.search(
+            [("user_type_id", "=", bank_type.id)], order="company_id, code"
+        )
+        for account in accounts:
+            if account not in journal_accounts_bank_type:
+                account.user_type_id = asset_type.id
+                logger.info(
+                    "Company %s: Account %s updated to Current Asset type",
+                    account.company_id.display_name,
+                    account.code,
+                )
+        logger.info("END of the script 'fix bank and cash account types'")
+        return True

account_usability/models/account_analytic_account.py

@@ -0,0 +1,27 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import models
+
+
+class AccountAnalyticAccount(models.Model):
+    _inherit = "account.analytic.account"
+
+    def name_get(self):
+        if self._context.get("analytic_account_show_code_only"):
+            res = []
+            for record in self:
+                res.append((record.id, record.code or record.name))
+            return res
+        else:
+            return super().name_get()
+
+    _sql_constraints = [
+        (
+            "code_company_unique",
+            "unique(code, company_id)",
+            "An analytic account with the same code already "
+            "exists in the same company!",
+        )
+    ]

account_usability/models/account_bank_statement.py

@@ -0,0 +1,99 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+from odoo.tools.misc import format_date
+
+
+class AccountBankStatement(models.Model):
+    _inherit = "account.bank.statement"
+
+    start_date = fields.Date(
+        compute="_compute_dates", string="Start Date", readonly=True, store=True
+    )
+    end_date = fields.Date(
+        compute="_compute_dates", string="End Date", readonly=True, store=True
+    )
+    hide_bank_statement_balance = fields.Boolean(
+        related="journal_id.hide_bank_statement_balance", readonly=True
+    )
+
+    @api.depends("line_ids.date")
+    def _compute_dates(self):
+        for st in self:
+            dates = [line.date for line in st.line_ids]
+            st.start_date = dates and min(dates) or False
+            st.end_date = dates and max(dates) or False
+
+    def _check_balance_end_real_same_as_computed(self):
+        for stmt in self:
+            if stmt.hide_bank_statement_balance:
+                continue
+            else:
+                super(
+                    AccountBankStatement, stmt
+                )._check_balance_end_real_same_as_computed()
+        return True
+
+    @api.depends("name", "start_date", "end_date")
+    def name_get(self):
+        res = []
+        for statement in self:
+            name = "%s (%s => %s)" % (
+                statement.name,
+                statement.start_date
+                and format_date(self.env, statement.start_date)
+                or "",
+                statement.end_date and format_date(self.env, statement.end_date) or "",
+            )
+            res.append((statement.id, name))
+        return res
+
+
+class AccountBankStatementLine(models.Model):
+    _inherit = "account.bank.statement.line"
+    # Native order is:
+    # _order = 'statement_id desc, sequence, id desc'
+    _order = "statement_id desc, date desc, sequence, id desc"
+
+    # Disable guessing for reconciliation
+    # because my experience with several customers shows that it is a problem
+    # in the following scenario : move line 'x' has been "guessed" by OpenERP
+    # to be reconciled with a statement line 'Y' at the end of the bank
+    # statement, but it is a mistake because it should be reconciled with
+    # statement line 'B' at the beginning of the bank statement
+    # When the user is on statement line 'B', he tries to select
+    # move line 'x', but it can't find it... because it is already "reserved"
+    # by the guess of OpenERP for statement line 'Y' ! To solve this problem,
+    # the user must go to statement line 'Y' and unselect move line 'x'
+    # and then come back on statement line 'B' and select move line 'A'...
+    # but non super-expert users can't do that because it is impossible to
+    # figure out that the fact that the user can't find move line 'x'
+    # is caused by this.
+    # Set search_reconciliation_proposition to False by default
+    # TODO: re-write in v10
+    # def get_data_for_reconciliations(
+    #        self, cr, uid, ids, excluded_ids=None,
+    #        search_reconciliation_proposition=False, context=None):
+    #    # Make variable name shorted for PEP8 !
+    #    search_rec_prop = search_reconciliation_proposition
+    #    return super().\
+    #        get_data_for_reconciliations(
+    #            cr, uid, ids, excluded_ids=excluded_ids,
+    #            search_reconciliation_proposition=search_rec_prop,
+    #            context=context)
+
+    def show_account_move(self):
+        self.ensure_one()
+        action = self.env.ref("account.action_move_line_form").read()[0]
+        # Note: this action is on account.move, not account.move.line !
+        action.update(
+            {
+                "views": False,
+                "view_id": False,
+                "view_mode": "form,tree",
+                "res_id": self.move_id.id,
+            }
+        )
+        return action

account_usability/models/account_incoterms.py

@@ -0,0 +1,16 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, models
+
+
+class AccountIncoterms(models.Model):
+    _inherit = "account.incoterms"
+
+    @api.depends("code", "name")
+    def name_get(self):
+        res = []
+        for rec in self:
+            res.append((rec.id, "[%s] %s" % (rec.code, rec.name)))
+        return res

account_usability/models/account_journal.py

@@ -0,0 +1,62 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+
+
+class AccountJournal(models.Model):
+    _inherit = "account.journal"
+
+    hide_bank_statement_balance = fields.Boolean(
+        string="Hide Bank Statement Balance",
+        help="You may want to enable this option when your bank "
+        "journal is generated from a bank statement file that "
+        "doesn't handle start/end balance (QIF for instance) and "
+        "you don't want to enter the start/end balance manually: it "
+        "will prevent the display of wrong information in the accounting "
+        "dashboard and on bank statements.",
+    )
+
+    @api.depends("name", "currency_id", "company_id", "company_id.currency_id", "code")
+    def name_get(self):
+        res = []
+        if self._context.get("journal_show_code_only"):
+            for journal in self:
+                res.append((journal.id, journal.code))
+            return res
+        else:
+            for journal in self:
+                name = "[%s] %s" % (journal.code, journal.name)
+                if (
+                    journal.currency_id
+                    and journal.currency_id != journal.company_id.currency_id
+                ):
+                    name = "%s (%s)" % (name, journal.currency_id.name)
+                res.append((journal.id, name))
+            return res
+
+
+#    @api.constrains('default_credit_account_id', 'default_debit_account_id')
+#    def _check_account_type_on_bank_journal(self):
+#        bank_acc_type = self.env.ref('account.data_account_type_liquidity')
+#        for jrl in self:
+#            if jrl.type in ('bank', 'cash'):
+#                if (
+#                        jrl.default_debit_account_id and
+#                        jrl.default_debit_account_id.user_type_id !=
+#                        bank_acc_type):
+#                    raise ValidationError(_(
+#                        "On journal '%s', the default debit account '%s' "
+#                        "should be configured with Type = 'Bank and Cash'.")
+#                        % (jrl.display_name,
+#                           jrl.default_debit_account_id.display_name))
+#                if (
+#                        jrl.default_credit_account_id and
+#                        jrl.default_credit_account_id.user_type_id !=
+#                        bank_acc_type):
+#                    raise ValidationError(_(
+#                        "On journal '%s', the default credit account '%s' "
+#                        "should be configured with Type = 'Bank and Cash'.")
+#                        % (jrl.display_name,
+#                           jrl.default_credit_account_id.display_name))

account_usability/models/account_move.py

@@ -0,0 +1,293 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+from odoo.osv import expression
+from odoo.tools import float_is_zero
+from odoo.tools.misc import format_date
+
+
+class AccountMove(models.Model):
+    _inherit = "account.move"
+
+    # By default, we can still modify "ref" when account move is posted
+    # which seems a bit lazy for me...
+    ref = fields.Char(states={"posted": [("readonly", True)]})
+    date = fields.Date(tracking=True)
+    invoice_date_due = fields.Date(tracking=True)
+    invoice_payment_term_id = fields.Many2one(tracking=True)
+    journal_id = fields.Many2one(tracking=True)
+    partner_bank_id = fields.Many2one(tracking=True)
+    fiscal_position_id = fields.Many2one(tracking=True)
+    amount_total = fields.Monetary(tracking=True)
+    # for invoice report
+    has_discount = fields.Boolean(compute="_compute_has_discount", readonly=True)
+    # has_attachment is useful for those who use attachment to archive
+    # supplier invoices. It allows them to find supplier invoices
+    # that don't have any attachment
+    has_attachment = fields.Boolean(
+        compute="_compute_has_attachment",
+        search="_search_has_attachment",
+        readonly=True,
+    )
+    sale_dates = fields.Char(
+        compute="_compute_sales_dates",
+        readonly=True,
+        help="This information appears on invoice qweb report "
+        "(you may use it for your own report)",
+    )
+
+    def _compute_has_discount(self):
+        prec = self.env["decimal.precision"].precision_get("Discount")
+        for inv in self:
+            has_discount = False
+            for line in inv.invoice_line_ids:
+                if not line.display_type and not float_is_zero(
+                    line.discount, precision_digits=prec
+                ):
+                    has_discount = True
+                    break
+            inv.has_discount = has_discount
+
+    def _compute_has_attachment(self):
+        iao = self.env["ir.attachment"]
+        for move in self:
+            if iao.search_count(
+                [
+                    ("res_model", "=", "account.move"),
+                    ("res_id", "=", move.id),
+                    ("type", "=", "binary"),
+                    ("company_id", "=", move.company_id.id),
+                ]
+            ):
+                move.has_attachment = True
+            else:
+                move.has_attachment = False
+
+    def _search_has_attachment(self, operator, value):
+        att_inv_ids = {}
+        if operator == "=":
+            search_res = self.env["ir.attachment"].search_read(
+                [
+                    ("res_model", "=", "account.move"),
+                    ("type", "=", "binary"),
+                    ("res_id", "!=", False),
+                ],
+                ["res_id"],
+            )
+            for att in search_res:
+                att_inv_ids[att["res_id"]] = True
+        res = [("id", value and "in" or "not in", list(att_inv_ids))]
+        return res
+
+    # when you have an invoice created from a lot of sale orders, the 'name'
+    # field is very large, which makes the name_get() of that invoice very big
+    # which screws-up the form view of that invoice because of the link at the
+    # top of the screen
+    # That's why we have to cut the name_get() when it's too long
+    def name_get(self):
+        old_res = super().name_get()
+        res = []
+        for old_re in old_res:
+            name = old_re[1]
+            if name and len(name) > 100:
+                # nice cut
+                name = "%s ..." % ", ".join(name.split(", ")[:3])
+                # if not enough, hard cut
+                if len(name) > 120:
+                    name = "%s ..." % old_re[1][:120]
+            res.append((old_re[0], name))
+        return res
+
+    # I really hate to see a "/" in the 'name' field of the account.move.line
+    # generated from customer invoices linked to the partners' account because:
+    # 1) the label of an account move line is an important field, we can't
+    #    write a rubbish '/' in it !
+    # 2) the 'name' field of the account.move.line is used in the overdue
+    # letter, and '/' is not meaningful for our customer !
+    # TODO mig to v12
+    #    def action_move_create(self):
+    #        res = super().action_move_create()
+    #        for inv in self:
+    #            self._cr.execute(
+    #                "UPDATE account_move_line SET name= "
+    #                "CASE WHEN name='/' THEN %s "
+    #                "ELSE %s||' - '||name END "
+    #                "WHERE move_id=%s", (inv.number, inv.number, inv.move_id.id))
+    #            self.invalidate_cache()
+    #        return res
+
+    def delete_lines_qty_zero(self):
+        lines = self.env["account.move.line"].search(
+            [
+                ("display_type", "=", False),
+                ("move_id", "in", self.ids),
+                ("quantity", "=", 0),
+            ]
+        )
+        lines.unlink()
+        return True
+
+    # for report
+    def py3o_lines_layout(self):
+        self.ensure_one()
+        res = []
+        has_sections = False
+        subtotal = 0.0
+        sign = self.move_type == "out_refund" and -1 or 1
+        # Warning: the order of invoice line is forced in the view
+        # <tree editable="bottom" default_order="sequence, date desc, move_name desc, id"
+        # it's not the same as the _order in the class AccountMoveLine
+        lines = self.env["account.move.line"].search(
+            [("exclude_from_invoice_tab", "=", False), ("move_id", "=", self.id)],
+            order="sequence, date desc, move_name desc, id",
+        )
+        for line in lines:
+            if line.display_type == "line_section":
+                # insert line
+                if has_sections:
+                    res.append({"subtotal": subtotal})
+                subtotal = 0.0  # reset counter
+                has_sections = True
+            else:
+                if not line.display_type:
+                    subtotal += line.price_subtotal * sign
+            res.append({"line": line})
+        if has_sections:  # insert last subtotal line
+            res.append({"subtotal": subtotal})
+        # res:
+        # [
+        #    {'line': account_invoice_line(1) with display_type=='line_section'},
+        #    {'line': account_invoice_line(2) without display_type},
+        #    {'line': account_invoice_line(3) without display_type},
+        #    {'line': account_invoice_line(4) with display_type=='line_note'},
+        #    {'subtotal': 8932.23},
+        # ]
+        return res
+
+    def _compute_sales_dates(self):
+        """French law requires to set sale order dates into invoice
+        returned string: "sale1 (date1), sale2 (date2) ..."
+        """
+        for inv in self:
+            sales = inv.invoice_line_ids.mapped("sale_line_ids").mapped("order_id")
+            dates = [
+                "%s (%s)" % (x.name, format_date(inv.env, self.date_order))
+                for x in sales
+            ]
+            inv.sale_dates = ", ".join(dates)
+
+    # allow to manually create moves not only in general journals,
+    # but also in cash journal and check journals (= bank journals not linked to a bank account)
+    @api.depends("company_id", "invoice_filter_type_domain")
+    def _compute_suitable_journal_ids(self):
+        for move in self:
+            if move.invoice_filter_type_domain:
+                super(AccountMove, move)._compute_suitable_journal_ids()
+            else:
+                company_id = move.company_id.id or self.env.company.id
+                domain = expression.AND(
+                    [
+                        [("company_id", "=", company_id)],
+                        expression.OR(
+                            [
+                                [("type", "in", ("general", "cash"))],
+                                [
+                                    ("type", "=", "bank"),
+                                    ("bank_account_id", "=", False),
+                                ],
+                            ]
+                        ),
+                    ]
+                )
+                move.suitable_journal_ids = self.env["account.journal"].search(domain)
+
+    def button_draft(self):
+        super().button_draft()
+        # Delete attached pdf invoice
+        try:
+            report_invoice = self.env["ir.actions.report"]._get_report_from_name(
+                "account.report_invoice"
+            )
+        except IndexError:
+            report_invoice = False
+        if report_invoice and report_invoice.attachment:
+            for move in self.filtered(
+                lambda x: x.move_type in ("out_invoice", "out_refund")
+            ):
+                # The pb is that the filename is dynamic and related to move.state
+                # in v12, the feature was native and they used that kind of code:
+                # with invoice.env.do_in_draft():
+                #    invoice.number, invoice.state = invoice.move_name, 'open'
+                #    attachment = self.env.ref('account.account_invoices').retrieve_attachment(invoice)
+                # But do_in_draft() doesn't exists in v14
+                # If you know how we could do that, please update the code below
+                attachment = self.env["ir.attachment"].search(
+                    [
+                        ("name", "=", self._get_invoice_attachment_name()),
+                        ("res_id", "=", move.id),
+                        ("res_model", "=", self._name),
+                        ("type", "=", "binary"),
+                    ],
+                    limit=1,
+                )
+                if attachment:
+                    attachment.unlink()
+
+    def _get_invoice_attachment_name(self):
+        self.ensure_one()
+        return "%s.pdf" % (self.name and self.name.replace("/", "_") or "INV")
+
+
+class AccountMoveLine(models.Model):
+    _inherit = "account.move.line"
+    # Native order:
+    # _order = "date desc, move_name desc, id"
+    # Problem: when you manually create a journal entry, the
+    # order of the lines is inverted when you save ! It is quite annoying for
+    # the user...
+    _order = "date desc, id asc"
+
+    # In the 'account' module, we have related stored field for:
+    # name (move_name), date, ref, state (parent_state),
+    # journal_id, company_id, payment_id, statement_line_id,
+    account_reconcile = fields.Boolean(related="account_id.reconcile")
+    full_reconcile_id = fields.Many2one(string="Full Reconcile")
+    matched_debit_ids = fields.One2many(string="Partial Reconcile Debit")
+    matched_credit_ids = fields.One2many(string="Partial Reconcile Credit")
+    reconcile_string = fields.Char(
+        compute="_compute_reconcile_string", string="Reconcile", store=True
+    )
+    # for optional display in tree view
+    product_barcode = fields.Char(
+        related="product_id.barcode", string="Product Barcode"
+    )
+
+    def show_account_move_form(self):
+        self.ensure_one()
+        action = self.env.ref("account.action_move_line_form").read()[0]
+        action.update(
+            {
+                "res_id": self.move_id.id,
+                "view_id": False,
+                "views": False,
+                "view_mode": "form,tree",
+            }
+        )
+        return action
+
+    @api.depends("full_reconcile_id", "matched_debit_ids", "matched_credit_ids")
+    def _compute_reconcile_string(self):
+        for line in self:
+            rec_str = False
+            if line.full_reconcile_id:
+                rec_str = line.full_reconcile_id.name
+            else:
+                rec_str = ", ".join(
+                    [
+                        "a%d" % pr.id
+                        for pr in line.matched_debit_ids + line.matched_credit_ids
+                    ]
+                )
+            line.reconcile_string = rec_str

account_usability/models/account_partial_reconcile.py

@@ -0,0 +1,24 @@
+# Copyright 2015-2020 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import models
+from odoo.tools.misc import formatLang
+
+
+class AccountPartialReconcile(models.Model):
+    _inherit = "account.partial.reconcile"
+    _rec_name = "id"
+
+    def name_get(self):
+        res = []
+        for rec in self:
+            # There is no seq for partial rec, so I simulate one with the ID
+            # Prefix for full rec: 'A' (upper case)
+            # Prefix for partial rec: 'a' (lower case)
+            amount_fmt = formatLang(
+                self.env, rec.amount, currency_obj=rec.company_currency_id
+            )
+            name = "a%d (%s)" % (rec.id, amount_fmt)
+            res.append((rec.id, name))
+        return res

account_usability/models/product.py

@@ -0,0 +1,62 @@
+# Copyright 2015-2021 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import _, api, fields, models
+
+
+class ProductTemplate(models.Model):
+    _inherit = "product.template"
+
+    # DON'T put store=True on those fields, because they are company dependent
+    sale_price_type = fields.Selection(
+        "_sale_purchase_price_type_sel",
+        compute="_compute_sale_price_type",
+        string="Sale Price Type",
+        compute_sudo=False,
+        readonly=True,
+    )
+    purchase_price_type = fields.Selection(
+        "_sale_purchase_price_type_sel",
+        compute="_compute_purchase_price_type",
+        string="Purchase Price Type",
+        compute_sudo=False,
+        readonly=True,
+    )
+
+    @api.model
+    def _sale_purchase_price_type_sel(self):
+        return [("incl", _("Tax incl.")), ("excl", _("Tax excl."))]
+
+    @api.depends("taxes_id")
+    def _compute_sale_price_type(self):
+        for pt in self:
+            sale_price_type = "incl"
+            if pt.taxes_id and all(
+                [not t.price_include for t in pt.taxes_id if t.amount_type == "percent"]
+            ):
+                sale_price_type = "excl"
+            pt.sale_price_type = sale_price_type
+
+    @api.depends("supplier_taxes_id")
+    def _compute_purchase_price_type(self):
+        for pt in self:
+            purchase_price_type = "incl"
+            if pt.supplier_taxes_id and all(
+                [
+                    not t.price_include
+                    for t in pt.supplier_taxes_id
+                    if t.amount_type == "percent"
+                ]
+            ):
+                purchase_price_type = "excl"
+            pt.purchase_price_type = purchase_price_type
+
+
+class ProductSupplierinfo(models.Model):
+    _inherit = "product.supplierinfo"
+
+    # DON'T put store=True on those fields, because they are company dependent
+    purchase_price_type = fields.Selection(
+        related="product_tmpl_id.purchase_price_type", related_sudo=False
+    )

account_usability/models/res_partner.py

@@ -0,0 +1,12 @@
+# Copyright 2017-2020 Akretion France (https://akretion.com/)
+# @author: Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import fields, models
+
+
+class ResPartner(models.Model):
+    _inherit = "res.partner"
+
+    invoice_warn = fields.Selection(tracking=True)
+    property_account_position_id = fields.Many2one(tracking=True)

account_usability/readme/CONTRIBUTORS.rst

@@ -0,0 +1,2 @@
+* Alexis de Lattre <alexis.delattre@akretion.com>
+* David Beal <david.beal@akretion.com>

account_usability/readme/DESCRIPTION.rst

@@ -0,0 +1,39 @@
+This modules adds the following functions:
+
+* Add an *Overdue* filter on invoice search view (this feature was previously
+  located in te module *account_invoice_overdue_filter*)
+* Increase the default limit of 80 lines in account move and account move line view.
+* disable reconciliation "guessing"
+* fast search on *Reconcile Ref* for account move line.
+* add sale dates to invoice report to be compliant with
+  https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808
+* Sale date on qweb invoices
+* A wizard to mark several invoices as sent at once (forward from v8)
+* Default date for Account Move Reversal is now D+1 instead of today
+* Track more fields on invoice (see details in account.py)
+* Add boolean fields `has_discount` and `has_attachment` on invoice
+* Add button "Delete line qty = 0" on supplier invoice
+* Cut name_get() of invoice if too long
+* A script for if Odoo screws up invoice attachment filename
+* help functions for py3o reports
+* Show code on name_get of journal
+* add direct search of journal using code
+* add copy=False on some fields
+* Add unicity constraint on analytic codes per company
+* Better default values on account move
+* Add link from account move line to invoice
+* Add start_date and end_date on bank statements
+* Add transfer_account_id to invoicing config page
+* Improve domain reconciliation widget
+* account.reconcile.model don't copy name to label via onchange
+* Add method to get fiscal position without partner_id
+* Restore drill-through on sale and invoice reports
+* don't attach PDF upon invoice report generation on supplier invoices/refunds
+* Add filter on debit and credit amount for Move Lines
+* Add supplier invoice number in invoice tree view
+
+Together with this module, I recommend the use of the following modules:
+
+* account_invoice_supplier_ref_unique (OCA project account-invoicing)
+* account_move_line_no_default_search (OCA project account-financial-tools)
+* invoice_fiscal_position_update (OCA project account-invoicing)

account_usability/report/invoice_report.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+
+<template id="report_invoice_document" inherit_id="account.report_invoice_document">
+    <xpath expr="//div[@name='origin']/p" position="replace">
+        <p class="m-0" t-field="o.sale_dates" />
+    </xpath>
+</template>
+
+</odoo>

account_usability/security/ir.model.access.csv

@@ -0,0 +1,3 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_account_group_generate_full,Full access on account.group.generate,model_account_group_generate,account.group_account_manager,1,1,1,1
+access_account_invoice_mark_sent_full,Full access on account.invoice.mark.sent,model_account_invoice_mark_sent,account.group_account_invoice,1,1,1,1

account_usability/static/description/index.html

@@ -0,0 +1,454 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<title>Account Usability</title>
+<style type="text/css">
+
+/*
+:Author: David Goodger (goodger@python.org)
+:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
+:Copyright: This stylesheet has been placed in the public domain.
+
+Default cascading style sheet for the HTML output of Docutils.
+
+See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
+customize this style sheet.
+*/
+
+/* used to remove borders from tables and images */
+.borderless, table.borderless td, table.borderless th {
+  border: 0 }
+
+table.borderless td, table.borderless th {
+  /* Override padding for "table.docutils td" with "! important".
+     The right padding separates the table cells. */
+  padding: 0 0.5em 0 0 ! important }
+
+.first {
+  /* Override more specific margin styles with "! important". */
+  margin-top: 0 ! important }
+
+.last, .with-subtitle {
+  margin-bottom: 0 ! important }
+
+.hidden {
+  display: none }
+
+.subscript {
+  vertical-align: sub;
+  font-size: smaller }
+
+.superscript {
+  vertical-align: super;
+  font-size: smaller }
+
+a.toc-backref {
+  text-decoration: none ;
+  color: black }
+
+blockquote.epigraph {
+  margin: 2em 5em ; }
+
+dl.docutils dd {
+  margin-bottom: 0.5em }
+
+object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
+  overflow: hidden;
+}
+
+/* Uncomment (and remove this text!) to get bold-faced definition list terms
+dl.docutils dt {
+  font-weight: bold }
+*/
+
+div.abstract {
+  margin: 2em 5em }
+
+div.abstract p.topic-title {
+  font-weight: bold ;
+  text-align: center }
+
+div.admonition, div.attention, div.caution, div.danger, div.error,
+div.hint, div.important, div.note, div.tip, div.warning {
+  margin: 2em ;
+  border: medium outset ;
+  padding: 1em }
+
+div.admonition p.admonition-title, div.hint p.admonition-title,
+div.important p.admonition-title, div.note p.admonition-title,
+div.tip p.admonition-title {
+  font-weight: bold ;
+  font-family: sans-serif }
+
+div.attention p.admonition-title, div.caution p.admonition-title,
+div.danger p.admonition-title, div.error p.admonition-title,
+div.warning p.admonition-title, .code .error {
+  color: red ;
+  font-weight: bold ;
+  font-family: sans-serif }
+
+/* Uncomment (and remove this text!) to get reduced vertical space in
+   compound paragraphs.
+div.compound .compound-first, div.compound .compound-middle {
+  margin-bottom: 0.5em }
+
+div.compound .compound-last, div.compound .compound-middle {
+  margin-top: 0.5em }
+*/
+
+div.dedication {
+  margin: 2em 5em ;
+  text-align: center ;
+  font-style: italic }
+
+div.dedication p.topic-title {
+  font-weight: bold ;
+  font-style: normal }
+
+div.figure {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+div.footer, div.header {
+  clear: both;
+  font-size: smaller }
+
+div.line-block {
+  display: block ;
+  margin-top: 1em ;
+  margin-bottom: 1em }
+
+div.line-block div.line-block {
+  margin-top: 0 ;
+  margin-bottom: 0 ;
+  margin-left: 1.5em }
+
+div.sidebar {
+  margin: 0 0 0.5em 1em ;
+  border: medium outset ;
+  padding: 1em ;
+  background-color: #ffffee ;
+  width: 40% ;
+  float: right ;
+  clear: right }
+
+div.sidebar p.rubric {
+  font-family: sans-serif ;
+  font-size: medium }
+
+div.system-messages {
+  margin: 5em }
+
+div.system-messages h1 {
+  color: red }
+
+div.system-message {
+  border: medium outset ;
+  padding: 1em }
+
+div.system-message p.system-message-title {
+  color: red ;
+  font-weight: bold }
+
+div.topic {
+  margin: 2em }
+
+h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
+h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
+  margin-top: 0.4em }
+
+h1.title {
+  text-align: center }
+
+h2.subtitle {
+  text-align: center }
+
+hr.docutils {
+  width: 75% }
+
+img.align-left, .figure.align-left, object.align-left, table.align-left {
+  clear: left ;
+  float: left ;
+  margin-right: 1em }
+
+img.align-right, .figure.align-right, object.align-right, table.align-right {
+  clear: right ;
+  float: right ;
+  margin-left: 1em }
+
+img.align-center, .figure.align-center, object.align-center {
+  display: block;
+  margin-left: auto;
+  margin-right: auto;
+}
+
+table.align-center {
+  margin-left: auto;
+  margin-right: auto;
+}
+
+.align-left {
+  text-align: left }
+
+.align-center {
+  clear: both ;
+  text-align: center }
+
+.align-right {
+  text-align: right }
+
+/* reset inner alignment in figures */
+div.align-right {
+  text-align: inherit }
+
+/* div.align-center * { */
+/*   text-align: left } */
+
+.align-top    {
+  vertical-align: top }
+
+.align-middle {
+  vertical-align: middle }
+
+.align-bottom {
+  vertical-align: bottom }
+
+ol.simple, ul.simple {
+  margin-bottom: 1em }
+
+ol.arabic {
+  list-style: decimal }
+
+ol.loweralpha {
+  list-style: lower-alpha }
+
+ol.upperalpha {
+  list-style: upper-alpha }
+
+ol.lowerroman {
+  list-style: lower-roman }
+
+ol.upperroman {
+  list-style: upper-roman }
+
+p.attribution {
+  text-align: right ;
+  margin-left: 50% }
+
+p.caption {
+  font-style: italic }
+
+p.credits {
+  font-style: italic ;
+  font-size: smaller }
+
+p.label {
+  white-space: nowrap }
+
+p.rubric {
+  font-weight: bold ;
+  font-size: larger ;
+  color: maroon ;
+  text-align: center }
+
+p.sidebar-title {
+  font-family: sans-serif ;
+  font-weight: bold ;
+  font-size: larger }
+
+p.sidebar-subtitle {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+p.topic-title {
+  font-weight: bold }
+
+pre.address {
+  margin-bottom: 0 ;
+  margin-top: 0 ;
+  font: inherit }
+
+pre.literal-block, pre.doctest-block, pre.math, pre.code {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+pre.code .ln { color: grey; } /* line numbers */
+pre.code, code { background-color: #eeeeee }
+pre.code .comment, code .comment { color: #5C6576 }
+pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
+pre.code .literal.string, code .literal.string { color: #0C5404 }
+pre.code .name.builtin, code .name.builtin { color: #352B84 }
+pre.code .deleted, code .deleted { background-color: #DEB0A1}
+pre.code .inserted, code .inserted { background-color: #A3D289}
+
+span.classifier {
+  font-family: sans-serif ;
+  font-style: oblique }
+
+span.classifier-delimiter {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+span.interpreted {
+  font-family: sans-serif }
+
+span.option {
+  white-space: nowrap }
+
+span.pre {
+  white-space: pre }
+
+span.problematic {
+  color: red }
+
+span.section-subtitle {
+  /* font-size relative to parent (h1..h6 element) */
+  font-size: 80% }
+
+table.citation {
+  border-left: solid 1px gray;
+  margin-left: 1px }
+
+table.docinfo {
+  margin: 2em 4em }
+
+table.docutils {
+  margin-top: 0.5em ;
+  margin-bottom: 0.5em }
+
+table.footnote {
+  border-left: solid 1px black;
+  margin-left: 1px }
+
+table.docutils td, table.docutils th,
+table.docinfo td, table.docinfo th {
+  padding-left: 0.5em ;
+  padding-right: 0.5em ;
+  vertical-align: top }
+
+table.docutils th.field-name, table.docinfo th.docinfo-name {
+  font-weight: bold ;
+  text-align: left ;
+  white-space: nowrap ;
+  padding-left: 0 }
+
+/* "booktabs" style (no vertical lines) */
+table.docutils.booktabs {
+  border: 0px;
+  border-top: 2px solid;
+  border-bottom: 2px solid;
+  border-collapse: collapse;
+}
+table.docutils.booktabs * {
+  border: 0px;
+}
+table.docutils.booktabs th {
+  border-bottom: thin solid;
+  text-align: left;
+}
+
+h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
+h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
+  font-size: 100% }
+
+ul.auto-toc {
+  list-style-type: none }
+
+</style>
+</head>
+<body>
+<div class="document" id="account-usability">
+<h1 class="title">Account Usability</h1>
+
+<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! This file is generated by oca-gen-addon-readme !!
+!! changes will be overwritten.                   !!
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/account_usability"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
+<p>This modules adds the following functions:</p>
+<ul class="simple">
+<li>Add an <em>Overdue</em> filter on invoice search view (this feature was previously
+located in te module <em>account_invoice_overdue_filter</em>)</li>
+<li>Increase the default limit of 80 lines in account move and account move line view.</li>
+<li>disable reconciliation “guessing”</li>
+<li>fast search on <em>Reconcile Ref</em> for account move line.</li>
+<li>add sale dates to invoice report to be compliant with
+<a class="reference external" href="https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808">https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808</a></li>
+<li>Sale date on qweb invoices</li>
+<li>A wizard to mark several invoices as sent at once (forward from v8)</li>
+<li>Default date for Account Move Reversal is now D+1 instead of today</li>
+<li>Track more fields on invoice (see details in account.py)</li>
+<li>Add boolean fields <cite>has_discount</cite> and <cite>has_attachment</cite> on invoice</li>
+<li>Add button “Delete line qty = 0” on supplier invoice</li>
+<li>Cut name_get() of invoice if too long</li>
+<li>A script for if Odoo screws up invoice attachment filename</li>
+<li>help functions for py3o reports</li>
+<li>Show code on name_get of journal</li>
+<li>add direct search of journal using code</li>
+<li>add copy=False on some fields</li>
+<li>Add unicity constraint on analytic codes per company</li>
+<li>Better default values on account move</li>
+<li>Add link from account move line to invoice</li>
+<li>Add start_date and end_date on bank statements</li>
+<li>Add transfer_account_id to invoicing config page</li>
+<li>Improve domain reconciliation widget</li>
+<li>account.reconcile.model don’t copy name to label via onchange</li>
+<li>Add method to get fiscal position without partner_id</li>
+<li>Restore drill-through on sale and invoice reports</li>
+<li>don’t attach PDF upon invoice report generation on supplier invoices/refunds</li>
+<li>Add filter on debit and credit amount for Move Lines</li>
+<li>Add supplier invoice number in invoice tree view</li>
+</ul>
+<p>Together with this module, I recommend the use of the following modules:</p>
+<ul class="simple">
+<li>account_invoice_supplier_ref_unique (OCA project account-invoicing)</li>
+<li>account_move_line_no_default_search (OCA project account-financial-tools)</li>
+<li>invoice_fiscal_position_update (OCA project account-invoicing)</li>
+</ul>
+<p><strong>Table of contents</strong></p>
+<div class="contents local topic" id="contents">
+<ul class="simple">
+<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
+</ul>
+</li>
+</ul>
+</div>
+<div class="section" id="bug-tracker">
+<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
+<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20account_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<p>Do not contact contributors directly about support or help with technical issues.</p>
+</div>
+<div class="section" id="credits">
+<h1><a class="toc-backref" href="#id2">Credits</a></h1>
+<div class="section" id="authors">
+<h2><a class="toc-backref" href="#id3">Authors</a></h2>
+<ul class="simple">
+<li>Akretion</li>
+</ul>
+</div>
+<div class="section" id="contributors">
+<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
+<ul class="simple">
+<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
+<li>David Beal &lt;<a class="reference external" href="mailto:david.beal&#64;akretion.com">david.beal&#64;akretion.com</a>&gt;</li>
+</ul>
+</div>
+<div class="section" id="maintainers">
+<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
+<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/account_usability">akretion/odoo-usability</a> project on GitHub.</p>
+<p>You are welcome to contribute.</p>
+</div>
+</div>
+</div>
+</body>
+</html>

account_usability/views/account_account.xml

@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2021 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+
+<record id="view_account_form" model="ir.ui.view">
+    <field name="name">account.account.form</field>
+    <field name="model">account.account</field>
+    <field name="inherit_id" ref="account.view_account_form" />
+    <field name="arch" type="xml">
+        <field name="deprecated" position="before">
+            <field
+                    name="reconcile"
+                    attrs="{'invisible': ['|', ('internal_type','=','liquidity'), ('internal_group', '=', 'off_balance')]}"
+                />
+        </field>
+    </field>
+</record>
+
+
+<record id="view_account_search" model="ir.ui.view">
+    <field name="name">account.account.search</field>
+    <field name="model">account.account</field>
+    <field name="inherit_id" ref="account.view_account_search" />
+    <field name="arch" type="xml">
+        <!-- The native "name" filter uses a domain ['|', ('name','ilike',self), ('code','=like',str(self)+'%')]
+        This is good because it uses '=like' on 'code', but sometimes there are digits in account names,
+        so you get additionnal unexpected accounts in the result of the search -->
+        <field name="name" position="after">
+            <field
+                    name="code"
+                    filter_domain="[('code', '=like', str(self)+'%')]"
+                    string="Code"
+                />
+        </field>
+    </field>
+</record>
+
+
+</odoo>

account_usability/views/account_account_type.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="view_account_type_tree" model="ir.ui.view">
+    <field name="name">account_usability.account_type_tree</field>
+    <field name="model">account.account.type</field>
+    <field name="inherit_id" ref="account.view_account_type_tree" />
+    <field name="arch" type="xml">
+        <field name="type" position="after">
+            <field name="include_initial_balance" optional="show" />
+        </field>
+    </field>
+</record>
+
+</odoo>

account_usability/views/account_bank_statement.xml

@@ -0,0 +1,112 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+
+<record id="view_bank_statement_form" model="ir.ui.view">
+    <field name="name">usability.account.bank.statement.form</field>
+    <field name="model">account.bank.statement</field>
+    <field name="inherit_id" ref="account.view_bank_statement_form" />
+    <field name="arch" type="xml">
+        <xpath
+                expr="//field[@name='line_ids']/tree/button[@name='button_undo_reconciliation']"
+                position="after"
+            >
+            <field name="move_id" invisible="1" />
+            <button
+                    name="show_account_move"
+                    type="object"
+                    title="View Journal Entry"
+                    icon="fa-arrow-right"
+                />
+        </xpath>
+        <field name="date" position="after">
+            <field name="start_date" />
+            <field name="end_date" />
+            <field name="hide_bank_statement_balance" invisible="1" />
+        </field>
+        <field name="date" position="attributes">
+            <attribute name="invisible">1</attribute>
+        </field>
+        <label for="balance_start" position="attributes">
+            <attribute
+                    name="attrs"
+                >{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
+        </label>
+        <label for="balance_end_real" position="attributes">
+            <attribute
+                    name="attrs"
+                >{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
+        </label>
+        <xpath expr="//field[@name='balance_start']/.." position="attributes">
+            <attribute
+                    name="attrs"
+                >{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
+        </xpath>
+        <xpath expr="//field[@name='balance_end_real']/.." position="attributes">
+            <attribute
+                    name="attrs"
+                >{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
+        </xpath>
+        <group name="sale_total" position="attributes">
+            <attribute
+                    name="attrs"
+                >{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
+        </group>
+    </field>
+</record>
+
+<record id="view_bank_statement_tree" model="ir.ui.view">
+    <field name="name">usability.account.bank.statement.tree</field>
+    <field name="model">account.bank.statement</field>
+    <field name="inherit_id" ref="account.view_bank_statement_tree" />
+    <field name="arch" type="xml">
+        <field name="date" position="attributes">
+            <attribute name="invisible">1</attribute>
+        </field>
+        <field name="journal_id" position="after">
+            <field name="start_date" />
+            <field name="end_date" />
+        </field>
+    </field>
+</record>
+
+<record id="view_bank_statement_search" model="ir.ui.view">
+    <field name="name">usability.account.bank.statement.search</field>
+    <field name="model">account.bank.statement</field>
+    <field name="inherit_id" ref="account.view_bank_statement_search" />
+    <field name="arch" type="xml">
+        <field name="date" position="attributes">
+            <attribute name="invisible">1</attribute>
+        </field>
+        <filter name="filter_date" position="attributes">
+            <attribute name="invisible">1</attribute>
+        </filter>
+        <filter name="date" position="attributes">
+            <attribute name="invisible">1</attribute>
+        </filter>
+        <field name="date" position="after">
+            <field name="start_date" />
+            <field name="end_date" />
+        </field>
+        <filter name="date" position="after">
+            <filter
+                    name="start_date_groupby"
+                    string="Start Date"
+                    context="{'group_by': 'start_date'}"
+                />
+            <filter
+                    name="end_date_groupby"
+                    string="End Date"
+                    context="{'group_by': 'end_date'}"
+                />
+        </filter>
+    </field>
+</record>
+
+
+</odoo>

account_usability/views/account_invoice_report.xml

@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2018-2020 Akretion (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+
+<record id="account_invoice_report_tree" model="ir.ui.view">
+    <field name="name">usability.account.invoice.report.tree</field>
+    <field name="model">account.invoice.report</field>
+    <field name="arch" type="xml">
+        <tree string="Invoices Analysis">
+            <field name="move_id" />
+            <field name="invoice_date" />
+            <field name="invoice_date_due" />
+            <field name="move_type" />
+            <field name="commercial_partner_id" />
+            <field name="invoice_user_id" />
+            <field name="product_id" />
+            <field name="quantity" sum="1" />
+            <field name="product_uom_id" groups="uom.group_uom" />
+            <field name="price_subtotal" sum="1" />
+            <field name="state" />
+        </tree>
+    </field>
+</record>
+
+<record
+        id="account.action_account_invoice_report_all_supp"
+        model="ir.actions.act_window"
+    >
+    <field
+            name="context"
+        >{'search_default_current': 1, 'search_default_supplier': 1, 'group_by': ['invoice_date']}</field>  <!-- Remove group_by_no_leaf, which breaks tree view -->
+</record>
+
+<record id="account.action_account_invoice_report_all" model="ir.actions.act_window">
+    <field
+            name="context"
+        >{'search_default_current': 1, 'search_default_customer': 1, 'group_by': ['invoice_date']}</field>  <!-- Remove group_by_no_leaf, which breaks tree view -->
+</record>
+
+<record id="view_account_invoice_report_pivot" model="ir.ui.view">
+    <field name="name">usability.account.invoice.report</field>
+    <field name="model">account.invoice.report</field>
+    <field name="inherit_id" ref="account.view_account_invoice_report_pivot" />
+    <field name="arch" type="xml">
+        <pivot position="attributes">
+            <attribute name="disable_linking" />
+        </pivot>
+    </field>
+</record>
+
+
+</odoo>

account_usability/views/account_journal.xml

@@ -0,0 +1,67 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="view_account_journal_form" model="ir.ui.view">
+    <field name="name">usability.account.journal.form</field>
+    <field name="model">account.journal</field>
+    <field name="inherit_id" ref="account.view_account_journal_form" />
+    <field name="arch" type="xml">
+        <field name="bank_statements_source" position="after">
+            <field
+                    name="hide_bank_statement_balance"
+                    groups="account.group_account_readonly"
+                />
+        </field>
+    </field>
+</record>
+
+<record id="account_journal_dashboard_kanban_view" model="ir.ui.view">
+    <field name="name">usability.account.journal.dashboard</field>
+    <field name="model">account.journal</field>
+    <field name="inherit_id" ref="account.account_journal_dashboard_kanban_view" />
+    <field name="arch" type="xml">
+        <field name="kanban_dashboard" position="after">
+            <field name="hide_bank_statement_balance" />
+        </field>
+        <xpath expr="//div[@name='latest_statement']/.." position="attributes">
+            <attribute
+                    name="t-if"
+                >dashboard.has_at_least_one_statement and dashboard.account_balance != dashboard.last_balance and !record.hide_bank_statement_balance.raw_value</attribute>
+        </xpath>
+    </field>
+</record>
+
+<record id="view_account_journal_tree" model="ir.ui.view">
+    <field name="name">usability.account.journal.tree</field>
+    <field name="model">account.journal</field>
+    <field name="inherit_id" ref="account.view_account_journal_tree" />
+    <field name="arch" type="xml">
+        <field name="name" position="after">
+            <field name="code" optional="show" />
+        </field>
+    </field>
+</record>
+
+<record id="view_account_journal_search" model="ir.ui.view">
+    <field name="name">usability.account.journal.search</field>
+    <field name="model">account.journal</field>
+    <field name="inherit_id" ref="account.view_account_journal_search" />
+    <field name="arch" type="xml">
+        <filter name="inactive" position="after">
+            <group name="groupby" string="Group By">
+                <filter
+                        name="type_groupby"
+                        string="Type"
+                        context="{'group_by': 'type'}"
+                    />
+            </group>
+        </filter>
+    </field>
+</record>
+
+</odoo>

account_usability/views/account_menu.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<!-- Duplicate the menu "Sales > Configuration > Contacts > Bank Accounts"
+under "Accounting > Configuration", because most users will try to find it there -->
+<menuitem
+        id="res_bank_account_config_menu"
+        action="base.action_res_bank_form"
+        parent="account.account_banks_menu"
+        sequence="10"
+    />
+
+<menuitem
+        id="res_partner_bank_account_config_menu"
+        action="base.action_res_partner_bank_account_form"
+        parent="account.account_banks_menu"
+        sequence="20"
+    />
+
+</odoo>

account_usability/views/account_move.xml

@@ -0,0 +1,164 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="view_move_form" model="ir.ui.view">
+    <field name="name">account_usability.account.move.form</field>
+    <field name="model">account.move</field>
+    <field name="inherit_id" ref="account.view_move_form" />
+    <field name="arch" type="xml">
+        <field name="fiscal_position_id" position="attributes">
+            <attribute name="widget">selection</attribute>
+        </field>
+        <field name="invoice_incoterm_id" position="attributes">
+            <attribute name="widget">selection</attribute>
+        </field>
+        <button name="action_register_payment" position="attributes">
+            <attribute name="class">btn-default</attribute>
+        </button>
+        <button name="action_register_payment" position="before">
+            <button
+                    name="%(account.account_invoices)d"
+                    type="action"
+                    string="Print"
+                    attrs="{'invisible': [('move_type', 'not in', ('out_invoice', 'out_refund'))]}"
+                />
+        </button>
+        <button name="preview_invoice" position="attributes">
+            <attribute name="attrs">{'invisible': 1}</attribute>
+        </button>
+        <!-- move sent field and make it visible -->
+        <field name="is_move_sent" position="replace" />
+        <field name="invoice_origin" position="attributes">
+            <attribute name="invisible">0</attribute>
+        </field>
+        <field name="invoice_origin" position="after">
+            <field
+                    name="is_move_sent"
+                    attrs="{'invisible': [('move_type', 'not in', ('out_invoice', 'out_refund'))]}"
+                />
+        </field>
+        <xpath
+                expr="//field[@name='line_ids']/tree/field[@name='analytic_account_id']"
+                position="attributes"
+            >
+            <attribute name="optional">show</attribute>
+        </xpath>
+        <xpath
+                expr="//field[@name='line_ids']/tree/field[@name='tax_tag_ids']"
+                position="after"
+            >
+            <field name="matching_number" optional="hide" />
+            <field name="reconcile_string" optional="show" />
+        </xpath>
+        <xpath
+                expr="//field[@name='invoice_line_ids']/tree/field[@name='product_id']"
+                position="after"
+            >
+            <field name="product_barcode" optional="hide" />
+        </xpath>
+    </field>
+</record>
+
+<record id="view_account_invoice_filter" model="ir.ui.view">
+    <field name="name">account_usability.account.move.search</field>
+    <field name="model">account.move</field>
+    <field name="inherit_id" ref="account.view_account_invoice_filter" />
+    <field name="arch" type="xml">
+        <filter name="due_date" position="after">
+            <separator />
+             <filter
+                    name="to_send"
+                    string="To Send"
+                    domain="[('is_move_sent', '=', False), ('state', '=', 'posted'), ('move_type', 'in', ('out_invoice', 'out_refund'))]"
+                />
+             <filter
+                    name="sent"
+                    string="Sent"
+                    domain="[('is_move_sent', '=', True), ('move_type', 'in', ('out_invoice', 'out_refund'))]"
+                />
+            <separator />
+            <filter
+                    name="no_attachment"
+                    string="Missing Attachment"
+                    domain="[('has_attachment', '=', False)]"
+                />
+         </filter>
+    </field>
+</record>
+
+<record id="view_move_line_tree" model="ir.ui.view">
+    <field name="model">account.move.line</field>
+    <field name="inherit_id" ref="account.view_move_line_tree" />
+    <field name="arch" type="xml">
+        <field name="matching_number" position="after">
+            <button
+                    title="View Journal Entry Form"
+                    type="object"
+                    name="show_account_move_form"
+                    icon="fa-arrow-right"
+                />
+        </field>
+    </field>
+</record>
+
+<record id="view_account_move_line_filter" model="ir.ui.view">
+    <field name="name">account_usability.account_move_line_search</field>
+    <field name="model">account.move.line</field>
+    <field name="inherit_id" ref="account.view_account_move_line_filter" />
+    <field name="arch" type="xml">
+        <filter name="unposted" position="before">
+            <filter
+                    name="current_year"
+                    string="Current Year"
+                    domain="[('date', '&gt;=', (context_today().strftime('%Y-01-01'))), ('date', '&lt;=', (context_today().strftime('%Y-12-31')))]"
+                />
+            <filter
+                    name="previous_year"
+                    string="Previous Year"
+                    domain="[('date', '&gt;=', (context_today() + relativedelta(day=1, month=1, years=-1)).strftime('%Y-%m-%d')), ('date', '&lt;=', (context_today() + relativedelta(day=31, month=12, years=-1)).strftime('%Y-%m-%d'))]"
+                />
+            <separator />
+        </filter>
+        <field name="partner_id" position="after">
+            <field name="reconcile_string" />
+            <field
+                    name="debit"
+                    filter_domain="['|', ('debit', '=', self), ('credit', '=', self)]"
+                    string="Debit or Credit"
+                />
+        </field>
+        <filter name="unreconciled" position="before">
+            <filter
+                    name="reconciled"
+                    string="Fully Reconciled"
+                    domain="[('full_reconcile_id', '!=', False)]"
+                />
+        </filter>
+        <filter name="unreconciled" position="attributes">
+            <attribute name="string">Unreconciled or Partially Reconciled</attribute>
+        </filter>
+        <!--
+        <field name="name" position="attributes">
+            <attribute name="string">Name or Reference</attribute>
+        </field>  -->
+        <field name="partner_id" position="attributes">
+            <attribute
+                    name="domain"
+                >['|', ('parent_id', '=', False), ('is_company', '=', True)]</attribute>
+        </field>
+    </field>
+</record>
+
+<record id="account.action_move_journal_line" model="ir.actions.act_window">
+    <field
+            name="context"
+        >{'default_move_type': 'entry', 'view_no_maturity': True}</field>
+    <!-- Remove 'search_default_misc_filter': 1 -->
+</record>
+
+</odoo>

account_usability/views/account_report.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2018-2020 Akretion (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="account.account_invoices" model="ir.actions.report">
+    <!-- Attach only on customer invoices/refunds -->
+    <field
+            name="attachment"
+        >(object.move_type in ('out_invoice', 'out_refund')) and (object.state == 'posted') and ((object.name or 'INV').replace('/','_')+'.pdf')</field>
+</record>
+
+<record id="account.account_invoices_without_payment" model="ir.actions.report">
+    <!-- Attach only on customer invoices/refunds -->
+    <field
+            name="attachment"
+        >(object.move_type in ('out_invoice', 'out_refund')) and (object.state == 'posted') and ((object.name or 'INV').replace('/','_')+'.pdf')</field>
+</record>
+
+
+</odoo>

account_usability/views/account_tax.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="view_tax_tree" model="ir.ui.view">
+    <field name="model">account.tax</field>
+    <field name="inherit_id" ref="account.view_tax_tree" />
+    <field name="arch" type="xml">
+        <field name="description" position="after">
+            <field name="price_include" optional="show" />
+        </field>
+    </field>
+</record>
+
+</odoo>

account_usability/views/product.xml

@@ -0,0 +1,78 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2017-2020 Akretion (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<!-- In the official account module, on product category and product template,
+some fields/groups are on account.group_account_invoice, some on
+account.group_account_user and some on account.group_account_manager
+Here, we set all those fields on account.group_account_invoice
+-->
+
+<record id="product_template_form_view" model="ir.ui.view">
+    <field name="name">account_usability.product.template.form</field>
+    <field name="model">product.template</field>
+    <field
+            name="priority"
+        >100</field> <!-- when you replace a field, it's always better to inherit at the end -->
+    <field name="inherit_id" ref="account.product_template_form_view" />
+    <field name="arch" type="xml">
+        <field name="property_account_income_id" position="attributes">
+            <attribute name="groups">account.group_account_invoice</attribute>
+        </field>
+        <field name="property_account_expense_id" position="attributes">
+            <attribute name="groups">account.group_account_invoice</attribute>
+        </field>
+        <field name="list_price" position="replace">
+            <div name="list_price">
+                <field
+                        name="list_price"
+                        widget='monetary'
+                        options="{'currency_field': 'currency_id', 'field_digits': True}"
+                        class="oe_inline"
+                    />
+                <label for="sale_price_type" string=" " />
+                <field name="sale_price_type" />
+            </div>
+        </field>
+    </field>
+</record>
+
+<record id="view_category_property_form" model="ir.ui.view">
+    <field name="name">account_usability.product.category.form</field>
+    <field name="model">product.category</field>
+    <field name="inherit_id" ref="account.view_category_property_form" />
+    <field name="arch" type="xml">
+        <group name="account_property" position="attributes">
+            <attribute name="groups">account.group_account_invoice</attribute>
+        </group>
+    </field>
+</record>
+
+<record id="product_supplierinfo_form_view" model="ir.ui.view">
+    <field name="name">account_usability.product.supplierinfo.form</field>
+    <field name="model">product.supplierinfo</field>
+    <field name="inherit_id" ref="product.product_supplierinfo_form_view" />
+    <field name="arch" type="xml">
+        <field name="currency_id" position="after">
+            <field name="purchase_price_type" />
+        </field>
+    </field>
+</record>
+
+<record id="product_supplierinfo_tree_view" model="ir.ui.view">
+    <field name="name">account_usability.product.supplierinfo.tree</field>
+    <field name="model">product.supplierinfo</field>
+    <field name="inherit_id" ref="product.product_supplierinfo_tree_view" />
+    <field name="arch" type="xml">
+        <field name="price" position="after">
+            <field name="purchase_price_type" string="Tax" />
+        </field>
+    </field>
+</record>
+
+
+</odoo>

account_usability/views/res_config_settings.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2015-2020 Akretion France (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+<record id="res_config_settings_view_form" model="ir.ui.view">
+    <field name="name">account_usability account config page</field>
+    <field name="model">res.config.settings</field>
+    <field name="inherit_id" ref="account.res_config_settings_view_form" />
+    <field name="arch" type="xml">
+        <xpath expr="//div[@id='bank_cash']" position="inside">
+            <div class="col-xs-12 col-md-6 o_setting_box" id="transfer_account">
+                <div class="o_setting_left_pane" />
+                <div class="o_setting_right_pane">
+                    <label for="transfer_account_id" />
+                    <div class="text-muted">
+                    Transit account when you transfer money from a bank account of your company to another bank account of your company.
+                    </div>
+                    <field name="transfer_account_id" />
+                </div>
+            </div>
+        </xpath>
+    </field>
+</record>
+
+
+</odoo>

account_usability/views/res_partner.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+  Copyright 2017-2020 Akretion (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+<odoo>
+
+
+<record id="view_partner_property_form" model="ir.ui.view">
+    <field name="name">account_usability.res.partner.form</field>
+    <field name="model">res.partner</field>
+    <field name="inherit_id" ref="account.view_partner_property_form" />
+    <field name="arch" type="xml">
+        <field name="property_account_position_id" position="attributes">
+            <attribute name="widget">selection</attribute>
+        </field>
+        <xpath
+                expr="//field[@name='bank_ids']/tree/field[@name='acc_number']"
+                position="after"
+            >
+            <field name="acc_type" />
+        </xpath>
+    </field>
+</record>
+
+
+</odoo>