Elabore/account-tools
8
1
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

New account advanced protection features module #23

Merged
mondot merged 8 commits from new_account_advanced_protection_features into 16.0 2025-09-26 09:52:15 +00:00
Conversation 7 Commits 8 Files Changed 28 +230 -946
mondot commented 2025-08-21 16:29:36 +00:00 (Migrated from github.com)
Copy Link

https://elabore.coop/web#id=5202&cids=1&menu_id=198&active_id=4457&model=project.task&view_type=form

In this PR, modules account_move_protect_deleting and account_move_protect_reset_to_draft have been merged into one module account_advanced_protection_features.
I've removed the group group_account_super_user from module account_usability_misc.

I've created a new group group_account_protection_manager that gives access to these 3 account journal features :

  • Prevent to reset to draft a sent invoice
  • Prevent to delete an already posted account move
  • Allow bank statement deletion

These features are visible in the journal configuration form.

https://elabore.coop/web#id=5202&cids=1&menu_id=198&active_id=4457&model=project.task&view_type=form In this PR, modules `account_move_protect_deleting` and `account_move_protect_reset_to_draft` have been merged into one module `account_advanced_protection_features`. I've removed the group `group_account_super_user` from module `account_usability_misc`. I've created a new group `group_account_protection_manager` that gives access to these 3 account journal features : * Prevent to reset to draft a sent invoice * Prevent to delete an already posted account move * Allow bank statement deletion These features are visible in the journal configuration form.
mondot (Migrated from github.com) reviewed 2025-09-15 10:01:22 +00:00
account_advanced_protection_features/README.rst Outdated
@@ -0,0 +8,4 @@
* Allow bank statements and bank statement lines deletion
Installation
============
mondot (Migrated from github.com) commented 2025-09-15 10:01:21 +00:00
Copy Link

write about deleting bank statements

write about deleting bank statements
mondot marked this conversation as resolved
mondot (Migrated from github.com) reviewed 2025-09-15 10:27:49 +00:00
account_advanced_protection_features/models/account_move.py Outdated
mondot (Migrated from github.com) commented 2025-09-15 10:27:49 +00:00
Copy Link
```suggestion ```
mondot marked this conversation as resolved
LaetitiaElabore (Migrated from github.com) approved these changes 2025-09-15 10:59:32 +00:00
mondot commented 2025-09-15 16:40:57 +00:00 (Migrated from github.com)
Copy Link

account_move_protect_deleting installé sur

gestion moulin nature
gestion moneko
gestion le mat le vieil audon
gestion ree auvergne
odoo archijeux
gestion lerozo
odoo sikle
gestion coop tier lieux
admin fresque oceane
odoo.cairn-monnaie.com
la racine
loubatas
agniel
monnaie gentiane

`account_move_protect_deleting` installé sur gestion moulin nature gestion moneko gestion le mat le vieil audon gestion ree auvergne odoo archijeux gestion lerozo odoo sikle gestion coop tier lieux admin fresque oceane odoo.cairn-monnaie.com la racine loubatas agniel monnaie gentiane
mondot commented 2025-09-17 13:54:06 +00:00
Owner
Copy Link

Wait for Elabore/elabore-addons#9 to be merged

Wait for https://git.elabore.coop/Elabore/elabore-addons/pulls/9 to be merged
mondot self-assigned this 2025-09-25 13:00:47 +00:00
mondot commented 2025-09-25 15:54:00 +00:00
Owner
Copy Link

What I've done to try the deployment of these changes :

  1. Build a new image rc/16.0-ELABORE-LIGHT-test-quentin that has these changes and the new version of OCA contract module (to have these changes : https://github.com/OCA/contract/pull/1301).
  2. Make the server test.elabore.coop as similar as possible to elabore.coop (modifying the compose, re-importing the prod DB and relaunching compose debug up) : in this step I still use ELABORE-LIGHT image.
  3. Install account_move_protect_deleting and check that the group group_account_user (Montrer les fonctions de comptabilité complètes in french) is not accepting deletion, as configured in account_usability_misc.
  4. Modify the compose to use the new test image rc/16.0-ELABORE-LIGHT-test-quentin. Then compose --debug up. Then Mettre à jour la liste des apps then install account_advanced_protection_features then update account_usability_misc. The module account_move_protect_deleting was still displayed as installed even if I could not found it while entering the container with bash. I uninstalled it.
  5. I updated the module account to retrieve initial rights with the group group_account_user (allowed to delete account_bank_statement and account_bank_statement_line) (maybe I can only modify it from the user interface ? because it's a very long update).
What I've done to try the deployment of these changes : 1. Build a new image `rc/16.0-ELABORE-LIGHT-test-quentin` that has these changes and the new version of OCA contract module (to have these changes : https://github.com/OCA/contract/pull/1301). 2. Make the server test.elabore.coop as similar as possible to elabore.coop (modifying the compose, re-importing the prod DB and relaunching compose debug up) : in this step I still use ELABORE-LIGHT image. 3. Install `account_move_protect_deleting` and check that the group `group_account_user` (`Montrer les fonctions de comptabilité complètes` in french) is not accepting deletion, as configured in account_usability_misc. 4. Modify the compose to use the new test image `rc/16.0-ELABORE-LIGHT-test-quentin`. Then `compose --debug up`. Then `Mettre à jour la liste des apps` then install `account_advanced_protection_features` then update `account_usability_misc`. The module `account_move_protect_deleting` was still displayed as `installed` even if I could not found it while entering the container with bash. I uninstalled it. 5. I updated the module `account` to retrieve initial rights with the group `group_account_user` (allowed to delete account_bank_statement and account_bank_statement_line) (maybe I can only modify it from the user interface ? because it's a very long update).
mondot added 2 commits 2025-09-26 09:44:29 +00:00
[IMP] account_advanced_protection_features : remove exceptions about cash and check deposits when trying to delete an posted account move 8d2c01953a
[IMP] account_advanced_protection_features : remove exceptions about cash and check deposits when trying to delete an posted account move c5b10113ea
mondot commented 2025-09-26 09:45:59 +00:00
Owner
Copy Link

I've only modified one translation in my last push, Leatitia approval still works.
I merge

I've only modified one translation in my last push, Leatitia approval still works. I merge
mondot merged commit c7254a7b84 into 16.0 2025-09-26 09:52:15 +00:00
mondot deleted branch new_account_advanced_protection_features 2025-09-26 09:52:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
LaetitiaElabore
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
admin borisgallet elabore_bot laetitiadacosta mathieusarrasin mondot stephansainleger vlab
No Assignees mondot
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Elabore/account-tools#23
No description provided.
Delete Branch "new_account_advanced_protection_features"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?