[IMP] survey_extra_fields : handle file question on page navigation

* Show a stored file (after navigating back) the same way as a freshly
  selected one: a "filename + Remove file" chip, input hidden until removal.
* Keep the stored file when a page is re-submitted without a new selection
  (instead of overwriting it with a skipped answer).
* "Remove file" now sends a sentinel to actually delete the stored file,
  so the removal persists across navigation.

survey_base/__manifest__.py

@@ -13,7 +13,7 @@ Add fields used by several survey addons
 * Implementation of theses fields should be in another module
 
 """, 
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "Elabore",
     "website": "https://www.elabore.coop",

survey_extra_fields/__manifest__.py

@@ -13,7 +13,7 @@ Add extra question types to surveys:
   - Client-side validation (size and extension) before form submission
   - Server-side validation on save to enforce constraints
 """,
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "Elabore",
     "website": "https://www.elabore.coop",

survey_extra_fields/controllers/main.py

@@ -31,7 +31,7 @@ class SurveyExtraFieldsController(Survey):
             [("access_token", "=", survey_token)], limit=1
         )
         if not survey:
-            return request.not_found()
+            raise request.not_found()
 
         answer = request.env["survey.user_input"].sudo().search(
             [
@@ -41,14 +41,14 @@ class SurveyExtraFieldsController(Survey):
             limit=1,
         )
         if not answer:
-            return request.not_found()
+            raise request.not_found()
 
         line = request.env["survey.user_input.line"].sudo().browse(line_id)
         if not line.exists() or line.user_input_id != answer:
-            return request.not_found()
+            raise request.not_found()
 
         if not line.value_file:
-            return request.not_found()
+            raise request.not_found()
 
         file_content = base64.b64decode(line.value_file)
         filename = line.value_file_fname or "file"

survey_extra_fields/i18n/fr.po

@@ -4,10 +4,10 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 16.0\n"
+"Project-Id-Version: Odoo Server 18.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2026-02-18 16:38+0000\n"
-"PO-Revision-Date: 2026-02-18 16:38+0000\n"
+"POT-Creation-Date: 2026-06-10 15:03+0000\n"
+"PO-Revision-Date: 2026-06-10 15:03+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -20,6 +20,11 @@ msgstr ""
 msgid ".pdf,.docx,.xlsx"
 msgstr ""
 
+#. module: survey_extra_fields
+#: model_terms:ir.ui.view,arch_db:survey_extra_fields.question_file
+msgid "<i class=\"fa fa-times me-1\"/>Remove file"
+msgstr "<i class=\"fa fa-times me-1\"/>Supprimer le fichier"
+
 #. module: survey_extra_fields
 #: model:ir.model.fields,field_description:survey_extra_fields.field_survey_question__allowed_extensions
 msgid "Allowed Extensions"
@@ -36,8 +41,8 @@ msgid ""
 "Comma-separated list of allowed extensions (e.g. .pdf,.docx). Leave empty to"
 " allow all types."
 msgstr ""
-"Liste d'extensions autorisées séparées par une virgule (e.g. .pdf,.docx). Laisser vide pour"
-" autoriser tous les types de fichier."
+"Liste d'extensions autorisées séparées par une virgule (e.g. .pdf,.docx). "
+"Laisser vide pour autoriser tous les types de fichier."
 
 #. module: survey_extra_fields
 #: model:ir.model.fields.selection,name:survey_extra_fields.selection__survey_question__question_type__file
@@ -54,7 +59,9 @@ msgstr "Taille maximale du fichier"
 #. module: survey_extra_fields
 #: model:ir.model.fields,help:survey_extra_fields.field_survey_question__max_file_size
 msgid "Maximum file size in MB. Leave 0 for no limit."
-msgstr "Taille maximale du fichier en MB. Laisser à 0 pour ne pas restreindre la taille. La valeur par défaut est 10 MB."
+msgstr ""
+"Taille maximale du fichier en MB. Laisser à 0 pour ne pas restreindre la "
+"taille. La valeur par défaut est 10 MB."
 
 #. module: survey_extra_fields
 #: model:ir.model.fields,field_description:survey_extra_fields.field_survey_question__question_type
@@ -66,13 +73,6 @@ msgstr "Type de question"
 msgid "Skipped"
 msgstr "Ignoré"
 
-#. module: survey_extra_fields
-#: model:ir.model.fields,field_description:survey_extra_fields.field_survey_question__smart_search
-#: model:ir.model.fields,field_description:survey_extra_fields.field_survey_user_input__smart_search
-#: model:ir.model.fields,field_description:survey_extra_fields.field_survey_user_input_line__smart_search
-msgid "Smart Search"
-msgstr "Recherche intelligente"
-
 #. module: survey_extra_fields
 #: model:ir.model,name:survey_extra_fields.model_survey_question
 msgid "Survey Question"
@@ -91,34 +91,39 @@ msgstr "Ligne d'entrée pour l'utilisateur du sondage"
 #. module: survey_extra_fields
 #. odoo-python
 #: code:addons/survey_extra_fields/models/survey_user_input.py:0
-#, python-format
 msgid "The file '%(name)s' exceeds the maximum allowed size of %(size)s MB."
-msgstr "Le fichier '%(name)s' dépasse la taille maximale autorisée de %(size)s MB."
+msgstr ""
+"Le fichier '%(name)s' dépasse la taille maximale autorisée de %(size)s MB."
 
 #. module: survey_extra_fields
 #. odoo-python
 #: code:addons/survey_extra_fields/models/survey_user_input.py:0
-#, python-format
 msgid "The file '%(name)s' is not allowed. Accepted formats: %(exts)s."
-msgstr "Le fichier '%(name)s' n'est pas autorisé. Les formats de fichier autorisés sont : %(exts)s."
+msgstr ""
+"Le fichier '%(name)s' n'est pas autorisé. Les formats de fichier autorisés "
+"sont : %(exts)s."
 
 #. module: survey_extra_fields
 #. odoo-javascript
 #: code:addons/survey_extra_fields/static/src/js/survey_form.js:0
-#, python-format
 msgid "The file exceeds the maximum allowed size of %s MB."
 msgstr "Le fichier dépasse la taille maximale autorisée de %s MB."
 
 #. module: survey_extra_fields
-#. odoo-javascript
-#: code:addons/survey_extra_fields/static/src/js/survey_form.js:0
-#, python-format
-msgid "This file type is not allowed. Accepted formats: %s."
-msgstr "Le fichier n'est pas autorisé. Les formats de fichier autorisés sont : %s."
+#. odoo-python
+#: code:addons/survey_extra_fields/models/survey_user_input.py:0
+msgid "This answer cannot be overwritten."
+msgstr "Cette réponse ne peut pas être remplacée."
+
+#. module: survey_extra_fields
+#. odoo-javascript
+#: code:addons/survey_extra_fields/static/src/js/survey_form.js:0
+msgid "This file type is not allowed. Accepted formats: %s."
+msgstr ""
+"Le fichier n'est pas autorisé. Les formats de fichier autorisés sont : %s."
 
 #. module: survey_extra_fields
 #. odoo-javascript
 #: code:addons/survey_extra_fields/static/src/js/survey_form.js:0
-#, python-format
 msgid "This question requires an answer."
 msgstr "Cette question requiert une réponse."

survey_extra_fields/models/survey_user_input.py

@@ -8,7 +8,7 @@ import os
 from typing import TYPE_CHECKING
 
 from odoo import _, models
-from odoo.exceptions import ValidationError
+from odoo.exceptions import UserError, ValidationError
 
 if TYPE_CHECKING:
     from odoo.addons.survey_extra_fields.models.survey_question import SurveyQuestion
@@ -17,20 +17,39 @@ if TYPE_CHECKING:
 class SurveyUserInput(models.Model):
     _inherit = "survey.user_input"
 
-    def save_lines(self, question: SurveyQuestion, answer: str | None, comment: str | None = None) -> None:
+    def _save_lines(
+        self,
+        question: SurveyQuestion,
+        answer: str | None,
+        comment: str | None = None,
+        overwrite_existing: bool = True,
+    ) -> None:
         if question.question_type == "file":
             old_answers = self.env["survey.user_input.line"].search([
                 ("user_input_id", "=", self.id),
                 ("question_id", "=", question.id),
             ])
+            if old_answers and not overwrite_existing:
+                raise UserError(_("This answer cannot be overwritten."))
+            if not answer and any(line.value_file for line in old_answers):
+                # No new file was submitted: a file input cannot be pre-filled
+                # by the browser when navigating back to a previous page, so an
+                # empty answer here does not mean the user removed their file.
+                # Keep the previously uploaded file instead of overwriting it
+                # with a skipped answer.
+                return
             vals = {
                 "user_input_id": self.id,
                 "question_id": question.id,
                 "skipped": False,
                 "answer_type": "file",
             }
-            if answer:
-                file_data = json.loads(answer)
+            file_data = json.loads(answer) if answer else {}
+            if file_data.get("cleared"):
+                # The user explicitly removed the file: drop the stored data and
+                # mark the line as skipped.
+                vals.update(answer_type=None, skipped=True, value_file=False, value_file_fname=False)
+            elif file_data:
                 file_b64 = file_data.get("data", "")
                 file_name = file_data.get("name", "")
                 self._check_file_constraints(question, file_b64, file_name)
@@ -43,7 +62,9 @@ class SurveyUserInput(models.Model):
             else:
                 self.env["survey.user_input.line"].create(vals)
         else:
-            return super().save_lines(question, answer, comment=comment)
+            return super()._save_lines(
+                question, answer, comment=comment, overwrite_existing=overwrite_existing
+            )
 
     def _check_file_constraints(
             self,

survey_extra_fields/static/src/js/survey_form.js

@@ -1,14 +1,83 @@
-odoo.define("survey_extra_fields.survey_form", function (require) {
-    "use strict";
+/** @odoo-module **/
 
-    var core = require("web.core");
-    var _t = core._t;
-    var survey_form = require("survey.form");
+import publicWidget from "@web/legacy/js/public/public_widget";
+import { _t } from "@web/core/l10n/translation";
+import { rpc } from "@web/core/network/rpc";
+
+publicWidget.registry.SurveyFormWidget.include({
+    /**
+     * @override
+     * Bind delegated listeners on the form root so they keep working after each
+     * page is re-rendered (the inner content is replaced on navigation, but the
+     * root element persists). They let the user clear a selected file before
+     * submitting the form.
+     */
+    start: function () {
+        return this._super.apply(this, arguments).then(() => {
+            this.$el.on(
+                "change.surveyExtraFile",
+                'input[data-question-type="file"]',
+                this._onFileInputChange.bind(this)
+            );
+            this.$el.on(
+                "click.surveyExtraFile",
+                ".o_survey_file_clear",
+                this._onFileClearClick.bind(this)
+            );
+        });
+    },
+
+    /**
+     * On selection, show the file "chip" (filename + remove button) and hide the
+     * raw input, so a freshly selected file looks exactly like an already stored
+     * one (rendered server-side when navigating back).
+     */
+    _onFileInputChange: function (ev) {
+        const input = ev.currentTarget;
+        const container = input.closest(".o_survey_comment_container");
+        if (!container || !(input.files && input.files.length > 0)) {
+            return;
+        }
+        const chip = container.querySelector(".o_survey_file_selected");
+        const nameEl = container.querySelector(".o_survey_file_name");
+        if (nameEl) {
+            nameEl.textContent = input.files[0].name;
+        }
+        if (chip) {
+            chip.classList.remove("d-none");
+        }
+        delete input.dataset.fileCleared;
+        input.classList.add("d-none");
+    },
+
+    /**
+     * Discard the current file: hide the chip and bring back the input so the
+     * user can pick a new one. A file already stored server-side is only really
+     * replaced once a new file is submitted (see _save_lines).
+     */
+    _onFileClearClick: function (ev) {
+        ev.preventDefault();
+        const container = ev.currentTarget.closest(".o_survey_comment_container");
+        if (!container) {
+            return;
+        }
+        const input = container.querySelector('input[data-question-type="file"]');
+        const chip = container.querySelector(".o_survey_file_selected");
+        if (input) {
+            input.value = "";
+            // Flag the explicit removal so the submit tells the server to drop
+            // any previously stored file (instead of preserving it).
+            input.dataset.fileCleared = "1";
+            input.classList.remove("d-none");
+        }
+        if (chip) {
+            chip.classList.add("d-none");
+        }
+    },
 
-    survey_form.include({
     _readFileAsDataURL: function (file) {
         return new Promise(function (resolve, reject) {
-                var reader = new FileReader();
+            const reader = new FileReader();
             reader.onload = function (e) {
                 resolve(e.target.result);
             };
@@ -19,116 +88,132 @@ odoo.define("survey_extra_fields.survey_form", function (require) {
         });
     },
 
-        _submitForm: function (options) {
-            var self = this;
-            var $fileInputs = this.$('input[data-question-type="file"]');
-            var hasFiles = false;
-            $fileInputs.each(function () {
-                if (this.files && this.files.length > 0) {
-                    hasFiles = true;
-                    return false;
-                }
-            });
+    /**
+     * @override
+     * The base implementation builds the submit params synchronously and fires
+     * the RPC immediately. File inputs need to be read asynchronously (FileReader),
+     * so when the current page contains file answers we replicate the submit flow
+     * here, injecting the base64 file payload before submitting.
+     */
+    _submitForm: async function (options) {
+        const fileInputs = this.el.querySelectorAll('input[data-question-type="file"]');
+        // A file action is either a new selection or an explicit removal of a
+        // previously stored file (which must be communicated to the server).
+        const hasFileAction = Array.from(fileInputs).some(
+            (input) => (input.files && input.files.length > 0) || input.dataset.fileCleared
+        );
 
-            if (!hasFiles || this.options.isStartScreen) {
+        if (!hasFileAction || this.options.isStartScreen) {
             return this._super(options);
         }
 
-            // Async flow: read files then submit
-            var params = {};
+        const params = {};
         if (options.previousPageId) {
             params.previous_page_id = options.previousPageId;
         }
-
-            var $form = this.$("form");
-            var formData = new FormData($form[0]);
-
-            if (!options.skipValidation) {
-                if (!this._validateForm($form, formData)) {
-                    return;
+        if (options.nextSkipped) {
+            params.next_skipped_page_or_question = true;
         }
+
+        const $form = this.$("form");
+        const formData = new FormData($form[0]);
+
+        if (!options.skipValidation && !this._validateForm($form, formData)) {
+            return;
         }
 
         this._prepareSubmitValues(formData, params);
 
-            // Read all selected files as base64
-            var filePromises = [];
-            $fileInputs.each(function () {
-                if (this.files && this.files.length > 0) {
-                    var file = this.files[0];
-                    var name = this.name;
+        // Read all selected files as base64 and add them to the submit params.
+        // Explicitly cleared inputs (no new file) send a "cleared" sentinel so
+        // the server removes the previously stored file.
+        const filePromises = [];
+        for (const input of fileInputs) {
+            if (input.files && input.files.length > 0) {
+                const file = input.files[0];
+                const name = input.name;
                 filePromises.push(
-                        self._readFileAsDataURL(file).then(function (dataURL) {
+                    this._readFileAsDataURL(file).then((dataURL) => {
                         params[name] = JSON.stringify({
                             data: dataURL.split(",")[1],
                             name: file.name,
                         });
                     })
                 );
+            } else if (input.dataset.fileCleared) {
+                params[input.name] = JSON.stringify({ cleared: true });
+            }
         }
-            });
 
+        // Prevent user from submitting more times using enter key.
         this.preventEnterSubmit = true;
-
         if (this.options.sessionInProgress) {
             this.fadeInOutDelay = 400;
             this.readonly = true;
         }
 
-            Promise.all(filePromises).then(function () {
-                var submitPromise = self._rpc({
-                    route: _.str.sprintf(
-                        "%s/%s/%s",
-                        "/survey/submit",
-                        self.options.surveyToken,
-                        self.options.answerToken
-                    ),
-                    params: params,
-                });
-                self._nextScreen(submitPromise, options);
-            });
+        await Promise.all(filePromises);
+
+        const submitPromise = rpc(
+            `/survey/submit/${this.options.surveyToken}/${this.options.answerToken}`,
+            params
+        );
+        this._nextScreen(submitPromise, options);
     },
 
+    /**
+     * @override
+     * Add client-side validation (required, max size, allowed extensions) for
+     * file questions, which the base implementation does not know about.
+     */
     _validateForm: function ($form, formData) {
-            var result = this._super.apply(this, arguments);
-            var errors = {};
-            var inactiveQuestionIds = this.options.sessionInProgress
+        const result = this._super.apply(this, arguments);
+        const errors = {};
+        const inactiveQuestionIds = this.options.sessionInProgress
             ? []
             : this._getInactiveConditionalQuestionIds();
 
         $form.find('input[data-question-type="file"]').each(function () {
-                var $questionWrapper = $(this).closest(".js_question-wrapper");
-                var questionId = $questionWrapper.attr("id");
+            const $questionWrapper = $(this).closest(".js_question-wrapper");
+            const questionId = $questionWrapper.attr("id");
             if (inactiveQuestionIds.includes(parseInt(questionId))) {
                 return;
             }
-                var questionRequired = $questionWrapper.data("required");
-                var constrErrorMsg =
+            const questionRequired = $questionWrapper.data("required");
+            const constrErrorMsg =
                 $questionWrapper.data("constrErrorMsg") ||
                 _t("This question requires an answer.");
             if (questionRequired && !(this.files && this.files.length > 0)) {
+                // A file may already be stored server-side (e.g. uploaded then
+                // navigating back): the chip is visible even though the input is
+                // empty. Treat that as a valid answer.
+                const container = this.closest(".o_survey_comment_container");
+                const chip = container && container.querySelector(".o_survey_file_selected");
+                const hasExistingFile = chip && !chip.classList.contains("d-none");
+                if (!hasExistingFile) {
                     errors[questionId] = constrErrorMsg;
+                }
                 return;
             }
             if (this.files && this.files.length > 0) {
-                    var file = this.files[0];
-                    var maxSizeMB = parseInt($(this).data("maxFileSize"));
+                const file = this.files[0];
+                const maxSizeMB = parseInt($(this).data("maxFileSize"));
                 if (maxSizeMB && file.size > maxSizeMB * 1024 * 1024) {
-                        errors[questionId] = _.str.sprintf(
-                            _t("The file exceeds the maximum allowed size of %s MB."),
+                    errors[questionId] = _t(
+                        "The file exceeds the maximum allowed size of %s MB.",
                         maxSizeMB
                     );
                     return;
                 }
-                    var allowedExtensions = $(this).data("allowedExtensions");
+                const allowedExtensions = $(this).data("allowedExtensions");
                 if (allowedExtensions) {
-                        var allowed = allowedExtensions.split(",").map(function (e) {
-                            return e.trim().toLowerCase();
-                        });
-                        var ext = "." + file.name.split(".").pop().toLowerCase();
+                    const allowed = allowedExtensions
+                        .split(",")
+                        .map((e) => e.trim().toLowerCase());
+                    const ext = "." + file.name.split(".").pop().toLowerCase();
                     if (!allowed.includes(ext)) {
-                            errors[questionId] = _.str.sprintf(
-                                _t("This file type is not allowed. Accepted formats: %s."),
+                        errors[questionId] = _t(
+                            "This file type is not allowed. Accepted formats: %s.",
                             allowedExtensions
                         );
                     }
@@ -136,11 +221,12 @@ odoo.define("survey_extra_fields.survey_form", function (require) {
             }
         });
 
-            if (_.keys(errors).length > 0) {
+        if (Object.keys(errors).length > 0) {
             this._showErrors(errors);
             return false;
         }
         return result;
     },
 });
-});
+
+export default publicWidget.registry.SurveyFormWidget;

survey_extra_fields/tests/test_survey_file.py

@@ -46,14 +46,14 @@ class TestSurveyFileCommon(common.TestSurveyCommon):
 
 
 class TestSurveyFileSaveLines(TestSurveyFileCommon):
-    """Test the save_lines method for file question type."""
+    """Test the _save_lines method for file question type."""
 
     def test_save_file_answer(self):
         """Submitting a file stores base64 data and filename."""
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": self.file_name})
 
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
 
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
@@ -68,7 +68,7 @@ class TestSurveyFileSaveLines(TestSurveyFileCommon):
         """Submitting empty answer marks the line as skipped."""
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
 
-        answer.save_lines(self.question_file, "")
+        answer._save_lines(self.question_file, "")
 
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
@@ -81,11 +81,11 @@ class TestSurveyFileSaveLines(TestSurveyFileCommon):
         """Submitting a new file updates the existing answer line."""
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json_1 = json.dumps({"data": self.file_b64, "name": "first.pdf"})
-        answer.save_lines(self.question_file, file_json_1)
+        answer._save_lines(self.question_file, file_json_1)
 
         new_b64 = base64.b64encode(b"Updated content").decode()
         file_json_2 = json.dumps({"data": new_b64, "name": "second.pdf"})
-        answer.save_lines(self.question_file, file_json_2)
+        answer._save_lines(self.question_file, file_json_2)
 
         lines = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
@@ -94,19 +94,38 @@ class TestSurveyFileSaveLines(TestSurveyFileCommon):
         self.assertEqual(lines.value_file, new_b64.encode())
         self.assertEqual(lines.value_file_fname, "second.pdf")
 
-    def test_save_file_then_skip(self):
-        """Uploading a file then submitting empty marks line as skipped."""
+    def test_save_file_then_empty_keeps_file(self):
+        """Submitting empty after a file keeps it (file inputs cannot be
+        pre-filled when navigating back, so an empty answer must not erase it)."""
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": self.file_name})
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
 
-        answer.save_lines(self.question_file, "")
+        answer._save_lines(self.question_file, "")
+
+        line = answer.user_input_line_ids.filtered(
+            lambda l: l.question_id == self.question_file
+        )
+        self.assertEqual(len(line), 1)
+        self.assertFalse(line.skipped)
+        self.assertEqual(line.value_file, self.file_b64.encode())
+        self.assertEqual(line.value_file_fname, self.file_name)
+
+    def test_save_file_explicitly_cleared(self):
+        """Submitting the 'cleared' sentinel after a file removes it."""
+        answer = self._add_answer(self.survey, self.survey_manager.partner_id)
+        file_json = json.dumps({"data": self.file_b64, "name": self.file_name})
+        answer._save_lines(self.question_file, file_json)
+
+        answer._save_lines(self.question_file, json.dumps({"cleared": True}))
 
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
         )
         self.assertEqual(len(line), 1)
         self.assertTrue(line.skipped)
+        self.assertFalse(line.value_file)
+        self.assertFalse(line.value_file_fname)
 
 
 class TestSurveyFileConstraints(TestSurveyFileCommon):
@@ -117,7 +136,7 @@ class TestSurveyFileConstraints(TestSurveyFileCommon):
         self.question_file.write({"max_file_size": 0, "allowed_extensions": False})
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": "anything.exe"})
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
         )
@@ -128,7 +147,7 @@ class TestSurveyFileConstraints(TestSurveyFileCommon):
         self.question_file.write({"max_file_size": 10})
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": self.file_name})
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
         )
@@ -142,14 +161,14 @@ class TestSurveyFileConstraints(TestSurveyFileCommon):
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": large_b64, "name": self.file_name})
         with self.assertRaises(Exception):
-            answer.save_lines(self.question_file, file_json)
+            answer._save_lines(self.question_file, file_json)
 
     def test_allowed_extension_passes(self):
         """File with an allowed extension passes."""
         self.question_file.write({"allowed_extensions": ".pdf,.docx"})
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": "report.docx"})
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
         )
@@ -161,14 +180,14 @@ class TestSurveyFileConstraints(TestSurveyFileCommon):
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": "script.exe"})
         with self.assertRaises(Exception):
-            answer.save_lines(self.question_file, file_json)
+            answer._save_lines(self.question_file, file_json)
 
     def test_both_constraints_valid(self):
         """File respecting both size and extension constraints passes."""
         self.question_file.write({"max_file_size": 10, "allowed_extensions": ".pdf"})
         answer = self._add_answer(self.survey, self.survey_manager.partner_id)
         file_json = json.dumps({"data": self.file_b64, "name": self.file_name})
-        answer.save_lines(self.question_file, file_json)
+        answer._save_lines(self.question_file, file_json)
         line = answer.user_input_line_ids.filtered(
             lambda l: l.question_id == self.question_file
         )

survey_extra_fields/views/survey_question_views.xml

@@ -8,10 +8,10 @@
         <field name="arch" type="xml">
             <xpath expr="//page[@name='options']//field[@name='matrix_subtype']" position="before">
                 <field name="max_file_size"
-                    attrs="{'invisible': [('question_type', '!=', 'file')]}"
+                    invisible="question_type != 'file'"
                     string="Max File Size (MB)"/>
                 <field name="allowed_extensions"
-                    attrs="{'invisible': [('question_type', '!=', 'file')]}"
+                    invisible="question_type != 'file'"
                     placeholder=".pdf,.docx,.xlsx"/>
             </xpath>
         </field>

survey_extra_fields/views/survey_templates.xml

@@ -6,7 +6,7 @@
         id="question_container_inh_type_file"
         inherit_id="survey.question_container"
     >
-        <xpath expr="//t[@t-call='survey.question_matrix']/.." position="after">
+        <xpath expr="//t[@t-call='survey.question_matrix']" position="after">
             <t t-if="question.question_type == 'file'">
                 <t t-call="survey_extra_fields.question_file"/>
             </t>
@@ -15,13 +15,26 @@
 
     <template id="question_file" name="Question: File">
         <div class="o_survey_comment_container p-0">
-            <t t-if="survey_form_readonly and answer_lines and answer_lines[0].value_file_fname">
-                <p><t t-out="answer_lines[0].value_file_fname"/></p>
+            <t t-set="existing_fname" t-value="answer_lines and answer_lines[0].value_file_fname"/>
+            <t t-if="survey_form_readonly">
+                <p t-if="existing_fname" class="mb-1">
+                    <i class="fa fa-paperclip me-1"/><t t-out="answer_lines[0].value_file_fname"/>
+                </p>
             </t>
-            <t t-if="not survey_form_readonly">
+            <t t-else="">
+                <!-- Uploaded file display, shown both for a fresh selection and when a
+                     file was already stored server-side (e.g. navigating back). The raw
+                     file input is hidden until the user clicks "Remove file". -->
+                <span t-attf-class="o_survey_file_selected d-inline-flex align-items-center #{'' if existing_fname else 'd-none'}">
+                    <i class="fa fa-paperclip me-1"/>
+                    <span class="o_survey_file_name"><t t-out="existing_fname or ''"/></span>
+                    <button type="button" class="btn btn-link btn-sm text-danger o_survey_file_clear ms-2 py-0">
+                        <i class="fa fa-times me-1"/>Remove file
+                    </button>
+                </span>
                 <input
                     type="file"
-                    class="o_survey_question_file"
+                    t-attf-class="o_survey_question_file #{'d-none' if existing_fname else ''}"
                     t-att-name="question.id"
                     t-att-data-question-type="question.question_type"
                     t-att-accept="question.allowed_extensions or None"

survey_extra_fields/views/survey_user_views.xml

@@ -8,7 +8,7 @@
         <field name="arch" type="xml">
             <xpath expr="//field[@name='suggested_answer_id']" position="after">
                 <field name="value_file" filename="value_file_fname" colspan="2"
-                    attrs="{'invisible': [('answer_type', '!=', 'file')]}"/>
+                    invisible="answer_type != 'file'"/>
                 <field name="value_file_fname" invisible="1"/>
             </xpath>
         </field>