[IMP] survey_record_generation : new option update_existing_fields

survey_record_generation/tests/test_survey_record_creation.py

@@ -722,9 +722,91 @@ class TestSurveyRecordCreation(SurveyCase):
         self.answer._mark_done()
 
         partner = self.env["res.partner"].search([("name", "=", "Jean")])
-        self.assertTrue(len(partner) == 1)
-        self.assertTrue(partner.email == "jean@test.fr")
-        self.assertTrue(partner.function == "happiness office manager")
+        self.assertEqual(len(partner), 1)
+        self.assertEqual(partner.email, "jean@test.fr")
+        self.assertEqual(partner.function, "happiness office manager")
+
+    def test_update_all_fields_when_updating_records(self):
+        # A contact with name 'Jean' and email 'jean@test.fr' already exists.
+        # We'll update the fields 'function' AND 'email' of this partner
+        # because the option 'update_existing_fields' is True
+        self.env["res.partner"].create(
+            {
+                "name": "Jean",
+                "email": "jean@test.fr",
+            }
+        )
+        self.question_email = self._add_question(
+            page=None,
+            name="Email",
+            qtype="char_box",
+            survey_id=self.survey.id,
+            sequence=1,
+        )
+        self.question_function = self._add_question(
+            page=None,
+            name="Function",
+            qtype="char_box",
+            survey_id=self.survey.id,
+            sequence=1,
+        )
+
+        self.survey_record_creation.write(
+            {
+                "update_existing_records": True,
+                "field_to_retrieve_existing_records": self.name_field.id,
+                "update_existing_fields": True,
+            }
+        )
+        email_field = self.env["ir.model.fields"].search(
+            [("model", "=", "res.partner"), ("name", "=", "email")]
+        )
+        self.env["survey.record.creation.field.values"].create(
+            {
+                "survey_record_creation_id": self.survey_record_creation.id,
+                "survey_id": self.survey.id,
+                "model_id": self.res_partner_model.id,
+                "field_id": email_field.id,
+                "value_origin": "question",
+                "question_id": self.question_email.id,
+            }
+        )
+        function_field = self.env["ir.model.fields"].search(
+            [("model", "=", "res.partner"), ("name", "=", "function")]
+        )
+        self.env["survey.record.creation.field.values"].create(
+            {
+                "survey_record_creation_id": self.survey_record_creation.id,
+                "survey_id": self.survey.id,
+                "model_id": self.res_partner_model.id,
+                "field_id": function_field.id,
+                "value_origin": "question",
+                "question_id": self.question_function.id,
+            }
+        )
+
+        self.answer = self._add_answer(
+            survey=self.survey, partner=False, email="jean@test.fr"
+        )
+        self._add_answer_line(
+            question=self.question_name, answer=self.answer, answer_value="Jean"
+        )
+        self._add_answer_line(
+            question=self.question_email,
+            answer=self.answer,
+            answer_value="IAmTheNewEmailReplacingTheOldOne@test.fr",
+        )
+        self._add_answer_line(
+            question=self.question_function,
+            answer=self.answer,
+            answer_value="happiness office manager",
+        )
+        self.answer._mark_done()
+
+        partner = self.env["res.partner"].search([("name", "=", "Jean")])
+        self.assertEqual(len(partner), 1)
+        self.assertEqual(partner.email, "IAmTheNewEmailReplacingTheOldOne@test.fr")
+        self.assertEqual(partner.function, "happiness office manager")
 
     def test_unicity_check_has_priority_over_update(self):
         # In this test, we verify that if a field is set up with unicity_check