picking_status: adapt and improve SO filter view

Fix typo

account_fiscal_position_payable_receivable/__init__.py

@@ -1 +0,0 @@
-from . import models

account_fiscal_position_payable_receivable/__manifest__.py

@@ -1,23 +0,0 @@
-# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-{
-    "name": "Account Fiscal Position Payable Receivable",
-    "version": "12.0.1.0.0",
-    "category": "Accounting & Finance",
-    "license": "AGPL-3",
-    "summary": "Configure payable/receivable accounts on fiscal positions",
-    "description": """
-Account Fiscal Position Payable Receivable
-==========================================
-
-This module allows to configure a special *Partner Receivable Account* and a special *Partner Payable Account* on fiscal positions. This is used in the onchange of the fiscal position of partners.
-
-This module has been written by Alexis de Lattre from Akretion <alexis.delattre@akretion.com>.
-    """,
-    "author": "Akretion",
-    "website": "http://www.akretion.com",
-    "depends": ["account"],
-    "data": ["views/account_fiscal_position_view.xml"],
-    "installable": True,
-}

account_fiscal_position_payable_receivable/models/__init__.py

@@ -1,2 +0,0 @@
-from . import account_fiscal_position
-from . import res_partner

account_fiscal_position_payable_receivable/models/account_fiscal_position.py

@@ -1,21 +0,0 @@
-# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import models, fields
-
-
-class AccountFiscalPosition(models.Model):
-    _inherit = "account.fiscal.position"
-
-    receivable_account_id = fields.Many2one(
-        "account.account",
-        string="Partner Receivable Account",
-        company_dependent=True,
-        domain=[("internal_type", "=", "receivable")],
-    )
-    payable_account_id = fields.Many2one(
-        "account.account",
-        string="Partner Payable Account",
-        company_dependent=True,
-        domain=[("internal_type", "=", "payable")],
-    )

account_fiscal_position_payable_receivable/models/res_partner.py

@@ -1,25 +0,0 @@
-# © 2016-2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import models, api
-
-
-class ResPartner(models.Model):
-    _inherit = "res.partner"
-
-    @api.onchange("property_account_position_id")
-    def fiscal_position_receivable_payable_change(self):
-        fp = self.property_account_position_id
-        ipo = self.env["ir.property"]
-        if fp.receivable_account_id:
-            self.property_account_receivable_id = fp.receivable_account_id
-        else:
-            self.property_account_receivable_id = ipo.get(
-                "property_account_receivable_id", "res.partner"
-            )
-        if fp.payable_account_id:
-            self.property_account_payable_id = fp.payable_account_id
-        else:
-            self.property_account_payable_id = ipo.get(
-                "property_account_payable_id", "res.partner"
-            )

account_fiscal_position_payable_receivable/views/account_fiscal_position_view.xml

@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-  © 2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
-  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
--->
-
-<odoo>
-
-
-<record id="view_account_position_form" model="ir.ui.view">
-    <field name="name">receivable_payable.fiscal_position_form</field>
-    <field name="model">account.fiscal.position</field>
-    <field name="inherit_id" ref="account.view_account_position_form" />
-    <field name="arch" type="xml">
-        <field name="company_id" position="after">
-            <field name="receivable_account_id"/>
-            <field name="payable_account_id"/>
-        </field>
-    </field>
-</record>
-
-
-</odoo>

account_usability/README.rst

@@ -1,96 +0,0 @@
-=================
-Account Usability
-=================
-
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! This file is generated by oca-gen-addon-readme !!
-   !! changes will be overwritten.                   !!
-   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-
-.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
-    :target: https://odoo-community.org/page/development-status
-    :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
-    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-    :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github
-    :target: https://github.com/akretion/odoo-usability/tree/12.0/account_usability
-    :alt: akretion/odoo-usability
-
-|badge1| |badge2| |badge3| 
-
-This modules adds the following functions:
-
-* Add an *Overdue* filter on invoice search view (this feature was previously 
-  located in te module *account_invoice_overdue_filter*)
-* Increase the default limit of 80 lines in account move and account move line view.
-* disable reconciliation "guessing"
-* fast search on *Reconcile Ref* for account move line.
-* add sale dates to invoice report to be compliant with
-  https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808
-* Sale date on qweb invoices
-* A wizard to mark several invoices as sent at once (forward from v8)
-* Default date for Account Move Reversal is now D+1 instead of today
-* Track more fields on invoice (see details in account.py)
-* Add boolean fields `has_discount` and `has_attachment` on invoice
-* Add button "Delete line qty = 0" on supplier invoice
-* Cut name_get() of invoice if too long
-* A script for if Odoo screws up invoice attachment filename
-* help functions for py3o reports
-* Show code on name_get of journal
-* add direct search of journal using code
-* add copy=False on some fields
-* Add unicity constraint on analytic codes per company
-* Better default values on account move
-* Add link from account move line to invoice
-* Add start_date and end_date on bank statements
-* Add transfer_account_id to invoicing config page
-* Improve domain reconciliation widget
-* account.reconcile.model don't copy name to label via onchange
-* Add method to get fiscal position without partner_id
-* Restore drill-through on sale and invoice reports
-* don't attach PDF upon invoice report generation on supplier invoices/refunds
-* Add filter on debit and credit amount for Move Lines
-* Add supplier invoice number in invoice tree view
-
-Together with this module, I recommend the use of the following modules:
-
-* account_invoice_supplier_ref_unique (OCA project account-invoicing)
-* account_move_line_no_default_search (OCA project account-financial-tools)
-* invoice_fiscal_position_update (OCA project account-invoicing)
-
-**Table of contents**
-
-.. contents::
-   :local:
-
-Bug Tracker
-===========
-
-Bugs are tracked on `GitHub Issues <https://github.com/akretion/odoo-usability/issues>`_.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/akretion/odoo-usability/issues/new?body=module:%20account_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-
-Do not contact contributors directly about support or help with technical issues.
-
-Credits
-=======
-
-Authors
-~~~~~~~
-
-* Akretion
-
-Contributors
-~~~~~~~~~~~~
-
-* Alexis de Lattre <alexis.delattre@akretion.com>
-* David Beal <david.beal@akretion.com>
-
-Maintainers
-~~~~~~~~~~~
-
-This module is part of the `akretion/odoo-usability <https://github.com/akretion/odoo-usability/tree/12.0/account_usability>`_ project on GitHub.
-
-You are welcome to contribute.

account_usability/__manifest__.py

@@ -4,10 +4,31 @@
 
 {
     'name': 'Account Usability',
-    'version': '12.0.1.0.0',
+    'version': '10.0.1.0.0',
     'category': 'Accounting & Finance',
     'license': 'AGPL-3',
     'summary': 'Small usability enhancements in account module',
+    'description': """
+Account Usability
+=================
+
+The usability enhancements include:
+* show the supplier invoice number in the tree view of supplier invoices
+* add an *Overdue* filter on invoice search view (this feature was previously 
+  located in te module *account_invoice_overdue_filter*)
+* increase the default limit of 80 lines in account move and account move line view.
+* fast search on *Reconcile Ref* for account move line.
+* disable reconciliation "guessing"
+* add sale dates to invoice report to be compliant with
+  https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808
+
+Together with this module, I recommend the use of the following modules:
+* account_invoice_supplier_ref_unique (OCA project account-invoicing)
+* account_move_line_no_default_search (OCA project account-financial-tools)
+* invoice_fiscal_position_update (OCA project account-invoicing)
+
+This module has been written by Alexis de Lattre from Akretion <alexis.delattre@akretion.com>.
+    """,
     'author': 'Akretion',
     'website': 'http://www.akretion.com',
     'depends': [

account_usability/account.py

@@ -3,10 +3,9 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import models, fields, api, _
-from odoo.tools import float_compare, float_is_zero, float_round
+from odoo.tools import float_compare, float_is_zero
 from odoo.tools.misc import formatLang
 from odoo.exceptions import UserError, ValidationError
-from odoo.osv import expression
 from odoo import SUPERUSER_ID
 import logging
 
@@ -83,7 +82,7 @@ class AccountInvoice(models.Model):
     # top of the screen
     # That's why we have to cut the name_get() when it's too long
     def name_get(self):
-        old_res = super().name_get()
+        old_res = super(AccountInvoice, self).name_get()
         res = []
         for old_re in old_res:
             name = old_re[1]
@@ -103,8 +102,9 @@ class AccountInvoice(models.Model):
     # 2) the 'name' field of the account.move.line is used in the overdue
     # letter, and '/' is not meaningful for our customer !
 # TODO mig to v12
+#    @api.multi
 #    def action_move_create(self):
-#        res = super().action_move_create()
+#        res = super(AccountInvoice, self).action_move_create()
 #        for inv in self:
 #            self._cr.execute(
 #                "UPDATE account_move_line SET name= "
@@ -215,15 +215,7 @@ class AccountInvoiceLine(models.Model):
 class AccountJournal(models.Model):
     _inherit = 'account.journal'
 
-    hide_bank_statement_balance = fields.Boolean(
-        string='Hide Bank Statement Balance',
-        help="You may want to enable this option when your bank "
-        "journal is generated from a bank statement file that "
-        "doesn't handle start/end balance (QIF for instance) and "
-        "you don't want to enter the start/end balance manually: it "
-        "will prevent the display of wrong information in the accounting "
-        "dashboard and on bank statements.")
-
+    @api.multi
     @api.depends(
         'name', 'currency_id', 'company_id', 'company_id.currency_id', 'code')
     def name_get(self):
@@ -269,6 +261,7 @@ class AccountJournal(models.Model):
 class AccountAccount(models.Model):
     _inherit = 'account.account'
 
+    @api.multi
     @api.depends('name', 'code')
     def name_get(self):
         if self._context.get('account_account_show_code_only'):
@@ -277,7 +270,7 @@ class AccountAccount(models.Model):
                 res.append((record.id, record.code))
             return res
         else:
-            return super().name_get()
+            return super(AccountAccount, self).name_get()
 
     # https://github.com/odoo/odoo/issues/23040
     # TODO mig to v12
@@ -318,6 +311,7 @@ class AccountAccount(models.Model):
         logger.info("END of the script 'fix bank and cash account types'")
         return True
 
+    # TODO mig to v12
     @api.model
     def create_account_groups(self, level=2, name_prefix=u'Comptes '):
         '''Should be launched by a script. Make sure the account_group module is installed
@@ -359,6 +353,7 @@ class AccountAccount(models.Model):
 class AccountAnalyticAccount(models.Model):
     _inherit = 'account.analytic.account'
 
+    @api.multi
     def name_get(self):
         if self._context.get('analytic_account_show_code_only'):
             res = []
@@ -366,7 +361,7 @@ class AccountAnalyticAccount(models.Model):
                 res.append((record.id, record.code or record.name))
             return res
         else:
-            return super().name_get()
+            return super(AccountAnalyticAccount, self).name_get()
 
     _sql_constraints = [(
         'code_company_unique',
@@ -407,58 +402,6 @@ class AccountMove(models.Model):
             move.default_credit = default_credit
             move.default_debit = default_debit
 
-    @api.model
-    def _fix_debit_credit_round_bug(self):
-        logger.info('START script _fix_debit_credit_round_bug')
-        moves = self.sudo().search([])  # sudo to search in all companies
-        bug_move_ids = []
-        for move in moves:
-            buggy = False
-            for l in move.line_ids:
-                if not float_is_zero(l.debit, precision_digits=2):
-                    debit_rounded = float_round(l.debit, precision_digits=2)
-                    if float_compare(l.debit, debit_rounded, precision_digits=6):
-                        logger.info('Bad move to fix ID %d company_id %d name %s ref %s date %s journal %s (line ID %d debit=%s)', move.id, move.company_id.id, move.name, move.ref, move.date, move.journal_id.code, l.id, l.debit)
-                        buggy = True
-                        break
-                else:
-                    credit_rounded = float_round(l.credit, precision_digits=2)
-                    if float_compare(l.credit, credit_rounded, precision_digits=6):
-                        logger.info('Bad move to fix ID %d company_id %d name %s ref %s date %s journal %s (line ID %d credit=%s)', move.id, move.company_id.id, move.name, move.ref, move.date, move.journal_id.code, l.id, l.credit)
-                        buggy = True
-                        break
-            if buggy:
-                bug_move_ids.append(move.id)
-                bal = 0.0
-                max_credit = (False, 0)
-                for l in move.line_ids:
-                    if not float_is_zero(l.debit, precision_digits=2):
-                        new_debit = float_round(l.debit, precision_digits=2)
-                        self._cr.execute(
-                            'UPDATE account_move_line set debit=%s, balance=%s where id=%s',
-                            (new_debit, new_debit, l.id))
-                        bal -= new_debit
-                    elif not float_is_zero(l.credit, precision_digits=2):
-                        new_credit = float_round(l.credit, precision_digits=2)
-                        self._cr.execute(
-                            'UPDATE account_move_line set credit=%s, balance=%s where id=%s',
-                            (new_credit, new_credit * -1, l.id))
-                        bal += new_credit
-                        if new_credit > max_credit[1]:
-                            max_credit = (l, new_credit)
-                if not float_is_zero(bal, precision_digits=2):
-                    assert abs(bal) < 0.05
-                    l = max_credit[0]
-                    new_credit = max_credit[1]
-                    new_new_credit = float_round(new_credit - bal, precision_digits=2)
-                    assert new_new_credit > 0
-                    self._cr.execute(
-                        'UPDATE account_move_line set credit=%s, balance=%s where id=%s',
-                        (new_new_credit, new_new_credit * -1, l.id))
-                logger.info('Move ID %d fixed', move.id)
-        logger.info('%d buggy moves fixed (IDs: %s)', len(bug_move_ids), bug_move_ids)
-        logger.info('END _fix_debit_credit_round_bug')
-
 
 class AccountMoveLine(models.Model):
     _inherit = 'account.move.line'
@@ -565,9 +508,8 @@ class AccountBankStatement(models.Model):
     end_date = fields.Date(
         compute='_compute_dates', string='End Date', readonly=True,
         store=True)
-    hide_bank_statement_balance = fields.Boolean(
-        related='journal_id.hide_bank_statement_balance', readonly=True)
 
+    @api.multi
     @api.depends('line_ids.date')
     def _compute_dates(self):
         for st in self:
@@ -575,14 +517,7 @@ class AccountBankStatement(models.Model):
             st.start_date = dates and min(dates) or False
             st.end_date = dates and max(dates) or False
 
-    def _balance_check(self):
-        for stmt in self:
-            if stmt.hide_bank_statement_balance:
-                continue
-            else:
-                super(AccountBankStatement, stmt)._balance_check()
-        return True
-
+    @api.multi
     @api.depends('name', 'start_date', 'end_date')
     def name_get(self):
         res = []
@@ -620,14 +555,15 @@ class AccountBankStatementLine(models.Model):
     #        search_reconciliation_proposition=False, context=None):
     #    # Make variable name shorted for PEP8 !
     #    search_rec_prop = search_reconciliation_proposition
-    #    return super().\
+    #    return super(AccountBankStatementLine, self).\
     #        get_data_for_reconciliations(
     #            cr, uid, ids, excluded_ids=excluded_ids,
     #            search_reconciliation_proposition=search_rec_prop,
     #            context=context)
 
     def _prepare_reconciliation_move(self, move_ref):
-        vals = super()._prepare_reconciliation_move(move_ref)
+        vals = super(AccountBankStatementLine, self).\
+            _prepare_reconciliation_move(move_ref)
         # By default, ref contains the name of the statement + name of the
         # statement line. It causes 2 problems:
         # 1) The 'ref' field is too big
@@ -645,13 +581,13 @@ class AccountBankStatementLine(models.Model):
     def show_account_move(self):
         self.ensure_one()
         action = self.env['ir.actions.act_window'].for_xml_id(
-            'account', 'action_move_line_form')
+            'account', 'action_move_journal_line')
         if self.journal_entry_ids:
             action.update({
                 'views': False,
                 'view_id': False,
                 'view_mode': 'form,tree',
-                'res_id': self.journal_entry_ids[0].move_id.id,
+                'res_id': self.journal_entry_ids[0].id,
                 })
             return action
         else:
@@ -723,65 +659,3 @@ class AccountIncoterms(models.Model):
         for rec in self:
             res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
         return res
-
-    @api.model
-    def name_search(self, name='', args=None, operator='ilike', limit=80):
-        if args is None:
-            args = []
-        if name and operator == 'ilike':
-            recs = self.search([('code', '=', name)] + args, limit=limit)
-            if recs:
-                return recs.name_get()
-        return super().name_search(name=name, args=args, operator=operator, limit=limit)
-
-
-class AccountReconciliation(models.AbstractModel):
-    _inherit = 'account.reconciliation.widget'
-
-    # Add ability to filter by account code in the work interface of the
-    # bank statement
-    @api.model
-    def _domain_move_lines(self, search_str):
-        str_domain = super()._domain_move_lines(search_str)
-        account_code_domain = [('account_id.code', '=ilike', search_str + '%')]
-        str_domain = expression.OR([str_domain, account_code_domain])
-        return str_domain
-
-    @api.model
-    def _domain_move_lines_for_reconciliation(
-            self, st_line, aml_accounts, partner_id,
-            excluded_ids=None, search_str=False):
-        domain = super()._domain_move_lines_for_reconciliation(
-            st_line, aml_accounts, partner_id,
-            excluded_ids=excluded_ids, search_str=search_str)
-        # We want to replace a domain item by another one
-        if ('payment_id', '<>', False) in domain:
-            position = domain.index(('payment_id', '<>', False))
-            domain[position] = ['journal_id', '=', st_line.journal_id.id]
-        return domain
-
-
-class ResConfigSettings(models.TransientModel):
-    _inherit = 'res.config.settings'
-
-    transfer_account_id = fields.Many2one(
-        related='company_id.transfer_account_id', readonly=False)
-
-
-class AccountChartTemplate(models.Model):
-    _inherit = "account.chart.template"
-
-    @api.model
-    def _prepare_transfer_account_template(self):
-        """Change the type of default account in order to be
-        compliant with _check_account_type_on_bank_journal
-        Used at installation of payment modules like stripe
-        See https://github.com/akretion/odoo-usability/issues/115
-        """
-        vals = super()._prepare_transfer_account_template()
-        current_assets_type = self.env.ref(
-            'account.data_account_type_liquidity', raise_if_not_found=False)
-        vals.update({
-            'user_type_id': current_assets_type and current_assets_type.id or False,
-        })
-        return vals

account_usability/account_several_improvements.diff

@@ -1,13 +1,53 @@
-diff --git a/addons/account/static/src/js/reconciliation/reconciliation_renderer.js b/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
-index 53f28e0c620..1721d01edf9 100644
---- a/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
-+++ b/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
-@@ -514,7 +514,7 @@ var LineRenderer = Widget.extend(FieldManagerMixin, {
-         }
-         return this.model.makeRecord('account.bank.statement.line', [field], {
-             partner_id: {
--                domain: ["|", ["is_company", "=", true], ["parent_id", "=", false], "|", ["customer", "=", true], ["supplier", "=", true]],
-+                domain: ["|", ["is_company", "=", true], ["parent_id", "=", false]],
-                 options: {
-                     no_open: true
-                 }
+diff --git a/addons/account/models/account_bank_statement.py b/addons/account/models/account_bank_statement.py
+index 8ed1e48..615da43 100644
+--- a/addons/account/models/account_bank_statement.py
++++ b/addons/account/models/account_bank_statement.py
+@@ -563,7 +563,13 @@ class AccountBankStatementLine(models.Model):
+         """
+         # Blue lines = payment on bank account not assigned to a statement yet
+         reconciliation_aml_accounts = [self.journal_id.default_credit_account_id.id, self.journal_id.default_debit_account_id.id]
+-        domain_reconciliation = ['&', '&', ('statement_id', '=', False), ('account_id', 'in', reconciliation_aml_accounts), ('payment_id','<>', False)]
++        # AKRETION HACK 11/7/2017
++        # Remove ('payment_id','<>', False) in order to allow to select move lines
++        # generated from payment orders or check deposit
++        # but I add ('journal_id', '=', self.journal_id.id) to exclude the
++        # opening entry of the first fiscal year
++        #domain_reconciliation = ['&', '&', ('statement_id', '=', False), ('account_id', 'in', reconciliation_aml_accounts), ('payment_id','<>', False)]
++        domain_reconciliation = ['&', '&', ('statement_id', '=', False), ('account_id', 'in', reconciliation_aml_accounts), ('journal_id', '=', self.journal_id.id)]
+ 
+         # Black lines = unreconciled & (not linked to a payment or open balance created by statement
+         domain_matching = [('reconciled', '=', False)]
+diff --git a/addons/account/models/account_move.py b/addons/account/models/account_move.py
+index b60ffbe..6c27c57 100644
+--- a/addons/account/models/account_move.py
++++ b/addons/account/models/account_move.py
+@@ -599,6 +599,7 @@ class AccountMoveLine(models.Model):
+             domain = expression.AND([domain, [('id', 'not in', excluded_ids)]])
+         if str:
+             str_domain = [
++                '|', ('account_id.code', '=ilike', str + '%'),
+                 '|', ('move_id.name', 'ilike', str),
+                 '|', ('move_id.ref', 'ilike', str),
+                 '|', ('date_maturity', 'like', str),
+diff --git a/addons/account/static/src/js/account_reconciliation_widgets.js b/addons/account/static/src/js/account_reconciliation_widgets.js
+index 453bd41..48c396e 100644
+--- a/addons/account/static/src/js/account_reconciliation_widgets.js
++++ b/addons/account/static/src/js/account_reconciliation_widgets.js
+@@ -76,7 +76,7 @@ var abstractReconciliation = Widget.extend(ControlPanelMixin, {
+         this.model_res_users = new Model("res.users");
+         this.model_tax = new Model("account.tax");
+         this.model_presets = new Model("account.reconcile.model");
+-        this.max_move_lines_displayed = 5;
++        this.max_move_lines_displayed = 15;
+         // Number of reconciliations loaded initially and by clicking 'show more'
+         this.num_reconciliations_fetched_in_batch = 10;
+         this.animation_speed = 100; // "Blocking" animations
+@@ -1755,7 +1755,7 @@ var bankStatementReconciliationLine = abstractReconciliationLine.extend({
+             relation: "res.partner",
+             string: _t("Partner"),
+             type: "many2one",
+-            domain: [['parent_id','=',false], '|', ['customer','=',true], ['supplier','=',true]],
++            domain: [['parent_id','=',false]],  // AKRETION HACK 26/6/2017 allow all parent partners
+             help: "",
+             readonly: false,
+             required: true,

account_usability/account_statement_black_cancel_blue_ok.diff

@@ -0,0 +1,14 @@
+diff --git a/addons/account/models/account_bank_statement.py b/addons/account/models/account_bank_statement.py
+index 4374528..aea1361 100644
+--- a/addons/account/models/account_bank_statement.py
++++ b/addons/account/models/account_bank_statement.py
+@@ -1008,7 +1008,7 @@ class AccountBankStatementLine(models.Model):
+             #record the move name on the statement line to be able to retrieve it in case of unreconciliation
+             self.write({'move_name': move.name})
+             payment.write({'payment_reference': move.name})
+-        elif self.move_name:
+-            raise UserError(_('Operation not allowed. Since your statement line already received a number, you cannot reconcile it entirely with existing journal entries otherwise it would make a gap in the numbering. You should book an entry and make a regular revert of it in case you want to cancel it.'))
++        #elif self.move_name:
++        #    raise UserError(_('Operation not allowed. Since your statement line already received a number, you cannot reconcile it entirely with existing journal entries otherwise it would make a gap in the numbering. You should book an entry and make a regular revert of it in case you want to cancel it.'))
+         counterpart_moves.assert_balanced()
+         return counterpart_moves

account_usability/account_view.xml

@@ -360,9 +360,8 @@ module -->
     <field name="model">account.move.line</field>
     <field name="inherit_id" ref="account.view_move_line_tree"/>
     <field name="arch" type="xml">
-        <field name="full_reconcile_id" position="attributes">
-            <attribute name="invisible">1</attribute>
-        </field>
+        <!-- Move reconcile_id to a better position -->
+        <field name="full_reconcile_id" position="replace"/>
         <field name="credit" position="after">
             <field name="balance" sum="Total Balance"/>
             <field name="reconcile_string"/>
@@ -409,31 +408,6 @@ module -->
     </field>
 </record>
 
-<record id="view_account_journal_form" model="ir.ui.view">
-    <field name="name">usability.account.journal.form</field>
-    <field name="model">account.journal</field>
-    <field name="inherit_id" ref="account.view_account_journal_form"/>
-    <field name="arch" type="xml">
-        <field name="bank_statements_source" position="after">
-            <field name="hide_bank_statement_balance" groups="account.group_account_user"/>
-        </field>
-    </field>
-</record>
-
-<record id="account_journal_dashboard_kanban_view" model="ir.ui.view">
-    <field name="name">usability.account.journal.dashboard</field>
-    <field name="model">account.journal</field>
-    <field name="inherit_id" ref="account.account_journal_dashboard_kanban_view"/>
-    <field name="arch"  type="xml">
-        <field name="kanban_dashboard" position="after">
-            <field name="hide_bank_statement_balance"/>
-        </field>
-        <xpath expr="//div[@name='latest_statement']/.." position="attributes">
-            <attribute name="t-if">dashboard.last_balance != dashboard.account_balance &amp;&amp; !record.hide_bank_statement_balance.raw_value</attribute>
-        </xpath>
-    </field>
-</record>
-
 <record id="view_account_journal_tree" model="ir.ui.view">
     <field name="name">usability.account.journal.tree</field>
     <field name="model">account.journal</field>
@@ -466,32 +440,16 @@ module -->
         <xpath expr="//field[@name='line_ids']/tree/field[@name='bank_account_id']" position="after">
             <!-- The cancel button is provided by the account_cancel module, but we don't want to depend on it -->
             <button name="show_account_move" type="object"
-                string="View Account Move" icon="fa-arrow-right"
+                string="View Account Move" icon="fa fa-arrow-right"
                 attrs="{'invisible': [('journal_entry_ids', '=', [])]}"/>
         </xpath>
         <field name="date" position="after">
             <field name="start_date"/>
             <field name="end_date"/>
-            <field name="hide_bank_statement_balance" invisible="1"/>
         </field>
         <field name="date" position="attributes">
             <attribute name="invisible">1</attribute>
         </field>
-        <label for="balance_start" position="attributes">
-            <attribute name="attrs">{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
-        </label>
-        <label for="balance_end_real" position="attributes">
-            <attribute name="attrs">{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
-        </label>
-        <xpath expr="//field[@name='balance_start']/.." position="attributes">
-            <attribute name="attrs">{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
-        </xpath>
-        <xpath expr="//field[@name='balance_end_real']/.." position="attributes">
-            <attribute name="attrs">{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
-        </xpath>
-        <group name="sale_total" position="attributes">
-            <attribute name="attrs">{'invisible': [('hide_bank_statement_balance', '=', True)]}</attribute>
-        </group>
     </field>
 </record>
 
@@ -579,28 +537,6 @@ module -->
 
 <menuitem id="account_tax_group_menu" action="account_tax_group_action" parent="account.account_account_menu" sequence="2"/>
 
-<!-- Account config page -->
-<record id="res_config_settings_view_form" model="ir.ui.view">
-    <field name="name">account_usability account config page</field>
-    <field name="model">res.config.settings</field>
-    <field name="inherit_id" ref="account.res_config_settings_view_form"/>
-    <field name="arch" type="xml">
-        <xpath expr="//field[@name='account_bank_reconciliation_start']/../.." position="after">
-            <div class="col-xs-12 col-md-6 o_setting_box">
-                <div class="o_setting_left_pane"/>
-                <div class="o_setting_right_pane">
-                    <label for="transfer_account_id"/>
-                    <div class="text-muted">
-                    Transit account when you transfer money from a bank account of your company to another bank account of your company.
-                    </div>
-                    <field name="transfer_account_id"/>
-                </div>
-            </div>
-        </xpath>
-    </field>
-</record>
-
-
 <!-- Remove menu entry "Accounting > Configuration > Accounting > Bank Accounts"
 (account.journal filtered on type = 'bank' with special tree and form view)
 because it is useless and confusing -->

account_usability/invoice_register_payment_writeoff_analytic.diff

@@ -1,33 +1,33 @@
 diff --git a/addons/account/models/account_payment.py b/addons/account/models/account_payment.py
-index f38f459c533..a475d6a82c7 100644
+index b1d8012329d..b8a8e2a673d 100644
 --- a/addons/account/models/account_payment.py
 +++ b/addons/account/models/account_payment.py
-@@ -62,6 +62,7 @@ class account_abstract_payment(models.AbstractModel):
+@@ -210,6 +210,7 @@ class account_payment(models.Model):
      payment_difference = fields.Monetary(compute='_compute_payment_difference', readonly=True)
-     payment_difference_handling = fields.Selection([('open', 'Keep open'), ('reconcile', 'Mark invoice as fully paid')], default='open', string="Payment Difference Handling", copy=False)
+     payment_difference_handling = fields.Selection([('open', 'Keep open'), ('reconcile', 'Mark invoice as fully paid')], default='open', string="Payment Difference", copy=False)
      writeoff_account_id = fields.Many2one('account.account', string="Difference Account", domain=[('deprecated', '=', False)], copy=False)
 +    writeoff_analytic_account_id = fields.Many2one('account.analytic.account', string="Difference Analytic Account", copy=False)
-     writeoff_label = fields.Char(
-         string='Journal Item Label',
-         help='Change label of the counterpart that will hold the payment difference',
-@@ -717,6 +718,7 @@ class account_payment(models.Model):
-             debit_wo, credit_wo, amount_currency_wo, currency_id = aml_obj.with_context(date=self.payment_date)._compute_amount_fields(self.payment_difference, self.currency_id, self.company_id.currency_id)
-             writeoff_line['name'] = self.writeoff_label
+ 
+     # FIXME: ondelete='restrict' not working (eg. cancel a bank statement reconciliation with a payment)
+     move_line_ids = fields.One2many('account.move.line', 'payment_id', readonly=True, copy=False, ondelete='restrict')
+@@ -431,6 +432,7 @@ class account_payment(models.Model):
+                 amount_currency_wo = -abs(amount_currency_wo)
+             writeoff_line['name'] = _('Counterpart')
              writeoff_line['account_id'] = self.writeoff_account_id.id
 +            writeoff_line['analytic_account_id'] = self.writeoff_analytic_account_id.id or False
              writeoff_line['debit'] = debit_wo
              writeoff_line['credit'] = credit_wo
              writeoff_line['amount_currency'] = amount_currency_wo
 diff --git a/addons/account/views/account_payment_view.xml b/addons/account/views/account_payment_view.xml
-index 07230902ee8..1359009bf23 100644
+index 2460458fbaa..4065d8f9952 100644
 --- a/addons/account/views/account_payment_view.xml
 +++ b/addons/account/views/account_payment_view.xml
-@@ -277,6 +277,8 @@
-                                     <div attrs="{'invisible': [('payment_difference_handling','=','open')]}">
-                                         <label for="writeoff_account_id" class="oe_edit_only" string="Post Difference In"/>
-                                         <field name="writeoff_account_id" string="Post Difference In" attrs="{'required': [('payment_difference_handling', '=', 'reconcile')]}"/>
-+                                        <label for="writeoff_analytic_account_id" class="oe_edit_only" string="Analytic Account" groups="analytic.group_analytic_accounting"/>
-+                                        <field name="writeoff_analytic_account_id" groups="analytic.group_analytic_accounting"/>
-                                         <label for="journal_id" string="Journal" attrs="{'invisible': [('amount', '!=', 0)]}"/>
-                                         <field name="journal_id" string="Journal" widget="selection" attrs="{'invisible': [('amount', '!=', 0)]}"/>
-                                         <label for="writeoff_label" class="oe_edit_only" string="Label"/>
+@@ -206,6 +206,8 @@
+                                 </div>
+                                 <field name="writeoff_account_id" string="Post Difference In"
+                                     attrs="{'invisible': [('payment_difference_handling','=','open')], 'required': [('payment_difference_handling', '=', 'reconcile')]}"/>
++                                <field name="writeoff_analytic_account_id" string="Post Difference In Analytic Account"
++                                    attrs="{'invisible': [('payment_difference_handling','=','open')]}"/>
+                             </group>
+                         </group>
+                     </sheet>

account_usability/readme/CONTRIBUTORS.rst

@@ -1,2 +0,0 @@
-* Alexis de Lattre <alexis.delattre@akretion.com>
-* David Beal <david.beal@akretion.com>

account_usability/readme/DESCRIPTION.rst

@@ -1,40 +0,0 @@
-This modules adds the following functions:
-
-* Add an *Overdue* filter on invoice search view (this feature was previously 
-  located in te module *account_invoice_overdue_filter*)
-* Increase the default limit of 80 lines in account move and account move line view.
-* disable reconciliation "guessing"
-* fast search on *Reconcile Ref* for account move line.
-* add sale dates to invoice report to be compliant with
-  https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808
-* Sale date on qweb invoices
-* A wizard to mark several invoices as sent at once (forward from v8)
-* Default date for Account Move Reversal is now D+1 instead of today
-* Track more fields on invoice (see details in account.py)
-* Add boolean fields `has_discount` and `has_attachment` on invoice
-* Add button "Delete line qty = 0" on supplier invoice
-* Cut name_get() of invoice if too long
-* A script for if Odoo screws up invoice attachment filename
-* help functions for py3o reports
-* Show code on name_get of journal
-* add direct search of journal using code
-* add copy=False on some fields
-* Add unicity constraint on analytic codes per company
-* Better default values on account move
-* Add link from account move line to invoice
-* Add start_date and end_date on bank statements
-* Add transfer_account_id to invoicing config page
-* Improve domain reconciliation widget
-* account.reconcile.model don't copy name to label via onchange
-* Add method to get fiscal position without partner_id
-* Restore drill-through on sale and invoice reports
-* don't attach PDF upon invoice report generation on supplier invoices/refunds
-* Add filter on debit and credit amount for Move Lines
-* Add supplier invoice number in invoice tree view
-* Change type from current_assets to  liquidity for transfert account template.
-
-Together with this module, I recommend the use of the following modules:
-
-* account_invoice_supplier_ref_unique (OCA project account-invoicing)
-* account_move_line_no_default_search (OCA project account-financial-tools)
-* invoice_fiscal_position_update (OCA project account-invoicing)

account_usability/static/description/index.html

@@ -1,454 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>
-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
-<title>Account Usability</title>
-<style type="text/css">
-
-/*
-:Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
-:Copyright: This stylesheet has been placed in the public domain.
-
-Default cascading style sheet for the HTML output of Docutils.
-
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
-customize this style sheet.
-*/
-
-/* used to remove borders from tables and images */
-.borderless, table.borderless td, table.borderless th {
-  border: 0 }
-
-table.borderless td, table.borderless th {
-  /* Override padding for "table.docutils td" with "! important".
-     The right padding separates the table cells. */
-  padding: 0 0.5em 0 0 ! important }
-
-.first {
-  /* Override more specific margin styles with "! important". */
-  margin-top: 0 ! important }
-
-.last, .with-subtitle {
-  margin-bottom: 0 ! important }
-
-.hidden {
-  display: none }
-
-.subscript {
-  vertical-align: sub;
-  font-size: smaller }
-
-.superscript {
-  vertical-align: super;
-  font-size: smaller }
-
-a.toc-backref {
-  text-decoration: none ;
-  color: black }
-
-blockquote.epigraph {
-  margin: 2em 5em ; }
-
-dl.docutils dd {
-  margin-bottom: 0.5em }
-
-object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
-  overflow: hidden;
-}
-
-/* Uncomment (and remove this text!) to get bold-faced definition list terms
-dl.docutils dt {
-  font-weight: bold }
-*/
-
-div.abstract {
-  margin: 2em 5em }
-
-div.abstract p.topic-title {
-  font-weight: bold ;
-  text-align: center }
-
-div.admonition, div.attention, div.caution, div.danger, div.error,
-div.hint, div.important, div.note, div.tip, div.warning {
-  margin: 2em ;
-  border: medium outset ;
-  padding: 1em }
-
-div.admonition p.admonition-title, div.hint p.admonition-title,
-div.important p.admonition-title, div.note p.admonition-title,
-div.tip p.admonition-title {
-  font-weight: bold ;
-  font-family: sans-serif }
-
-div.attention p.admonition-title, div.caution p.admonition-title,
-div.danger p.admonition-title, div.error p.admonition-title,
-div.warning p.admonition-title, .code .error {
-  color: red ;
-  font-weight: bold ;
-  font-family: sans-serif }
-
-/* Uncomment (and remove this text!) to get reduced vertical space in
-   compound paragraphs.
-div.compound .compound-first, div.compound .compound-middle {
-  margin-bottom: 0.5em }
-
-div.compound .compound-last, div.compound .compound-middle {
-  margin-top: 0.5em }
-*/
-
-div.dedication {
-  margin: 2em 5em ;
-  text-align: center ;
-  font-style: italic }
-
-div.dedication p.topic-title {
-  font-weight: bold ;
-  font-style: normal }
-
-div.figure {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-div.footer, div.header {
-  clear: both;
-  font-size: smaller }
-
-div.line-block {
-  display: block ;
-  margin-top: 1em ;
-  margin-bottom: 1em }
-
-div.line-block div.line-block {
-  margin-top: 0 ;
-  margin-bottom: 0 ;
-  margin-left: 1.5em }
-
-div.sidebar {
-  margin: 0 0 0.5em 1em ;
-  border: medium outset ;
-  padding: 1em ;
-  background-color: #ffffee ;
-  width: 40% ;
-  float: right ;
-  clear: right }
-
-div.sidebar p.rubric {
-  font-family: sans-serif ;
-  font-size: medium }
-
-div.system-messages {
-  margin: 5em }
-
-div.system-messages h1 {
-  color: red }
-
-div.system-message {
-  border: medium outset ;
-  padding: 1em }
-
-div.system-message p.system-message-title {
-  color: red ;
-  font-weight: bold }
-
-div.topic {
-  margin: 2em }
-
-h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
-h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
-  margin-top: 0.4em }
-
-h1.title {
-  text-align: center }
-
-h2.subtitle {
-  text-align: center }
-
-hr.docutils {
-  width: 75% }
-
-img.align-left, .figure.align-left, object.align-left, table.align-left {
-  clear: left ;
-  float: left ;
-  margin-right: 1em }
-
-img.align-right, .figure.align-right, object.align-right, table.align-right {
-  clear: right ;
-  float: right ;
-  margin-left: 1em }
-
-img.align-center, .figure.align-center, object.align-center {
-  display: block;
-  margin-left: auto;
-  margin-right: auto;
-}
-
-table.align-center {
-  margin-left: auto;
-  margin-right: auto;
-}
-
-.align-left {
-  text-align: left }
-
-.align-center {
-  clear: both ;
-  text-align: center }
-
-.align-right {
-  text-align: right }
-
-/* reset inner alignment in figures */
-div.align-right {
-  text-align: inherit }
-
-/* div.align-center * { */
-/*   text-align: left } */
-
-.align-top    {
-  vertical-align: top }
-
-.align-middle {
-  vertical-align: middle }
-
-.align-bottom {
-  vertical-align: bottom }
-
-ol.simple, ul.simple {
-  margin-bottom: 1em }
-
-ol.arabic {
-  list-style: decimal }
-
-ol.loweralpha {
-  list-style: lower-alpha }
-
-ol.upperalpha {
-  list-style: upper-alpha }
-
-ol.lowerroman {
-  list-style: lower-roman }
-
-ol.upperroman {
-  list-style: upper-roman }
-
-p.attribution {
-  text-align: right ;
-  margin-left: 50% }
-
-p.caption {
-  font-style: italic }
-
-p.credits {
-  font-style: italic ;
-  font-size: smaller }
-
-p.label {
-  white-space: nowrap }
-
-p.rubric {
-  font-weight: bold ;
-  font-size: larger ;
-  color: maroon ;
-  text-align: center }
-
-p.sidebar-title {
-  font-family: sans-serif ;
-  font-weight: bold ;
-  font-size: larger }
-
-p.sidebar-subtitle {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-p.topic-title {
-  font-weight: bold }
-
-pre.address {
-  margin-bottom: 0 ;
-  margin-top: 0 ;
-  font: inherit }
-
-pre.literal-block, pre.doctest-block, pre.math, pre.code {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-pre.code .ln { color: grey; } /* line numbers */
-pre.code, code { background-color: #eeeeee }
-pre.code .comment, code .comment { color: #5C6576 }
-pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
-pre.code .literal.string, code .literal.string { color: #0C5404 }
-pre.code .name.builtin, code .name.builtin { color: #352B84 }
-pre.code .deleted, code .deleted { background-color: #DEB0A1}
-pre.code .inserted, code .inserted { background-color: #A3D289}
-
-span.classifier {
-  font-family: sans-serif ;
-  font-style: oblique }
-
-span.classifier-delimiter {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-span.interpreted {
-  font-family: sans-serif }
-
-span.option {
-  white-space: nowrap }
-
-span.pre {
-  white-space: pre }
-
-span.problematic {
-  color: red }
-
-span.section-subtitle {
-  /* font-size relative to parent (h1..h6 element) */
-  font-size: 80% }
-
-table.citation {
-  border-left: solid 1px gray;
-  margin-left: 1px }
-
-table.docinfo {
-  margin: 2em 4em }
-
-table.docutils {
-  margin-top: 0.5em ;
-  margin-bottom: 0.5em }
-
-table.footnote {
-  border-left: solid 1px black;
-  margin-left: 1px }
-
-table.docutils td, table.docutils th,
-table.docinfo td, table.docinfo th {
-  padding-left: 0.5em ;
-  padding-right: 0.5em ;
-  vertical-align: top }
-
-table.docutils th.field-name, table.docinfo th.docinfo-name {
-  font-weight: bold ;
-  text-align: left ;
-  white-space: nowrap ;
-  padding-left: 0 }
-
-/* "booktabs" style (no vertical lines) */
-table.docutils.booktabs {
-  border: 0px;
-  border-top: 2px solid;
-  border-bottom: 2px solid;
-  border-collapse: collapse;
-}
-table.docutils.booktabs * {
-  border: 0px;
-}
-table.docutils.booktabs th {
-  border-bottom: thin solid;
-  text-align: left;
-}
-
-h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
-h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
-  font-size: 100% }
-
-ul.auto-toc {
-  list-style-type: none }
-
-</style>
-</head>
-<body>
-<div class="document" id="account-usability">
-<h1 class="title">Account Usability</h1>
-
-<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! This file is generated by oca-gen-addon-readme !!
-!! changes will be overwritten.                   !!
-!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/account_usability"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
-<p>This modules adds the following functions:</p>
-<ul class="simple">
-<li>Add an <em>Overdue</em> filter on invoice search view (this feature was previously
-located in te module <em>account_invoice_overdue_filter</em>)</li>
-<li>Increase the default limit of 80 lines in account move and account move line view.</li>
-<li>disable reconciliation “guessing”</li>
-<li>fast search on <em>Reconcile Ref</em> for account move line.</li>
-<li>add sale dates to invoice report to be compliant with
-<a class="reference external" href="https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808">https://www.service-public.fr/professionnels-entreprises/vosdroits/F31808</a></li>
-<li>Sale date on qweb invoices</li>
-<li>A wizard to mark several invoices as sent at once (forward from v8)</li>
-<li>Default date for Account Move Reversal is now D+1 instead of today</li>
-<li>Track more fields on invoice (see details in account.py)</li>
-<li>Add boolean fields <cite>has_discount</cite> and <cite>has_attachment</cite> on invoice</li>
-<li>Add button “Delete line qty = 0” on supplier invoice</li>
-<li>Cut name_get() of invoice if too long</li>
-<li>A script for if Odoo screws up invoice attachment filename</li>
-<li>help functions for py3o reports</li>
-<li>Show code on name_get of journal</li>
-<li>add direct search of journal using code</li>
-<li>add copy=False on some fields</li>
-<li>Add unicity constraint on analytic codes per company</li>
-<li>Better default values on account move</li>
-<li>Add link from account move line to invoice</li>
-<li>Add start_date and end_date on bank statements</li>
-<li>Add transfer_account_id to invoicing config page</li>
-<li>Improve domain reconciliation widget</li>
-<li>account.reconcile.model don’t copy name to label via onchange</li>
-<li>Add method to get fiscal position without partner_id</li>
-<li>Restore drill-through on sale and invoice reports</li>
-<li>don’t attach PDF upon invoice report generation on supplier invoices/refunds</li>
-<li>Add filter on debit and credit amount for Move Lines</li>
-<li>Add supplier invoice number in invoice tree view</li>
-</ul>
-<p>Together with this module, I recommend the use of the following modules:</p>
-<ul class="simple">
-<li>account_invoice_supplier_ref_unique (OCA project account-invoicing)</li>
-<li>account_move_line_no_default_search (OCA project account-financial-tools)</li>
-<li>invoice_fiscal_position_update (OCA project account-invoicing)</li>
-</ul>
-<p><strong>Table of contents</strong></p>
-<div class="contents local topic" id="contents">
-<ul class="simple">
-<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
-</ul>
-</li>
-</ul>
-</div>
-<div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20account_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
-<p>Do not contact contributors directly about support or help with technical issues.</p>
-</div>
-<div class="section" id="credits">
-<h1><a class="toc-backref" href="#id2">Credits</a></h1>
-<div class="section" id="authors">
-<h2><a class="toc-backref" href="#id3">Authors</a></h2>
-<ul class="simple">
-<li>Akretion</li>
-</ul>
-</div>
-<div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
-<ul class="simple">
-<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
-<li>David Beal &lt;<a class="reference external" href="mailto:david.beal&#64;akretion.com">david.beal&#64;akretion.com</a>&gt;</li>
-</ul>
-</div>
-<div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
-<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/account_usability">akretion/odoo-usability</a> project on GitHub.</p>
-<p>You are welcome to contribute.</p>
-</div>
-</div>
-</div>
-</body>
-</html>

base_company_extension/README.rst

@@ -1,61 +0,0 @@
-======================
-Base Company Extension
-======================
-
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! This file is generated by oca-gen-addon-readme !!
-   !! changes will be overwritten.                   !!
-   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-
-.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
-    :target: https://odoo-community.org/page/development-status
-    :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
-    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-    :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github
-    :target: https://github.com/akretion/odoo-usability/tree/12.0/base_company_extension
-    :alt: akretion/odoo-usability
-
-|badge1| |badge2| |badge3| 
-
-This module adds the following fields to the ResCompany model:
-* Capital Amount
-* Legal Type
-
-This is useful to display the legal name of the company in reports
-
-**Table of contents**
-
-.. contents::
-   :local:
-
-Bug Tracker
-===========
-
-Bugs are tracked on `GitHub Issues <https://github.com/akretion/odoo-usability/issues>`_.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/akretion/odoo-usability/issues/new?body=module:%20base_company_extension%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-
-Do not contact contributors directly about support or help with technical issues.
-
-Credits
-=======
-
-Authors
-~~~~~~~
-
-* Akretion
-
-Contributors
-~~~~~~~~~~~~
-
-* Alexis de Lattre <alexis.delattre@akretion.com>
-
-Maintainers
-~~~~~~~~~~~
-
-This module is part of the `akretion/odoo-usability <https://github.com/akretion/odoo-usability/tree/12.0/base_company_extension>`_ project on GitHub.
-
-You are welcome to contribute.

base_company_extension/__manifest__.py

@@ -9,6 +9,16 @@
     'category': 'Partner',
     'license': 'AGPL-3',
     'summary': 'Adds capital and title on company',
+    'description': """
+Base Company Extension
+======================
+
+This module adds 2 fields on the Company :
+
+* *Capital Amount*
+
+* *Legal Form*
+    """,
     'author': 'Akretion',
     'website': 'http://www.akretion.com',
     # I depend on base_usability only for _report_company_legal_name()

base_company_extension/readme/CONTRIBUTORS.rst

@@ -1 +0,0 @@
-* Alexis de Lattre <alexis.delattre@akretion.com>

base_company_extension/readme/DESCRIPTION.rst

@@ -1,5 +0,0 @@
-This module adds the following fields to the ResCompany model:
-* Capital Amount
-* Legal Type
-
-This is useful to display the legal name of the company in reports

base_company_extension/static/description/index.html

@@ -1,417 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>
-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
-<title>Base Company Extension</title>
-<style type="text/css">
-
-/*
-:Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
-:Copyright: This stylesheet has been placed in the public domain.
-
-Default cascading style sheet for the HTML output of Docutils.
-
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
-customize this style sheet.
-*/
-
-/* used to remove borders from tables and images */
-.borderless, table.borderless td, table.borderless th {
-  border: 0 }
-
-table.borderless td, table.borderless th {
-  /* Override padding for "table.docutils td" with "! important".
-     The right padding separates the table cells. */
-  padding: 0 0.5em 0 0 ! important }
-
-.first {
-  /* Override more specific margin styles with "! important". */
-  margin-top: 0 ! important }
-
-.last, .with-subtitle {
-  margin-bottom: 0 ! important }
-
-.hidden {
-  display: none }
-
-.subscript {
-  vertical-align: sub;
-  font-size: smaller }
-
-.superscript {
-  vertical-align: super;
-  font-size: smaller }
-
-a.toc-backref {
-  text-decoration: none ;
-  color: black }
-
-blockquote.epigraph {
-  margin: 2em 5em ; }
-
-dl.docutils dd {
-  margin-bottom: 0.5em }
-
-object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
-  overflow: hidden;
-}
-
-/* Uncomment (and remove this text!) to get bold-faced definition list terms
-dl.docutils dt {
-  font-weight: bold }
-*/
-
-div.abstract {
-  margin: 2em 5em }
-
-div.abstract p.topic-title {
-  font-weight: bold ;
-  text-align: center }
-
-div.admonition, div.attention, div.caution, div.danger, div.error,
-div.hint, div.important, div.note, div.tip, div.warning {
-  margin: 2em ;
-  border: medium outset ;
-  padding: 1em }
-
-div.admonition p.admonition-title, div.hint p.admonition-title,
-div.important p.admonition-title, div.note p.admonition-title,
-div.tip p.admonition-title {
-  font-weight: bold ;
-  font-family: sans-serif }
-
-div.attention p.admonition-title, div.caution p.admonition-title,
-div.danger p.admonition-title, div.error p.admonition-title,
-div.warning p.admonition-title, .code .error {
-  color: red ;
-  font-weight: bold ;
-  font-family: sans-serif }
-
-/* Uncomment (and remove this text!) to get reduced vertical space in
-   compound paragraphs.
-div.compound .compound-first, div.compound .compound-middle {
-  margin-bottom: 0.5em }
-
-div.compound .compound-last, div.compound .compound-middle {
-  margin-top: 0.5em }
-*/
-
-div.dedication {
-  margin: 2em 5em ;
-  text-align: center ;
-  font-style: italic }
-
-div.dedication p.topic-title {
-  font-weight: bold ;
-  font-style: normal }
-
-div.figure {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-div.footer, div.header {
-  clear: both;
-  font-size: smaller }
-
-div.line-block {
-  display: block ;
-  margin-top: 1em ;
-  margin-bottom: 1em }
-
-div.line-block div.line-block {
-  margin-top: 0 ;
-  margin-bottom: 0 ;
-  margin-left: 1.5em }
-
-div.sidebar {
-  margin: 0 0 0.5em 1em ;
-  border: medium outset ;
-  padding: 1em ;
-  background-color: #ffffee ;
-  width: 40% ;
-  float: right ;
-  clear: right }
-
-div.sidebar p.rubric {
-  font-family: sans-serif ;
-  font-size: medium }
-
-div.system-messages {
-  margin: 5em }
-
-div.system-messages h1 {
-  color: red }
-
-div.system-message {
-  border: medium outset ;
-  padding: 1em }
-
-div.system-message p.system-message-title {
-  color: red ;
-  font-weight: bold }
-
-div.topic {
-  margin: 2em }
-
-h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
-h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
-  margin-top: 0.4em }
-
-h1.title {
-  text-align: center }
-
-h2.subtitle {
-  text-align: center }
-
-hr.docutils {
-  width: 75% }
-
-img.align-left, .figure.align-left, object.align-left, table.align-left {
-  clear: left ;
-  float: left ;
-  margin-right: 1em }
-
-img.align-right, .figure.align-right, object.align-right, table.align-right {
-  clear: right ;
-  float: right ;
-  margin-left: 1em }
-
-img.align-center, .figure.align-center, object.align-center {
-  display: block;
-  margin-left: auto;
-  margin-right: auto;
-}
-
-table.align-center {
-  margin-left: auto;
-  margin-right: auto;
-}
-
-.align-left {
-  text-align: left }
-
-.align-center {
-  clear: both ;
-  text-align: center }
-
-.align-right {
-  text-align: right }
-
-/* reset inner alignment in figures */
-div.align-right {
-  text-align: inherit }
-
-/* div.align-center * { */
-/*   text-align: left } */
-
-.align-top    {
-  vertical-align: top }
-
-.align-middle {
-  vertical-align: middle }
-
-.align-bottom {
-  vertical-align: bottom }
-
-ol.simple, ul.simple {
-  margin-bottom: 1em }
-
-ol.arabic {
-  list-style: decimal }
-
-ol.loweralpha {
-  list-style: lower-alpha }
-
-ol.upperalpha {
-  list-style: upper-alpha }
-
-ol.lowerroman {
-  list-style: lower-roman }
-
-ol.upperroman {
-  list-style: upper-roman }
-
-p.attribution {
-  text-align: right ;
-  margin-left: 50% }
-
-p.caption {
-  font-style: italic }
-
-p.credits {
-  font-style: italic ;
-  font-size: smaller }
-
-p.label {
-  white-space: nowrap }
-
-p.rubric {
-  font-weight: bold ;
-  font-size: larger ;
-  color: maroon ;
-  text-align: center }
-
-p.sidebar-title {
-  font-family: sans-serif ;
-  font-weight: bold ;
-  font-size: larger }
-
-p.sidebar-subtitle {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-p.topic-title {
-  font-weight: bold }
-
-pre.address {
-  margin-bottom: 0 ;
-  margin-top: 0 ;
-  font: inherit }
-
-pre.literal-block, pre.doctest-block, pre.math, pre.code {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-pre.code .ln { color: grey; } /* line numbers */
-pre.code, code { background-color: #eeeeee }
-pre.code .comment, code .comment { color: #5C6576 }
-pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
-pre.code .literal.string, code .literal.string { color: #0C5404 }
-pre.code .name.builtin, code .name.builtin { color: #352B84 }
-pre.code .deleted, code .deleted { background-color: #DEB0A1}
-pre.code .inserted, code .inserted { background-color: #A3D289}
-
-span.classifier {
-  font-family: sans-serif ;
-  font-style: oblique }
-
-span.classifier-delimiter {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-span.interpreted {
-  font-family: sans-serif }
-
-span.option {
-  white-space: nowrap }
-
-span.pre {
-  white-space: pre }
-
-span.problematic {
-  color: red }
-
-span.section-subtitle {
-  /* font-size relative to parent (h1..h6 element) */
-  font-size: 80% }
-
-table.citation {
-  border-left: solid 1px gray;
-  margin-left: 1px }
-
-table.docinfo {
-  margin: 2em 4em }
-
-table.docutils {
-  margin-top: 0.5em ;
-  margin-bottom: 0.5em }
-
-table.footnote {
-  border-left: solid 1px black;
-  margin-left: 1px }
-
-table.docutils td, table.docutils th,
-table.docinfo td, table.docinfo th {
-  padding-left: 0.5em ;
-  padding-right: 0.5em ;
-  vertical-align: top }
-
-table.docutils th.field-name, table.docinfo th.docinfo-name {
-  font-weight: bold ;
-  text-align: left ;
-  white-space: nowrap ;
-  padding-left: 0 }
-
-/* "booktabs" style (no vertical lines) */
-table.docutils.booktabs {
-  border: 0px;
-  border-top: 2px solid;
-  border-bottom: 2px solid;
-  border-collapse: collapse;
-}
-table.docutils.booktabs * {
-  border: 0px;
-}
-table.docutils.booktabs th {
-  border-bottom: thin solid;
-  text-align: left;
-}
-
-h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
-h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
-  font-size: 100% }
-
-ul.auto-toc {
-  list-style-type: none }
-
-</style>
-</head>
-<body>
-<div class="document" id="base-company-extension">
-<h1 class="title">Base Company Extension</h1>
-
-<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! This file is generated by oca-gen-addon-readme !!
-!! changes will be overwritten.                   !!
-!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/base_company_extension"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
-<p>This module adds the following fields to the ResCompany model:
-* Capital Amount
-* Legal Type</p>
-<p>This is useful to display the legal name of the company in reports</p>
-<p><strong>Table of contents</strong></p>
-<div class="contents local topic" id="contents">
-<ul class="simple">
-<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
-</ul>
-</li>
-</ul>
-</div>
-<div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20base_company_extension%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
-<p>Do not contact contributors directly about support or help with technical issues.</p>
-</div>
-<div class="section" id="credits">
-<h1><a class="toc-backref" href="#id2">Credits</a></h1>
-<div class="section" id="authors">
-<h2><a class="toc-backref" href="#id3">Authors</a></h2>
-<ul class="simple">
-<li>Akretion</li>
-</ul>
-</div>
-<div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
-<ul class="simple">
-<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
-</ul>
-</div>
-<div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
-<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/base_company_extension">akretion/odoo-usability</a> project on GitHub.</p>
-<p>You are welcome to contribute.</p>
-</div>
-</div>
-</div>
-</body>
-</html>

base_dynamic_list/__init__.py

@@ -1 +0,0 @@
-from . import models

base_dynamic_list/__manifest__.py

@@ -1,62 +0,0 @@
-# Copyright 2020-2022 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-{
-    'name': 'Base Dynamic List',
-    'version': '12.0.1.0.0',
-    'category': 'Tools',
-    'license': 'AGPL-3',
-    'summary': 'Dynamic lists',
-    'description': """
-Base Dynamic List
-=================
-
-Very often during an Odoo implementation, we need to add selection fields on a native objet, and we don't want to have a hard-coded selection list (fields.Selection), but a selection list that can be changed by users (Many2one field). For that, the developper needs to add a new object (with just a 'name' and 'sequence' field) with a form/tree view. The goal of this module is to speed-up this process by defining a dynamic list object that already has all the required views.
-
-This module provides several ready-to-go objects:
-
-* simple list : fields *name*, *sequence* and *active*
-* translatable list : fields *name* with translate=True, *sequence* and *active*
-* code list : fields *code* (unique), *name*, *sequence* and *active*
-* translatable code list : fields *code* (unique), *name* with translate=True, *sequence* and *active*
-
-These objects are readable by the employee group. The system group has full rights on it.
-
-To use it, you need to do 2 or 3 things :
-
-1) Add an entry in the domain field and the object you selected:
-
-domain = fields.Selection(selection_add=[('risk.type', "Risk Type")], ondelete={"risk.type": "cascade"})
-
-2) Add the many2one field on your object:
-
-risk_type_id = fields.Many2one(
-    'dynamic.list', string="Risk Type",
-    ondelete='restrict', domain=[('domain', '=', 'risk.type')])
-
-
-3) Optionally, you can add a dedicated action and a menu entry (otherwize, you can use the generic menu entry under *Settings > Technical > Dynamic Lists*:
-
-<record id="dynamic_list_risk_type_action" model="ir.actions.act_window">
-    <field name="name">Risk Type</field>
-    <field name="res_model">dynamic.list</field>
-    <field name="view_mode">tree,form</field>
-    <field name="domain">[('domain', '=', 'risk.type')]</field>
-    <field name="context">{'default_domain': 'risk.type'}</field>
-</record>
-
-<menuitem id="dynamic_list_risk_type_menu" action="dynamic_list_risk_type_action"
-parent="parent_menu_xmlid"/>
-
-Limitation: when you want to have different access rights on these lists depending on the source object, you should prefer to use dedicated objects.
-""",
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['base'],
-    'data': [
-        'security/ir.model.access.csv',
-        'views/dynamic_list.xml',
-        ],
-    'installable': True,
-}

base_dynamic_list/models/__init__.py

@@ -1 +0,0 @@
-from . import dynamic_list

base_dynamic_list/models/dynamic_list.py

@@ -1,115 +0,0 @@
-# Copyright 2020-2022 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import api, fields, models
-
-
-class DynamicList(models.Model):
-    _name = 'dynamic.list'
-    _description = 'Dynamic List (non translatable)'
-    _order = 'sequence, id'
-
-    name = fields.Char(required=True)
-    sequence = fields.Integer(default=10)
-    active = fields.Boolean(default=True)
-    domain = fields.Selection([], string='Domain', required=True, index=True)
-
-    _sql_constraint = [(
-        'domain_name_uniq',
-        'unique(domain, name)',
-        'This entry already exists!'
-        )]
-
-
-class DynamicListTranslate(models.Model):
-    _name = 'dynamic.list.translate'
-    _description = 'Translatable Dynamic List'
-    _order = 'sequence, id'
-
-    name = fields.Char(translate=True, required=True)
-    sequence = fields.Integer(default=10)
-    active = fields.Boolean(default=True)
-    domain = fields.Selection([], string='Domain', required=True, index=True)
-
-    _sql_constraint = [(
-        'domain_name_uniq',
-        'unique(domain, name)',
-        'This entry already exists!'
-        )]
-
-
-class DynamicListCode(models.Model):
-    _name = 'dynamic.list.code'
-    _description = 'Dynamic list with code'
-    _order = 'sequence, id'
-
-    code = fields.Char(required=True)
-    name = fields.Char(translate=True, required=True)
-    sequence = fields.Integer(default=10)
-    active = fields.Boolean(default=True)
-    domain = fields.Selection([], string='Domain', required=True, index=True)
-
-    _sql_constraint = [(
-        'domain_code_uniq',
-        'unique(domain, code)',
-        'This code already exists!'
-        )]
-
-    @api.depends('code', 'name')
-    def name_get(self):
-        res = []
-        for rec in self:
-            res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
-        return res
-
-    @api.model
-    def name_search(
-            self, name='', args=None, operator='ilike', limit=80):
-        if args is None:
-            args = []
-        if name and operator == 'ilike':
-            recs = self.search(
-                [('code', '=', name)] + args, limit=limit)
-            if recs:
-                return recs.name_get()
-        return super().name_search(
-            name=name, args=args, operator=operator, limit=limit)
-
-
-class DynamicListCodeTranslate(models.Model):
-    _name = 'dynamic.list.code.translate'
-    _description = 'Translatable dynamic list with code'
-    _order = 'sequence, id'
-
-    code = fields.Char(required=True)
-    name = fields.Char(translate=True, required=True)
-    sequence = fields.Integer(default=10)
-    active = fields.Boolean(default=True)
-    domain = fields.Selection([], string='Domain', required=True, index=True)
-
-    _sql_constraint = [(
-        'domain_code_uniq',
-        'unique(domain, code)',
-        'This code already exists!'
-        )]
-
-    @api.depends('code', 'name')
-    def name_get(self):
-        res = []
-        for rec in self:
-            res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
-        return res
-
-    @api.model
-    def name_search(
-            self, name='', args=None, operator='ilike', limit=80):
-        if args is None:
-            args = []
-        if name and operator == 'ilike':
-            recs = self.search(
-                [('code', '=', name)] + args, limit=limit)
-            if recs:
-                return recs.name_get()
-        return super().name_search(
-            name=name, args=args, operator=operator, limit=limit)

base_dynamic_list/security/ir.model.access.csv

@@ -1,9 +0,0 @@
-id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_dynamic_list_read,Read access on dynamic.list to employees,model_dynamic_list,base.group_user,1,0,0,0
-access_dynamic_list_full,Full access to dynamic.list to System group,model_dynamic_list,base.group_system,1,1,1,1
-access_dynamic_list_translate_read,Read access on dynamic.list.translate to employees,model_dynamic_list_translate,base.group_user,1,0,0,0
-access_dynamic_list_translate_full,Full access to dynamic.list.translate to System group,model_dynamic_list_translate,base.group_system,1,1,1,1
-access_dynamic_list_code_read,Read access on dynamic.list.code to employees,model_dynamic_list_code,base.group_user,1,0,0,0
-access_dynamic_list_code_full,Full access to dynamic.list.code to System group,model_dynamic_list_code,base.group_system,1,1,1,1
-access_dynamic_list_code_translate_read,Read access on dynamic.list.code.translate to employees,model_dynamic_list_code_translate,base.group_user,1,0,0,0
-access_dynamic_list_code_translate_full,Full access to dynamic.list.code.translate to System group,model_dynamic_list_code_translate,base.group_system,1,1,1,1

base_dynamic_list/views/dynamic_list.xml

@@ -1,240 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-  Copyright 2020 Akretion France (http://www.akretion.com/)
-  @author: Alexis de Lattre <alexis.delattre@akretion.com>
-  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
--->
-
-<odoo>
-
-
-<menuitem id="dynamic_list_root_menu" name="Dynamic Lists" parent="base.menu_custom" sequence="100"/>
-
-<record id="dynamic_list_form" model="ir.ui.view">
-    <field name="model">dynamic.list</field>
-    <field name="arch" type="xml">
-        <form>
-            <sheet>
-                <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                        class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                            options='{"terminology": "archive"}'/>
-                    </button>
-                </div>
-                <group name="main">
-                    <field name="name"/>
-                    <field name="domain" invisible="not context.get('dynamic_list_main_view')"/>
-                </group>
-            </sheet>
-        </form>
-    </field>
-</record>
-
-<record id="dynamic_list_tree" model="ir.ui.view">
-    <field name="model">dynamic.list</field>
-    <field name="arch" type="xml">
-        <tree>
-            <field name="sequence" widget="handle"/>
-            <field name="name"/>
-            <field name="domain" invisible="not context.get('dynamic_list_main_view')"/>
-        </tree>
-    </field>
-</record>
-
-<record id="dynamic_list_search" model="ir.ui.view">
-    <field name="model">dynamic.list</field>
-    <field name="arch" type="xml">
-        <search>
-            <field name="name"/>
-            <separator/>
-            <filter string="Archived" name="inactive" domain="[('active', '=', False)]"/>
-            <group string="Group By" name="groupby">
-                <filter name="domain_groupby" string="Domain" context="{'group_by': 'domain'}"/>
-            </group>
-        </search>
-    </field>
-</record>
-
-<record id="dynamic_list_action" model="ir.actions.act_window">
-    <field name="name">Simple List</field>
-    <field name="res_model">dynamic.list</field>
-    <field name="view_mode">tree,form</field>
-    <field name="context">{'dynamic_list_main_view': True, 'search_default_domain_groupby': True}</field>
-</record>
-
-<menuitem id="dynamic_list_menu" action="dynamic_list_action" parent="dynamic_list_root_menu" sequence="10"/>
-
-<record id="dynamic_list_translate_form" model="ir.ui.view">
-    <field name="model">dynamic.list.translate</field>
-    <field name="arch" type="xml">
-        <form>
-            <sheet>
-                <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                        class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                            options='{"terminology": "archive"}'/>
-                    </button>
-                </div>
-                <group name="main">
-                    <field name="name"/>
-                    <field name="domain" invisible="not context.get('dynamic_list_translate_main_view')"/>
-                </group>
-            </sheet>
-        </form>
-    </field>
-</record>
-
-<record id="dynamic_list_translate_tree" model="ir.ui.view">
-    <field name="model">dynamic.list.translate</field>
-    <field name="arch" type="xml">
-        <tree>
-            <field name="sequence" widget="handle"/>
-            <field name="name"/>
-            <field name="domain" invisible="not context.get('dynamic_list_translate_main_view')"/>
-        </tree>
-    </field>
-</record>
-
-<record id="dynamic_list_translate_search" model="ir.ui.view">
-    <field name="model">dynamic.list.translate</field>
-    <field name="arch" type="xml">
-        <search>
-            <field name="name"/>
-            <separator/>
-            <filter string="Archived" name="inactive" domain="[('active', '=', False)]"/>
-            <group string="Group By" name="groupby">
-                <filter name="domain_groupby" string="Domain" context="{'group_by': 'domain'}"/>
-            </group>
-        </search>
-    </field>
-</record>
-
-<record id="dynamic_list_translate_action" model="ir.actions.act_window">
-    <field name="name">Translatable Simple List</field>
-    <field name="res_model">dynamic.list.translate</field>
-    <field name="view_mode">tree,form</field>
-    <field name="context">{'dynamic_list_translate_main_view': True, 'search_default_domain_groupby': True}</field>
-</record>
-
-<menuitem id="dynamic_list_translate_menu" action="dynamic_list_translate_action" parent="dynamic_list_root_menu" sequence="20"/>
-
-<record id="dynamic_list_code_form" model="ir.ui.view">
-    <field name="model">dynamic.list.code</field>
-    <field name="arch" type="xml">
-        <form>
-            <sheet>
-                <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                        class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                            options='{"terminology": "archive"}'/>
-                    </button>
-                </div>
-                <group name="main">
-                    <field name="code"/>
-                    <field name="name"/>
-                    <field name="domain" invisible="not context.get('dynamic_list_code_main_view')"/>
-                </group>
-            </sheet>
-        </form>
-    </field>
-</record>
-
-<record id="dynamic_list_code_tree" model="ir.ui.view">
-    <field name="model">dynamic.list.code</field>
-    <field name="arch" type="xml">
-        <tree>
-            <field name="sequence" widget="handle"/>
-            <field name="code"/>
-            <field name="name"/>
-            <field name="domain" invisible="not context.get('dynamic_list_code_main_view')"/>
-        </tree>
-    </field>
-</record>
-
-<record id="dynamic_list_code_search" model="ir.ui.view">
-    <field name="model">dynamic.list.code</field>
-    <field name="arch" type="xml">
-        <search>
-            <field name="name" string="Name or Code" filter_domain="['|', ('name', 'ilike', self), ('code', 'ilike', self)]"/>
-            <separator/>
-            <filter string="Archived" name="inactive" domain="[('active', '=', False)]"/>
-            <field name="code"/>
-            <group string="Group By" name="groupby">
-                <filter name="domain_groupby" string="Domain" context="{'group_by': 'domain'}"/>
-            </group>
-        </search>
-    </field>
-</record>
-
-<record id="dynamic_list_code_action" model="ir.actions.act_window">
-    <field name="name">Code List</field>
-    <field name="res_model">dynamic.list.code</field>
-    <field name="view_mode">tree,form</field>
-    <field name="context">{'dynamic_list_code_main_view': True, 'search_default_domain_groupby': True}</field>
-</record>
-
-<menuitem id="dynamic_list_code_menu" action="dynamic_list_code_action" parent="dynamic_list_root_menu" sequence="30"/>
-
-<record id="dynamic_list_code_translate_form" model="ir.ui.view">
-    <field name="model">dynamic.list.code.translate</field>
-    <field name="arch" type="xml">
-        <form>
-            <sheet>
-                <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                        class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                            options='{"terminology": "archive"}'/>
-                    </button>
-                </div>
-                <group name="main">
-                    <field name="code"/>
-                    <field name="name"/>
-                    <field name="domain" invisible="not context.get('dynamic_list_code_translate_main_view')"/>
-                </group>
-            </sheet>
-        </form>
-    </field>
-</record>
-
-<record id="dynamic_list_code_translate_tree" model="ir.ui.view">
-    <field name="model">dynamic.list.code.translate</field>
-    <field name="arch" type="xml">
-        <tree>
-            <field name="sequence" widget="handle"/>
-            <field name="code"/>
-            <field name="name"/>
-            <field name="domain" invisible="not context.get('dynamic_list_code_translate_main_view')"/>
-        </tree>
-    </field>
-</record>
-
-<record id="dynamic_list_code_translate_search" model="ir.ui.view">
-    <field name="model">dynamic.list.code.translate</field>
-    <field name="arch" type="xml">
-        <search>
-            <field name="name" string="Name or Code" filter_domain="['|', ('name', 'ilike', self), ('code', 'ilike', self)]"/>
-            <field name="code"/>
-            <separator/>
-            <filter string="Archived" name="inactive" domain="[('active', '=', False)]"/>
-            <group string="Group By" name="groupby">
-                <filter name="domain_groupby" string="Domain" context="{'group_by': 'domain'}"/>
-            </group>
-        </search>
-    </field>
-</record>
-
-<record id="dynamic_list_code_translate_action" model="ir.actions.act_window">
-    <field name="name">Translatable Code List</field>
-    <field name="res_model">dynamic.list.code.translate</field>
-    <field name="view_mode">tree,form</field>
-    <field name="context">{'dynamic_list_code_translate_main_view': True, 'search_default_domain_groupby': True}</field>
-</record>
-
-<menuitem id="dynamic_list_code_translate_menu" action="dynamic_list_code_translate_action" parent="dynamic_list_root_menu" sequence="40"/>
-
-
-</odoo>

base_partner_ref/partner.py

@@ -2,14 +2,13 @@
 # @author: Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import models, fields
 
 
 class ResPartner(models.Model):
     _inherit = 'res.partner'
 
     ref = fields.Char(copy=False)  # To avoid blocking duplicate
-    invalidate_display_name = fields.Boolean()
 
     _sql_constraints = [(
         'ref_unique',
@@ -17,11 +16,6 @@ class ResPartner(models.Model):
         'A partner already exists with this internal reference!'
         )]
 
-    # add 'ref' in depends
-    @api.depends('is_company', 'name', 'parent_id.name', 'type', 'company_name', 'ref', 'invalidate_display_name')
-    def _compute_display_name(self):
-        super(ResPartner, self)._compute_display_name()
-
     def _get_name(self):
         partner = self
         name = partner.name or ''

base_usability/README.rst

@@ -1,82 +0,0 @@
-==============
-Base Usability
-==============
-
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! This file is generated by oca-gen-addon-readme !!
-   !! changes will be overwritten.                   !!
-   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-
-.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
-    :target: https://odoo-community.org/page/development-status
-    :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
-    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-    :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github
-    :target: https://github.com/akretion/odoo-usability/tree/12.0/base_usability
-    :alt: akretion/odoo-usability
-
-|badge1| |badge2| |badge3| 
-
-This module adds the following functions:
-
-* Adds *track_visibility='onchange'* on all the important fields of the Partner object
-* By default, Odoo doesn't display the title field on all the partner form views. This module fixes it (it replaces the module base_title_on_partner)
-* Adds a log message at INFO level when sending an email via SMTP
-* Displays the local modules with installable filter
-* A group by "State" is added to module search view
-* Provides a _display_report_header method on the res.company object and _display_full_address on res.partner which are useful for reporting.
-* Add model in cron tree view
-* Add prefix field in sequence search view
-* Better search and form view for country and state
-* Display technical name of modules in kanban view
-* Change module filter to `installable`
-* Add widget=handle on sequence of res.partner.bank 
-* Add city and country in partner tree view
-* Add widget="email" on email of contacts
-* Add script to fix partners related to users in multi-company setup
-* Add methods for py3o reports
-* Add name_get() on ir.model
-* Language wizard defaults to ".po"
-* Add tracking on partner fields
-* Handle lang in name_title field
-* Remove empty lines in address
-* Add bank Name field on res.partner.bank
-* Partners auto-created for users are Suppliers and not Customers
-
-**Table of contents**
-
-.. contents::
-   :local:
-
-Bug Tracker
-===========
-
-Bugs are tracked on `GitHub Issues <https://github.com/akretion/odoo-usability/issues>`_.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/akretion/odoo-usability/issues/new?body=module:%20base_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-
-Do not contact contributors directly about support or help with technical issues.
-
-Credits
-=======
-
-Authors
-~~~~~~~
-
-* Akretion
-
-Contributors
-~~~~~~~~~~~~
-
-* Alexis de Lattre <alexis.delattre@akretion.com>
-* David Beal <david.beal@akretion.com>
-
-Maintainers
-~~~~~~~~~~~
-
-This module is part of the `akretion/odoo-usability <https://github.com/akretion/odoo-usability/tree/12.0/base_usability>`_ project on GitHub.
-
-You are welcome to contribute.

base_usability/__manifest__.py

@@ -8,6 +8,22 @@
     'category': 'Partner',
     'license': 'AGPL-3',
     'summary': 'Better usability in base module',
+    'description': """
+Base Usability
+==============
+
+This module adds *track_visibility='onchange'* on all the important fields of the Partner object.
+
+By default, Odoo doesn't display the title field on all the partner form views. This module fixes it (it replaces the module base_title_on_partner).
+
+It also adds a log message at INFO level when sending an email via SMTP.
+
+It displays the local modules with installable filter.
+A group by 'State' is added to module search view.
+
+It provides a _display_report_header method on the res.company object and
+_display_full_address on res.partner which are useful for reporting.
+    """,
     'author': 'Akretion',
     'website': 'http://www.akretion.com',
     'depends': ['base'],

base_usability/models/users.py

@@ -23,9 +23,12 @@ class ResUsers(models.Model):
 
     @api.model
     def _script_partners_linked_to_users_no_company(self):
+        if self.env.user.id != SUPERUSER_ID:
+            raise UserError(_('You must run this script as admin user'))
         logger.info(
             'START to set company_id=False on partners related to users')
-        users = self.sudo().with_context(active_test=False).search([])
+        users = self.search(
+            ['|', ('active', '=', True), ('active', '=', False)])
         for user in users:
             if user.partner_id.company_id:
                 user.partner_id.company_id = False
@@ -34,3 +37,4 @@ class ResUsers(models.Model):
                     user.login, user.id)
         logger.info(
             'END setting company_id=False on partners related to users')
+        return True

base_usability/readme/CONTRIBUTORS.rst

@@ -1,3 +0,0 @@
-* Alexis de Lattre <alexis.delattre@akretion.com>
-* Raphaël Valyi <rvalyi@akretion.com>
-* David Beal <david.beal@akretion.com>

base_usability/readme/DESCRIPTION.rst

@@ -1,25 +0,0 @@
-This module adds the following functions:
-
-* Adds *track_visibility='onchange'* on all the important fields of the Partner object
-* By default, Odoo doesn't display the title field on all the partner form views. This module fixes it (it replaces the module base_title_on_partner)
-* Adds a log message at INFO level when sending an email via SMTP
-* Displays the local modules with installable filter
-* A group by "State" is added to module search view
-* Provides a _display_report_header method on the res.company object and _display_full_address on res.partner which are useful for reporting.
-* Add model in cron tree view
-* Add prefix field in sequence search view
-* Better search and form view for country and state
-* Display technical name of modules in kanban view
-* Change module filter to `installable`
-* Add widget=handle on sequence of res.partner.bank 
-* Add city and country in partner tree view
-* Add widget="email" on email of contacts
-* Add script to fix partners related to users in multi-company setup
-* Add methods for py3o reports
-* Add name_get() on ir.model
-* Language wizard defaults to ".po"
-* Add tracking on partner fields
-* Handle lang in name_title field
-* Remove empty lines in address
-* Add bank Name field on res.partner.bank
-* Partners auto-created for users are Suppliers and not Customers

base_usability/static/description/index.html

@@ -1,440 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>
-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
-<title>Base Usability</title>
-<style type="text/css">
-
-/*
-:Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
-:Copyright: This stylesheet has been placed in the public domain.
-
-Default cascading style sheet for the HTML output of Docutils.
-
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
-customize this style sheet.
-*/
-
-/* used to remove borders from tables and images */
-.borderless, table.borderless td, table.borderless th {
-  border: 0 }
-
-table.borderless td, table.borderless th {
-  /* Override padding for "table.docutils td" with "! important".
-     The right padding separates the table cells. */
-  padding: 0 0.5em 0 0 ! important }
-
-.first {
-  /* Override more specific margin styles with "! important". */
-  margin-top: 0 ! important }
-
-.last, .with-subtitle {
-  margin-bottom: 0 ! important }
-
-.hidden {
-  display: none }
-
-.subscript {
-  vertical-align: sub;
-  font-size: smaller }
-
-.superscript {
-  vertical-align: super;
-  font-size: smaller }
-
-a.toc-backref {
-  text-decoration: none ;
-  color: black }
-
-blockquote.epigraph {
-  margin: 2em 5em ; }
-
-dl.docutils dd {
-  margin-bottom: 0.5em }
-
-object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
-  overflow: hidden;
-}
-
-/* Uncomment (and remove this text!) to get bold-faced definition list terms
-dl.docutils dt {
-  font-weight: bold }
-*/
-
-div.abstract {
-  margin: 2em 5em }
-
-div.abstract p.topic-title {
-  font-weight: bold ;
-  text-align: center }
-
-div.admonition, div.attention, div.caution, div.danger, div.error,
-div.hint, div.important, div.note, div.tip, div.warning {
-  margin: 2em ;
-  border: medium outset ;
-  padding: 1em }
-
-div.admonition p.admonition-title, div.hint p.admonition-title,
-div.important p.admonition-title, div.note p.admonition-title,
-div.tip p.admonition-title {
-  font-weight: bold ;
-  font-family: sans-serif }
-
-div.attention p.admonition-title, div.caution p.admonition-title,
-div.danger p.admonition-title, div.error p.admonition-title,
-div.warning p.admonition-title, .code .error {
-  color: red ;
-  font-weight: bold ;
-  font-family: sans-serif }
-
-/* Uncomment (and remove this text!) to get reduced vertical space in
-   compound paragraphs.
-div.compound .compound-first, div.compound .compound-middle {
-  margin-bottom: 0.5em }
-
-div.compound .compound-last, div.compound .compound-middle {
-  margin-top: 0.5em }
-*/
-
-div.dedication {
-  margin: 2em 5em ;
-  text-align: center ;
-  font-style: italic }
-
-div.dedication p.topic-title {
-  font-weight: bold ;
-  font-style: normal }
-
-div.figure {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-div.footer, div.header {
-  clear: both;
-  font-size: smaller }
-
-div.line-block {
-  display: block ;
-  margin-top: 1em ;
-  margin-bottom: 1em }
-
-div.line-block div.line-block {
-  margin-top: 0 ;
-  margin-bottom: 0 ;
-  margin-left: 1.5em }
-
-div.sidebar {
-  margin: 0 0 0.5em 1em ;
-  border: medium outset ;
-  padding: 1em ;
-  background-color: #ffffee ;
-  width: 40% ;
-  float: right ;
-  clear: right }
-
-div.sidebar p.rubric {
-  font-family: sans-serif ;
-  font-size: medium }
-
-div.system-messages {
-  margin: 5em }
-
-div.system-messages h1 {
-  color: red }
-
-div.system-message {
-  border: medium outset ;
-  padding: 1em }
-
-div.system-message p.system-message-title {
-  color: red ;
-  font-weight: bold }
-
-div.topic {
-  margin: 2em }
-
-h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
-h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
-  margin-top: 0.4em }
-
-h1.title {
-  text-align: center }
-
-h2.subtitle {
-  text-align: center }
-
-hr.docutils {
-  width: 75% }
-
-img.align-left, .figure.align-left, object.align-left, table.align-left {
-  clear: left ;
-  float: left ;
-  margin-right: 1em }
-
-img.align-right, .figure.align-right, object.align-right, table.align-right {
-  clear: right ;
-  float: right ;
-  margin-left: 1em }
-
-img.align-center, .figure.align-center, object.align-center {
-  display: block;
-  margin-left: auto;
-  margin-right: auto;
-}
-
-table.align-center {
-  margin-left: auto;
-  margin-right: auto;
-}
-
-.align-left {
-  text-align: left }
-
-.align-center {
-  clear: both ;
-  text-align: center }
-
-.align-right {
-  text-align: right }
-
-/* reset inner alignment in figures */
-div.align-right {
-  text-align: inherit }
-
-/* div.align-center * { */
-/*   text-align: left } */
-
-.align-top    {
-  vertical-align: top }
-
-.align-middle {
-  vertical-align: middle }
-
-.align-bottom {
-  vertical-align: bottom }
-
-ol.simple, ul.simple {
-  margin-bottom: 1em }
-
-ol.arabic {
-  list-style: decimal }
-
-ol.loweralpha {
-  list-style: lower-alpha }
-
-ol.upperalpha {
-  list-style: upper-alpha }
-
-ol.lowerroman {
-  list-style: lower-roman }
-
-ol.upperroman {
-  list-style: upper-roman }
-
-p.attribution {
-  text-align: right ;
-  margin-left: 50% }
-
-p.caption {
-  font-style: italic }
-
-p.credits {
-  font-style: italic ;
-  font-size: smaller }
-
-p.label {
-  white-space: nowrap }
-
-p.rubric {
-  font-weight: bold ;
-  font-size: larger ;
-  color: maroon ;
-  text-align: center }
-
-p.sidebar-title {
-  font-family: sans-serif ;
-  font-weight: bold ;
-  font-size: larger }
-
-p.sidebar-subtitle {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-p.topic-title {
-  font-weight: bold }
-
-pre.address {
-  margin-bottom: 0 ;
-  margin-top: 0 ;
-  font: inherit }
-
-pre.literal-block, pre.doctest-block, pre.math, pre.code {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-pre.code .ln { color: grey; } /* line numbers */
-pre.code, code { background-color: #eeeeee }
-pre.code .comment, code .comment { color: #5C6576 }
-pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
-pre.code .literal.string, code .literal.string { color: #0C5404 }
-pre.code .name.builtin, code .name.builtin { color: #352B84 }
-pre.code .deleted, code .deleted { background-color: #DEB0A1}
-pre.code .inserted, code .inserted { background-color: #A3D289}
-
-span.classifier {
-  font-family: sans-serif ;
-  font-style: oblique }
-
-span.classifier-delimiter {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-span.interpreted {
-  font-family: sans-serif }
-
-span.option {
-  white-space: nowrap }
-
-span.pre {
-  white-space: pre }
-
-span.problematic {
-  color: red }
-
-span.section-subtitle {
-  /* font-size relative to parent (h1..h6 element) */
-  font-size: 80% }
-
-table.citation {
-  border-left: solid 1px gray;
-  margin-left: 1px }
-
-table.docinfo {
-  margin: 2em 4em }
-
-table.docutils {
-  margin-top: 0.5em ;
-  margin-bottom: 0.5em }
-
-table.footnote {
-  border-left: solid 1px black;
-  margin-left: 1px }
-
-table.docutils td, table.docutils th,
-table.docinfo td, table.docinfo th {
-  padding-left: 0.5em ;
-  padding-right: 0.5em ;
-  vertical-align: top }
-
-table.docutils th.field-name, table.docinfo th.docinfo-name {
-  font-weight: bold ;
-  text-align: left ;
-  white-space: nowrap ;
-  padding-left: 0 }
-
-/* "booktabs" style (no vertical lines) */
-table.docutils.booktabs {
-  border: 0px;
-  border-top: 2px solid;
-  border-bottom: 2px solid;
-  border-collapse: collapse;
-}
-table.docutils.booktabs * {
-  border: 0px;
-}
-table.docutils.booktabs th {
-  border-bottom: thin solid;
-  text-align: left;
-}
-
-h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
-h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
-  font-size: 100% }
-
-ul.auto-toc {
-  list-style-type: none }
-
-</style>
-</head>
-<body>
-<div class="document" id="base-usability">
-<h1 class="title">Base Usability</h1>
-
-<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! This file is generated by oca-gen-addon-readme !!
-!! changes will be overwritten.                   !!
-!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/base_usability"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
-<p>This module adds the following functions:</p>
-<ul class="simple">
-<li>Adds <em>track_visibility=’onchange’</em> on all the important fields of the Partner object</li>
-<li>By default, Odoo doesn’t display the title field on all the partner form views. This module fixes it (it replaces the module base_title_on_partner)</li>
-<li>Adds a log message at INFO level when sending an email via SMTP</li>
-<li>Displays the local modules with installable filter</li>
-<li>A group by “State” is added to module search view</li>
-<li>Provides a _display_report_header method on the res.company object and _display_full_address on res.partner which are useful for reporting.</li>
-<li>Add model in cron tree view</li>
-<li>Add prefix field in sequence search view</li>
-<li>Better search and form view for country and state</li>
-<li>Display technical name of modules in kanban view</li>
-<li>Change module filter to <cite>installable</cite></li>
-<li>Add widget=handle on sequence of res.partner.bank</li>
-<li>Add city and country in partner tree view</li>
-<li>Add widget=”email” on email of contacts</li>
-<li>Add script to fix partners related to users in multi-company setup</li>
-<li>Add methods for py3o reports</li>
-<li>Add name_get() on ir.model</li>
-<li>Language wizard defaults to “.po”</li>
-<li>Add tracking on partner fields</li>
-<li>Handle lang in name_title field</li>
-<li>Remove empty lines in address</li>
-<li>Add bank Name field on res.partner.bank</li>
-<li>Partners auto-created for users are Suppliers and not Customers</li>
-</ul>
-<p><strong>Table of contents</strong></p>
-<div class="contents local topic" id="contents">
-<ul class="simple">
-<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
-</ul>
-</li>
-</ul>
-</div>
-<div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20base_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
-<p>Do not contact contributors directly about support or help with technical issues.</p>
-</div>
-<div class="section" id="credits">
-<h1><a class="toc-backref" href="#id2">Credits</a></h1>
-<div class="section" id="authors">
-<h2><a class="toc-backref" href="#id3">Authors</a></h2>
-<ul class="simple">
-<li>Akretion</li>
-</ul>
-</div>
-<div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
-<ul class="simple">
-<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
-<li>David Beal &lt;<a class="reference external" href="mailto:david.beal&#64;akretion.com">david.beal&#64;akretion.com</a>&gt;</li>
-</ul>
-</div>
-<div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
-<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/base_usability">akretion/odoo-usability</a> project on GitHub.</p>
-<p>You are welcome to contribute.</p>
-</div>
-</div>
-</div>
-</body>
-</html>

base_usability/views/base_view.xml

@@ -12,14 +12,4 @@
     </field>
 </record>
 
-<record id="view_sequence_search" model="ir.ui.view">
-    <field name="model">ir.sequence</field>
-    <field name="inherit_id" ref="base.view_sequence_search"/>
-    <field name="arch" type="xml">
-        <field name="name" position="after">
-            <field name="prefix"/>
-        </field>
-    </field>
-</record>
-
 </odoo>

base_usability/views/module_view.xml

@@ -12,7 +12,7 @@
     <field name="model">ir.module.module</field>
     <field name="inherit_id" ref="base.module_view_kanban"/>
     <field name="arch" type="xml">
-        <xpath expr="//h4[hasclass('o_kanban_record_title')]/code[@groups='base.group_no_one']" position="before">
+        <xpath expr="//h4[@class='o_kanban_record_title']/code[@groups='base.group_no_one']" position="before">
             <br/>
         </xpath>
     </field>

base_usability/views/partner_view.xml

@@ -12,6 +12,10 @@
     <field name="model">res.partner</field>
     <field name="inherit_id" ref="base.view_partner_form"/>
     <field name="arch" type="xml">
+        <!-- Wider 'name' field -->
+        <xpath expr="//sheet/div[hasclass('oe_title')]" position="attributes">
+            <attribute name="style">width: 650px;</attribute>
+        </xpath>
         <xpath expr="//field[@name='child_ids']/form//field[@name='email']" position="attributes">
             <attribute name="widget">email</attribute>
         </xpath>
@@ -57,9 +61,6 @@
             <!-- for 'ref', change '=' to 'start with' -->
             <attribute name="filter_domain">['|','|',('display_name','ilike',self),('ref','=ilike',self + '%'),('email','ilike',self)]</attribute>
         </field>
-        <filter name="inactive" position="before">
-            <separator/>
-        </filter>
     </field>
 </record>
 

developer_menu/menu_view.xml

@@ -2,7 +2,7 @@
 
 <odoo>
 
-<menuitem id="conf_tech" parent="base.menu_administration" name="🧰" groups="base.group_erp_manager" sequence="1"/>
+<menuitem id="conf_tech" parent="base.menu_administration" name="🧰" groups="base.group_erp_manager" sequence="100"/>
 <menuitem id="model" name="Model" parent="conf_tech" action="base.action_model_model" sequence="10"/>
 <menuitem id="view" name="View" parent="conf_tech" action="base.action_ui_view" sequence="20" />
 <menuitem id="rec_rule" name="Record Rule" parent="conf_tech" action="base.action_rule" sequence="30" />

intrastat_product_type/__manifest__.py

@@ -20,7 +20,8 @@ This module has been written by Alexis de Lattre from Akretion <alexis.delattre@
     """,
     'author': 'Akretion',
     'website': 'http://www.akretion.com',
-    'depends': ['intrastat_product', 'l10n_fr_intrastat_service'],
+#    'depends': ['intrastat_product', 'l10n_fr_intrastat_service'],
+    'depends': ['intrastat_product'],
     'data': ['product_view.xml'],
     'post_init_hook': 'set_intrastat_type_on_products',
     'installable': True,

intrastat_product_type/intrastat_product_type.py

@@ -60,14 +60,14 @@ class ProductTemplate(models.Model):
         return super(ProductTemplate, self).create(vals)
 
 
-class L10nFrIntrastatServiceDeclaration(models.Model):
-    _inherit = "l10n.fr.intrastat.service.declaration"
+#class L10nFrIntrastatServiceDeclaration(models.Model):
+#    _inherit = "l10n.fr.intrastat.service.declaration"
 
-    def _is_service(self, invoice_line):
-        if invoice_line.product_id.intrastat_type == 'service':
-            return True
-        else:
-            return False
+#    def _is_service(self, invoice_line):
+#        if invoice_line.product_id.intrastat_type == 'service':
+#            return True
+#        else:
+#            return False
 
 
 class IntrastatProductDeclaration(models.Model):

mail_usability/README.rst

@@ -1,19 +0,0 @@
-# Mail Usability
-
-Take back the control on your email
-
-## Feature
-
-- do not follow automatically a object when sending an email
-- better email preview, allow to select between the whole database object and not only the last 10
-- use a light template version for notification without link (link should be explicit)
-- add some additional style in the white list when santizing html field (see tools.py)
-- make the email template by default not 'auto_delete'
-
-## TIPS
-
-Never, never tick the 'auto_delete' on mail template because it fucking hard to debug
-and understand what have been sent (we should create a module with a crontask, that drop them latter)
-
-If the template of mail do not look like the same when saving it in odoo, maybe the sanitize style have drop some balise
-please run odoo with "LOG_STYLE_SANITIZE=True odoo" to understand what have been drop, magic warning logger will tell you everthing

mail_usability/__init__.py

@@ -1,2 +0,0 @@
-from . import models
-from . import wizard

mail_usability/__manifest__.py

@@ -1,33 +0,0 @@
-# Copyright 2020 Akretion France (http://www.akretion.com)
-# @author Benoît Guillot <benoit.guillot@akretion.com>
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-{
-    'name': 'Mail Usability',
-    'version': '12.0.1.0.0',
-    'category': 'Base',
-    'license': 'AGPL-3',
-    'summary': 'Usability improvements on mails',
-    'description': """
-Mail Usability
-==============
-
-Small usability improvements on mails:
-
-* remove link in mail footer
-
-* remove 'sent by' in notification footer
-
-* add a new entry *All Messages Except Notifications* to the field *Receive Inbox Notifications by Email* of partners (becomes the default value)
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['mail'],
-    'data': [
-        'views/mail_view.xml',
-        'data/mail_data.xml',
-        'wizard/email_template_preview_view.xml',
-    ],
-    'installable': True,
-}

mail_usability/data/mail_data.xml

@@ -1,18 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<odoo noupdate="1">
-    
-    <!--Default Notification Email template -->
-    <record id="mail_template_notification" model="mail.template">
-        <field name="name">Notification Email</field>
-        <field name="subject">${object.subject}</field>
-        <field name="model_id" ref="mail.model_mail_message"/>
-        <field name="auto_delete" eval="True"/>
-        <field name="body_html">${object.body | safe}</field>
-    </record>
-
-        <template id="message_notification_email_usability">
-<div t-raw="message.body"/>
-        </template>
-
-
-</odoo>

mail_usability/models/__init__.py

@@ -1,5 +0,0 @@
-from . import mail
-from . import tools
-from . import mail_template
-from . import mail_message
-from . import res_partner

mail_usability/models/mail.py

@@ -1,36 +0,0 @@
-# Copyright 2016-2017 Akretion France (http://www.akretion.com)
-# @author: Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-
-from odoo import models, api
-import logging
-_logger = logging.getLogger(__name__)
-
-
-class MailThread(models.AbstractModel):
-    _inherit = 'mail.thread'
-
-    def _active_message_auto_subscribe_notify(self):
-        _logger.debug('Skip automatic subscribe notification')
-        return False
-
-    def _message_auto_subscribe_notify(self, partner_ids, template):
-        if self._active_message_auto_subscribe_notify():
-            return super(MailThread, self)._message_auto_subscribe_notify(
-                partner_ids, template)
-        else:
-            return True
-
-    @api.multi
-    @api.returns('self', lambda value: value.id)
-    def message_post(self, body='', subject=None, message_type='notification',
-                     subtype=None, parent_id=False, attachments=None,
-                     content_subtype='html', **kwargs):
-        if not 'mail_create_nosubscribe' in self._context:
-            # Do not implicitly follow an object by just sending a message
-            self = self.with_context(mail_create_nosubscribe=True)
-        return super(MailThread, self).message_post(
-            body=body, subject=subject, message_type=message_type,
-            subtype=subtype, parent_id=parent_id, attachments=attachments,
-            content_subtype=content_subtype, **kwargs)

mail_usability/models/mail_message.py

@@ -1,19 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Sébastien BEAU <sebastien.beau@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import models
-
-
-class MailMessage(models.Model):
-    _inherit = 'mail.message'
-
-    @property
-    def record_id(self):
-        # we do not use a reference field here as mail message
-        # are used everywhere and many model are not yet loaded
-        # so odoo raise exception
-        if self:
-            self.ensure_one()
-            return self.env[self.model].browse(self.res_id)
-        return None

mail_usability/models/mail_template.py

@@ -1,11 +0,0 @@
-# Copyright 2018 Akretion France (http://www.akretion.com)
-# @author Sébastien BEAU <sebastien.beau@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from openerp import fields, models
-
-
-class MailTemplate(models.Model):
-    _inherit = 'mail.template'
-
-    auto_delete = fields.Boolean(default=False)

mail_usability/models/res_partner.py

@@ -1,27 +0,0 @@
-# Copyright 2016-2019 Akretion France (http://www.akretion.com)
-# @author Sébastien BEAU <sebastien.beau@akretion.com>
-# @author: Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import models, fields, api
-
-
-class ResPartner(models.Model):
-    _inherit = 'res.partner'
-
-    opt_out = fields.Boolean(track_visibility='onchange')
-
-    @api.model
-    def _notify(self, message, rdata, record, force_send=False,
-                send_after_commit=True, model_description=False,
-                mail_auto_delete=True):
-        # use an empty layout for notification by default
-        if not message.layout:
-            message.layout = 'mail_usability.message_notification_email_usability'
-        # Never auto delete notification email
-        # fucking to hard to debug when message have been delete
-        mail_auto_delete = False
-        return super(ResPartner, self)._notify(
-            message=message, rdata=rdata, record=record,
-            force_send=force_send, send_after_commit=send_after_commit,
-            model_description=model_description, mail_auto_delete=mail_auto_delete)

mail_usability/models/tools.py

@@ -1,43 +0,0 @@
-# Copyright 2018 Akretion France (http://www.akretion.com)
-# @author Sébastien BEAU <sebastien.beau@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo.tools.mail import _Cleaner
-import os
-import logging
-_logger = logging.getLogger(__name__)
-
-_Cleaner._style_whitelist += [
-    'word-wrap',
-    'display'
-    'border-top',
-    'border-bottom',
-    'border-left',
-    'border-right',
-    'text-transform',
-    ]
-
-
-if os.getenv('LOG_STYLE_SANITIZE'):
-    # Monkey patch the parse style method to debug
-    # the missing style
-    def parse_style(self, el):
-        attributes = el.attrib
-        styling = attributes.get('style')
-        if styling:
-            valid_styles = {}
-            styles = self._style_re.findall(styling)
-            for style in styles:
-                if style[0].lower() in self._style_whitelist:
-                    valid_styles[style[0].lower()] = style[1]
-                # START HACK
-                else:
-                    _logger.warning('Remove style %s %s', *style)
-                # END HACK
-            if valid_styles:
-                el.attrib['style'] = '; '.join(
-			'%s:%s' % (key, val)
-			for (key, val) in valid_styles.iteritems())
-            else:
-                del el.attrib['style']
-    _Cleaner.parse_style = parse_style

mail_usability/views/mail_view.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<odoo>
-
-    <record id="view_mail_tree" model="ir.ui.view">
-        <field name="model">mail.mail</field>
-        <field name="inherit_id" ref="mail.view_mail_tree"/>
-        <field name="arch" type="xml">
-            <field name="email_from" position="replace"/>
-            <field name="date" position="after">
-                <field name="email_from"/>
-                <field name="email_to"/>
-            </field>
-        </field>
-    </record>
-
-</odoo>

mail_usability/wizard/__init__.py

@@ -1 +0,0 @@
-from . import email_template_preview

mail_usability/wizard/email_template_preview.py

@@ -1,43 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Sébastien BEAU <sebastien.beau@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from openerp import api, fields, models
-
-
-class TemplatePreview(models.TransientModel):
-    _inherit = "email_template.preview"
-
-    res_id = fields.Integer(compute='_compute_res_id')
-    object_id = fields.Reference(selection='_reference_models')
-
-    @api.model
-    def default_get(self, fields):
-        result = super(TemplatePreview, self).default_get(fields)
-        if result.get('model_id'):
-            model = self.env['ir.model'].browse(result['model_id'])
-            result['object_id'] = model.model
-        return result
-
-    def _reference_models(self):
-        result = self.default_get(['model_id'])
-        if result.get('model_id'):
-            model = self.env['ir.model'].browse(result['model_id'])
-            return [(model.model, model.name)]
-        else:
-            ir_models = self.env['ir.model'].search([('state', '!=', 'manual')])
-            return [(ir_model.model, ir_model.name)
-                    for ir_model in ir_models
-                    if not ir_model.model.startswith('ir.')]
-
-    @api.depends('object_id')
-    def _compute_res_id(self):
-        for record in self:
-            if self.object_id:
-                record.res_id = self.object_id.id
-
-    def send(self):
-        template = self.env['mail.template'].browse(
-            self._context['template_id'])
-        template.send_mail(
-            self.res_id, force_send=True, raise_exception=True)

mail_usability/wizard/email_template_preview_view.xml

@@ -1,24 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<odoo>
-
-    <record id="email_template_preview_form" model="ir.ui.view">
-        <field name="model">email_template.preview</field>
-        <field name="inherit_id" ref="mail.email_template_preview_form"/>
-        <field name="arch" type="xml">
-            <field name="res_id" position="attributes">
-                <attribute name="invisible">True</attribute>
-            </field>
-            <field name="res_id" position="after">
-                <field name="object_id"/>
-            </field>
-            <footer position="inside">
-                <button
-                    string="Send"
-                    name="send"
-                    class="btn-primary"
-                    type='object'/>
-            </footer>
-        </field>
-    </record>
-
-</odoo>

mrp_average_cost/models/mrp.py

@@ -17,7 +17,7 @@ class MrpBomLabourLine(models.Model):
 
     bom_id = fields.Many2one(
         comodel_name='mrp.bom',
-        string='Bill of Material',
+        string='Labour Lines',
         ondelete='cascade')
 
     labour_time = fields.Float(
@@ -75,7 +75,7 @@ class MrpBom(models.Model):
     total_labour_cost = fields.Float(
         compute='_compute_total_labour_cost', readonly=True,
         digits=dp.get_precision('Product Price'),
-        string="Total Labour Cost", store=True, track_visibility='onchange')
+        string="Total Labour Cost", store=True)
     extra_cost = fields.Float(
         string='Extra Cost', track_visibility='onchange',
         digits=dp.get_precision('Product Price'),
@@ -117,18 +117,15 @@ class MrpBom(models.Model):
             wproduct = bom.product_id
             if not wproduct:
                 wproduct = bom.product_tmpl_id
-            bom_cost_per_unit_in_product_uom = 0
-            qty_product_uom = bom.product_uom_id._compute_quantity(bom.product_qty, wproduct.uom_id)
-            if qty_product_uom:
-                bom_cost_per_unit_in_product_uom = bom.total_cost / qty_product_uom
             if float_compare(
-                    wproduct.standard_price, bom_cost_per_unit_in_product_uom,
+                    wproduct.standard_price, bom.total_cost,
                     precision_digits=precision):
                 wproduct.with_context().write(
-                    {'standard_price': bom_cost_per_unit_in_product_uom})
+                    {'standard_price': bom.total_cost})
                 logger.info(
                     'Cost price updated to %s on product %s',
-                    bom_cost_per_unit_in_product_uom, wproduct.display_name)
+                    bom.total_cost, wproduct.display_name)
+        return True
 
 
 class MrpBomLine(models.Model):
@@ -199,7 +196,6 @@ class MrpProduction(models.Model):
         mo_total_price = 0.0  # In the UoM of the M0
         labor_cost_per_unit = 0.0  # In the UoM of the product
         extra_cost_per_unit = 0.0  # In the UoM of the product
-        subcontract_cost_per_unit = 0.0
         # I read the raw materials MO, not on BOM, in order to make
         # it work with the "dynamic" BOMs (few raw material are auto-added
         # on the fly on MO)
@@ -235,13 +231,6 @@ class MrpProduction(models.Model):
             assert bom_qty_product_uom > 0, 'BoM qty should be positive'
             labor_cost_per_unit = bom.total_labour_cost / bom_qty_product_uom
             extra_cost_per_unit = bom.extra_cost / bom_qty_product_uom
-            if bom.type == 'subcontract':
-                one_finished_move = self.env['stock.move'].search([
-                    ('production_id', '=', self.id),
-                    ('product_id', '=', self.product_id.id),
-                    ('move_dest_ids', '!=', False)], limit=1)
-                if one_finished_move:
-                    subcontract_cost_per_unit = one_finished_move.move_dest_ids[0].price_unit
         # mo_standard_price and labor_cost_per_unit are
         # in the UoM of the product (not of the MO/BOM)
         mo_qty_product_uom = self.product_uom_id._compute_quantity(
@@ -249,13 +238,10 @@ class MrpProduction(models.Model):
         assert mo_qty_product_uom > 0, 'MO qty should be positive'
         mo_standard_price = mo_total_price / mo_qty_product_uom
         logger.info(
-            'MO %s: labor_cost_per_unit=%s extra_cost_per_unit=%s '
-            'subcontract_cost_per_unit=%s',
-            self.name, labor_cost_per_unit, extra_cost_per_unit,
-            subcontract_cost_per_unit)
+            'MO %s: labor_cost_per_unit=%s extra_cost_per_unit=%s',
+            self.name, labor_cost_per_unit, extra_cost_per_unit)
         mo_standard_price += labor_cost_per_unit
         mo_standard_price += extra_cost_per_unit
-        mo_standard_price += subcontract_cost_per_unit
         return mo_standard_price
 
     def post_inventory(self):
@@ -266,9 +252,9 @@ class MrpProduction(models.Model):
         for order in self:
             if order.product_id.cost_method == 'average':
                 unit_cost = order.compute_order_unit_cost()
-                order.write({'unit_cost': unit_cost})
+                order.unit_cost = unit_cost
                 logger.info('MO %s: unit_cost=%s', order.name, unit_cost)
-                order.move_finished_ids.filtered(
-                    lambda x: x.product_id == order.product_id).write({
-                        'price_unit': unit_cost})
+                for finished_move in order.move_finished_ids.filtered(
+                        lambda x: x.product_id == order.product_id):
+                    finished_move.price_unit = unit_cost
         return super(MrpProduction, self).post_inventory()

mrp_average_cost/security/ir.model.access.csv

@@ -1,7 +1,9 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_labour_cost_profile_read,Read access on labour.cost.profile to MRP user,model_labour_cost_profile,mrp.group_mrp_user,1,0,0,0
+access_labour_cost_profile_read_sale,Read access on labour.cost.profile to Sale user,model_labour_cost_profile,sales_team.group_sale_salesman,1,0,0,0
 access_labour_cost_profile_read_stock,Read access on labour.cost.profile to Stock user,model_labour_cost_profile,stock.group_stock_user,1,0,0,0
 access_labour_cost_profile_full,Full access on labour.cost.profile to MRP manager,model_labour_cost_profile,mrp.group_mrp_manager,1,1,1,1
 access_mrp_bom_labour_line_read,Read access on mrp.bom.labour.line to MRP user,model_mrp_bom_labour_line,mrp.group_mrp_user,1,0,0,0
+access_mrp_bom_labour_line_read_sale,Read access on mrp.bom.labour.line to Sale user,model_mrp_bom_labour_line,sales_team.group_sale_salesman,1,0,0,0
 access_mrp_bom_labour_line_read_stock,Read access on mrp.bom.labour.line to Stock user,model_mrp_bom_labour_line,stock.group_stock_user,1,0,0,0
 access_mrp_bom_labour_line_full,Full access on mrp.bom.labour.line to MRP manager,model_mrp_bom_labour_line,mrp.group_mrp_manager,1,1,1,1

mrp_average_cost/views/mrp_view.xml

@@ -37,7 +37,7 @@
                 </group>
             </page>
         </notebook>
-        <xpath expr="//field[@name='bom_line_ids']/tree/field[@name='operation_id']" position="after">
+        <xpath expr="//field[@name='bom_line_ids']/tree/field[@name='product_uom_id']" position="after">
             <field name="standard_price"/>
         </xpath>
     </field>

mrp_usability/README.rst

@@ -17,7 +17,7 @@ MRP Usability
     :target: https://github.com/akretion/odoo-usability/tree/12.0/mrp_usability
     :alt: akretion/odoo-usability
 
-|badge1| |badge2| |badge3|
+|badge1| |badge2| |badge3| 
 
 Small usability improvements on MRP:
 
@@ -31,8 +31,6 @@ Small usability improvements on MRP:
 
 * complete Manufacturing Order report with unvailable products
 
-* improve smart button from products to BoMs (display BoM form if only one instead of displaying a list of one)
-
 **Table of contents**
 
 .. contents::

mrp_usability/__init__.py

@@ -1 +1 @@
-from . import models
+from . import mrp

mrp_usability/__manifest__.py

@@ -13,8 +13,7 @@
     'website': 'http://www.akretion.com',
     'depends': ['mrp'],
     'data': [
-        'views/mrp_views.xml',
-        'views/product_views.xml',
+        'mrp_view.xml',
         'report/mrp_report.xml'
     ],
     'installable': True,

mrp_usability/i18n/fr.po

@@ -6,8 +6,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 12.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2020-10-06 13:37+0000\n"
-"PO-Revision-Date: 2020-10-06 15:38+0200\n"
+"POT-Creation-Date: 2019-07-16 13:56+0000\n"
+"PO-Revision-Date: 2019-07-16 16:01+0200\n"
 "Last-Translator: <>\n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -15,52 +15,41 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: \n"
 "Language: fr\n"
-"X-Generator: Poedit 2.3\n"
+"X-Generator: Poedit 2.0.6\n"
 
 #. module: mrp_usability
 #: model_terms:ir.ui.view,arch_db:mrp_usability.mrp_production_form_view
 msgid "Are you sure you want to cancel this manufacturing order?"
 msgstr "Etes vous sur de vouloir annuler cet ordre de production"
 
-#. module: mrp_usability
-#: model_terms:ir.ui.view,arch_db:mrp_usability.product_template_form_view_bom_button
-msgid "Bill of Materials"
-msgstr "Nomenclature"
-
 #. module: mrp_usability
 #: model_terms:ir.ui.view,arch_db:mrp_usability.report_mrporder
 msgid "Lot"
 msgstr ""
 
 #. module: mrp_usability
-#: model:ir.model,name:mrp_usability.model_product_product
 #: model_terms:ir.ui.view,arch_db:mrp_usability.report_mrporder
 msgid "Product"
 msgstr "Article"
 
-#. module: mrp_usability
-#: model:ir.model,name:mrp_usability.model_product_template
-msgid "Product Template"
-msgstr "Modèle d'article"
-
 #. module: mrp_usability
 #: model:ir.model,name:mrp_usability.model_mrp_production
 msgid "Production Order"
-msgstr ""
+msgstr "Ordre de production"
 
 #. module: mrp_usability
 #: model_terms:ir.ui.view,arch_db:mrp_usability.report_mrporder
-msgid "Sold Out Quantity"
-msgstr "Quantité en Rupture"
+msgid "Quantity"
+msgstr "Quantité"
 
 #. module: mrp_usability
 #: model_terms:ir.ui.view,arch_db:mrp_usability.report_mrporder
 msgid ""
 "These products were unavailable (or partially) while edition of this Manufacturing Order.\n"
-"            Here is missing quantities."
+"            Here is complete quantities for these."
 msgstr ""
 "Les produits ci-dessous étaient indisponibles (complètement ou partiellement) lors de l'édition de l'OF.<br/>\n"
-"Voici les quantités manquantes."
+"Voici les quantités totales de ceux-ci."
 
 #. module: mrp_usability
 #: model_terms:ir.ui.view,arch_db:mrp_usability.view_mrp_bom_filter

mrp_usability/models/__init__.py

@@ -1,2 +0,0 @@
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-from . import mrp, product

mrp_usability/models/mrp.py

@@ -1,37 +0,0 @@
-# Copyright 2015-2021 Akretion (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-
-from odoo import api, fields, models
-
-
-class MrpProduction(models.Model):
-    _inherit = 'mrp.production'
-    _order = 'id desc'
-
-    date_planned_start = fields.Datetime(track_visibility='onchange')
-    date_planned_finished = fields.Datetime(track_visibility='onchange')
-
-    @api.model
-    def get_stock_move_sold_out_report(self, move):
-        lines = move.active_move_line_ids
-        qty_in_lots = sum([x.product_uom_qty for x in lines])
-        diff = round(move.product_qty - qty_in_lots, 3)
-        if diff == 0.0:
-            return ""
-        return diff
-
-
-class MrpBom(models.Model):
-    _inherit = 'mrp.bom'
-
-    code = fields.Char(track_visibility='onchange')
-    type = fields.Selection(track_visibility='onchange')
-    product_tmpl_id = fields.Many2one(track_visibility='onchange')
-    product_id = fields.Many2one(track_visibility='onchange')
-    product_qty = fields.Float(track_visibility='onchange')
-    product_uom_id = fields.Many2one(track_visibility='onchange')
-    routing_id = fields.Many2one(track_visibility='onchange')
-    ready_to_produce = fields.Selection(track_visibility='onchange')
-    picking_type_id = fields.Many2one(track_visibility='onchange')

mrp_usability/models/product.py

@@ -1,44 +0,0 @@
-# Copyright (C) 2020 - Akretion
-# License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
-
-from odoo import models
-
-
-class ProductTemplate(models.Model):
-    _inherit = "product.template"
-
-    def action_view_bom(self):
-        """Replace native action `template_open_bom` to distinguish if we will display
-        only one BoM form or a list of BoMs."""
-        self.ensure_one()
-
-        act_window_xml_id = "mrp.mrp_bom_form_action"
-        act_window = self.env.ref(act_window_xml_id).read()[0]
-        if self.bom_count > 1:
-            act_window["context"] = {
-                "default_product_tmpl_id": self.id,
-                "search_default_product_tmpl_id": self.id,
-            }
-        else:
-            act_window["context"] = {"default_product_tmpl_id": self.id}
-            act_window["views"] = [(self.env.ref("mrp.mrp_bom_form_view").id, "form")]
-            act_window["res_id"] = (
-                self.env["mrp.bom"].search([("product_tmpl_id", "=", self.id)]).id
-            )
-
-        return act_window
-
-
-class ProductProduct(models.Model):
-    _inherit = "product.product"
-
-    def action_view_bom(self):
-        res = super().action_view_bom()
-
-        bom_target_ids = self.env["mrp.bom"].search(res["domain"])
-
-        if len(bom_target_ids) == 1:
-            res["views"] = [(self.env.ref("mrp.mrp_bom_form_view").id, "form")]
-            res["res_id"] = bom_target_ids[0].id
-
-        return res

mrp_usability/mrp.py

@@ -0,0 +1,11 @@
+# © 2015-2016 Akretion (http://www.akretion.com)
+# @author Alexis de Lattre <alexis.delattre@akretion.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+
+from odoo import models
+
+
+class MrpProduction(models.Model):
+    _inherit = 'mrp.production'
+    _order = 'id desc'

mrp_usability/mrp_view.xml

@@ -26,26 +26,6 @@
         <button name="action_cancel" type="object" position="attributes">
             <attribute name="confirm">Are you sure you want to cancel this manufacturing order?</attribute>
         </button>
-        <xpath expr="//field[@name='finished_move_line_ids']/tree/field[@name='product_uom_id']" position="replace"/>
-        <xpath expr="//field[@name='finished_move_line_ids']/tree/field[@name='qty_done']" position="after">
-            <field name="product_uom_id" groups="uom.group_uom"/> <!-- Move after qty -->
-            <field name="location_dest_id" groups="stock.group_stock_multi_locations"/>
-        </xpath>
-    </field>
-</record>
-
-<record id="view_stock_move_lots" model="ir.ui.view">
-    <field name="model">stock.move</field>
-    <field name="inherit_id" ref="mrp.view_stock_move_lots" />
-    <field name="arch" type="xml">
-        <xpath expr="//field[@name='active_move_line_ids']/tree/field[@name='lot_id']" position="before">
-            <xpath expr="//field[@name='active_move_line_ids']/tree/field[@name='location_id']" position="move"/>
-        </xpath>
-        <xpath expr="//field[@name='active_move_line_ids']/tree/field[@name='location_id']" position="attributes">
-            <attribute name="invisible">0</attribute>
-            <attribute name="readonly">0</attribute>
-            <attribute name="groups">stock.group_stock_multi_locations</attribute>
-        </xpath>
     </field>
 </record>
 
@@ -60,17 +40,6 @@
     </field>
 </record>
 
-<record id="view_finisehd_move_line" model="ir.ui.view">
-    <field name="model">stock.move.line</field>
-    <field name="inherit_id" ref="mrp.view_finisehd_move_line" />
-    <field name="arch" type="xml">
-        <field name="lot_id" position="after">
-            <field name="location_id" groups="stock.group_stock_multi_locations"/>
-            <field name="location_dest_id" groups="stock.group_stock_multi_locations"/>
-        </field>
-    </field>
-</record>
-
 <record id="mrp_bom_tree_view" model="ir.ui.view">
     <field name="model">mrp.bom</field>
     <field name="inherit_id" ref="mrp.mrp_bom_tree_view"/>

mrp_usability/readme/DESCRIPTION.rst

@@ -9,5 +9,3 @@ Small usability improvements on MRP:
 * show bom type in tree view + add group by
 
 * complete Manufacturing Order report with unvailable products
-
-* improve smart button from products to BoMs (display BoM form if only one instead of displaying a list of one)

mrp_usability/report/mrp_report.xml

@@ -16,26 +16,27 @@
            t-value="any(o.move_raw_ids.filtered(lambda x: x.product_uom_qty > x.reserved_availability))"/>
         <h4 if="has_product_unavailable">
             These products were unavailable (or partially) while edition of this Manufacturing Order.
-            Here is missing quantities.
+            Here is complete quantities for these.
         </h4>
         <table class="table table-sm" t-if="o.move_raw_ids and has_product_unavailable">
             <thead>
                 <tr>
                     <th>Product</th>
-                    <th>Sold Out Quantity</th>
+                    <th>Quantity</th>
                 </tr>
             </thead>
             <tbody>
-                <t t-set="moves" 
+                <t t-set="lines" 
                    t-value="o.move_raw_ids.filtered(lambda x: x.product_uom_qty &gt; x.reserved_availability)"/>
-                <t t-foreach="moves" t-as="m">
+                <t t-foreach="lines" t-as="ml">
                     <tr>
                         <td>
-                            <span t-field="m.product_id"/>
+                            <span t-field="ml.product_id"/>
                         </td>
                         <td>
-                            <span t-esc="o.get_stock_move_sold_out_report(m)" t-if="m.state !='done'"/>
-                            <span t-field="m.product_uom" groups="uom.group_uom"/>
+                            <span t-esc="ml.product_uom_qty" t-if="ml.state !='done'"/>
+                            <span t-esc="ml.qty_done" t-if="ml.state =='done'"/>
+                            <span t-field="ml.product_uom" groups="uom.group_uom"/>
                         </td>
                     </tr>
                 </t>

mrp_usability/views/product_views.xml

@@ -1,25 +0,0 @@
-<?xml version="1.0"?>
-<odoo>
-
-    <record id="product_template_form_view_bom_button" model="ir.ui.view">
-        <field name="name">product.template.procurement</field>
-        <field name="model">product.template</field>
-        <field name="inherit_id" ref="mrp.product_template_form_view_bom_button" />
-        <field name="arch" type="xml">
-
-            <xpath expr="//field[@name='bom_count']/.." position="attributes">
-                <attribute name="invisible">1</attribute>
-            </xpath>
-            <xpath expr="//field[@name='bom_count']/.." position="after">
-                <button class="oe_stat_button" name="action_view_bom" type="object"
-                        attrs="{'invisible':[('type', 'not in', ['product', 'consu'])]}"
-                        icon="fa-flask">
-                    <field string="Bill of Materials" name="bom_count"
-                           widget="statinfo" />
-                </button>
-            </xpath>
-
-        </field>
-    </record>
-
-</odoo>

pos_usability/__manifest__.py

@@ -1,29 +0,0 @@
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-{
-    "name": "POS Usability",
-    "version": "12.0.1.0.0",
-    "category": "Point of sale",
-    "license": "AGPL-3",
-    "summary": "Misc usability improvement for point of sale",
-    "description": """
-POS Usability
-=============
-
-- Sales Details report : add sub total amount by tax
-
-
-authors
--------
-
-Akretion:
-
-* David Béal <david.beal@akretion.com>
-
-    """,
-    "author": "Akretion",
-    "website": "http://www.akretion.com",
-    "depends": ["point_of_sale"],
-    "data": ["report/pos.xml"],
-    "installable": True,
-}

pos_usability/i18n/fr.po

@@ -1,23 +0,0 @@
-# Translation of Odoo Server.
-# This file contains the translation of the following modules:
-# 	* pos_usability
-#
-msgid ""
-msgstr ""
-"Project-Id-Version: Odoo Server 12.0\n"
-"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2019-10-11 13:11+0000\n"
-"PO-Revision-Date: 2019-10-11 15:11+0200\n"
-"Last-Translator: <>\n"
-"Language-Team: \n"
-"MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=UTF-8\n"
-"Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: \n"
-"Language: fr\n"
-"X-Generator: Poedit 2.0.6\n"
-
-#. module: pos_usability
-#: model_terms:ir.ui.view,arch_db:pos_usability.report_saledetails
-msgid "Amount"
-msgstr "Montant"

pos_usability/report/pos.xml

@@ -1,17 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<odoo>
-
-<template id="report_saledetails" inherit_id="point_of_sale.report_saledetails">
-
-    <xpath expr="//table[3]/thead/tr/th[3]" position="after">
-        <th>Amount</th>
-    </xpath>
-    <xpath expr="//table[3]/tbody/tr" position="inside">
-        <td><t t-esc="tax['tax_amount'] + tax['base_amount']"
-               t-options="{'widget': 'float', 'precision': currency_precision}" /></td>
-    </xpath>
-
-</template>
-
-</odoo>

product_no_translation/__init__.py

@@ -1,23 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Product No Translation module for Odoo
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from . import product

product_no_translation/__manifest__.py

@@ -1,40 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Product No Translation module for Odoo
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-
-{
-    'name': 'Product no Translation',
-    'version': '12.0.0.0.1',
-    'category': 'Sales Management',
-    'license': 'AGPL-3',
-    'summary': 'For companies that work with only one language',
-    'description': """
-This module sets the translatable fields of the product object (name,
-descriptions) to non-translatable fields.
-
-This change is usefull for companies that work with only one language.
-And it reduces the start time of the Point of Sale !
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['product'],
-}

product_no_translation/product.py

@@ -1,62 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    Product No Translation module for Odoo
-#    Copyright (C) 2014 Akretion (http://www.akretion.com)
-#    @author Alexis de Lattre <alexis.delattre@akretion.com>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from odoo import models, fields
-
-
-class ProductTemplate(models.Model):
-    _inherit = "product.template"
-
-    description_sale = fields.Text(translate=False)
-    description_purchase = fields.Text(translate=False)
-    description = fields.Text(translate=False)
-    name = fields.Char(translate=False)
-
-
-class ProductCategory(models.Model):
-    _inherit = "product.category"
-
-    name = fields.Char(translate=False)
-
-
-class ProductAttribute(models.Model):
-    _inherit = "product.attribute"
-
-    name = fields.Char(translate=False)
-
-
-class ProductAttributeValue(models.Model):
-    _inherit = "product.attribute.value"
-
-    name = fields.Char(translate=False)
-
-
-class UomCategory(models.Model):
-    _inherit = 'uom.category'
-
-    name = fields.Char(translate=False)
-
-
-class UomUom(models.Model):
-    _inherit = 'uom.uom'
-
-    name = fields.Char(translate=False)

product_usability/models/product.py

@@ -4,6 +4,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import models, fields
+from odoo.tools.safe_eval import safe_eval
 
 
 class ProductProduct(models.Model):
@@ -42,5 +43,6 @@ class ProductProduct(models.Model):
         self.ensure_one()
         action = self.env.ref(
             'product_usability.product_price_history_action').read()[0]
-        action['domain'] = [('product_id', '=', self.id)]
+        action['domain'] = safe_eval(action['domain'])
+        action['domain'].append(('product_id', '=', self.id))
         return action

product_usability/static/description/index.html

@@ -1,419 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>
-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" />
-<title>MRP Usability</title>
-<style type="text/css">
-
-/*
-:Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
-:Copyright: This stylesheet has been placed in the public domain.
-
-Default cascading style sheet for the HTML output of Docutils.
-
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
-customize this style sheet.
-*/
-
-/* used to remove borders from tables and images */
-.borderless, table.borderless td, table.borderless th {
-  border: 0 }
-
-table.borderless td, table.borderless th {
-  /* Override padding for "table.docutils td" with "! important".
-     The right padding separates the table cells. */
-  padding: 0 0.5em 0 0 ! important }
-
-.first {
-  /* Override more specific margin styles with "! important". */
-  margin-top: 0 ! important }
-
-.last, .with-subtitle {
-  margin-bottom: 0 ! important }
-
-.hidden {
-  display: none }
-
-.subscript {
-  vertical-align: sub;
-  font-size: smaller }
-
-.superscript {
-  vertical-align: super;
-  font-size: smaller }
-
-a.toc-backref {
-  text-decoration: none ;
-  color: black }
-
-blockquote.epigraph {
-  margin: 2em 5em ; }
-
-dl.docutils dd {
-  margin-bottom: 0.5em }
-
-object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
-  overflow: hidden;
-}
-
-/* Uncomment (and remove this text!) to get bold-faced definition list terms
-dl.docutils dt {
-  font-weight: bold }
-*/
-
-div.abstract {
-  margin: 2em 5em }
-
-div.abstract p.topic-title {
-  font-weight: bold ;
-  text-align: center }
-
-div.admonition, div.attention, div.caution, div.danger, div.error,
-div.hint, div.important, div.note, div.tip, div.warning {
-  margin: 2em ;
-  border: medium outset ;
-  padding: 1em }
-
-div.admonition p.admonition-title, div.hint p.admonition-title,
-div.important p.admonition-title, div.note p.admonition-title,
-div.tip p.admonition-title {
-  font-weight: bold ;
-  font-family: sans-serif }
-
-div.attention p.admonition-title, div.caution p.admonition-title,
-div.danger p.admonition-title, div.error p.admonition-title,
-div.warning p.admonition-title, .code .error {
-  color: red ;
-  font-weight: bold ;
-  font-family: sans-serif }
-
-/* Uncomment (and remove this text!) to get reduced vertical space in
-   compound paragraphs.
-div.compound .compound-first, div.compound .compound-middle {
-  margin-bottom: 0.5em }
-
-div.compound .compound-last, div.compound .compound-middle {
-  margin-top: 0.5em }
-*/
-
-div.dedication {
-  margin: 2em 5em ;
-  text-align: center ;
-  font-style: italic }
-
-div.dedication p.topic-title {
-  font-weight: bold ;
-  font-style: normal }
-
-div.figure {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-div.footer, div.header {
-  clear: both;
-  font-size: smaller }
-
-div.line-block {
-  display: block ;
-  margin-top: 1em ;
-  margin-bottom: 1em }
-
-div.line-block div.line-block {
-  margin-top: 0 ;
-  margin-bottom: 0 ;
-  margin-left: 1.5em }
-
-div.sidebar {
-  margin: 0 0 0.5em 1em ;
-  border: medium outset ;
-  padding: 1em ;
-  background-color: #ffffee ;
-  width: 40% ;
-  float: right ;
-  clear: right }
-
-div.sidebar p.rubric {
-  font-family: sans-serif ;
-  font-size: medium }
-
-div.system-messages {
-  margin: 5em }
-
-div.system-messages h1 {
-  color: red }
-
-div.system-message {
-  border: medium outset ;
-  padding: 1em }
-
-div.system-message p.system-message-title {
-  color: red ;
-  font-weight: bold }
-
-div.topic {
-  margin: 2em }
-
-h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
-h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
-  margin-top: 0.4em }
-
-h1.title {
-  text-align: center }
-
-h2.subtitle {
-  text-align: center }
-
-hr.docutils {
-  width: 75% }
-
-img.align-left, .figure.align-left, object.align-left, table.align-left {
-  clear: left ;
-  float: left ;
-  margin-right: 1em }
-
-img.align-right, .figure.align-right, object.align-right, table.align-right {
-  clear: right ;
-  float: right ;
-  margin-left: 1em }
-
-img.align-center, .figure.align-center, object.align-center {
-  display: block;
-  margin-left: auto;
-  margin-right: auto;
-}
-
-table.align-center {
-  margin-left: auto;
-  margin-right: auto;
-}
-
-.align-left {
-  text-align: left }
-
-.align-center {
-  clear: both ;
-  text-align: center }
-
-.align-right {
-  text-align: right }
-
-/* reset inner alignment in figures */
-div.align-right {
-  text-align: inherit }
-
-/* div.align-center * { */
-/*   text-align: left } */
-
-.align-top    {
-  vertical-align: top }
-
-.align-middle {
-  vertical-align: middle }
-
-.align-bottom {
-  vertical-align: bottom }
-
-ol.simple, ul.simple {
-  margin-bottom: 1em }
-
-ol.arabic {
-  list-style: decimal }
-
-ol.loweralpha {
-  list-style: lower-alpha }
-
-ol.upperalpha {
-  list-style: upper-alpha }
-
-ol.lowerroman {
-  list-style: lower-roman }
-
-ol.upperroman {
-  list-style: upper-roman }
-
-p.attribution {
-  text-align: right ;
-  margin-left: 50% }
-
-p.caption {
-  font-style: italic }
-
-p.credits {
-  font-style: italic ;
-  font-size: smaller }
-
-p.label {
-  white-space: nowrap }
-
-p.rubric {
-  font-weight: bold ;
-  font-size: larger ;
-  color: maroon ;
-  text-align: center }
-
-p.sidebar-title {
-  font-family: sans-serif ;
-  font-weight: bold ;
-  font-size: larger }
-
-p.sidebar-subtitle {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-p.topic-title {
-  font-weight: bold }
-
-pre.address {
-  margin-bottom: 0 ;
-  margin-top: 0 ;
-  font: inherit }
-
-pre.literal-block, pre.doctest-block, pre.math, pre.code {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-pre.code .ln { color: grey; } /* line numbers */
-pre.code, code { background-color: #eeeeee }
-pre.code .comment, code .comment { color: #5C6576 }
-pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
-pre.code .literal.string, code .literal.string { color: #0C5404 }
-pre.code .name.builtin, code .name.builtin { color: #352B84 }
-pre.code .deleted, code .deleted { background-color: #DEB0A1}
-pre.code .inserted, code .inserted { background-color: #A3D289}
-
-span.classifier {
-  font-family: sans-serif ;
-  font-style: oblique }
-
-span.classifier-delimiter {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-span.interpreted {
-  font-family: sans-serif }
-
-span.option {
-  white-space: nowrap }
-
-span.pre {
-  white-space: pre }
-
-span.problematic {
-  color: red }
-
-span.section-subtitle {
-  /* font-size relative to parent (h1..h6 element) */
-  font-size: 80% }
-
-table.citation {
-  border-left: solid 1px gray;
-  margin-left: 1px }
-
-table.docinfo {
-  margin: 2em 4em }
-
-table.docutils {
-  margin-top: 0.5em ;
-  margin-bottom: 0.5em }
-
-table.footnote {
-  border-left: solid 1px black;
-  margin-left: 1px }
-
-table.docutils td, table.docutils th,
-table.docinfo td, table.docinfo th {
-  padding-left: 0.5em ;
-  padding-right: 0.5em ;
-  vertical-align: top }
-
-table.docutils th.field-name, table.docinfo th.docinfo-name {
-  font-weight: bold ;
-  text-align: left ;
-  white-space: nowrap ;
-  padding-left: 0 }
-
-/* "booktabs" style (no vertical lines) */
-table.docutils.booktabs {
-  border: 0px;
-  border-top: 2px solid;
-  border-bottom: 2px solid;
-  border-collapse: collapse;
-}
-table.docutils.booktabs * {
-  border: 0px;
-}
-table.docutils.booktabs th {
-  border-bottom: thin solid;
-  text-align: left;
-}
-
-h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
-h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
-  font-size: 100% }
-
-ul.auto-toc {
-  list-style-type: none }
-
-</style>
-</head>
-<body>
-<div class="document" id="mrp-usability">
-<h1 class="title">MRP Usability</h1>
-
-<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! This file is generated by oca-gen-addon-readme !!
-!! changes will be overwritten.                   !!
-!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/mrp_usability"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
-<p>Small usability improvements on MRP:</p>
-<ul class="simple">
-<li>order by id desc</li>
-<li>show field date_start and date_finished on mrp.production form view</li>
-<li>show more fields on stock move form</li>
-<li>show bom type in tree view + add group by</li>
-<li>complete Manufacturing Order report with unvailable products</li>
-</ul>
-<p><strong>Table of contents</strong></p>
-<div class="contents local topic" id="contents">
-<ul class="simple">
-<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
-</ul>
-</li>
-</ul>
-</div>
-<div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20mrp_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
-<p>Do not contact contributors directly about support or help with technical issues.</p>
-</div>
-<div class="section" id="credits">
-<h1><a class="toc-backref" href="#id2">Credits</a></h1>
-<div class="section" id="authors">
-<h2><a class="toc-backref" href="#id3">Authors</a></h2>
-<ul class="simple">
-<li>Akretion</li>
-</ul>
-</div>
-<div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
-<p>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</p>
-</div>
-<div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
-<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/mrp_usability">akretion/odoo-usability</a> project on GitHub.</p>
-<p>You are welcome to contribute.</p>
-</div>
-</div>
-</div>
-</body>
-</html>

product_usability/views/product_supplierinfo_view.xml

@@ -16,8 +16,8 @@
                 <field name="product_name"/>
                 <field name="product_code" string="Supplier Code"/>
             </field>
-            <field name="currency_id" position="after">
-                <field name="delay"/>
+            <field name="price" position="after">
+                <field name="currency_id" groups="base.group_multi_currency"/>
             </field>
             <field name="min_qty" position="after">
                 <field name="product_uom" groups="uom.group_uom"/>

product_usability/views/product_template_view.xml

@@ -16,6 +16,11 @@
             <field name="standard_price" class="oe_inline" position="after">
                 <button name="show_product_price_history" class="oe_inline oe_link" type="object" string="Show History" context="{'active_id': active_id}"/>
             </field>
+            <!-- Don't make it too big, othesize computers with small resolutions
+            will see the product name + image under the block of buttons -->
+            <div class="oe_title" position="attributes">
+                <attribute name="style">width: 650px;</attribute>
+            </div>
         </field>
     </record>
 

purchase_usability/README.rst

@@ -1,63 +0,0 @@
-==================
-Purchase Usability
-==================
-
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! This file is generated by oca-gen-addon-readme !!
-   !! changes will be overwritten.                   !!
-   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-
-.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
-    :target: https://odoo-community.org/page/development-status
-    :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
-    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-    :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github
-    :target: https://github.com/akretion/odoo-usability/tree/12.0/purchase_usability
-    :alt: akretion/odoo-usability
-
-|badge1| |badge2| |badge3| 
-
-This module adds the following functions:
- - Track visibility on partner and product purchase warning
- - Track visibility on Purchase Order warning
- - Methods to help generate py3o purchase reports
- - Use untaxed amount in name_get of purchase orders
- - Protect Cancel button with a confirmation pop-up
- - Misc. improvements to Purchase Order Line views
-
-**Table of contents**
-
-.. contents::
-   :local:
-
-Bug Tracker
-===========
-
-Bugs are tracked on `GitHub Issues <https://github.com/akretion/odoo-usability/issues>`_.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/akretion/odoo-usability/issues/new?body=module:%20purchase_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-
-Do not contact contributors directly about support or help with technical issues.
-
-Credits
-=======
-
-Authors
-~~~~~~~
-
-* Akretion
-
-Contributors
-~~~~~~~~~~~~
-
-* Alexis de Lattre <alexis.delattre@akretion.com>
-
-Maintainers
-~~~~~~~~~~~
-
-This module is part of the `akretion/odoo-usability <https://github.com/akretion/odoo-usability/tree/12.0/purchase_usability>`_ project on GitHub.
-
-You are welcome to contribute.

purchase_usability/__manifest__.py

@@ -8,6 +8,14 @@
     'category': 'Purchases',
     'license': 'AGPL-3',
     'summary': 'Usability improvements on purchase module',
+    'description': """
+Purchase Usability
+==================
+
+Several usability improvements on the official purchase module:
+
+Please contact Alexis de Lattre from Akretion <alexis.delattre@akretion.com> for any help or question about this module.
+    """,
     'author': 'Akretion',
     'website': 'http://www.akretion.com',
     'depends': ['purchase'],

purchase_usability/purchase.py

@@ -3,9 +3,8 @@
 # @author Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import models, fields, api, _
+from odoo import models, fields, api
 from odoo.tools.misc import formatLang
-from odoo.tools import float_compare
 
 
 class PurchaseOrder(models.Model):
@@ -43,51 +42,6 @@ class PurchaseOrder(models.Model):
             if po.partner_ref:
                 name += ' (' + po.partner_ref + ')'
             if self.env.context.get('show_total_amount') and po.amount_total:
-                name += ': ' + formatLang(
-                    self.env, po.amount_untaxed, currency_obj=po.currency_id)
+                name += ': ' + formatLang(self.env, po.amount_untaxed, currency_obj=po.currency_id)
             result.append((po.id, name))
         return result
-
-
-class PurchaseOrderLine(models.Model):
-    _inherit = 'purchase.order.line'
-
-    @api.onchange('product_qty', 'product_uom')
-    def _onchange_quantity(self):
-        # When the user has manually set a price and/or planned_date
-        # he is often upset when Odoo changes it when he changes the qty
-        # So we add a warning...
-        res = {}
-        old_price = self.price_unit
-        old_date_planned = self.date_planned
-        super()._onchange_quantity()
-        new_price = self.price_unit
-        new_date_planned = self.date_planned
-        prec = self.env['decimal.precision'].precision_get('Product Price')
-        price_compare = float_compare(old_price, new_price, precision_digits=prec)
-        if price_compare or old_date_planned != new_date_planned:
-            res['warning'] = {
-                'title': _('Updates'),
-                'message': _(
-                    "Due to the update of the ordered quantity on line '%s', "
-                    "the following data has been updated using the supplier info "
-                    "of the product:"
-                    ) % self.name
-                }
-            if price_compare:
-                res['warning']['message'] += _(
-                    "\nOld price: %s\nNew price: %s") % (
-                        formatLang(
-                            self.env, old_price,
-                            currency_obj=self.order_id.currency_id),
-                        formatLang(
-                            self.env, new_price,
-                            currency_obj=self.order_id.currency_id))
-
-            if old_date_planned != new_date_planned:
-                res['warning']['message'] += _(
-                    "\nOld delivery date: %s\nNew delivery date: %s") % (
-                        old_date_planned,
-                        new_date_planned,
-                    )
-        return res

purchase_usability/purchase_view.xml

@@ -172,40 +172,5 @@
 
 <!-- The menu entry should be added in customer-specific module -->
 
-<record id="purchase.action_purchase_order_report_all" model="ir.actions.act_window">
-    <field name="view_mode">pivot,graph,tree</field>  <!--- native order is graph,pivot. Switch order and add tree -->
-</record>
-
-<record id="view_purchase_order_pivot" model="ir.ui.view">
-    <field name="model">purchase.report</field>
-    <field name="inherit_id" ref="purchase.view_purchase_order_pivot"/>
-    <field name="arch" type="xml">
-        <pivot position="attributes">
-            <attribute name="disable_linking"></attribute>
-        </pivot>
-        <field name="unit_quantity" position="replace"/>  <!-- it's stupid to display a unit_quantity by default... it will sum qty of different products, which doesn't make a lot of sense -->
-        <field name="price_average" position="replace"/>  <!-- it's stupid to display a price_average by default... it will average between different products, which is a non-sense -->
-    </field>
-</record>
-
-<record id="view_purchase_order_tree" model="ir.ui.view">
-    <field name="name">purchase.report.tree</field>
-    <field name="model">purchase.report</field>
-    <field name="arch" type="xml">
-        <tree>
-            <field name="commercial_partner_id"/>
-            <field name="date_order"/>
-            <field name="date_approve"/>
-            <field name="product_id"/>
-            <field name="unit_quantity" sum="1"/>
-            <field name="product_uom"/>
-            <field name="price_total" sum="1"/>
-            <field name="account_analytic_id"/>
-            <field name="currency_id" invisible="1"/>
-            <field name="user_id"/>
-            <field name="state"/>
-        </tree>
-    </field>
-</record>
 
 </odoo>

purchase_usability/readme/CONTRIBUTORS.rst

@@ -1 +0,0 @@
-* Alexis de Lattre <alexis.delattre@akretion.com>

purchase_usability/readme/DESCRIPTION.rst

@@ -1,7 +0,0 @@
-This module adds the following functions:
- - Track visibility on partner and product purchase warning
- - Track visibility on Purchase Order warning
- - Methods to help generate py3o purchase reports
- - Use untaxed amount in name_get of purchase orders
- - Protect Cancel button with a confirmation pop-up
- - Misc. improvements to Purchase Order Line views

purchase_usability/static/description/index.html

@@ -1,425 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>
-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
-<title>Purchase Usability</title>
-<style type="text/css">
-
-/*
-:Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
-:Copyright: This stylesheet has been placed in the public domain.
-
-Default cascading style sheet for the HTML output of Docutils.
-
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
-customize this style sheet.
-*/
-
-/* used to remove borders from tables and images */
-.borderless, table.borderless td, table.borderless th {
-  border: 0 }
-
-table.borderless td, table.borderless th {
-  /* Override padding for "table.docutils td" with "! important".
-     The right padding separates the table cells. */
-  padding: 0 0.5em 0 0 ! important }
-
-.first {
-  /* Override more specific margin styles with "! important". */
-  margin-top: 0 ! important }
-
-.last, .with-subtitle {
-  margin-bottom: 0 ! important }
-
-.hidden {
-  display: none }
-
-.subscript {
-  vertical-align: sub;
-  font-size: smaller }
-
-.superscript {
-  vertical-align: super;
-  font-size: smaller }
-
-a.toc-backref {
-  text-decoration: none ;
-  color: black }
-
-blockquote.epigraph {
-  margin: 2em 5em ; }
-
-dl.docutils dd {
-  margin-bottom: 0.5em }
-
-object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
-  overflow: hidden;
-}
-
-/* Uncomment (and remove this text!) to get bold-faced definition list terms
-dl.docutils dt {
-  font-weight: bold }
-*/
-
-div.abstract {
-  margin: 2em 5em }
-
-div.abstract p.topic-title {
-  font-weight: bold ;
-  text-align: center }
-
-div.admonition, div.attention, div.caution, div.danger, div.error,
-div.hint, div.important, div.note, div.tip, div.warning {
-  margin: 2em ;
-  border: medium outset ;
-  padding: 1em }
-
-div.admonition p.admonition-title, div.hint p.admonition-title,
-div.important p.admonition-title, div.note p.admonition-title,
-div.tip p.admonition-title {
-  font-weight: bold ;
-  font-family: sans-serif }
-
-div.attention p.admonition-title, div.caution p.admonition-title,
-div.danger p.admonition-title, div.error p.admonition-title,
-div.warning p.admonition-title, .code .error {
-  color: red ;
-  font-weight: bold ;
-  font-family: sans-serif }
-
-/* Uncomment (and remove this text!) to get reduced vertical space in
-   compound paragraphs.
-div.compound .compound-first, div.compound .compound-middle {
-  margin-bottom: 0.5em }
-
-div.compound .compound-last, div.compound .compound-middle {
-  margin-top: 0.5em }
-*/
-
-div.dedication {
-  margin: 2em 5em ;
-  text-align: center ;
-  font-style: italic }
-
-div.dedication p.topic-title {
-  font-weight: bold ;
-  font-style: normal }
-
-div.figure {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-div.footer, div.header {
-  clear: both;
-  font-size: smaller }
-
-div.line-block {
-  display: block ;
-  margin-top: 1em ;
-  margin-bottom: 1em }
-
-div.line-block div.line-block {
-  margin-top: 0 ;
-  margin-bottom: 0 ;
-  margin-left: 1.5em }
-
-div.sidebar {
-  margin: 0 0 0.5em 1em ;
-  border: medium outset ;
-  padding: 1em ;
-  background-color: #ffffee ;
-  width: 40% ;
-  float: right ;
-  clear: right }
-
-div.sidebar p.rubric {
-  font-family: sans-serif ;
-  font-size: medium }
-
-div.system-messages {
-  margin: 5em }
-
-div.system-messages h1 {
-  color: red }
-
-div.system-message {
-  border: medium outset ;
-  padding: 1em }
-
-div.system-message p.system-message-title {
-  color: red ;
-  font-weight: bold }
-
-div.topic {
-  margin: 2em }
-
-h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
-h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
-  margin-top: 0.4em }
-
-h1.title {
-  text-align: center }
-
-h2.subtitle {
-  text-align: center }
-
-hr.docutils {
-  width: 75% }
-
-img.align-left, .figure.align-left, object.align-left, table.align-left {
-  clear: left ;
-  float: left ;
-  margin-right: 1em }
-
-img.align-right, .figure.align-right, object.align-right, table.align-right {
-  clear: right ;
-  float: right ;
-  margin-left: 1em }
-
-img.align-center, .figure.align-center, object.align-center {
-  display: block;
-  margin-left: auto;
-  margin-right: auto;
-}
-
-table.align-center {
-  margin-left: auto;
-  margin-right: auto;
-}
-
-.align-left {
-  text-align: left }
-
-.align-center {
-  clear: both ;
-  text-align: center }
-
-.align-right {
-  text-align: right }
-
-/* reset inner alignment in figures */
-div.align-right {
-  text-align: inherit }
-
-/* div.align-center * { */
-/*   text-align: left } */
-
-.align-top    {
-  vertical-align: top }
-
-.align-middle {
-  vertical-align: middle }
-
-.align-bottom {
-  vertical-align: bottom }
-
-ol.simple, ul.simple {
-  margin-bottom: 1em }
-
-ol.arabic {
-  list-style: decimal }
-
-ol.loweralpha {
-  list-style: lower-alpha }
-
-ol.upperalpha {
-  list-style: upper-alpha }
-
-ol.lowerroman {
-  list-style: lower-roman }
-
-ol.upperroman {
-  list-style: upper-roman }
-
-p.attribution {
-  text-align: right ;
-  margin-left: 50% }
-
-p.caption {
-  font-style: italic }
-
-p.credits {
-  font-style: italic ;
-  font-size: smaller }
-
-p.label {
-  white-space: nowrap }
-
-p.rubric {
-  font-weight: bold ;
-  font-size: larger ;
-  color: maroon ;
-  text-align: center }
-
-p.sidebar-title {
-  font-family: sans-serif ;
-  font-weight: bold ;
-  font-size: larger }
-
-p.sidebar-subtitle {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-p.topic-title {
-  font-weight: bold }
-
-pre.address {
-  margin-bottom: 0 ;
-  margin-top: 0 ;
-  font: inherit }
-
-pre.literal-block, pre.doctest-block, pre.math, pre.code {
-  margin-left: 2em ;
-  margin-right: 2em }
-
-pre.code .ln { color: grey; } /* line numbers */
-pre.code, code { background-color: #eeeeee }
-pre.code .comment, code .comment { color: #5C6576 }
-pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
-pre.code .literal.string, code .literal.string { color: #0C5404 }
-pre.code .name.builtin, code .name.builtin { color: #352B84 }
-pre.code .deleted, code .deleted { background-color: #DEB0A1}
-pre.code .inserted, code .inserted { background-color: #A3D289}
-
-span.classifier {
-  font-family: sans-serif ;
-  font-style: oblique }
-
-span.classifier-delimiter {
-  font-family: sans-serif ;
-  font-weight: bold }
-
-span.interpreted {
-  font-family: sans-serif }
-
-span.option {
-  white-space: nowrap }
-
-span.pre {
-  white-space: pre }
-
-span.problematic {
-  color: red }
-
-span.section-subtitle {
-  /* font-size relative to parent (h1..h6 element) */
-  font-size: 80% }
-
-table.citation {
-  border-left: solid 1px gray;
-  margin-left: 1px }
-
-table.docinfo {
-  margin: 2em 4em }
-
-table.docutils {
-  margin-top: 0.5em ;
-  margin-bottom: 0.5em }
-
-table.footnote {
-  border-left: solid 1px black;
-  margin-left: 1px }
-
-table.docutils td, table.docutils th,
-table.docinfo td, table.docinfo th {
-  padding-left: 0.5em ;
-  padding-right: 0.5em ;
-  vertical-align: top }
-
-table.docutils th.field-name, table.docinfo th.docinfo-name {
-  font-weight: bold ;
-  text-align: left ;
-  white-space: nowrap ;
-  padding-left: 0 }
-
-/* "booktabs" style (no vertical lines) */
-table.docutils.booktabs {
-  border: 0px;
-  border-top: 2px solid;
-  border-bottom: 2px solid;
-  border-collapse: collapse;
-}
-table.docutils.booktabs * {
-  border: 0px;
-}
-table.docutils.booktabs th {
-  border-bottom: thin solid;
-  text-align: left;
-}
-
-h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
-h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
-  font-size: 100% }
-
-ul.auto-toc {
-  list-style-type: none }
-
-</style>
-</head>
-<body>
-<div class="document" id="purchase-usability">
-<h1 class="title">Purchase Usability</h1>
-
-<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! This file is generated by oca-gen-addon-readme !!
-!! changes will be overwritten.                   !!
-!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/purchase_usability"><img alt="akretion/odoo-usability" src="https://img.shields.io/badge/github-akretion%2Fodoo--usability-lightgray.png?logo=github" /></a></p>
-<dl class="docutils">
-<dt>This module adds the following functions:</dt>
-<dd><ul class="first last simple">
-<li>Track visibility on partner and product purchase warning</li>
-<li>Track visibility on Purchase Order warning</li>
-<li>Methods to help generate py3o purchase reports</li>
-<li>Use untaxed amount in name_get of purchase orders</li>
-<li>Protect Cancel button with a confirmation pop-up</li>
-<li>Misc. improvements to Purchase Order Line views</li>
-</ul>
-</dd>
-</dl>
-<p><strong>Table of contents</strong></p>
-<div class="contents local topic" id="contents">
-<ul class="simple">
-<li><a class="reference internal" href="#bug-tracker" id="id1">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id2">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id3">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id4">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id5">Maintainers</a></li>
-</ul>
-</li>
-</ul>
-</div>
-<div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id1">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/akretion/odoo-usability/issues">GitHub Issues</a>.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/akretion/odoo-usability/issues/new?body=module:%20purchase_usability%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
-<p>Do not contact contributors directly about support or help with technical issues.</p>
-</div>
-<div class="section" id="credits">
-<h1><a class="toc-backref" href="#id2">Credits</a></h1>
-<div class="section" id="authors">
-<h2><a class="toc-backref" href="#id3">Authors</a></h2>
-<ul class="simple">
-<li>Akretion</li>
-</ul>
-</div>
-<div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id4">Contributors</a></h2>
-<ul class="simple">
-<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
-</ul>
-</div>
-<div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
-<p>This module is part of the <a class="reference external" href="https://github.com/akretion/odoo-usability/tree/12.0/purchase_usability">akretion/odoo-usability</a> project on GitHub.</p>
-<p>You are welcome to contribute.</p>
-</div>
-</div>
-</div>
-</body>
-</html>

purchase_usability/stock_view.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  Copyright (C) 2017 Akretion (http://www.akretion.com/)
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
+  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+-->
+
+<openerp>
+<data>
+
+<record id="view_picking_form" model="ir.ui.view">
+    <field name="name">purchase_usability.stock.picking.form</field>
+    <field name="model">stock.picking</field>
+    <field name="inherit_id" ref="stock.view_picking_form"/>
+    <field name="arch" type="xml">
+        <field name="origin" position="after">
+            <field name="purchase_id" attrs="{'invisible': [('picking_type_code', '!=', 'incoming')]}" context="{'show_purchase': True}"/>
+        </field>
+    </field>
+</record>
+
+
+</data>
+</openerp>

sale_down_payment/__init__.py

@@ -1,2 +0,0 @@
-from . import models
-from . import wizard

sale_down_payment/__manifest__.py

@@ -1,35 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-{
-    'name': 'Sale Down Payment',
-    'version': '12.0.1.0.0',
-    'category': 'Sales',
-    'license': 'AGPL-3',
-    'summary': 'Link payment to sale orders',
-    'description': """
-Sale Down Payment
-=================
-
-This module adds a link between payments and sale orders. It allows to see down payments directly on the sale order form view.
-
-After processing a bank statement, you can start a wizard to link unreconciled incoming payments to a sale order. There is also a button *Register Payment* on the sale order.
-
-This module targets B2B companies that don't want to generate a down payment invoice for an advanced payment.
-
-This module has been written by Alexis de Lattre from Akretion
-<alexis.delattre@akretion.com>.
-    """,
-    'author': 'Akretion',
-    'website': 'http://www.akretion.com',
-    'depends': ['sale'],
-    'data': [
-        'wizard/account_bank_statement_sale_view.xml',
-        'views/account_bank_statement.xml',
-        'views/sale.xml',
-        'views/account_move_line.xml',
-        'views/account_payment.xml',
-        ],
-    'installable': True,
-}

sale_down_payment/models/__init__.py

@@ -1,3 +0,0 @@
-from . import sale
-from . import account_move_line
-from . import account_payment

sale_down_payment/models/account_invoice.py

@@ -1,27 +0,0 @@
-# Copyright 2023 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import api, models
-
-
-class AccountInvoice(models.Model):
-    _inherit = 'account.invoice'
-
-    @api.multi
-    def action_invoice_open(self):
-        res = super().action_invoice_open()
-        amlo = self.env['account.move.line']
-        for inv in self:
-            if inv.state == 'open' and inv.type == 'out_invoice':
-                sales = inv.invoice_line_ids.mapped('sale_line_ids').\
-                    mapped('order_id')
-                if sales:
-                    mlines = amlo.search([('sale_id', 'in', sales.ids)])
-                    if mlines:
-                        receivable_lines = inv.move_id.mapped('line_ids').filtered(
-                            lambda l: l.account_id == inv.account_id)
-                        mlines |= receivable_lines
-                        mlines.remove_move_reconcile()
-                        mlines.reconcile()
-        return res

sale_down_payment/models/account_move_line.py

@@ -1,37 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import api, fields, models, _
-from odoo.exceptions import ValidationError
-
-
-class AccountMoveLine(models.Model):
-    _inherit = 'account.move.line'
-
-    sale_id = fields.Many2one('sale.order', string='Sale Order')
-    account_internal_type = fields.Selection(
-        related='account_id.user_type_id.type', store=True,
-        string='Account Internal Type')
-
-    @api.constrains('sale_id', 'account_id')
-    def sale_id_check(self):
-        for line in self:
-            if line.sale_id and line.account_id.internal_type != 'receivable':
-                raise ValidationError(_(
-                    "The account move line '%s' is linked to sale order '%s' "
-                    "but it uses account '%s' which is not a receivable "
-                    "account.")
-                    % (line.name,
-                       line.sale_id.name,
-                       line.account_id.display_name))
-
-    @api.onchange('account_id')
-    def sale_advance_payement_account_id_change(self):
-        if self.sale_id and self.account_id.user_type_id.type != 'receivable':
-            self.sale_id = False
-
-    def _sale_down_payment_hook(self):
-        # can be used for notifications
-        self.ensure_one()
-

sale_down_payment/models/account_payment.py

@@ -1,67 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import fields, models
-from odoo.tools import float_round
-
-
-class AccountPayment(models.Model):
-    _inherit = 'account.payment'
-
-    sale_id = fields.Many2one('sale.order', string='Sale Order')
-
-    def action_validate_invoice_payment(self):
-        if self.sale_id:
-            self.post()
-        else:
-            return super(AccountPayment, self).\
-                action_validate_invoice_payment()
-
-    def _get_counterpart_move_line_vals(self, invoice=False):
-        res = super(AccountPayment, self)._get_counterpart_move_line_vals(
-            invoice=invoice)
-        if self.sale_id:
-            res['sale_id'] = self.sale_id.id
-        return res
-
-    def _create_payment_entry(self, amount):
-        move = super()._create_payment_entry(amount)
-        if hasattr(self, 'sale_id') and self.sale_id:
-            for line in move.line_ids:
-                if line.sale_id and line.account_id.internal_type == 'receivable':
-                    line._sale_down_payment_hook()
-        return move
-
-
-class AccountAbstractPayment(models.AbstractModel):
-    _inherit = "account.abstract.payment"
-
-    def default_get(self, fields_list):
-        res = super(AccountAbstractPayment, self).default_get(fields_list)
-        if (
-                self._context.get('active_model') == 'sale.order' and
-                self._context.get('active_id')):
-            so = self.env['sale.order'].browse(self._context['active_id'])
-            res.update({
-                'amount': so.amount_total,
-                'currency_id': so.currency_id.id,
-                'payment_type': 'inbound',
-                'partner_id': so.partner_invoice_id.commercial_partner_id.id,
-                'partner_type': 'customer',
-                'communication': so.name,
-                'sale_id': so.id,
-                })
-        return res
-
-    def _compute_payment_amount(self, invoices=None, currency=None):
-        amount = super(AccountAbstractPayment, self)._compute_payment_amount(
-            invoices=invoices, currency=currency)
-        if hasattr(self, 'sale_id') and self.sale_id:
-            payment_currency = currency
-            if not payment_currency:
-                payment_currency = self.sale_id.currency_id
-            amount = float_round(
-                self.sale_id.amount_total - self.sale_id.amount_down_payment,
-                precision_rounding=payment_currency.rounding)
-        return amount

sale_down_payment/models/sale.py

@@ -1,48 +0,0 @@
-# Copyright 2019 Akretion France (http://www.akretion.com)
-# @author Alexis de Lattre <alexis.delattre@akretion.com>
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
-from odoo import api, fields, models
-from odoo.tools import float_round
-
-
-class SaleOrder(models.Model):
-    _inherit = 'sale.order'
-
-    payment_line_ids = fields.One2many(
-        'account.move.line', 'sale_id', string='Advance Payments',
-        readonly=True)
-    amount_down_payment = fields.Monetary(
-        compute='_compute_amount_down_payment', string='Down Payment Amount')
-    # amount_residual : only used to hide 'Register Payment' button
-    amount_residual = fields.Monetary(
-        compute='_compute_amount_down_payment', string='Residual')
-
-    @api.depends(
-        'payment_line_ids.credit', 'payment_line_ids.debit',
-        'payment_line_ids.amount_currency', 'payment_line_ids.currency_id',
-        'payment_line_ids.date', 'currency_id')
-    def _compute_amount_down_payment(self):
-        for sale in self:
-            down_payment = 0.0
-            sale_currency = sale.pricelist_id.currency_id
-            if sale_currency == sale.company_id.currency_id:
-                for pl in sale.payment_line_ids:
-                    down_payment -= pl.balance
-            else:
-                for pl in sale.payment_line_ids:
-                    if (
-                            pl.currency_id and
-                            pl.currency_id == sale_currency and
-                            pl.amount_currency):
-                        down_payment -= pl.amount_currency
-                    else:
-                        down_payment -= sale.company_id.currency_id._convert(
-                            pl.balance, sale_currency, sale.company_id,
-                            pl.date)
-            down_payment = float_round(
-                down_payment, precision_rounding=sale.currency_id.rounding)
-            sale.amount_down_payment = down_payment
-            sale.amount_residual = float_round(
-                sale.amount_total - down_payment,
-                precision_rounding=sale.currency_id.rounding)