[ADD] tax_receipt_in_portal: publish tax receipts on the portal #34

stephansainleger · 2026-10-20T22:15:46Z

stephansainleger commented

2026-10-20 22:15:46 +00:00

Let donors view and download their own tax receipts from
/my/tax-receipts: a paginated list, a detail page with the receipt
information, its invoices and the native portal chatter, and a PDF
download rendered on demand through the configured pdf_form report.

The PDF rendering is delegated to pdf_form_report and nothing is
archived: a confirmed receipt is frozen by l10n_fr_tax_receipt, so
rendering it again yields the same document.

Two safety nets compensate third-party behaviors:

report resolution by report_uuid (system parameter
tax_receipt_in_portal.report_uuid) with strict validation of
report type and target model;
a blank-field guard which resolves every mapped PDF field value
before rendering, because pdf_form_report swallows resolution
errors and would otherwise silently serve a receipt with a blank
amount.

Access is enforced twice: a portal record rule (own commercial partner,
confirmed/sent state only) and an explicit controller domain that also
covers internal users browsing /my.

Tested with 17 tests (portal isolation, draft exposure, chatter data
access, blank-field guard, report misconfiguration, private API
contract of pdf_form_report), including a mutation check proving
the security tests fail when the record rule is opened.

Let donors view and download their own tax receipts from ``/my/tax-receipts``: a paginated list, a detail page with the receipt information, its invoices and the native portal chatter, and a PDF download rendered on demand through the configured ``pdf_form`` report. The PDF rendering is delegated to ``pdf_form_report`` and nothing is archived: a confirmed receipt is frozen by ``l10n_fr_tax_receipt``, so rendering it again yields the same document. Two safety nets compensate third-party behaviors: - report resolution by ``report_uuid`` (system parameter ``tax_receipt_in_portal.report_uuid``) with strict validation of report type and target model; - a blank-field guard which resolves every mapped PDF field value before rendering, because ``pdf_form_report`` swallows resolution errors and would otherwise silently serve a receipt with a blank amount. Access is enforced twice: a portal record rule (own commercial partner, confirmed/sent state only) and an explicit controller domain that also covers internal users browsing ``/my``. Tested with 17 tests (portal isolation, draft exposure, chatter data access, blank-field guard, report misconfiguration, private API contract of ``pdf_form_report``), including a mutation check proving the security tests fail when the record rule is opened.

stephansainleger added 1 commit 2026-10-20 22:15:47 +00:00

[ADD] tax_receipt_in_portal: publish tax receipts on the portal

pre-commit / pre-commit (pull_request) Failing after 1m32s

Details

tests / test (pull_request) Failing after 38s

Details

73c0684623

Let donors view and download their own tax receipts from
``/my/tax-receipts``: a paginated list, a detail page with the receipt
information, its invoices and the native portal chatter, and a PDF
download rendered on demand through the configured ``pdf_form`` report.

The PDF rendering is delegated to ``pdf_form_report`` and nothing is
archived: a confirmed receipt is frozen by ``l10n_fr_tax_receipt``, so
rendering it again yields the same document.

Two safety nets compensate third-party behaviors:

- report resolution by ``report_uuid`` (system parameter
  ``tax_receipt_in_portal.report_uuid``) with strict validation of
  report type and target model;
- a blank-field guard which resolves every mapped PDF field value
  before rendering, because ``pdf_form_report`` swallows resolution
  errors and would otherwise silently serve a receipt with a blank
  amount.

Access is enforced twice: a portal record rule (own commercial partner,
confirmed/sent state only) and an explicit controller domain that also
covers internal users browsing ``/my``.

Tested with 17 tests (portal isolation, draft exposure, chatter data
access, blank-field guard, report misconfiguration, private API
contract of ``pdf_form_report``), including a mutation check proving
the security tests fail when the record rule is opened.

stephansainleger added 1 commit 2026-10-23 11:56:36 +00:00

[IMP] tax_receipt_in_portal: pick report per company, hide missing PDFs

pre-commit / pre-commit (pull_request) Failing after 1m30s

Details

tests / test (pull_request) Failing after 1m41s

Details

5eb3fe766b

Replace the ``tax_receipt_in_portal.report_uuid`` system parameter by a
per-company setting, in Settings > Invoicing > Tax Receipts
(``res.company.tax_receipt_report_id``). Each receipt is rendered with
the report of its issuing company, not the current one: in the portal,
the current company is the website's. The selector only offers PDF Form
reports on ``l10n.fr.tax.receipt``; type and model are still checked at
rendering time since the report can be edited after selection.

The download buttons of the list and detail pages are only shown when
the PDF can actually be rendered: a valid report is configured for the
issuing company and no mapped field resolves to an empty value. The
checks are those of the rendering itself, exposed as a filter
(``_get_pdf_available_receipts``) and run in sudo to avoid false
negatives on field paths the donor cannot read. Otherwise a discreet
"PDF available soon" mention replaces the button, and the download URL
redirects to the receipt page.

The detail page download link now also carries the share token, so a
visitor reaching the page by token can download the PDF.

pre-commit / pre-commit (pull_request) Failing after 1m30s

Details

tests / test (pull_request) Failing after 1m41s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 18.0-tax_receipt_in_portal:18.0-tax_receipt_in_portal

git checkout 18.0-tax_receipt_in_portal

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Elabore/account-tools#34