[IMP] migrate module account_advanced_protection_features from version 16 to version 18

.pre-commit-config.yaml

@@ -49,9 +49,12 @@ repos:
           $(git rev-parse --show-toplevel))"'
       - id: oca-gen-addon-readme
         entry:
-          bash -c 'oca-gen-addon-readme --addons-dir=. --branch=$(git symbolic-ref
+          bash -c 'oca-gen-addon-readme 
+          --addons-dir=. 
+          --branch=$(git symbolic-ref
           refs/remotes/origin/HEAD | sed "s@^refs/remotes/origin/@@")
-          --repo-name=$(basename $(git rev-parse --show-toplevel)) --org-name="Elabore"
+          --repo-name=$(basename $(git rev-parse --show-toplevel))
+          --org-name="Elabore"
           --if-source-changed --keep-source-digest'
 
   - repo: https://github.com/OCA/odoo-pre-commit-hooks

account_advanced_protection_features/.gitignore

@@ -1,2 +1,2 @@
 *.*~
-*pyc
+*pyc

account_advanced_protection_features/__manifest__.py

@@ -5,19 +5,25 @@
     "name": "account_advanced_protection_features",
     "version": "18.0.1.0.0",
     "author": "Elabore",
-    "website": "https://git.elabore.coop/elabore/account-tools",
+    "website": "https://elabore.coop",
     "maintainer": "Quentin Mondot",
     "license": "AGPL-3",
     "category": "Tools",
     "summary": "Add several protection features about accounting",
     # any module necessary for this one to work correctly
-    "depends": ["base", "account"],
+    "depends": [
+        "base",
+        "account"
+    ],
     "qweb": [],
     "external_dependencies": {
         "python": [],
     },
     # always loaded
-    "data": ["security/res_groups.xml", "views/account_journal_views.xml"],
+    "data": [
+        "security/res_groups.xml",
+        "views/account_journal_views.xml"
+    ],
     # only loaded in demonstration mode
     "demo": [],
     "js": [],

account_advanced_protection_features/models/account_bank_statement.py

@@ -1,7 +1,6 @@
-from odoo import _, models
+from odoo import models, _
 from odoo.exceptions import UserError
 
-
 class AccountBankStatement(models.Model):
     _inherit = "account.bank.statement"
 
@@ -9,16 +8,12 @@ class AccountBankStatement(models.Model):
         for statement in self:
             if not statement.journal_id.allow_bank_statement_deletion:
                 raise UserError(
-                    _(
+                    _("The deletion of bank statements is not allowed for the journal %s.") % statement.journal_id.display_name
-                        "The deletion of bank statements is "
-                        "not allowed for the journal %s."
-                    )
-                    % statement.journal_id.display_name
                 )
             # we delete all the statement lines before deleting the statement itself
             for line in statement.line_ids:
                 line.unlink()
-        return super().unlink()
+        return super(AccountBankStatement, self).unlink()
 
 
 class AccountBankStatementLine(models.Model):
@@ -28,10 +23,6 @@ class AccountBankStatementLine(models.Model):
         for line in self:
             if not line.journal_id.allow_bank_statement_deletion:
                 raise UserError(
-                    _(
+                    _("The deletion of bank statement lines is not allowed for the journal %s.") % line.journal_id.display_name
-                        "The deletion of bank statement lines is "
-                        "not allowed for the journal %s."
-                    )
-                    % line.journal_id.display_name
                 )
-        return super().unlink()
+        return super(AccountBankStatementLine, self).unlink()

account_advanced_protection_features/models/account_journal.py

@@ -1,18 +1,12 @@
-from odoo import fields, models
+from odoo import models, fields
-
 
 class AccountJournal(models.Model):
     _inherit = "account.journal"
 
-    prevent_reset_to_draft_sent_invoice = fields.Boolean(
+    prevent_reset_to_draft_sent_invoice = fields.Boolean("Prevent to reset to draft a sent invoice")
-        "Prevent to reset to draft a sent invoice"
+    prevent_deletion_of_posted_account_move = fields.Boolean("Prevent to delete an already posted account move")
-    )
-    prevent_deletion_of_posted_account_move = fields.Boolean(
-        "Prevent to delete an already posted account move"
-    )
     allow_bank_statement_deletion = fields.Boolean(
         "Allow bank statements deletion",
-        help="Users with group Show Full Accounting Features (id: group_account_user) "
+        help="Users with group Show Full Accounting Features (id: group_account_user) will be allowed to delete account bank statements "
-        "will be allowed to delete account bank statements "
+             "and bank statement lines."
-        "and bank statement lines.",
     )

account_advanced_protection_features/models/account_move.py

@@ -1,34 +1,23 @@
-from odoo import _, api, models
+from odoo import models, api, fields, _
 from odoo.exceptions import UserError
 
-
 class AccountMove(models.Model):
-    _inherit = "account.move"
+    _inherit = 'account.move'
 
     def button_draft(self):
         if self.is_move_sent and self.journal_id.prevent_reset_to_draft_sent_invoice:
-            raise UserError(
+            raise UserError(_(
-                _(
+                "You cannot reset to draft this invoice because it has been sent by email."
-                    "You cannot reset to draft this invoice because it "
+            ))
-                    "has been sent by email."
+        return super(AccountMove, self).button_draft()
-                )
-            )
-        return super().button_draft()
 
     @api.ondelete(at_uninstall=False)
     def _check_posted(self):
-        """
+        """ Prevent deletion of an account move if it has already been posted and
-        Prevent deletion of an account move if it has already been posted and journal
+        journal parameter prevent_deletion_of_posted_account_move is activated
-        parameter prevent_deletion_of_posted_account_move is activated.
         """
         for rec in self:
-            if (
+            if rec.posted_before and rec.journal_id.prevent_deletion_of_posted_account_move:
-                rec.posted_before
+                raise UserError(_(
-                and rec.journal_id.prevent_deletion_of_posted_account_move
+                    "You cannot delete this account move because it has already been posted."
-            ):
+                ))
-                raise UserError(
-                    _(
-                        "You cannot delete this account move because it "
-                        "has already been posted."
-                    )
-                )

account_advanced_protection_features/security/res_groups.xml

@@ -1,7 +1,7 @@
-<?xml version="1.0" encoding="utf-8" ?>
+<?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <record id="group_account_protection_manager" model="res.groups">
         <field name="name">Access to account advanced protection features</field>
-        <field name="category_id" ref="base.module_category_hidden" />
+        <field name="category_id" ref="base.module_category_hidden"/>
     </record>
 </odoo>

account_advanced_protection_features/views/account_journal_views.xml

@@ -1,27 +1,24 @@
-<?xml version="1.0" encoding="utf-8" ?>
+<?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <record
+    <record id="view_account_journal_form_inherit_prevent_reset_to_draft" model="ir.ui.view">
-        id="view_account_journal_form_inherit_prevent_reset_to_draft"
-        model="ir.ui.view"
-    >
         <field name="name">account.journal.form</field>
         <field name="model">account.journal</field>
-        <field name="inherit_id" ref="account.view_account_journal_form" />
+        <field name="inherit_id" ref="account.view_account_journal_form"/>
         <field name="arch" type="xml">
             <xpath expr="//field[@name='restrict_mode_hash_table']" position="after">
                 <field
-                    name="prevent_deletion_of_posted_account_move"
+                        name="prevent_deletion_of_posted_account_move"
-                    groups="account_advanced_protection_features.group_account_protection_manager"
+                        groups="account_advanced_protection_features.group_account_protection_manager"
                 />
                 <field
-                    name="prevent_reset_to_draft_sent_invoice"
+                        name="prevent_reset_to_draft_sent_invoice"
-                    groups="account_advanced_protection_features.group_account_protection_manager"
+                        groups="account_advanced_protection_features.group_account_protection_manager"
-                    invisible="type != 'sale'"
+                        invisible="type != 'sale'"
                 />
                 <field
-                    name="allow_bank_statement_deletion"
+                        name="allow_bank_statement_deletion"
-                    groups="account_advanced_protection_features.group_account_protection_manager"
+                        groups="account_advanced_protection_features.group_account_protection_manager"
-                    invisible="type not in ['bank', 'cash']"
+                        invisible="type not in ['bank', 'cash']"
                 />
             </xpath>
         </field>