From 6840765f5c0aededf5c465e6f007f1b5710e8b20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phan=20Sainl=C3=A9ger?=
 <contact@stephansainleger.fr>
Date: Fri, 16 Jun 2023 12:47:08 +0200
Subject: [PATCH] [FIX] learning_base: remove learning value frm product
 detailed_type

If we have to select "learning" value in the detailed_type field, this
means that we can not select Event Ticket, then we can not sell the
product as a ticket in an event.
---
 learning_base/__manifest__.py                |   1 -
 learning_base/ir_module_category_records.xml |   8 -
 learning_base/models/product_template.py     |  11 +-
 learning_base/views/product_template.xml     | 169 ++++++++++---------
 4 files changed, 88 insertions(+), 101 deletions(-)
 delete mode 100644 learning_base/ir_module_category_records.xml

diff --git a/learning_base/__manifest__.py b/learning_base/__manifest__.py
index 208e952..1adbcbf 100644
--- a/learning_base/__manifest__.py
+++ b/learning_base/__manifest__.py
@@ -24,7 +24,6 @@
         'security/ir.model.access.csv',
         'ir_actions_act_window_records.xml',
         'ir_ui_menu_records.xml',
-        'ir_module_category_records.xml',
         'views/product_template.xml',
         'views/event_event.xml',
         'views/res_company.xml',
diff --git a/learning_base/ir_module_category_records.xml b/learning_base/ir_module_category_records.xml
deleted file mode 100644
index a0c3866..0000000
--- a/learning_base/ir_module_category_records.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<openerp>
-  <data>
-    <record id="ir_module_category_formation_r0" model="ir.module.category">
-      <field name="name">Formation</field>
-    </record>
-  </data>
-</openerp>
diff --git a/learning_base/models/product_template.py b/learning_base/models/product_template.py
index 4ebed90..5802b15 100644
--- a/learning_base/models/product_template.py
+++ b/learning_base/models/product_template.py
@@ -17,11 +17,7 @@ class learningFinancialProgram(models.Model):
 class ProductTemplate(models.Model):
     _inherit = ['product.template']
 
-    is_learning = fields.Boolean(compute='_compute_is_learning', store=True)
-    detailed_type = fields.Selection(selection_add=[
-        ('learning', 'Training'),
-    ], ondelete={'learning': 'set service'})
-    
+    is_learning = fields.Boolean(string='is learning')
     
     goal = fields.Html(string='Goal', translate=True)
     duration_html = fields.Html(string='Duration', translate=True)
@@ -56,11 +52,6 @@ class ProductTemplate(models.Model):
         for record in self:
             record.count_session = len(self.env['event.event'].search([('learning_id', '=', record.id)]))
 
-    @api.depends('detailed_type')
-    def _compute_is_learning(self):
-        for record in self:
-            record.is_learning = record.detailed_type == 'learning'
-
     def _detailed_type_mapping(self):
         type_mapping = super()._detailed_type_mapping()
         type_mapping['learning'] = 'service'
diff --git a/learning_base/views/product_template.xml b/learning_base/views/product_template.xml
index 5d644cb..5067210 100644
--- a/learning_base/views/product_template.xml
+++ b/learning_base/views/product_template.xml
@@ -3,98 +3,103 @@
      License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
 
 <odoo>
-    <record id="learning_base_product_template_form" model="ir.ui.view">
-        <field name="name">product.template.learning.form.inherit</field>
-        <field name="model">product.template</field>
-        <field name="inherit_id" ref="product.product_template_form_view"/>
-        <field name="arch" type="xml">
- 
-            <div name="button_box" position="inside">
-                <button name="%(ir_actions_act_window_session_r0)d"
-                            type="action"
-                            class="oe_stat_button"
-                            icon="fa-pencil-square-o"
-                            context="{'search_default_learning_id': active_id, 'default_name': name, 'default_learning_id': active_id}">
-                            <field name="count_session" widget="statinfo" string="Sessions"/>
-                </button>
-            </div>
+  <record id="learning_base_product_template_form" model="ir.ui.view">
+    <field name="name">product.template.learning.form.inherit</field>
+    <field name="model">product.template</field>
+    <field name="inherit_id" ref="product.product_template_form_view" />
+    <field name="arch" type="xml">
 
-            <page name="sales" position="after">
-              <page string="Learning" attrs="{'invisible':[('detailed_type','!=','learning')]}" name="Learning">
-                <group name="Informations">
-                  <group>
-                    <field name="domain_id"/>
-		              </group>
-                </group>
-                <group name="Duration">
-                  <group>
-                    <field name="duration_days"/>
-                    <field name="hours_per_day"/>
-                    <field name="duration_hour"/>
-                  </group>
-                  <group>
-                    <field name="duration_text" placeholder="Specific duration details" nolabel="1"/>
-                  </group>
-                </group>
-                <group name="Financial Programs">
-                  <field name="financial_program_ids" widget="many2many_tags"/>
-                </group>
+      <div name="button_box" position="inside">
+        <button name="%(ir_actions_act_window_session_r0)d"
+          type="action"
+          class="oe_stat_button"
+          icon="fa-pencil-square-o"
+          context="{'search_default_learning_id': active_id, 'default_name': name, 'default_learning_id': active_id}">
+          <field name="count_session" widget="statinfo" string="Sessions" />
+        </button>
+      </div>
 
-		        <div name="learning_data">
-                    <separator string="Goal"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+      <field name="detailed_type" position="after">
+        <field name="is_learning" />
+      </field>
+
+      <page name="sales" position="after">
+        <page string="Learning" attrs="{'invisible':[('is_learning','=', False)]}"
+          name="Learning">
+          <group name="Informations">
+            <group>
+              <field name="domain_id" />
+            </group>
+          </group>
+          <group name="Duration">
+            <group>
+              <field name="duration_days" />
+              <field name="hours_per_day" />
+              <field name="duration_hour" />
+            </group>
+            <group>
+              <field name="duration_text" placeholder="Specific duration details" nolabel="1" />
+            </group>
+          </group>
+          <group name="Financial Programs">
+            <field name="financial_program_ids" widget="many2many_tags" />
+          </group>
+
+          <div name="learning_data">
+            <separator string="Goal" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="goal" readonly="1"/>
-                    <separator string="Duration Details"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="goal" readonly="1" />
+            <separator string="Duration Details" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
 
-                    <field name="duration_html" readonly="1"/>
-                    <separator string="Public"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="duration_html" readonly="1" />
+            <separator string="Public" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="public" readonly="1"/>
-                    <separator string="Prerequisite"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="public" readonly="1" />
+            <separator string="Prerequisite" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="prerequisite" readonly="1"/>
-                    <separator string="Content"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="prerequisite" readonly="1" />
+            <separator string="Content" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="content" readonly="1"/>
-                    <separator string="Organizer"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="content" readonly="1" />
+            <separator string="Organizer" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="organizer" readonly="1"/>
-                    <separator string="Methodology"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="organizer" readonly="1" />
+            <separator string="Methodology" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="methodology" readonly="1"/>
-                    <separator string="Technical"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="methodology" readonly="1" />
+            <separator string="Technical" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="technic" readonly="1"/>
-                    <separator string="Price details"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="technic" readonly="1" />
+            <separator string="Price details" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="price_html" readonly="1"/>
-                    <separator string="Registration"/>
-                    <div class="alert alert-info" role="alert">
-  To edit content, please go to the website page directly.
+            <field name="price_html" readonly="1" />
+            <separator string="Registration" />
+            <div class="alert alert-info" role="alert">
+              To edit content, please go to the website page directly.
 </div>
-                    <field name="registration" readonly="1"/>
-                </div>
-              </page>
-            </page>
-        </field>
-    </record>
-</odoo>
+            <field name="registration" readonly="1" />
+          </div>
+        </page>
+      </page>
+    </field>
+  </record>
+</odoo>
\ No newline at end of file