From ffec9795e6194b2a78172d9c9c2a8ca1d461b3fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phan=20Sainl=C3=A9ger?=
 <contact@stephansainleger.fr>
Date: Fri, 21 Apr 2023 10:43:27 +0200
Subject: [PATCH] [IMP] partner_profiles: remove useless fields in position
 form view

---
 partner_profiles/__manifest__.py            |  2 +-
 partner_profiles/views/res_partner_view.xml | 46 +++++++++++++++------
 2 files changed, 34 insertions(+), 14 deletions(-)

diff --git a/partner_profiles/__manifest__.py b/partner_profiles/__manifest__.py
index ba116ea..52d47de 100644
--- a/partner_profiles/__manifest__.py
+++ b/partner_profiles/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "partner_profiles",
-    "version": "12.0.2.0.0",
+    "version": "12.0.2.1.0",
     "author": "Elabore",
     "website": "https://elabore.coop",
     "maintainer": "Stéphan Sainléger",
diff --git a/partner_profiles/views/res_partner_view.xml b/partner_profiles/views/res_partner_view.xml
index a7476db..ef465f0 100644
--- a/partner_profiles/views/res_partner_view.xml
+++ b/partner_profiles/views/res_partner_view.xml
@@ -64,8 +64,7 @@
 
                 <!-- page Other Positions -->
                 <xpath expr="//page[@name='other_position']" position="attributes">
-                    <attribute name="attrs">{'invisible': ['|', ('contact_id','!=',False),
-                        ('is_company','=',True)]}</attribute>
+                    <attribute name="attrs">{'invisible': [('is_company','=',True)]}</attribute>
                 </xpath>
                 <xpath expr="//page[@name='other_position']/field[@name='other_contact_ids']/kanban"
                     position="attributes">
@@ -89,18 +88,28 @@
                         context="{'default_partner_profile': 1, 'default_is_company': True, 'show_vat': True}" />
                 </xpath>
 
+                <!-- #################################### -->
+                <!-- PUBLIC AND POSITION PROFILES DISPLAY -->
+                <!-- #################################### -->
+                <xpath expr="//div[@name='button_box']" position="attributes">
+                    <attribute name="attrs">{'invisible': ['|', ('is_public_profile','=', True),
+                        ('is_position_profile','=', True)]}</attribute>
+                </xpath>
+                <xpath expr="//field[@name='image']" position="attributes">
+                    <attribute name="attrs">{'invisible': ['|', ('is_public_profile','=', True),
+                        ('is_position_profile','=', True)]}</attribute>
+                </xpath>
+                <xpath expr="//notebook" position="attributes">
+                    <attribute name="attrs">{'invisible': ['|', ('is_public_profile','=', True),
+                        ('is_position_profile','=', True)]}</attribute>
+                </xpath>
+                <xpath expr="//field[@name='type']/../.." position="attributes">
+                    <attribute name="attrs">{'invisible': ['|', ('is_public_profile','=', True),
+                        ('is_position_profile','=', True)]}</attribute>
+                </xpath>
                 <!-- ###################### -->
                 <!-- PUBLIC PROFILE DISPLAY -->
                 <!-- ###################### -->
-                <xpath expr="//div[@name='button_box']" position="attributes">
-                    <attribute name="attrs">{'invisible': [('is_public_profile','=', True)]}</attribute>
-                </xpath>
-                <xpath expr="//field[@name='image']" position="attributes">
-                    <attribute name="attrs">{'invisible': [('is_public_profile','=', True)]}</attribute>
-                </xpath>
-                <xpath expr="//field[@name='type']/../.." position="attributes">
-                    <attribute name="attrs">{'invisible': [('is_public_profile','=', True)]}</attribute>
-                </xpath>
                 <xpath expr="//field[@name='type']/../.." position="after">
                     <group attrs="{'invisible': [('is_public_profile','=',False)]}">
                         <group>
@@ -135,8 +144,19 @@
                         </group>
                     </group>
                 </xpath>
-                <xpath expr="//notebook" position="attributes">
-                    <attribute name="attrs">{'invisible': [('is_public_profile','=', True)]}</attribute>
+                <!-- ######################## -->
+                <!-- POSITION PROFILE DISPLAY -->
+                <!-- ######################## -->
+                <xpath expr="//field[@name='type']/../.." position="after">
+                    <group attrs="{'invisible': [('is_position_profile','=',False)]}">
+                        <group>
+                            <field name="function" />
+                        </group>
+                        <group>
+                            <field name="phone" widget="phone" />
+                            <field name="email" widget="email" context="{'gravatar_image': True}" />
+                        </group>
+                    </group>
                 </xpath>
             </field>
         </record>