From 29e9299940d9d6fa8658889677d8c85b3b7aa35b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phan=20Sainl=C3=A9ger?= Date: Sun, 18 Oct 2026 23:53:05 +0200 Subject: [PATCH] [FIX] partner_gogocarto_export_api: restore GogoCarto entry in settings menu The migration to 18.0 anchored the settings block inside the "General Settings" app (after Contacts). In 18.0 the settings side menu is built exclusively from ```` elements (``web/static/src/webclient/settings_form_view/settings_form_compiler.js``), so the block rendered but the dedicated "GogoCarto" menu entry the 16.0 view provided (``app_settings_block`` with ``data-key``) was gone. Declare a dedicated ```` injected at form level (same pattern as core ``calendar``), which restores the menu entry; the block and its translatable strings are unchanged. The ``base_setup`` dependency is no longer needed and is dropped. Add a regression test asserting the app exists in the combined arch. Verified on a local 18.0 instance: 10 tests, 0 failed, 0 error, and the combined form arch exposes the app at top level. --- partner_gogocarto_export_api/__manifest__.py | 1 - .../tests/__init__.py | 1 + .../tests/test_settings_view.py | 19 +++++++++++ .../views/gogocarto_config_settings_view.xml | 34 +++++++++++-------- 4 files changed, 39 insertions(+), 16 deletions(-) create mode 100644 partner_gogocarto_export_api/tests/test_settings_view.py diff --git a/partner_gogocarto_export_api/__manifest__.py b/partner_gogocarto_export_api/__manifest__.py index fb2411f..a5b9602 100644 --- a/partner_gogocarto_export_api/__manifest__.py +++ b/partner_gogocarto_export_api/__manifest__.py @@ -8,7 +8,6 @@ "version": "18.0.1.0.0", "depends": [ "base", - "base_setup", "contacts", "base_geolocalize", "partner_geolocalize_usability", diff --git a/partner_gogocarto_export_api/tests/__init__.py b/partner_gogocarto_export_api/tests/__init__.py index 1d9df86..abc34a4 100644 --- a/partner_gogocarto_export_api/tests/__init__.py +++ b/partner_gogocarto_export_api/tests/__init__.py @@ -1,2 +1,3 @@ from . import test_controller from . import test_res_partner +from . import test_settings_view diff --git a/partner_gogocarto_export_api/tests/test_settings_view.py b/partner_gogocarto_export_api/tests/test_settings_view.py new file mode 100644 index 0000000..8967794 --- /dev/null +++ b/partner_gogocarto_export_api/tests/test_settings_view.py @@ -0,0 +1,19 @@ +from odoo.tests.common import TransactionCase + + +class TestGogocartoSettingsView(TransactionCase): + """Regression tests of the settings view structure.""" + + def test_settings_menu_entry_exists(self): + """A dedicated ```` must exist so GogoCarto gets its own entry + in the settings side menu: in 18.0 the menu is built exclusively + from ```` elements, blocks buried in another app's tab are + not listed.""" + arch = self.env["res.config.settings"].get_view( + view_id=self.env.ref( + "partner_gogocarto_export_api.res_config_settings_view_form_gogocarto" + ).id, + view_type="form", + )["arch"] + self.assertIn('name="partner_gogocarto_export_api"', arch) + self.assertIn("export_gogocarto_fields", arch) diff --git a/partner_gogocarto_export_api/views/gogocarto_config_settings_view.xml b/partner_gogocarto_export_api/views/gogocarto_config_settings_view.xml index ade85fe..052dbbf 100644 --- a/partner_gogocarto_export_api/views/gogocarto_config_settings_view.xml +++ b/partner_gogocarto_export_api/views/gogocarto_config_settings_view.xml @@ -4,22 +4,26 @@ res.config.settings.view.form.inherit.gogocarto res.config.settings - + - - - -
- Check the export on /web/{COMPANY_ID}/get_http_gogocarto_elements. -
-
- -
-
-
-
+ + + + +
+ Check the export on /web/{COMPANY_ID}/get_http_gogocarto_elements. +
+
+ +
+
+
+
+