From c1d0fd885d4695e6d1a37da7b4558215b5a6edf2 Mon Sep 17 00:00:00 2001 From: Alexis de Lattre Date: Tue, 24 Apr 2018 16:55:30 +0200 Subject: [PATCH] Code clean-up in purchase_auto_invoice_method --- purchase_auto_invoice_method/purchase.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/purchase_auto_invoice_method/purchase.py b/purchase_auto_invoice_method/purchase.py index 2e69e84..7fa03e3 100644 --- a/purchase_auto_invoice_method/purchase.py +++ b/purchase_auto_invoice_method/purchase.py @@ -33,11 +33,7 @@ class purchase_order(orm.Model): def wkf_confirm_order(self, cr, uid, ids, context=None): invoice_method_order_po_ids = [] for po in self.browse(cr, uid, ids, context=context): - service_only = True - for line in po.order_line: - if line.product_id.type != 'service': - service_only = False - if service_only: + if all([l.product_id.type == 'service' for l in po.order_line]): invoice_method_order_po_ids.append(po.id) if invoice_method_order_po_ids: self.write(cr, uid, invoice_method_order_po_ids, {