Mig account_usability, sale_stock_usability, sale_usability, stock_usability

New module stock_account_usability
2019-02-04 20:00:41 +01:00
parent 1a193dcbec
commit 9f1cf7af1e
39 changed files with 210 additions and 432 deletions
--- a/account_usability/init.py
+++ b/account_usability/init.py
@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-
 from . import account
-from . import account_invoice_report
+#from . import account_invoice_report
 from . import partner
 from . import wizard
--- a/account_usability/manifest.py
+++ b/account_usability/manifest.py
@@ -1,5 +1,4 @@
-# -*- coding: utf-8 -*-
-# © 2015-2016 Akretion (http://www.akretion.com)
+# Copyright 2015-2019 Akretion (http://www.akretion.com)
 # @author Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

@@ -40,7 +39,6 @@ This module has been written by Alexis de Lattre from Akretion <alexis.delattre@
        'account_report.xml',
        'account_invoice_report_view.xml',
        'partner_view.xml',
-        'product_view.xml',
        'wizard/account_invoice_mark_sent_view.xml',
        ],
    'installable': True,
--- a/account_usability/account.py
+++ b/account_usability/account.py
@@ -1,5 +1,4 @@
-# -*- coding: utf-8 -*-
-# © 2015-2016 Akretion (http://www.akretion.com)
+# Copyright 2015-2019 Akretion (http://www.akretion.com)
 # @author Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

@@ -27,11 +26,6 @@ class AccountInvoice(models.Model):
    partner_bank_id = fields.Many2one(track_visibility='onchange')
    fiscal_position_id = fields.Many2one(track_visibility='onchange')
    amount_total = fields.Monetary(track_visibility='onchange')
-    # for those fields, the 'account' module sets track_visibility='always':
-    partner_id = fields.Many2one(track_visibility='onchange')
-    currency_id = fields.Many2one(track_visibility='onchange')
-    type = fields.Selection(track_visibility='onchange')
-    amount_untaxed = fields.Monetary(track_visibility='onchange')
    # I want to see the number of cancelled invoice in chatter
    move_id = fields.Many2one(track_visibility='onchange')
    # for invoice report
@@ -75,7 +69,7 @@ class AccountInvoice(models.Model):
                ('res_id', '!=', False)], ['res_id'])
            for att in search_res:
                att_inv_ids[att['res_id']] = True
-        res = [('id', value and 'in' or 'not in', att_inv_ids.keys())]
+        res = [('id', value and 'in' or 'not in', list(att_inv_ids))]
        return res

    # when you have an invoice created from a lot of sale orders, the 'name'
@@ -103,17 +97,18 @@ class AccountInvoice(models.Model):
    #    write a rubbish '/' in it !
    # 2) the 'name' field of the account.move.line is used in the overdue
    # letter, and '/' is not meaningful for our customer !
-    @api.multi
-    def action_move_create(self):
-        res = super(AccountInvoice, self).action_move_create()
-        for inv in self:
-            self._cr.execute(
-                "UPDATE account_move_line SET name= "
-                "CASE WHEN name='/' THEN %s "
-                "ELSE %s||' - '||name END "
-                "WHERE move_id=%s", (inv.number, inv.number, inv.move_id.id))
-            self.invalidate_cache()
-        return res
+# TODO mig to v12
+#    @api.multi
+#    def action_move_create(self):
+#        res = super(AccountInvoice, self).action_move_create()
+#        for inv in self:
+#            self._cr.execute(
+#                "UPDATE account_move_line SET name= "
+#                "CASE WHEN name='/' THEN %s "
+#                "ELSE %s||' - '||name END "
+#                "WHERE move_id=%s", (inv.number, inv.number, inv.move_id.id))
+#            self.invalidate_cache()
+#        return res

    def delete_lines_qty_zero(self):
        lines = self.env['account.invoice.line'].search([
@@ -151,8 +146,7 @@ class AccountInvoiceLine(models.Model):

    # In the 'account' module, we have related stored field for:
    # company_id, partner_id, currency_id
-    invoice_type = fields.Selection(
-        related='invoice_id.type', store=True, readonly=True)
+    invoice_type = fields.Selection(store=True)
    date_invoice = fields.Date(
        related='invoice_id.date_invoice', store=True, readonly=True)
    commercial_partner_id = fields.Many2one(
@@ -187,20 +181,6 @@ class AccountJournal(models.Model):
                res.append((journal.id, name))
            return res

-    # Also search on start of 'code', not only on 'name'
-    @api.model
-    def name_search(
-            self, name='', args=None, operator='ilike', limit=80):
-        if args is None:
-            args = []
-        if name:
-            jrls = self.search(
-                [('code', '=ilike', name + '%')] + args, limit=limit)
-            if jrls:
-                return jrls.name_get()
-        return super(AccountJournal, self).name_search(
-            name=name, args=args, operator=operator, limit=limit)
-
    @api.constrains('default_credit_account_id', 'default_debit_account_id')
    def _check_account_type_on_bank_journal(self):
        bank_acc_type = self.env.ref('account.data_account_type_liquidity')
@@ -230,6 +210,7 @@ class AccountAccount(models.Model):
    _inherit = 'account.account'

    @api.multi
+    @api.depends('name', 'code')
    def name_get(self):
        if self._context.get('account_account_show_code_only'):
            res = []
@@ -240,6 +221,7 @@ class AccountAccount(models.Model):
            return super(AccountAccount, self).name_get()

    # https://github.com/odoo/odoo/issues/23040
+    # TODO mig to v12
    def fix_bank_account_types(self):
        aao = self.env['account.account']
        companies = self.env['res.company'].search([])
@@ -277,6 +259,7 @@ class AccountAccount(models.Model):
        logger.info("END of the script 'fix bank and cash account types'")
        return True

+    # TODO mig to v12
    @api.model
    def create_account_groups(self, level=2, name_prefix=u'Comptes '):
        '''Should be launched by a script. Make sure the account_group module is installed
@@ -379,7 +362,6 @@ class AccountMoveLine(models.Model):

    # Update field only to add a string (there is no string in account module)
    invoice_id = fields.Many2one(string='Invoice')
-    date_maturity = fields.Date(copy=False)
    account_reconcile = fields.Boolean(
        related='account_id.reconcile', readonly=True)
    full_reconcile_id = fields.Many2one(string='Full Reconcile')
@@ -544,7 +526,6 @@ class AccountBankStatementLine(models.Model):
        vals['ref'] = False
        return vals

-    @api.multi
    def show_account_move(self):
        self.ensure_one()
        action = self.env['ir.actions.act_window'].for_xml_id(
@@ -565,8 +546,7 @@ class AccountBankStatementLine(models.Model):
 class AccountFiscalPosition(models.Model):
    _inherit = 'account.fiscal.position'

-    note = fields.Text(translate=True)
-
+    # TODO mig to v12 ?
    @api.model
    def get_fiscal_position_no_partner(
            self, company_id=None, vat_subjected=False, country_id=None):
--- a/account_usability/account_invoice_report.py
+++ b/account_usability/account_invoice_report.py
@@ -1,5 +1,4 @@
-# -*- coding: utf-8 -*-
-# Copyright 2018 Akretion (http://www.akretion.com)
+# Copyright 2018-2019 Akretion (http://www.akretion.com)
 # @author Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

--- a/account_usability/account_invoice_report_view.xml
+++ b/account_usability/account_invoice_report_view.xml
@@ -21,7 +21,7 @@
            <field name="user_id"/>
            <field name="product_id"/>
            <field name="product_qty" sum="1"/>
-            <field name="uom_name" groups="product.group_uom"/>
+            <field name="uom_name" groups="uom.group_uom"/>
            <field name="price_total" sum="1"/>
            <field name="state"/>
        </tree>
--- a/account_usability/account_report.xml
+++ b/account_usability/account_report.xml
@@ -1,15 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  Copyright 2018 Akretion (http://www.akretion.com/)
+  Copyright 2018-2019 Akretion (http://www.akretion.com/)
  @author: Alexis de Lattre <alexis.delattre@akretion.com>
  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->

 <odoo>

-<record id="account.account_invoices" model="ir.actions.report.xml">
+<record id="account.account_invoices" model="ir.actions.report">
    <!-- Don't attach on supplier invoices/refunds ! -->
-    <field name="attachment">(object.type in ('out_invoice', 'out_refund')) and (object.state in ('open','paid')) and ('INV'+(object.number or '').replace('/','')+'.pdf')</field>
+    <field name="attachment">(object.type in ('out_invoice', 'out_refund')) and (object.state in ('open','in_payment','paid')) and ('INV'+(object.number or '').replace('/','')+'.pdf')</field>
 </record>

 </odoo>
--- a/account_usability/account_view.xml
+++ b/account_usability/account_view.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  © 2015-2016 Akretion (http://www.akretion.com/)
+  Copyright 2015-2019 Akretion France (http://www.akretion.com/)
  @author: Alexis de Lattre <alexis.delattre@akretion.com>
  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
@@ -42,12 +42,13 @@
            <field name="base" readonly="1"/>
        </xpath>
        <!-- Warning: there are 2 invoice_print buttons in the native view... probably a bug -->
+        <!--
        <xpath expr="//button[@name='invoice_print']" position="attributes">
            <attribute name="attrs">{'invisible': [('state', 'not in', ('open', 'paid'))]}</attribute>
        </xpath>
        <xpath expr="//button[@name='invoice_print'][2]" position="attributes">
            <attribute name="attrs">{'invisible': True}</attribute>
-        </xpath>
+        </xpath> -->
    </field>
 </record>

@@ -193,17 +194,6 @@ module -->
    <field name="context">{'show_invoice_fields': True}</field>
 </record>

-<record id="view_account_invoice_report_search" model="ir.ui.view">
-    <field name="name">usability.account.invoice.report.search</field>
-    <field name="model">account.invoice.report</field>
-    <field name="inherit_id" ref="account.view_account_invoice_report_search"/>
-    <field name="arch" type="xml">
-        <field name="categ_id" position="after">
-            <field name="product_id"/>
-        </field>
-    </field>
-</record>
-
 <record id="account_invoice_report_tree" model="ir.ui.view">
    <field name="name">usability.account.invoice.report.tree</field>
    <field name="model">account.invoice.report</field>
@@ -272,20 +262,15 @@ module -->
    <field name="context">{'journal_show_code_only': True}</field>
 </record>

-<!-- remove base.group_no_one on Journal Items-->
+<!-- replace group_account_manager on Journal Items-->
 <record id="account.menu_action_account_moves_all" model="ir.ui.menu">
    <field name="groups_id" eval="[(6, 0, [ref('account.group_account_user')])]"/>
 </record>

-<!-- accountant must be able to access the Adviser section ! -->
-<record id="account.menu_finance_entries" model="ir.ui.menu">
-    <field name="groups_id" eval="[(4, ref('account.group_account_user'))]"/>
-</record>
-
 <!-- model account.move / Journal Entries -->
 <record id="account.action_move_journal_line" model="ir.actions.act_window">
    <field name="limit">200</field>
-    <field name="context">{}</field>  <!-- Don't filter by default on misc journal -->
+    <field name="context">{'view_no_maturity': True}</field>  <!-- Don't filter by default on misc journal -->
 </record>

 <record id="view_move_form" model="ir.ui.view">
@@ -293,11 +278,11 @@ module -->
    <field name="model">account.move</field>
    <field name="inherit_id" ref="account.view_move_form"/>
    <field name="arch" type="xml">
-        <field name="ref" position="after">
+        <field name="journal_id" position="after">
            <field name="default_move_line_name"/>
            <field name="default_account_id" invisible="1"/>
-            <field name="default_credit" invisible="0"/>
-            <field name="default_debit" invisible="0"/>
+            <field name="default_credit" invisible="1"/>
+            <field name="default_debit" invisible="1"/>
        </field>
        <xpath expr="//field[@name='line_ids']" position="attributes">
            <attribute name="context" operation="python_dict" key="default_name">default_move_line_name</attribute>
@@ -355,7 +340,7 @@ module -->
            <field name="reconciled" invisible="1"/>
            <button name="open_reconcile_view" class="oe_link" type="object"
                    string="-> View partially reconciled entries" colspan="2"
-                    attrs="{'invisible': ['|', ('full_reconcile_id', '!=', False), '&amp;', ('matched_debit_ids', '=', []),('matched_credit_ids', '=', [])]}"/>
+                    attrs="{'invisible': ['|', ('full_reconcile_id', '!=', False), '&amp;', ('matched_debit_ids', '=', []), ('matched_credit_ids', '=', [])]}"/>
            <span colspan="2" attrs="{'invisible': ['|', '|', ('full_reconcile_id', '!=', False), ('matched_debit_ids', '!=', []), ('matched_credit_ids', '!=', [])]}" class="o_form_field">No Partial Reconcile</span>
        </xpath>
        <xpath expr="//label[@for='full_reconcile_id']/.." position="attributes">
@@ -435,9 +420,6 @@ module -->
    <field name="model">account.bank.statement</field>
    <field name="inherit_id" ref="account.view_bank_statement_form"/>
    <field name="arch" type="xml">
-        <button name="button_cancel" position="attributes">
-            <attribute name="invisible">1</attribute>
-        </button>
        <xpath expr="//field[@name='line_ids']/tree/field[@name='bank_account_id']" position="after">
            <!-- The cancel button is provided by the account_cancel module, but we don't want to depend on it -->
            <button name="show_account_move" type="object"
@@ -481,10 +463,10 @@ module -->
            <field name="start_date"/>
            <field name="end_date"/>
        </field>
-        <filter context="{'group_by': 'date'}" position="attributes">
+        <filter name="date" position="attributes">
            <attribute name="invisible">1</attribute>
        </filter>
-        <filter context="{'group_by': 'date'}" position="after">
+        <filter name="date" position="after">
            <filter name="start_date_groupby" string="Start Date"
                context="{'group_by': 'start_date'}"/>
            <filter name="end_date_groupby" string="End Date"
@@ -534,11 +516,6 @@ because it is useless and confusing -->
    <field name="groups_id" eval="[(6, 0, [ref('base_usability.group_nobody')])]"/>
 </record>

-<!-- Remove menu entry "Accounting > Reports > PDF Reports" as there are broken -->
-<record id="account.menu_finance_legal_statement" model="ir.ui.menu">
-    <field name="groups_id" eval="[(6, 0, [ref('base_usability.group_nobody')])]"/>
-</record>
-
 <!-- Duplicate the menu "Sales > Configuration > Contacts > Bank Accounts"
 under "Accounting > Configuration", because most users will try to find it there -->
 <menuitem id="bank_account_account_config_menu" name="Bank Accounts" parent="account.menu_finance_configuration" sequence="9"/>
--- a/account_usability/partner.py
+++ b/account_usability/partner.py
@@ -1,5 +1,5 @@
-# -*- coding: utf-8 -*-
-# © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# Copyright 2017-2019 Akretion France (https://akretion.com/)
+# @author: Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

 from odoo import models, fields
--- a/account_usability/partner_view.xml
+++ b/account_usability/partner_view.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  © 2017 Akretion (http://www.akretion.com/)
+  Copyright 2017-2019 Akretion (http://www.akretion.com/)
  @author: Alexis de Lattre <alexis.delattre@akretion.com>
  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
@@ -16,9 +16,6 @@
        <field name="property_account_position_id" position="attributes">
            <attribute name="widget">selection</attribute>
        </field>
-        <group name="accounting_entries" position="attributes">
-            <attribute name="groups">account.group_account_user</attribute>
-        </group>
    </field>
 </record>

--- a/account_usability/product_view.xml
+++ b/account_usability/product_view.xml
@@ -1,24 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-  © 2017 Akretion (http://www.akretion.com/)
-  @author: Alexis de Lattre <alexis.delattre@akretion.com>
-  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-->
-
-<odoo>
-
-
-<record id="view_category_property_form" model="ir.ui.view">
-    <field name="name">account_usability.product.category.form</field>
-    <field name="model">product.category</field>
-    <field name="inherit_id" ref="account.view_category_property_form"/>
-    <field name="arch" type="xml">
-        <!-- On product form view, the group for Invoicing tab is limited to account.group_account_invoice... but on product category form, it is limited to account.group_account_manager -> we fix this and also use account.group_account_invoice -->
-        <group name="account_property" position="attributes">
-            <attribute name="groups">account.group_account_invoice</attribute>
-        </group>
-    </field>
-</record>
-
-
-</odoo>
--- a/account_usability/wizard/init.py
+++ b/account_usability/wizard/init.py
@@ -1,4 +1,2 @@
-# -*- encoding: utf-8 -*-
-
 from . import account_invoice_mark_sent
 from . import account_move_reversal
--- a/account_usability/wizard/account_invoice_mark_sent.py
+++ b/account_usability/wizard/account_invoice_mark_sent.py
@@ -1,5 +1,5 @@
-# -*- coding: utf-8 -*-
-# © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# Copyright 2017-2019 Akretion France (https://akretion.com/en)
+# @author: Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

 from odoo import models
--- a/account_usability/wizard/account_invoice_mark_sent_view.xml
+++ b/account_usability/wizard/account_invoice_mark_sent_view.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  Copyright 2017-2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+  Copyright 2017-2019 Akretion France
+  @author: Alexis de Lattre <alexis.delattre@akretion.com>
  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->

@@ -16,7 +17,7 @@
            </p>
            <footer>
                <button type="object" name="run" string="Mark as Sent" class="btn-primary"/>
-                <button special="cancel" string="Cancel" class="oe_link"/>
+                <button special="cancel" string="Cancel"/>
            </footer>
        </form>
    </field>
--- a/account_usability/wizard/account_move_reversal.py
+++ b/account_usability/wizard/account_move_reversal.py
@@ -1,5 +1,5 @@
-# -*- coding: utf-8 -*-
-# Copyright 2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
+# Copyright 2018-2019 Akretion France (https://akretion.com/)
+# @author: Alexis de Lattre <alexis.delattre@akretion.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

 from odoo import api, fields, models