From 7ffadbf2ffa5a2996f2b4ebcaee719b5295db65e Mon Sep 17 00:00:00 2001 From: Valentin Lab Date: Tue, 27 Oct 2026 11:22:32 +0100 Subject: [PATCH] fix: [clickhouse] apply the low-memory settings that ClickHouse was ignoring The ``max_threads``, ``max_block_size``, ``max_download_threads`` and parallel parsing and formatting settings were declared in a ```` block of ``config.d/low-resources.xml``. ClickHouse only reads profile settings from users configuration files, so they were silently ignored and the server used its defaults (one thread per core, larger blocks). Following the Plausible Community Edition change of ``v3.2.0`` (its pull request 265), ``config.d/low-resources.xml`` now keeps only the server setting ``mark_cache_size``, and the profile settings move to ``users.d/default-profile-low-resources-overrides.xml``, inside ````. ``system.settings`` now reports ``max_threads`` 1. Assisted-by: Claude:claude-opus-5-5 --- clickhouse/README.org | 21 ++++++++++++++++- clickhouse/metadata.yml | 3 +++ .../config.d/low-resources.xml | 23 ++----------------- ...efault-profile-low-resources-overrides.xml | 19 +++++++++++++++ 4 files changed, 44 insertions(+), 22 deletions(-) create mode 100644 clickhouse/resources/etc/clickhouse-server/users.d/default-profile-low-resources-overrides.xml diff --git a/clickhouse/README.org b/clickhouse/README.org index 60a5e15..eda0e46 100644 --- a/clickhouse/README.org +++ b/clickhouse/README.org @@ -4,4 +4,23 @@ This charm is provided to work with plausible charm -* Usage \ No newline at end of file +Configuration files come from +https://github.com/plausible/community-edition/ (=clickhouse/=). + +* Usage + +Added automatically by the =plausible= charm (=event-db= relation). + +* Low memory settings + +- =config.d/low-resources.xml=: server settings (=mark_cache_size=). +- =users.d/default-profile-low-resources-overrides.xml=: settings of the + =default= profile (=max_threads= 1, …). ClickHouse reads profiles + only from users configuration files: in =config.d= they were ignored. + +Check that they apply: + +#+begin_src sh +docker exec clickhouse-client -q \ + "SELECT name, value FROM system.settings WHERE name = 'max_threads'" +#+end_src diff --git a/clickhouse/metadata.yml b/clickhouse/metadata.yml index e52a27e..ddacb04 100644 --- a/clickhouse/metadata.yml +++ b/clickhouse/metadata.yml @@ -9,6 +9,9 @@ charm-resources: - /etc/clickhouse-server/config.d/logs.xml - /etc/clickhouse-server/config.d/ipv4-only.xml - /etc/clickhouse-server/config.d/low-resources.xml + ## Profile settings are only read from users.d (they were ignored when + ## they lived in config.d/low-resources.xml). + - /etc/clickhouse-server/users.d/default-profile-low-resources-overrides.xml provides: event-db: diff --git a/clickhouse/resources/etc/clickhouse-server/config.d/low-resources.xml b/clickhouse/resources/etc/clickhouse-server/config.d/low-resources.xml index aab3cd8..7734a62 100644 --- a/clickhouse/resources/etc/clickhouse-server/config.d/low-resources.xml +++ b/clickhouse/resources/etc/clickhouse-server/config.d/low-resources.xml @@ -1,23 +1,4 @@ - - + 524288000 - - - - - 1 - - 8192 - - 1 - - 0 - - 0 - - - \ No newline at end of file + diff --git a/clickhouse/resources/etc/clickhouse-server/users.d/default-profile-low-resources-overrides.xml b/clickhouse/resources/etc/clickhouse-server/users.d/default-profile-low-resources-overrides.xml new file mode 100644 index 0000000..20874e1 --- /dev/null +++ b/clickhouse/resources/etc/clickhouse-server/users.d/default-profile-low-resources-overrides.xml @@ -0,0 +1,19 @@ + + + + + + 1 + + 8192 + + 1 + + 0 + + 0 + + +