From 995d7381c4bd24906332e8f72404458506009f6c Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Thu, 21 Aug 2025 18:07:38 +0200 Subject: [PATCH 1/8] [NEW] account_advanced_protection_features: fusion of both modules account_move_protect_deleting and account_move_protect_reset_to_draft --- .../.gitignore | 0 .../LICENSE | 0 .../README.rst | 19 +- .../__init__.py | 0 .../__manifest__.py | 10 +- .../i18n/fr.po | 14 +- .../models/__init__.py | 0 .../models/account_move.py | 12 +- .../wizard/__init__.py | 0 .../wizard/account_invoice_send.py | 2 +- account_move_protect_deleting/__manifest__.py | 34 - account_move_protect_deleting/i18n/fr.po | 23 - account_move_protect_reset_to_draft/LICENSE | 661 ------------------ .../README.rst | 44 -- .../__init__.py | 2 - .../account_move_protect_reset_to_draft.pot | 41 -- .../models/__init__.py | 1 - .../models/account_move.py | 15 - 18 files changed, 40 insertions(+), 838 deletions(-) rename {account_move_protect_deleting => account_advanced_protection_features}/.gitignore (100%) rename {account_move_protect_deleting => account_advanced_protection_features}/LICENSE (100%) rename {account_move_protect_deleting => account_advanced_protection_features}/README.rst (54%) rename {account_move_protect_deleting => account_advanced_protection_features}/__init__.py (100%) rename {account_move_protect_reset_to_draft => account_advanced_protection_features}/__manifest__.py (77%) rename {account_move_protect_reset_to_draft => account_advanced_protection_features}/i18n/fr.po (77%) rename {account_move_protect_deleting => account_advanced_protection_features}/models/__init__.py (100%) rename {account_move_protect_deleting => account_advanced_protection_features}/models/account_move.py (82%) rename {account_move_protect_reset_to_draft => account_advanced_protection_features}/wizard/__init__.py (100%) rename {account_move_protect_reset_to_draft => account_advanced_protection_features}/wizard/account_invoice_send.py (98%) delete mode 100644 account_move_protect_deleting/__manifest__.py delete mode 100644 account_move_protect_deleting/i18n/fr.po delete mode 100644 account_move_protect_reset_to_draft/LICENSE delete mode 100644 account_move_protect_reset_to_draft/README.rst delete mode 100644 account_move_protect_reset_to_draft/__init__.py delete mode 100644 account_move_protect_reset_to_draft/i18n/account_move_protect_reset_to_draft.pot delete mode 100644 account_move_protect_reset_to_draft/models/__init__.py delete mode 100644 account_move_protect_reset_to_draft/models/account_move.py diff --git a/account_move_protect_deleting/.gitignore b/account_advanced_protection_features/.gitignore similarity index 100% rename from account_move_protect_deleting/.gitignore rename to account_advanced_protection_features/.gitignore diff --git a/account_move_protect_deleting/LICENSE b/account_advanced_protection_features/LICENSE similarity index 100% rename from account_move_protect_deleting/LICENSE rename to account_advanced_protection_features/LICENSE diff --git a/account_move_protect_deleting/README.rst b/account_advanced_protection_features/README.rst similarity index 54% rename from account_move_protect_deleting/README.rst rename to account_advanced_protection_features/README.rst index 8d14f45..9cef227 100644 --- a/account_move_protect_deleting/README.rst +++ b/account_advanced_protection_features/README.rst @@ -1,14 +1,16 @@ -=============== -account_move_protect_deleting -=============== +==================================== +account_advanced_protection_features +==================================== -Forbid to delete an invoice that has been already validated +This module adds several protection features about accounting : +* Forbid to delete an invoice that has already been validated +* Forbid to reset to draft an invoice that has already been sent by email Installation ============ Use Odoo normal module installation procedure to install -``account_move_protect_deleting``. +``account_advanced_protection_features``. Known issues / Roadmap ====================== @@ -18,7 +20,7 @@ None yet. Bug Tracker =========== -Bugs are tracked on `our issues website `_. In case of +Bugs are tracked on `our issues website `_. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us smashing it by providing a detailed and welcomed feedback. @@ -30,6 +32,9 @@ Contributors ------------ * Boris Gallet - `Email` - `Github` +* Clément Thomas +* Quentin Mondot - `Email` - `Github` + Funders ------- @@ -41,4 +46,4 @@ The development of this module has been financially supported by: Maintainer ---------- -This module is maintained by Elabore. \ No newline at end of file +This module is maintained by Elabore. diff --git a/account_move_protect_deleting/__init__.py b/account_advanced_protection_features/__init__.py similarity index 100% rename from account_move_protect_deleting/__init__.py rename to account_advanced_protection_features/__init__.py diff --git a/account_move_protect_reset_to_draft/__manifest__.py b/account_advanced_protection_features/__manifest__.py similarity index 77% rename from account_move_protect_reset_to_draft/__manifest__.py rename to account_advanced_protection_features/__manifest__.py index ec21afa..e8f24f7 100644 --- a/account_move_protect_reset_to_draft/__manifest__.py +++ b/account_advanced_protection_features/__manifest__.py @@ -1,15 +1,15 @@ -# Copyright 2024 Boris Gallet () +# Copyright 2025 Boris Gallet, Clément Thomas, Quentin Mondot # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). { - "name": "account_move_protect_reset_to_draft", + "name": "account_advanced_protection_features", "version": "16.0.1.0.0", "author": "Elabore", "website": "https://elabore.coop", - "maintainer": "Clément Thomas", + "maintainer": "Quentin Mondot", "license": "AGPL-3", "category": "Tools", - "summary": "prohibits re-draft an invoice that has been sent by email", + "summary": "Add several protection features about accounting", # any module necessary for this one to work correctly "depends": [ "base", @@ -31,4 +31,4 @@ # and independently installed. Used for synergetic or glue modules. "auto_install": False, "application": False, -} \ No newline at end of file +} diff --git a/account_move_protect_reset_to_draft/i18n/fr.po b/account_advanced_protection_features/i18n/fr.po similarity index 77% rename from account_move_protect_reset_to_draft/i18n/fr.po rename to account_advanced_protection_features/i18n/fr.po index b0a48cc..0def132 100644 --- a/account_move_protect_reset_to_draft/i18n/fr.po +++ b/account_advanced_protection_features/i18n/fr.po @@ -1,13 +1,13 @@ # Translation of Odoo Server. # This file contains the translation of the following modules: -# * account_move_protect_reset_to_draft +# * account_advanced_protection_features # msgid "" msgstr "" "Project-Id-Version: Odoo Server 16.0\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2024-10-14 14:53+0000\n" -"PO-Revision-Date: 2025-06-06 15:47+0200\n" +"POT-Creation-Date: 2024-03-26 13:13+0000\n" +"PO-Revision-Date: 2024-03-26 13:13+0000\n" "Last-Translator: \n" "Language-Team: \n" "MIME-Version: 1.0\n" @@ -15,6 +15,14 @@ msgstr "" "Content-Transfer-Encoding: \n" "Plural-Forms: \n" +#. module: account_move_protect_deleting +#. odoo-python +#: code:addons/account_move_protect_deleting/models/account_move.py:0 +#, python-format +msgid "You cannot delete this account move because it has been posted." +msgstr "Vous ne pouvez pas supprimer cette pièce comptable car elle à déjà été confirmée." + + #. module: account_move_protect_reset_to_draft #: model:ir.model,name:account_move_protect_reset_to_draft.model_account_invoice_send msgid "Account Invoice Send" diff --git a/account_move_protect_deleting/models/__init__.py b/account_advanced_protection_features/models/__init__.py similarity index 100% rename from account_move_protect_deleting/models/__init__.py rename to account_advanced_protection_features/models/__init__.py diff --git a/account_move_protect_deleting/models/account_move.py b/account_advanced_protection_features/models/account_move.py similarity index 82% rename from account_move_protect_deleting/models/account_move.py rename to account_advanced_protection_features/models/account_move.py index af3601d..3e5d722 100644 --- a/account_move_protect_deleting/models/account_move.py +++ b/account_advanced_protection_features/models/account_move.py @@ -1,9 +1,19 @@ -from odoo import models, api, _ +from odoo import models, api, fields, _ from odoo.exceptions import UserError class AccountMove(models.Model): _inherit = 'account.move' + sent_by_email = fields.Boolean() + + def button_draft(self): + res = super(AccountMove, self).button_draft() + if self.sent_by_email: + raise UserError(_( + "You cannot reset to draft this invoice because it has been sent by email." + )) + return res + @api.ondelete(at_uninstall=False) def _check_posted(self): """ Prevent deletion of a account move if it has been posted diff --git a/account_move_protect_reset_to_draft/wizard/__init__.py b/account_advanced_protection_features/wizard/__init__.py similarity index 100% rename from account_move_protect_reset_to_draft/wizard/__init__.py rename to account_advanced_protection_features/wizard/__init__.py diff --git a/account_move_protect_reset_to_draft/wizard/account_invoice_send.py b/account_advanced_protection_features/wizard/account_invoice_send.py similarity index 98% rename from account_move_protect_reset_to_draft/wizard/account_invoice_send.py rename to account_advanced_protection_features/wizard/account_invoice_send.py index e0cec21..8724798 100644 --- a/account_move_protect_reset_to_draft/wizard/account_invoice_send.py +++ b/account_advanced_protection_features/wizard/account_invoice_send.py @@ -11,4 +11,4 @@ class AccountInvoiceSend(models.TransientModel): move = self.env[self.model].browse(self.res_id) move.sent_by_email = True - return super(AccountInvoiceSend, self).send_and_print_action() \ No newline at end of file + return super(AccountInvoiceSend, self).send_and_print_action() diff --git a/account_move_protect_deleting/__manifest__.py b/account_move_protect_deleting/__manifest__.py deleted file mode 100644 index 030ac76..0000000 --- a/account_move_protect_deleting/__manifest__.py +++ /dev/null @@ -1,34 +0,0 @@ -# Copyright 2024 Boris Gallet () -# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). - -{ - "name": "account_move_protect_deleting", - "version": "16.0.1.0.2", - "author": "Elabore", - "website": "https://elabore.coop", - "maintainer": "Boris Gallet", - "license": "AGPL-3", - "category": "Tools", - "summary": "Forbid to delete an account move that has already been posted", - # any module necessary for this one to work correctly - "depends": [ - "base", - "account" - ], - "qweb": [], - "external_dependencies": { - "python": [], - }, - # always loaded - "data": [ - ], - # only loaded in demonstration mode - "demo": [], - "js": [], - "css": [], - "installable": True, - # Install this module automatically if all dependency have been previously - # and independently installed. Used for synergetic or glue modules. - "auto_install": False, - "application": False, -} \ No newline at end of file diff --git a/account_move_protect_deleting/i18n/fr.po b/account_move_protect_deleting/i18n/fr.po deleted file mode 100644 index 56fb9a8..0000000 --- a/account_move_protect_deleting/i18n/fr.po +++ /dev/null @@ -1,23 +0,0 @@ -# Translation of Odoo Server. -# This file contains the translation of the following modules: -# * account_move_protect_deleting -# -msgid "" -msgstr "" -"Project-Id-Version: Odoo Server 16.0\n" -"Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2024-03-26 13:13+0000\n" -"PO-Revision-Date: 2024-03-26 13:13+0000\n" -"Last-Translator: \n" -"Language-Team: \n" -"MIME-Version: 1.0\n" -"Content-Type: text/plain; charset=UTF-8\n" -"Content-Transfer-Encoding: \n" -"Plural-Forms: \n" - -#. module: account_move_protect_deleting -#. odoo-python -#: code:addons/account_move_protect_deleting/models/account_move.py:0 -#, python-format -msgid "You cannot delete this account move because it has been posted." -msgstr "Vous ne pouvez pas supprimer cette pièce comptable car elle à déjà été confirmée." \ No newline at end of file diff --git a/account_move_protect_reset_to_draft/LICENSE b/account_move_protect_reset_to_draft/LICENSE deleted file mode 100644 index 0ad25db..0000000 --- a/account_move_protect_reset_to_draft/LICENSE +++ /dev/null @@ -1,661 +0,0 @@ - GNU AFFERO GENERAL PUBLIC LICENSE - Version 3, 19 November 2007 - - Copyright (C) 2007 Free Software Foundation, Inc. - Everyone is permitted to copy and distribute verbatim copies - of this license document, but changing it is not allowed. - - Preamble - - The GNU Affero General Public License is a free, copyleft license for -software and other kinds of works, specifically designed to ensure -cooperation with the community in the case of network server software. - - The licenses for most software and other practical works are designed -to take away your freedom to share and change the works. By contrast, -our General Public Licenses are intended to guarantee your freedom to -share and change all versions of a program--to make sure it remains free -software for all its users. - - When we speak of free software, we are referring to freedom, not -price. Our General Public Licenses are designed to make sure that you -have the freedom to distribute copies of free software (and charge for -them if you wish), that you receive source code or can get it if you -want it, that you can change the software or use pieces of it in new -free programs, and that you know you can do these things. - - Developers that use our General Public Licenses protect your rights -with two steps: (1) assert copyright on the software, and (2) offer -you this License which gives you legal permission to copy, distribute -and/or modify the software. - - A secondary benefit of defending all users' freedom is that -improvements made in alternate versions of the program, if they -receive widespread use, become available for other developers to -incorporate. Many developers of free software are heartened and -encouraged by the resulting cooperation. However, in the case of -software used on network servers, this result may fail to come about. -The GNU General Public License permits making a modified version and -letting the public access it on a server without ever releasing its -source code to the public. - - The GNU Affero General Public License is designed specifically to -ensure that, in such cases, the modified source code becomes available -to the community. It requires the operator of a network server to -provide the source code of the modified version running there to the -users of that server. Therefore, public use of a modified version, on -a publicly accessible server, gives the public access to the source -code of the modified version. - - An older license, called the Affero General Public License and -published by Affero, was designed to accomplish similar goals. This is -a different license, not a version of the Affero GPL, but Affero has -released a new version of the Affero GPL which permits relicensing under -this license. - - The precise terms and conditions for copying, distribution and -modification follow. - - TERMS AND CONDITIONS - - 0. Definitions. - - "This License" refers to version 3 of the GNU Affero General Public License. - - "Copyright" also means copyright-like laws that apply to other kinds of -works, such as semiconductor masks. - - "The Program" refers to any copyrightable work licensed under this -License. Each licensee is addressed as "you". "Licensees" and -"recipients" may be individuals or organizations. - - To "modify" a work means to copy from or adapt all or part of the work -in a fashion requiring copyright permission, other than the making of an -exact copy. The resulting work is called a "modified version" of the -earlier work or a work "based on" the earlier work. - - A "covered work" means either the unmodified Program or a work based -on the Program. - - To "propagate" a work means to do anything with it that, without -permission, would make you directly or secondarily liable for -infringement under applicable copyright law, except executing it on a -computer or modifying a private copy. Propagation includes copying, -distribution (with or without modification), making available to the -public, and in some countries other activities as well. - - To "convey" a work means any kind of propagation that enables other -parties to make or receive copies. Mere interaction with a user through -a computer network, with no transfer of a copy, is not conveying. - - An interactive user interface displays "Appropriate Legal Notices" -to the extent that it includes a convenient and prominently visible -feature that (1) displays an appropriate copyright notice, and (2) -tells the user that there is no warranty for the work (except to the -extent that warranties are provided), that licensees may convey the -work under this License, and how to view a copy of this License. If -the interface presents a list of user commands or options, such as a -menu, a prominent item in the list meets this criterion. - - 1. Source Code. - - The "source code" for a work means the preferred form of the work -for making modifications to it. "Object code" means any non-source -form of a work. - - A "Standard Interface" means an interface that either is an official -standard defined by a recognized standards body, or, in the case of -interfaces specified for a particular programming language, one that -is widely used among developers working in that language. - - The "System Libraries" of an executable work include anything, other -than the work as a whole, that (a) is included in the normal form of -packaging a Major Component, but which is not part of that Major -Component, and (b) serves only to enable use of the work with that -Major Component, or to implement a Standard Interface for which an -implementation is available to the public in source code form. A -"Major Component", in this context, means a major essential component -(kernel, window system, and so on) of the specific operating system -(if any) on which the executable work runs, or a compiler used to -produce the work, or an object code interpreter used to run it. - - The "Corresponding Source" for a work in object code form means all -the source code needed to generate, install, and (for an executable -work) run the object code and to modify the work, including scripts to -control those activities. However, it does not include the work's -System Libraries, or general-purpose tools or generally available free -programs which are used unmodified in performing those activities but -which are not part of the work. For example, Corresponding Source -includes interface definition files associated with source files for -the work, and the source code for shared libraries and dynamically -linked subprograms that the work is specifically designed to require, -such as by intimate data communication or control flow between those -subprograms and other parts of the work. - - The Corresponding Source need not include anything that users -can regenerate automatically from other parts of the Corresponding -Source. - - The Corresponding Source for a work in source code form is that -same work. - - 2. Basic Permissions. - - All rights granted under this License are granted for the term of -copyright on the Program, and are irrevocable provided the stated -conditions are met. This License explicitly affirms your unlimited -permission to run the unmodified Program. The output from running a -covered work is covered by this License only if the output, given its -content, constitutes a covered work. This License acknowledges your -rights of fair use or other equivalent, as provided by copyright law. - - You may make, run and propagate covered works that you do not -convey, without conditions so long as your license otherwise remains -in force. You may convey covered works to others for the sole purpose -of having them make modifications exclusively for you, or provide you -with facilities for running those works, provided that you comply with -the terms of this License in conveying all material for which you do -not control copyright. Those thus making or running the covered works -for you must do so exclusively on your behalf, under your direction -and control, on terms that prohibit them from making any copies of -your copyrighted material outside their relationship with you. - - Conveying under any other circumstances is permitted solely under -the conditions stated below. Sublicensing is not allowed; section 10 -makes it unnecessary. - - 3. Protecting Users' Legal Rights From Anti-Circumvention Law. - - No covered work shall be deemed part of an effective technological -measure under any applicable law fulfilling obligations under article -11 of the WIPO copyright treaty adopted on 20 December 1996, or -similar laws prohibiting or restricting circumvention of such -measures. - - When you convey a covered work, you waive any legal power to forbid -circumvention of technological measures to the extent such circumvention -is effected by exercising rights under this License with respect to -the covered work, and you disclaim any intention to limit operation or -modification of the work as a means of enforcing, against the work's -users, your or third parties' legal rights to forbid circumvention of -technological measures. - - 4. Conveying Verbatim Copies. - - You may convey verbatim copies of the Program's source code as you -receive it, in any medium, provided that you conspicuously and -appropriately publish on each copy an appropriate copyright notice; -keep intact all notices stating that this License and any -non-permissive terms added in accord with section 7 apply to the code; -keep intact all notices of the absence of any warranty; and give all -recipients a copy of this License along with the Program. - - You may charge any price or no price for each copy that you convey, -and you may offer support or warranty protection for a fee. - - 5. Conveying Modified Source Versions. - - You may convey a work based on the Program, or the modifications to -produce it from the Program, in the form of source code under the -terms of section 4, provided that you also meet all of these conditions: - - a) The work must carry prominent notices stating that you modified - it, and giving a relevant date. - - b) The work must carry prominent notices stating that it is - released under this License and any conditions added under section - 7. This requirement modifies the requirement in section 4 to - "keep intact all notices". - - c) You must license the entire work, as a whole, under this - License to anyone who comes into possession of a copy. This - License will therefore apply, along with any applicable section 7 - additional terms, to the whole of the work, and all its parts, - regardless of how they are packaged. This License gives no - permission to license the work in any other way, but it does not - invalidate such permission if you have separately received it. - - d) If the work has interactive user interfaces, each must display - Appropriate Legal Notices; however, if the Program has interactive - interfaces that do not display Appropriate Legal Notices, your - work need not make them do so. - - A compilation of a covered work with other separate and independent -works, which are not by their nature extensions of the covered work, -and which are not combined with it such as to form a larger program, -in or on a volume of a storage or distribution medium, is called an -"aggregate" if the compilation and its resulting copyright are not -used to limit the access or legal rights of the compilation's users -beyond what the individual works permit. Inclusion of a covered work -in an aggregate does not cause this License to apply to the other -parts of the aggregate. - - 6. Conveying Non-Source Forms. - - You may convey a covered work in object code form under the terms -of sections 4 and 5, provided that you also convey the -machine-readable Corresponding Source under the terms of this License, -in one of these ways: - - a) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by the - Corresponding Source fixed on a durable physical medium - customarily used for software interchange. - - b) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by a - written offer, valid for at least three years and valid for as - long as you offer spare parts or customer support for that product - model, to give anyone who possesses the object code either (1) a - copy of the Corresponding Source for all the software in the - product that is covered by this License, on a durable physical - medium customarily used for software interchange, for a price no - more than your reasonable cost of physically performing this - conveying of source, or (2) access to copy the - Corresponding Source from a network server at no charge. - - c) Convey individual copies of the object code with a copy of the - written offer to provide the Corresponding Source. This - alternative is allowed only occasionally and noncommercially, and - only if you received the object code with such an offer, in accord - with subsection 6b. - - d) Convey the object code by offering access from a designated - place (gratis or for a charge), and offer equivalent access to the - Corresponding Source in the same way through the same place at no - further charge. You need not require recipients to copy the - Corresponding Source along with the object code. If the place to - copy the object code is a network server, the Corresponding Source - may be on a different server (operated by you or a third party) - that supports equivalent copying facilities, provided you maintain - clear directions next to the object code saying where to find the - Corresponding Source. Regardless of what server hosts the - Corresponding Source, you remain obligated to ensure that it is - available for as long as needed to satisfy these requirements. - - e) Convey the object code using peer-to-peer transmission, provided - you inform other peers where the object code and Corresponding - Source of the work are being offered to the general public at no - charge under subsection 6d. - - A separable portion of the object code, whose source code is excluded -from the Corresponding Source as a System Library, need not be -included in conveying the object code work. - - A "User Product" is either (1) a "consumer product", which means any -tangible personal property which is normally used for personal, family, -or household purposes, or (2) anything designed or sold for incorporation -into a dwelling. In determining whether a product is a consumer product, -doubtful cases shall be resolved in favor of coverage. For a particular -product received by a particular user, "normally used" refers to a -typical or common use of that class of product, regardless of the status -of the particular user or of the way in which the particular user -actually uses, or expects or is expected to use, the product. A product -is a consumer product regardless of whether the product has substantial -commercial, industrial or non-consumer uses, unless such uses represent -the only significant mode of use of the product. - - "Installation Information" for a User Product means any methods, -procedures, authorization keys, or other information required to install -and execute modified versions of a covered work in that User Product from -a modified version of its Corresponding Source. The information must -suffice to ensure that the continued functioning of the modified object -code is in no case prevented or interfered with solely because -modification has been made. - - If you convey an object code work under this section in, or with, or -specifically for use in, a User Product, and the conveying occurs as -part of a transaction in which the right of possession and use of the -User Product is transferred to the recipient in perpetuity or for a -fixed term (regardless of how the transaction is characterized), the -Corresponding Source conveyed under this section must be accompanied -by the Installation Information. But this requirement does not apply -if neither you nor any third party retains the ability to install -modified object code on the User Product (for example, the work has -been installed in ROM). - - The requirement to provide Installation Information does not include a -requirement to continue to provide support service, warranty, or updates -for a work that has been modified or installed by the recipient, or for -the User Product in which it has been modified or installed. Access to a -network may be denied when the modification itself materially and -adversely affects the operation of the network or violates the rules and -protocols for communication across the network. - - Corresponding Source conveyed, and Installation Information provided, -in accord with this section must be in a format that is publicly -documented (and with an implementation available to the public in -source code form), and must require no special password or key for -unpacking, reading or copying. - - 7. Additional Terms. - - "Additional permissions" are terms that supplement the terms of this -License by making exceptions from one or more of its conditions. -Additional permissions that are applicable to the entire Program shall -be treated as though they were included in this License, to the extent -that they are valid under applicable law. If additional permissions -apply only to part of the Program, that part may be used separately -under those permissions, but the entire Program remains governed by -this License without regard to the additional permissions. - - When you convey a copy of a covered work, you may at your option -remove any additional permissions from that copy, or from any part of -it. (Additional permissions may be written to require their own -removal in certain cases when you modify the work.) You may place -additional permissions on material, added by you to a covered work, -for which you have or can give appropriate copyright permission. - - Notwithstanding any other provision of this License, for material you -add to a covered work, you may (if authorized by the copyright holders of -that material) supplement the terms of this License with terms: - - a) Disclaiming warranty or limiting liability differently from the - terms of sections 15 and 16 of this License; or - - b) Requiring preservation of specified reasonable legal notices or - author attributions in that material or in the Appropriate Legal - Notices displayed by works containing it; or - - c) Prohibiting misrepresentation of the origin of that material, or - requiring that modified versions of such material be marked in - reasonable ways as different from the original version; or - - d) Limiting the use for publicity purposes of names of licensors or - authors of the material; or - - e) Declining to grant rights under trademark law for use of some - trade names, trademarks, or service marks; or - - f) Requiring indemnification of licensors and authors of that - material by anyone who conveys the material (or modified versions of - it) with contractual assumptions of liability to the recipient, for - any liability that these contractual assumptions directly impose on - those licensors and authors. - - All other non-permissive additional terms are considered "further -restrictions" within the meaning of section 10. If the Program as you -received it, or any part of it, contains a notice stating that it is -governed by this License along with a term that is a further -restriction, you may remove that term. If a license document contains -a further restriction but permits relicensing or conveying under this -License, you may add to a covered work material governed by the terms -of that license document, provided that the further restriction does -not survive such relicensing or conveying. - - If you add terms to a covered work in accord with this section, you -must place, in the relevant source files, a statement of the -additional terms that apply to those files, or a notice indicating -where to find the applicable terms. - - Additional terms, permissive or non-permissive, may be stated in the -form of a separately written license, or stated as exceptions; -the above requirements apply either way. - - 8. Termination. - - You may not propagate or modify a covered work except as expressly -provided under this License. Any attempt otherwise to propagate or -modify it is void, and will automatically terminate your rights under -this License (including any patent licenses granted under the third -paragraph of section 11). - - However, if you cease all violation of this License, then your -license from a particular copyright holder is reinstated (a) -provisionally, unless and until the copyright holder explicitly and -finally terminates your license, and (b) permanently, if the copyright -holder fails to notify you of the violation by some reasonable means -prior to 60 days after the cessation. - - Moreover, your license from a particular copyright holder is -reinstated permanently if the copyright holder notifies you of the -violation by some reasonable means, this is the first time you have -received notice of violation of this License (for any work) from that -copyright holder, and you cure the violation prior to 30 days after -your receipt of the notice. - - Termination of your rights under this section does not terminate the -licenses of parties who have received copies or rights from you under -this License. If your rights have been terminated and not permanently -reinstated, you do not qualify to receive new licenses for the same -material under section 10. - - 9. Acceptance Not Required for Having Copies. - - You are not required to accept this License in order to receive or -run a copy of the Program. Ancillary propagation of a covered work -occurring solely as a consequence of using peer-to-peer transmission -to receive a copy likewise does not require acceptance. However, -nothing other than this License grants you permission to propagate or -modify any covered work. These actions infringe copyright if you do -not accept this License. Therefore, by modifying or propagating a -covered work, you indicate your acceptance of this License to do so. - - 10. Automatic Licensing of Downstream Recipients. - - Each time you convey a covered work, the recipient automatically -receives a license from the original licensors, to run, modify and -propagate that work, subject to this License. You are not responsible -for enforcing compliance by third parties with this License. - - An "entity transaction" is a transaction transferring control of an -organization, or substantially all assets of one, or subdividing an -organization, or merging organizations. If propagation of a covered -work results from an entity transaction, each party to that -transaction who receives a copy of the work also receives whatever -licenses to the work the party's predecessor in interest had or could -give under the previous paragraph, plus a right to possession of the -Corresponding Source of the work from the predecessor in interest, if -the predecessor has it or can get it with reasonable efforts. - - You may not impose any further restrictions on the exercise of the -rights granted or affirmed under this License. For example, you may -not impose a license fee, royalty, or other charge for exercise of -rights granted under this License, and you may not initiate litigation -(including a cross-claim or counterclaim in a lawsuit) alleging that -any patent claim is infringed by making, using, selling, offering for -sale, or importing the Program or any portion of it. - - 11. Patents. - - A "contributor" is a copyright holder who authorizes use under this -License of the Program or a work on which the Program is based. The -work thus licensed is called the contributor's "contributor version". - - A contributor's "essential patent claims" are all patent claims -owned or controlled by the contributor, whether already acquired or -hereafter acquired, that would be infringed by some manner, permitted -by this License, of making, using, or selling its contributor version, -but do not include claims that would be infringed only as a -consequence of further modification of the contributor version. For -purposes of this definition, "control" includes the right to grant -patent sublicenses in a manner consistent with the requirements of -this License. - - Each contributor grants you a non-exclusive, worldwide, royalty-free -patent license under the contributor's essential patent claims, to -make, use, sell, offer for sale, import and otherwise run, modify and -propagate the contents of its contributor version. - - In the following three paragraphs, a "patent license" is any express -agreement or commitment, however denominated, not to enforce a patent -(such as an express permission to practice a patent or covenant not to -sue for patent infringement). To "grant" such a patent license to a -party means to make such an agreement or commitment not to enforce a -patent against the party. - - If you convey a covered work, knowingly relying on a patent license, -and the Corresponding Source of the work is not available for anyone -to copy, free of charge and under the terms of this License, through a -publicly available network server or other readily accessible means, -then you must either (1) cause the Corresponding Source to be so -available, or (2) arrange to deprive yourself of the benefit of the -patent license for this particular work, or (3) arrange, in a manner -consistent with the requirements of this License, to extend the patent -license to downstream recipients. "Knowingly relying" means you have -actual knowledge that, but for the patent license, your conveying the -covered work in a country, or your recipient's use of the covered work -in a country, would infringe one or more identifiable patents in that -country that you have reason to believe are valid. - - If, pursuant to or in connection with a single transaction or -arrangement, you convey, or propagate by procuring conveyance of, a -covered work, and grant a patent license to some of the parties -receiving the covered work authorizing them to use, propagate, modify -or convey a specific copy of the covered work, then the patent license -you grant is automatically extended to all recipients of the covered -work and works based on it. - - A patent license is "discriminatory" if it does not include within -the scope of its coverage, prohibits the exercise of, or is -conditioned on the non-exercise of one or more of the rights that are -specifically granted under this License. You may not convey a covered -work if you are a party to an arrangement with a third party that is -in the business of distributing software, under which you make payment -to the third party based on the extent of your activity of conveying -the work, and under which the third party grants, to any of the -parties who would receive the covered work from you, a discriminatory -patent license (a) in connection with copies of the covered work -conveyed by you (or copies made from those copies), or (b) primarily -for and in connection with specific products or compilations that -contain the covered work, unless you entered into that arrangement, -or that patent license was granted, prior to 28 March 2007. - - Nothing in this License shall be construed as excluding or limiting -any implied license or other defenses to infringement that may -otherwise be available to you under applicable patent law. - - 12. No Surrender of Others' Freedom. - - If conditions are imposed on you (whether by court order, agreement or -otherwise) that contradict the conditions of this License, they do not -excuse you from the conditions of this License. If you cannot convey a -covered work so as to satisfy simultaneously your obligations under this -License and any other pertinent obligations, then as a consequence you may -not convey it at all. For example, if you agree to terms that obligate you -to collect a royalty for further conveying from those to whom you convey -the Program, the only way you could satisfy both those terms and this -License would be to refrain entirely from conveying the Program. - - 13. Remote Network Interaction; Use with the GNU General Public License. - - Notwithstanding any other provision of this License, if you modify the -Program, your modified version must prominently offer all users -interacting with it remotely through a computer network (if your version -supports such interaction) an opportunity to receive the Corresponding -Source of your version by providing access to the Corresponding Source -from a network server at no charge, through some standard or customary -means of facilitating copying of software. This Corresponding Source -shall include the Corresponding Source for any work covered by version 3 -of the GNU General Public License that is incorporated pursuant to the -following paragraph. - - Notwithstanding any other provision of this License, you have -permission to link or combine any covered work with a work licensed -under version 3 of the GNU General Public License into a single -combined work, and to convey the resulting work. The terms of this -License will continue to apply to the part which is the covered work, -but the work with which it is combined will remain governed by version -3 of the GNU General Public License. - - 14. Revised Versions of this License. - - The Free Software Foundation may publish revised and/or new versions of -the GNU Affero General Public License from time to time. Such new versions -will be similar in spirit to the present version, but may differ in detail to -address new problems or concerns. - - Each version is given a distinguishing version number. If the -Program specifies that a certain numbered version of the GNU Affero General -Public License "or any later version" applies to it, you have the -option of following the terms and conditions either of that numbered -version or of any later version published by the Free Software -Foundation. If the Program does not specify a version number of the -GNU Affero General Public License, you may choose any version ever published -by the Free Software Foundation. - - If the Program specifies that a proxy can decide which future -versions of the GNU Affero General Public License can be used, that proxy's -public statement of acceptance of a version permanently authorizes you -to choose that version for the Program. - - Later license versions may give you additional or different -permissions. However, no additional obligations are imposed on any -author or copyright holder as a result of your choosing to follow a -later version. - - 15. Disclaimer of Warranty. - - THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY -APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT -HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY -OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, -THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM -IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF -ALL NECESSARY SERVICING, REPAIR OR CORRECTION. - - 16. Limitation of Liability. - - IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING -WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS -THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY -GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE -USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF -DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD -PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), -EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF -SUCH DAMAGES. - - 17. Interpretation of Sections 15 and 16. - - If the disclaimer of warranty and limitation of liability provided -above cannot be given local legal effect according to their terms, -reviewing courts shall apply local law that most closely approximates -an absolute waiver of all civil liability in connection with the -Program, unless a warranty or assumption of liability accompanies a -copy of the Program in return for a fee. - - END OF TERMS AND CONDITIONS - - How to Apply These Terms to Your New Programs - - If you develop a new program, and you want it to be of the greatest -possible use to the public, the best way to achieve this is to make it -free software which everyone can redistribute and change under these terms. - - To do so, attach the following notices to the program. It is safest -to attach them to the start of each source file to most effectively -state the exclusion of warranty; and each file should have at least -the "copyright" line and a pointer to where the full notice is found. - - - Copyright (C) - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published - by the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -Also add information on how to contact you by electronic and paper mail. - - If your software can interact with users remotely through a computer -network, you should also make sure that it provides a way for users to -get its source. For example, if your program is a web application, its -interface could display a "Source" link that leads users to an archive -of the code. There are many ways you could offer source, and different -solutions will be better for different programs; see section 13 for the -specific requirements. - - You should also get your employer (if you work as a programmer) or school, -if any, to sign a "copyright disclaimer" for the program, if necessary. -For more information on this, and how to apply and follow the GNU AGPL, see -. diff --git a/account_move_protect_reset_to_draft/README.rst b/account_move_protect_reset_to_draft/README.rst deleted file mode 100644 index abd1aa7..0000000 --- a/account_move_protect_reset_to_draft/README.rst +++ /dev/null @@ -1,44 +0,0 @@ -=============== -account_move_protect_reset_to_draft -=============== - -Forbid to delete an invoice that has been already validated - -Installation -============ - -Use Odoo normal module installation procedure to install -``account_move_protect_reset_to_draft``. - -Known issues / Roadmap -====================== - -None yet. - -Bug Tracker -=========== - -Bugs are tracked on `our issues website `_. In case of -trouble, please check there if your issue has already been -reported. If you spotted it first, help us smashing it by providing a -detailed and welcomed feedback. - -Credits -======= - -Contributors ------------- - -* Clément Thomas - -Funders -------- - -The development of this module has been financially supported by: -* Elabore (https://elabore.coop) - - -Maintainer ----------- - -This module is maintained by Elabore. \ No newline at end of file diff --git a/account_move_protect_reset_to_draft/__init__.py b/account_move_protect_reset_to_draft/__init__.py deleted file mode 100644 index c536983..0000000 --- a/account_move_protect_reset_to_draft/__init__.py +++ /dev/null @@ -1,2 +0,0 @@ -from . import models -from . import wizard \ No newline at end of file diff --git a/account_move_protect_reset_to_draft/i18n/account_move_protect_reset_to_draft.pot b/account_move_protect_reset_to_draft/i18n/account_move_protect_reset_to_draft.pot deleted file mode 100644 index c966883..0000000 --- a/account_move_protect_reset_to_draft/i18n/account_move_protect_reset_to_draft.pot +++ /dev/null @@ -1,41 +0,0 @@ -# Translation of Odoo Server. -# This file contains the translation of the following modules: -# * account_move_protect_reset_to_draft -# -msgid "" -msgstr "" -"Project-Id-Version: Odoo Server 16.0\n" -"Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2024-10-14 14:52+0000\n" -"PO-Revision-Date: 2024-10-14 14:52+0000\n" -"Last-Translator: \n" -"Language-Team: \n" -"MIME-Version: 1.0\n" -"Content-Type: text/plain; charset=UTF-8\n" -"Content-Transfer-Encoding: \n" -"Plural-Forms: \n" - -#. module: account_move_protect_reset_to_draft -#: model:ir.model,name:account_move_protect_reset_to_draft.model_account_invoice_send -msgid "Account Invoice Send" -msgstr "" - -#. module: account_move_protect_reset_to_draft -#: model:ir.model,name:account_move_protect_reset_to_draft.model_account_move -msgid "Journal Entry" -msgstr "" - -#. module: account_move_protect_reset_to_draft -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_bank_statement_line__sent_by_email -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_move__sent_by_email -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_payment__sent_by_email -msgid "Sent By Email" -msgstr "" - -#. module: account_move_protect_reset_to_draft -#. odoo-python -#: code:addons/account_move_protect_reset_to_draft/models/account_move.py:0 -#, python-format -msgid "" -"You cannot reset to draft this invoice because it has been sent by email." -msgstr "" diff --git a/account_move_protect_reset_to_draft/models/__init__.py b/account_move_protect_reset_to_draft/models/__init__.py deleted file mode 100644 index 4c89822..0000000 --- a/account_move_protect_reset_to_draft/models/__init__.py +++ /dev/null @@ -1 +0,0 @@ -from . import account_move \ No newline at end of file diff --git a/account_move_protect_reset_to_draft/models/account_move.py b/account_move_protect_reset_to_draft/models/account_move.py deleted file mode 100644 index e622cd4..0000000 --- a/account_move_protect_reset_to_draft/models/account_move.py +++ /dev/null @@ -1,15 +0,0 @@ -from odoo import models, api, _, fields -from odoo.exceptions import UserError - -class AccountMove(models.Model): - _inherit = 'account.move' - - sent_by_email = fields.Boolean() - - def button_draft(self): - res = super(AccountMove, self).button_draft() - if self.sent_by_email: - raise UserError(_( - "You cannot reset to draft this invoice because it has been sent by email." - )) - return res -- 2.49.1 From 288e9dd7ea93e6718694919694d75de49be400a2 Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Thu, 21 Aug 2025 18:29:16 +0200 Subject: [PATCH 2/8] [IMP] account_advanced_protection_features: be able to manage prevent_reset_to_draft_sent_invoice option in sale journals --- .../__manifest__.py | 1 + .../models/__init__.py | 3 ++- .../models/account_journal.py | 6 ++++++ .../models/account_move.py | 2 +- .../views/account_journal_views.xml | 16 ++++++++++++++++ 5 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 account_advanced_protection_features/models/account_journal.py create mode 100644 account_advanced_protection_features/views/account_journal_views.xml diff --git a/account_advanced_protection_features/__manifest__.py b/account_advanced_protection_features/__manifest__.py index e8f24f7..fc596f8 100644 --- a/account_advanced_protection_features/__manifest__.py +++ b/account_advanced_protection_features/__manifest__.py @@ -21,6 +21,7 @@ }, # always loaded "data": [ + "views/account_journal_views.xml" ], # only loaded in demonstration mode "demo": [], diff --git a/account_advanced_protection_features/models/__init__.py b/account_advanced_protection_features/models/__init__.py index 4c89822..ea6d653 100644 --- a/account_advanced_protection_features/models/__init__.py +++ b/account_advanced_protection_features/models/__init__.py @@ -1 +1,2 @@ -from . import account_move \ No newline at end of file +from . import account_move +from . import account_journal diff --git a/account_advanced_protection_features/models/account_journal.py b/account_advanced_protection_features/models/account_journal.py new file mode 100644 index 0000000..07dc21a --- /dev/null +++ b/account_advanced_protection_features/models/account_journal.py @@ -0,0 +1,6 @@ +from odoo import models, fields + +class AccountJournal(models.Model): + _inherit = "account.journal" + + prevent_reset_to_draft_sent_invoice = fields.Boolean("Prevent to reset to draft a sent invoice") diff --git a/account_advanced_protection_features/models/account_move.py b/account_advanced_protection_features/models/account_move.py index 3e5d722..9ce757d 100644 --- a/account_advanced_protection_features/models/account_move.py +++ b/account_advanced_protection_features/models/account_move.py @@ -8,7 +8,7 @@ class AccountMove(models.Model): def button_draft(self): res = super(AccountMove, self).button_draft() - if self.sent_by_email: + if self.sent_by_email and self.journal_id.prevent_reset_to_draft_sent_invoice: raise UserError(_( "You cannot reset to draft this invoice because it has been sent by email." )) diff --git a/account_advanced_protection_features/views/account_journal_views.xml b/account_advanced_protection_features/views/account_journal_views.xml new file mode 100644 index 0000000..2541acf --- /dev/null +++ b/account_advanced_protection_features/views/account_journal_views.xml @@ -0,0 +1,16 @@ + + + + account.journal.form + account.journal + + + + + + + + -- 2.49.1 From a0ab4f96bddf3a647d862884afa422ae58212ffc Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Thu, 21 Aug 2025 18:43:17 +0200 Subject: [PATCH 3/8] [IMP] account_advanced_protection_features: be able to manage prevent_deletion_of_posted_account_move option in journals --- .../i18n/fr.po | 69 ++++++++++++------- .../models/account_journal.py | 1 + .../models/account_move.py | 8 ++- .../views/account_journal_views.xml | 3 + 4 files changed, 53 insertions(+), 28 deletions(-) diff --git a/account_advanced_protection_features/i18n/fr.po b/account_advanced_protection_features/i18n/fr.po index 0def132..bcf1711 100644 --- a/account_advanced_protection_features/i18n/fr.po +++ b/account_advanced_protection_features/i18n/fr.po @@ -6,8 +6,8 @@ msgid "" msgstr "" "Project-Id-Version: Odoo Server 16.0\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2024-03-26 13:13+0000\n" -"PO-Revision-Date: 2024-03-26 13:13+0000\n" +"POT-Creation-Date: 2025-08-21 16:39+0000\n" +"PO-Revision-Date: 2025-08-21 16:39+0000\n" "Last-Translator: \n" "Language-Team: \n" "MIME-Version: 1.0\n" @@ -15,35 +15,54 @@ msgstr "" "Content-Transfer-Encoding: \n" "Plural-Forms: \n" -#. module: account_move_protect_deleting -#. odoo-python -#: code:addons/account_move_protect_deleting/models/account_move.py:0 -#, python-format -msgid "You cannot delete this account move because it has been posted." -msgstr "Vous ne pouvez pas supprimer cette pièce comptable car elle à déjà été confirmée." +#. module: account_advanced_protection_features +#: model:ir.model,name:account_advanced_protection_features.model_account_journal +msgid "Journal" +msgstr "" - -#. module: account_move_protect_reset_to_draft -#: model:ir.model,name:account_move_protect_reset_to_draft.model_account_invoice_send -msgid "Account Invoice Send" -msgstr "Facture du compte envoyée" - -#. module: account_move_protect_reset_to_draft -#: model:ir.model,name:account_move_protect_reset_to_draft.model_account_move +#. module: account_advanced_protection_features +#: model:ir.model,name:account_advanced_protection_features.model_account_move msgid "Journal Entry" msgstr "Pièce comptable" -#. module: account_move_protect_reset_to_draft -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_bank_statement_line__sent_by_email -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_move__sent_by_email -#: model:ir.model.fields,field_description:account_move_protect_reset_to_draft.field_account_payment__sent_by_email -msgid "Sent By Email" -msgstr "Envoyé par email" +#. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__prevent_deletion_of_posted_account_move +msgid "Prevent to delete an already posted account move" +msgstr "Empêcher la suppression des pièces comptables déjà confirmées" -#. module: account_move_protect_reset_to_draft +#. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__prevent_reset_to_draft_sent_invoice +msgid "Prevent to reset to draft a sent invoice" +msgstr "Empêcher la remise en brouillon d'une facture envoyée" + +#. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_bank_statement_line__sent_by_email +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_move__sent_by_email +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_payment__sent_by_email +msgid "Sent By Email" +msgstr "Envoyée par email" + +#. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__smart_search +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_move__smart_search +msgid "Smart Search" +msgstr "" + +#. module: account_advanced_protection_features #. odoo-python -#: code:addons/account_move_protect_reset_to_draft/models/account_move.py:0 +#: code:addons/account_advanced_protection_features/models/account_move.py:0 +#, python-format +msgid "You cannot delete this account move because it has been posted." +msgstr "" +"Vous ne pouvez pas supprimer cette pièce comptable car elle à déjà été " +"confirmée." + +#. module: account_advanced_protection_features +#. odoo-python +#: code:addons/account_advanced_protection_features/models/account_move.py:0 #, python-format msgid "" "You cannot reset to draft this invoice because it has been sent by email." -msgstr "Vous ne pouvez pas remettre en brouillon cette facture parce qu'elle a déjà été envoyée par email au client." +msgstr "" +"Vous ne pouvez pas remettre en brouillon cette facture parce qu'elle a déjà " +"été envoyée par email au client." diff --git a/account_advanced_protection_features/models/account_journal.py b/account_advanced_protection_features/models/account_journal.py index 07dc21a..5bd793e 100644 --- a/account_advanced_protection_features/models/account_journal.py +++ b/account_advanced_protection_features/models/account_journal.py @@ -4,3 +4,4 @@ class AccountJournal(models.Model): _inherit = "account.journal" prevent_reset_to_draft_sent_invoice = fields.Boolean("Prevent to reset to draft a sent invoice") + prevent_deletion_of_posted_account_move = fields.Boolean("Prevent to delete an already posted account move") diff --git a/account_advanced_protection_features/models/account_move.py b/account_advanced_protection_features/models/account_move.py index 9ce757d..7c8f09b 100644 --- a/account_advanced_protection_features/models/account_move.py +++ b/account_advanced_protection_features/models/account_move.py @@ -16,12 +16,14 @@ class AccountMove(models.Model): @api.ondelete(at_uninstall=False) def _check_posted(self): - """ Prevent deletion of a account move if it has been posted - exeptions : Check deposit or Cash deposit. In V16 in odoo the account move is deleted + """ Prevent deletion of an account move if it has been posted + exceptions : Check deposit or Cash deposit. In V16 in odoo the account move is deleted when the check deposit is reset to draft. This work the same with Cash deposit """ for rec in self: + if not rec.journal_id.prevent_deletion_of_posted_account_move: + continue is_cash_deposit = False is_check_deposit = False @@ -30,7 +32,7 @@ class AccountMove(models.Model): if rec.env.get('account.cash.deposit'): for cash_deposit in rec.env['account.cash.deposit'].search([]): if cash_deposit.move_id == rec: - print (cash_deposit.move_id, rec) + print(cash_deposit.move_id, rec) is_cash_deposit = True # # search in account.check.deposit if account move is this one diff --git a/account_advanced_protection_features/views/account_journal_views.xml b/account_advanced_protection_features/views/account_journal_views.xml index 2541acf..d5d1f67 100644 --- a/account_advanced_protection_features/views/account_journal_views.xml +++ b/account_advanced_protection_features/views/account_journal_views.xml @@ -6,6 +6,9 @@ + Date: Fri, 22 Aug 2025 10:04:49 +0200 Subject: [PATCH 4/8] [IMP] account_advanced_protection_features: manage allow_bank_statement_deletion in cash and bank journals --- .../models/__init__.py | 1 + .../models/account_bank_statement.py | 13 +++++++++++++ .../models/account_journal.py | 1 + .../views/account_journal_views.xml | 4 ++++ 4 files changed, 19 insertions(+) create mode 100644 account_advanced_protection_features/models/account_bank_statement.py diff --git a/account_advanced_protection_features/models/__init__.py b/account_advanced_protection_features/models/__init__.py index ea6d653..c5a0293 100644 --- a/account_advanced_protection_features/models/__init__.py +++ b/account_advanced_protection_features/models/__init__.py @@ -1,2 +1,3 @@ from . import account_move from . import account_journal +from . import account_bank_statement diff --git a/account_advanced_protection_features/models/account_bank_statement.py b/account_advanced_protection_features/models/account_bank_statement.py new file mode 100644 index 0000000..e867a00 --- /dev/null +++ b/account_advanced_protection_features/models/account_bank_statement.py @@ -0,0 +1,13 @@ +from odoo import models, _ +from odoo.exceptions import UserError + +class AccountBankStatement(models.Model): + _inherit = "account.bank.statement" + + def unlink(self): + for statement in self: + if not statement.journal_id.allow_bank_statement_deletion: + raise UserError( + _(f"The deletion of bank statements is not allowed for the journal {statement.journal_id.display_name}.") + ) + return super(AccountBankStatement, self).unlink() diff --git a/account_advanced_protection_features/models/account_journal.py b/account_advanced_protection_features/models/account_journal.py index 5bd793e..9a2c628 100644 --- a/account_advanced_protection_features/models/account_journal.py +++ b/account_advanced_protection_features/models/account_journal.py @@ -5,3 +5,4 @@ class AccountJournal(models.Model): prevent_reset_to_draft_sent_invoice = fields.Boolean("Prevent to reset to draft a sent invoice") prevent_deletion_of_posted_account_move = fields.Boolean("Prevent to delete an already posted account move") + allow_bank_statement_deletion = fields.Boolean("Allow bank statement deletion") diff --git a/account_advanced_protection_features/views/account_journal_views.xml b/account_advanced_protection_features/views/account_journal_views.xml index d5d1f67..28a0832 100644 --- a/account_advanced_protection_features/views/account_journal_views.xml +++ b/account_advanced_protection_features/views/account_journal_views.xml @@ -13,6 +13,10 @@ name="prevent_reset_to_draft_sent_invoice" attrs="{'invisible': [('type', '!=', 'sale')]}" /> + -- 2.49.1 From 581589afc88250a1c7518f032371bb066a036f44 Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Fri, 22 Aug 2025 10:25:31 +0200 Subject: [PATCH 5/8] [IMP] account_advanced_protection_features: remove group group_account_super_user and create group_account_protection_manager which gives access to protection features --- .../__manifest__.py | 1 + .../i18n/fr.po | 20 +++++++++++++++++-- .../security/res_groups.xml | 7 +++++++ .../views/account_journal_views.xml | 3 +++ account_usability_misc/__manifest__.py | 2 -- .../security/ir.model.access.csv | 5 ----- .../security/res_groups.xml | 8 -------- 7 files changed, 29 insertions(+), 17 deletions(-) create mode 100644 account_advanced_protection_features/security/res_groups.xml delete mode 100644 account_usability_misc/security/ir.model.access.csv delete mode 100644 account_usability_misc/security/res_groups.xml diff --git a/account_advanced_protection_features/__manifest__.py b/account_advanced_protection_features/__manifest__.py index fc596f8..ac5740f 100644 --- a/account_advanced_protection_features/__manifest__.py +++ b/account_advanced_protection_features/__manifest__.py @@ -21,6 +21,7 @@ }, # always loaded "data": [ + "security/res_groups.xml", "views/account_journal_views.xml" ], # only loaded in demonstration mode diff --git a/account_advanced_protection_features/i18n/fr.po b/account_advanced_protection_features/i18n/fr.po index bcf1711..775e91b 100644 --- a/account_advanced_protection_features/i18n/fr.po +++ b/account_advanced_protection_features/i18n/fr.po @@ -6,8 +6,8 @@ msgid "" msgstr "" "Project-Id-Version: Odoo Server 16.0\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2025-08-21 16:39+0000\n" -"PO-Revision-Date: 2025-08-21 16:39+0000\n" +"POT-Creation-Date: 2025-08-22 08:18+0000\n" +"PO-Revision-Date: 2025-08-22 08:18+0000\n" "Last-Translator: \n" "Language-Team: \n" "MIME-Version: 1.0\n" @@ -15,6 +15,21 @@ msgstr "" "Content-Transfer-Encoding: \n" "Plural-Forms: \n" +#. module: account_advanced_protection_features +#: model:res.groups,name:account_advanced_protection_features.group_account_advanced_manager +msgid "Access to account advanced protection features" +msgstr "Accès aux fonctionnalités avancées de protection des journaux" + +#. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__allow_bank_statement_deletion +msgid "Allow bank statement deletion" +msgstr "Autoriser la suppression de relevé bancaire" + +#. module: account_advanced_protection_features +#: model:ir.model,name:account_advanced_protection_features.model_account_bank_statement +msgid "Bank Statement" +msgstr "Relevé bancaire" + #. module: account_advanced_protection_features #: model:ir.model,name:account_advanced_protection_features.model_account_journal msgid "Journal" @@ -43,6 +58,7 @@ msgid "Sent By Email" msgstr "Envoyée par email" #. module: account_advanced_protection_features +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_bank_statement__smart_search #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__smart_search #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_move__smart_search msgid "Smart Search" diff --git a/account_advanced_protection_features/security/res_groups.xml b/account_advanced_protection_features/security/res_groups.xml new file mode 100644 index 0000000..542f970 --- /dev/null +++ b/account_advanced_protection_features/security/res_groups.xml @@ -0,0 +1,7 @@ + + + + Access to account advanced protection features + + + diff --git a/account_advanced_protection_features/views/account_journal_views.xml b/account_advanced_protection_features/views/account_journal_views.xml index 28a0832..4e3b367 100644 --- a/account_advanced_protection_features/views/account_journal_views.xml +++ b/account_advanced_protection_features/views/account_journal_views.xml @@ -8,13 +8,16 @@ diff --git a/account_usability_misc/__manifest__.py b/account_usability_misc/__manifest__.py index fe72668..664c96f 100644 --- a/account_usability_misc/__manifest__.py +++ b/account_usability_misc/__manifest__.py @@ -14,8 +14,6 @@ 'account_statement_base', ], 'data': [ - 'security/res_groups.xml', - 'security/ir.model.access.csv', 'views/account_search.xml', 'views/account_tree_view.xml', 'views/bank_statement_line_views.xml', diff --git a/account_usability_misc/security/ir.model.access.csv b/account_usability_misc/security/ir.model.access.csv deleted file mode 100644 index 06be173..0000000 --- a/account_usability_misc/security/ir.model.access.csv +++ /dev/null @@ -1,5 +0,0 @@ -id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink -account.access_account_bank_statement,account.bank.statement,account.model_account_bank_statement,account.group_account_user,1,1,1,0 -account.access_account_bank_statement_line,account.bank.statement.line,account.model_account_bank_statement_line,account.group_account_user,1,1,1,0 -access_account_bank_statement,account.bank.statement,account.model_account_bank_statement,group_account_super_user,1,1,1,1 -access_account_bank_statement_line,account.bank.statement.line,account.model_account_bank_statement_line,group_account_super_user,1,1,1,1 \ No newline at end of file diff --git a/account_usability_misc/security/res_groups.xml b/account_usability_misc/security/res_groups.xml deleted file mode 100644 index cf400ae..0000000 --- a/account_usability_misc/security/res_groups.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - Right to delete bank statement and bank statement lines - - - - \ No newline at end of file -- 2.49.1 From 2bef8b4e0c76e889ec2e3d2557cc8d91fe71c717 Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Fri, 29 Aug 2025 09:26:42 +0200 Subject: [PATCH 6/8] [IMP] account_advanced_protection_features: use is_move_sent field to prevent_reset_to_draft_sent_invoice --- .../models/account_move.py | 7 ++----- .../wizard/__init__.py | 1 - .../wizard/account_invoice_send.py | 14 -------------- 3 files changed, 2 insertions(+), 20 deletions(-) delete mode 100644 account_advanced_protection_features/wizard/__init__.py delete mode 100644 account_advanced_protection_features/wizard/account_invoice_send.py diff --git a/account_advanced_protection_features/models/account_move.py b/account_advanced_protection_features/models/account_move.py index 7c8f09b..417e5af 100644 --- a/account_advanced_protection_features/models/account_move.py +++ b/account_advanced_protection_features/models/account_move.py @@ -4,15 +4,12 @@ from odoo.exceptions import UserError class AccountMove(models.Model): _inherit = 'account.move' - sent_by_email = fields.Boolean() - def button_draft(self): - res = super(AccountMove, self).button_draft() - if self.sent_by_email and self.journal_id.prevent_reset_to_draft_sent_invoice: + if self.is_move_sent and self.journal_id.prevent_reset_to_draft_sent_invoice: raise UserError(_( "You cannot reset to draft this invoice because it has been sent by email." )) - return res + return super(AccountMove, self).button_draft() @api.ondelete(at_uninstall=False) def _check_posted(self): diff --git a/account_advanced_protection_features/wizard/__init__.py b/account_advanced_protection_features/wizard/__init__.py deleted file mode 100644 index 641fd38..0000000 --- a/account_advanced_protection_features/wizard/__init__.py +++ /dev/null @@ -1 +0,0 @@ -from . import account_invoice_send \ No newline at end of file diff --git a/account_advanced_protection_features/wizard/account_invoice_send.py b/account_advanced_protection_features/wizard/account_invoice_send.py deleted file mode 100644 index 8724798..0000000 --- a/account_advanced_protection_features/wizard/account_invoice_send.py +++ /dev/null @@ -1,14 +0,0 @@ -# -*- coding: utf-8 -*- - -from odoo import api, fields, models, _ - - -class AccountInvoiceSend(models.TransientModel): - _inherit = 'account.invoice.send' - - def send_and_print_action(self): - if self.model == "account.move": - move = self.env[self.model].browse(self.res_id) - move.sent_by_email = True - - return super(AccountInvoiceSend, self).send_and_print_action() -- 2.49.1 From e437d7fdf24bb1f0c3de4910784f0f2062545e07 Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Fri, 29 Aug 2025 10:36:33 +0200 Subject: [PATCH 7/8] [IMP] account_advanced_protection_features: control bank statement lines deletion with allow_bank_statement_deletion journal param --- .../i18n/fr.po | 48 ++++++++++++++----- .../models/account_bank_statement.py | 17 ++++++- .../models/account_journal.py | 6 ++- 3 files changed, 58 insertions(+), 13 deletions(-) diff --git a/account_advanced_protection_features/i18n/fr.po b/account_advanced_protection_features/i18n/fr.po index 775e91b..c223027 100644 --- a/account_advanced_protection_features/i18n/fr.po +++ b/account_advanced_protection_features/i18n/fr.po @@ -6,8 +6,8 @@ msgid "" msgstr "" "Project-Id-Version: Odoo Server 16.0\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2025-08-22 08:18+0000\n" -"PO-Revision-Date: 2025-08-22 08:18+0000\n" +"POT-Creation-Date: 2025-08-29 08:28+0000\n" +"PO-Revision-Date: 2025-08-29 08:28+0000\n" "Last-Translator: \n" "Language-Team: \n" "MIME-Version: 1.0\n" @@ -16,13 +16,13 @@ msgstr "" "Plural-Forms: \n" #. module: account_advanced_protection_features -#: model:res.groups,name:account_advanced_protection_features.group_account_advanced_manager +#: model:res.groups,name:account_advanced_protection_features.group_account_protection_manager msgid "Access to account advanced protection features" msgstr "Accès aux fonctionnalités avancées de protection des journaux" #. module: account_advanced_protection_features #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__allow_bank_statement_deletion -msgid "Allow bank statement deletion" +msgid "Allow bank statements deletion" msgstr "Autoriser la suppression de relevé bancaire" #. module: account_advanced_protection_features @@ -30,6 +30,11 @@ msgstr "Autoriser la suppression de relevé bancaire" msgid "Bank Statement" msgstr "Relevé bancaire" +#. module: account_advanced_protection_features +#: model:ir.model,name:account_advanced_protection_features.model_account_bank_statement_line +msgid "Bank Statement Line" +msgstr "Ligne de relevé de compte" + #. module: account_advanced_protection_features #: model:ir.model,name:account_advanced_protection_features.model_account_journal msgid "Journal" @@ -50,20 +55,41 @@ msgstr "Empêcher la suppression des pièces comptables déjà confirmées" msgid "Prevent to reset to draft a sent invoice" msgstr "Empêcher la remise en brouillon d'une facture envoyée" -#. module: account_advanced_protection_features -#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_bank_statement_line__sent_by_email -#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_move__sent_by_email -#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_payment__sent_by_email -msgid "Sent By Email" -msgstr "Envoyée par email" - #. module: account_advanced_protection_features #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_bank_statement__smart_search +#: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_bank_statement_line__smart_search #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_journal__smart_search #: model:ir.model.fields,field_description:account_advanced_protection_features.field_account_move__smart_search msgid "Smart Search" msgstr "" +#. module: account_advanced_protection_features +#. odoo-python +#: code:addons/account_advanced_protection_features/models/account_bank_statement.py:0 +#, python-format +msgid "" +"The deletion of bank statement lines is not allowed for the journal %s." +msgstr "" +"La suppression des lignes de relevé bancaire n'est pas autorisée pour le journal %s." + +#. module: account_advanced_protection_features +#. odoo-python +#: code:addons/account_advanced_protection_features/models/account_bank_statement.py:0 +#, python-format +msgid "The deletion of bank statements is not allowed for the journal %s." +msgstr "" +"La suppression des relevés bancaires n'est pas autorisée pour le journal %s." + +#. module: account_advanced_protection_features +#: model:ir.model.fields,help:account_advanced_protection_features.field_account_journal__allow_bank_statement_deletion +msgid "" +"Users with group Show Full Accounting Features (id: group_account_user) will" +" be allowed to delete account bank statements and bank statement lines." +msgstr "" +"Les utilisateurs avec le groupe 'Montrer les fonctions de comptabilité " +"complètes' seront autorisés à supprimer les relevés bancaires ainsi que les " +"lignes de relevés bancaires." + #. module: account_advanced_protection_features #. odoo-python #: code:addons/account_advanced_protection_features/models/account_move.py:0 diff --git a/account_advanced_protection_features/models/account_bank_statement.py b/account_advanced_protection_features/models/account_bank_statement.py index e867a00..79093b3 100644 --- a/account_advanced_protection_features/models/account_bank_statement.py +++ b/account_advanced_protection_features/models/account_bank_statement.py @@ -8,6 +8,21 @@ class AccountBankStatement(models.Model): for statement in self: if not statement.journal_id.allow_bank_statement_deletion: raise UserError( - _(f"The deletion of bank statements is not allowed for the journal {statement.journal_id.display_name}.") + _("The deletion of bank statements is not allowed for the journal %s.") % statement.journal_id.display_name ) + # we delete all the statement lines before deleting the statement itself + for line in statement.line_ids: + line.unlink() return super(AccountBankStatement, self).unlink() + + +class AccountBankStatementLine(models.Model): + _inherit = "account.bank.statement.line" + + def unlink(self): + for line in self: + if not line.journal_id.allow_bank_statement_deletion: + raise UserError( + _("The deletion of bank statement lines is not allowed for the journal %s.") % line.journal_id.display_name + ) + return super(AccountBankStatementLine, self).unlink() diff --git a/account_advanced_protection_features/models/account_journal.py b/account_advanced_protection_features/models/account_journal.py index 9a2c628..94755d2 100644 --- a/account_advanced_protection_features/models/account_journal.py +++ b/account_advanced_protection_features/models/account_journal.py @@ -5,4 +5,8 @@ class AccountJournal(models.Model): prevent_reset_to_draft_sent_invoice = fields.Boolean("Prevent to reset to draft a sent invoice") prevent_deletion_of_posted_account_move = fields.Boolean("Prevent to delete an already posted account move") - allow_bank_statement_deletion = fields.Boolean("Allow bank statement deletion") + allow_bank_statement_deletion = fields.Boolean( + "Allow bank statements deletion", + help="Users with group Show Full Accounting Features (id: group_account_user) will be allowed to delete account bank statements " + "and bank statement lines." + ) -- 2.49.1 From 8d2c01953a081330c38fd5f11c92d3d108dec974 Mon Sep 17 00:00:00 2001 From: Quentin Mondot Date: Mon, 15 Sep 2025 12:54:21 +0200 Subject: [PATCH 8/8] [IMP] account_advanced_protection_features : remove exceptions about cash and check deposits when trying to delete an posted account move --- .../README.rst | 2 + .../models/account_move.py | 37 +++---------------- 2 files changed, 7 insertions(+), 32 deletions(-) diff --git a/account_advanced_protection_features/README.rst b/account_advanced_protection_features/README.rst index 9cef227..a172b41 100644 --- a/account_advanced_protection_features/README.rst +++ b/account_advanced_protection_features/README.rst @@ -5,6 +5,7 @@ account_advanced_protection_features This module adds several protection features about accounting : * Forbid to delete an invoice that has already been validated * Forbid to reset to draft an invoice that has already been sent by email +* Allow bank statements and bank statement lines deletion Installation ============ @@ -31,6 +32,7 @@ Credits Contributors ------------ +* Laetitia Da Costa (https://github.com/LaetitiaElabore) * Boris Gallet - `Email` - `Github` * Clément Thomas * Quentin Mondot - `Email` - `Github` diff --git a/account_advanced_protection_features/models/account_move.py b/account_advanced_protection_features/models/account_move.py index 417e5af..ebb091d 100644 --- a/account_advanced_protection_features/models/account_move.py +++ b/account_advanced_protection_features/models/account_move.py @@ -13,38 +13,11 @@ class AccountMove(models.Model): @api.ondelete(at_uninstall=False) def _check_posted(self): - """ Prevent deletion of an account move if it has been posted - exceptions : Check deposit or Cash deposit. In V16 in odoo the account move is deleted - when the check deposit is reset to draft. - This work the same with Cash deposit + """ Prevent deletion of an account move if it has already been posted and + journal parameter prevent_deletion_of_posted_account_move is activated """ for rec in self: - if not rec.journal_id.prevent_deletion_of_posted_account_move: - continue - - is_cash_deposit = False - is_check_deposit = False - - # search in account.cash.deposit if account move is this one - if rec.env.get('account.cash.deposit'): - for cash_deposit in rec.env['account.cash.deposit'].search([]): - if cash_deposit.move_id == rec: - print(cash_deposit.move_id, rec) - is_cash_deposit = True - - # # search in account.check.deposit if account move is this one - if rec.env.get('account.check.deposit'): - for check_deposit in rec.env['account.check.deposit'].search([]): - if check_deposit.move_id == rec: - is_check_deposit = True - - if ( - rec.posted_before and - ( - not is_cash_deposit - and not is_check_deposit - ) - ): - raise UserError(_("" - "You cannot delete this account move because it has been posted." + if rec.posted_before and rec.journal_id.prevent_deletion_of_posted_account_move: + raise UserError(_( + "You cannot delete this account move because it has already been posted." )) -- 2.49.1