diff --git a/account_advanced_protection_features/models/account_bank_statement.py b/account_advanced_protection_features/models/account_bank_statement.py index 3f5c472..798363b 100644 --- a/account_advanced_protection_features/models/account_bank_statement.py +++ b/account_advanced_protection_features/models/account_bank_statement.py @@ -19,6 +19,7 @@ class AccountBankStatement(models.Model): class AccountBankStatementLine(models.Model): _inherit = "account.bank.statement.line" + # This function is called when a user opens the form to create a new bank statement line @api.model def default_get(self, fields_list): res = super().default_get(fields_list) @@ -32,19 +33,6 @@ class AccountBankStatementLine(models.Model): ) return res - @api.model_create_multi - def create(self, vals_list): - for vals in vals_list: - journal_id = vals.get("journal_id") - if journal_id: - journal = self.env["account.journal"].browse(journal_id) - if not journal.allow_bank_statement_line_creation: - raise UserError( - _("Manual creation of bank statement lines is not allowed for the journal %s.") - % journal.display_name - ) - return super().create(vals_list) - def unlink(self): for line in self: if not line.journal_id.allow_bank_statement_deletion: diff --git a/account_advanced_protection_features/tests/test_account_bank_statement.py b/account_advanced_protection_features/tests/test_account_bank_statement.py index ba547b2..657297d 100644 --- a/account_advanced_protection_features/tests/test_account_bank_statement.py +++ b/account_advanced_protection_features/tests/test_account_bank_statement.py @@ -23,18 +23,6 @@ class TestBankStatementLineCreation(TransactionCase): default_journal_id=self.bank_journal.id ).default_get(["journal_id", "amount", "payment_ref"]) - def test_create_blocks_creation_when_not_allowed(self): - """Test that create raises UserError when creation is not allowed.""" - self.bank_journal.allow_bank_statement_line_creation = False - - with self.assertRaises(UserError): - self.env["account.bank.statement.line"].create({ - "journal_id": self.bank_journal.id, - "amount": 100.0, - "payment_ref": "Test", - "date": "2024-01-01", - }) - def test_default_get_allows_creation_when_allowed(self): """Test that default_get works when creation is allowed.""" self.bank_journal.allow_bank_statement_line_creation = True @@ -45,16 +33,3 @@ class TestBankStatementLineCreation(TransactionCase): ).default_get(["journal_id", "amount", "payment_ref"]) self.assertIsInstance(result, dict) - - def test_create_allows_creation_when_allowed(self): - """Test that create works when creation is allowed.""" - self.bank_journal.allow_bank_statement_line_creation = True - - line = self.env["account.bank.statement.line"].create({ - "journal_id": self.bank_journal.id, - "amount": 100.0, - "payment_ref": "Test", - "date": "2024-01-01", - }) - - self.assertTrue(line.exists()) diff --git a/account_usability_misc/README.rst b/account_usability_misc/README.rst index 02b8169..333bcf9 100644 --- a/account_usability_misc/README.rst +++ b/account_usability_misc/README.rst @@ -13,11 +13,9 @@ Use Odoo normal module installation procedure to install Description =========== -- Removes the right to unlink bank statements and bank statement lines for all users - Changes some french translation - On reconcile view : filter account move lines by defaut with journal type -- Hide Create button in Bank Statement tree view -- Create a technical group with unlink righ on bank statements and bank statement lines +- On bills list view (i.e factures fournisseurs) : add the column Message attachment count (i.e nombre de pièces jointes) Known issues / Roadmap ====================== diff --git a/account_usability_misc/__manifest__.py b/account_usability_misc/__manifest__.py index 664c96f..cac53d2 100644 --- a/account_usability_misc/__manifest__.py +++ b/account_usability_misc/__manifest__.py @@ -10,14 +10,11 @@ 'depends': [ 'account', 'base', - 'account_reconcile_oca', - 'account_statement_base', + 'account_reconcile_oca' ], 'data': [ 'views/account_search.xml', - 'views/account_tree_view.xml', - 'views/bank_statement_line_views.xml', - 'views/bank_statement_views.xml', + 'views/account_tree_view.xml' ], 'installable': True, 'auto_install': False, diff --git a/account_usability_misc/views/bank_statement_line_views.xml b/account_usability_misc/views/bank_statement_line_views.xml deleted file mode 100644 index 5400d71..0000000 --- a/account_usability_misc/views/bank_statement_line_views.xml +++ /dev/null @@ -1,32 +0,0 @@ - - - - - - - - account.bank.statement.line.tree.inherit.hide.create - account.bank.statement.line - - - - false - - - - - - - - account.bank.statement.line.kanban.inherit.hide.create - account.bank.statement.line - - - - false - - - - - - diff --git a/account_usability_misc/views/bank_statement_views.xml b/account_usability_misc/views/bank_statement_views.xml deleted file mode 100644 index 5349dea..0000000 --- a/account_usability_misc/views/bank_statement_views.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - account.bank.statement.tree - account.bank.statement - - - - false - - - - \ No newline at end of file