From 803ae858ea6e749eba77320f14913c8ad20aec69 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phan=20Sainl=C3=A9ger?=
 <contact@stephansainleger.fr>
Date: Fri, 7 Aug 2026 10:35:59 +0200
Subject: [PATCH] [REM] pre_upgrade: delete obsolete ``contract_payment_mode``
 before 18.0 load

``contract_payment_mode`` v18 still depends on ``account_payment_partner``
(removed by the bank-payment renaming) and uses the obsolete
``account.payment.mode`` model; no v18 replacement provides contract
integration, and only 2 contracts carried a ``payment_mode_id``.

Must run BEFORE the bank-payment renaming and BEFORE OpenUpgrade's
``button_upgrade()`` which would otherwise crash on the missing
dependency.

The module is DELETED (module row + ``ir_model_data`` + dependencies)
rather than marked 'to remove', because Odoo's "Transient module states
were reset" in ``load_modules()`` converts 'to remove' -> 'installed',
making ``button_upgrade()`` re-parse the missing
``account_payment_partner`` dependency and abort the registry load. The
orphaned ``base.module_contract_payment_mode`` xmlid is renamed so
``update_list()`` rediscovers the physical addon as a fresh uninstalled
module that ``button_upgrade()`` never touches.
---
 versions/18.0/pre_upgrade.sh | 50 ++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/versions/18.0/pre_upgrade.sh b/versions/18.0/pre_upgrade.sh
index 2f63d87..316ff33 100755
--- a/versions/18.0/pre_upgrade.sh
+++ b/versions/18.0/pre_upgrade.sh
@@ -6,6 +6,56 @@ echo "Prepare migration to 18.0..."
 # Copy database
 copy_database ou17 ou18 ou18 || exit 1
 
+# ============================================================================
+# REMOVE contract_payment_mode (depends on obsolete account_payment_partner)
+#
+# contract_payment_mode v18 still depends on account_payment_partner (deleted
+# by the bank-payment renaming below) and uses the obsolete account.payment.mode
+# model. No v18 replacement exists — account_payment_base_oca provides no
+# contract integration. Only 2 contracts had payment_mode_id set, and the
+# migration to the new payment.method.line model is not supported.
+#
+# MUST run BEFORE the bank-payment renaming and BEFORE OpenUpgrade's
+# button_upgrade() which would otherwise crash on the missing dependency.
+#
+# We DELETE the module entirely (like the bank-payment merged_modules pattern)
+# rather than marking it 'to remove', because Odoo's "Transient module states
+# were reset" in load_modules() converts 'to remove' -> 'installed', causing
+# button_upgrade() to re-parse the missing account_payment_partner dependency
+# and abort the registry load. Deleting the row + ir_model_data + dependencies
+# ensures OpenUpgrade's update_list() rediscovers the physical addon as a fresh
+# 'uninstalled' module that button_upgrade() never touches.
+# ============================================================================
+contract_payment_mode_sql=$(cat <<'EOF'
+DO $$
+DECLARE
+    mod_id INTEGER;
+BEGIN
+    SELECT id INTO mod_id FROM ir_module_module WHERE name = 'contract_payment_mode';
+    IF mod_id IS NOT NULL THEN
+        DELETE FROM ir_module_module_dependency WHERE module_id = mod_id;
+        DELETE FROM ir_model_data WHERE module = 'contract_payment_mode';
+        DELETE FROM ir_module_module WHERE id = mod_id;
+
+        -- Rename the module's own external ID (base.module_contract_payment_mode)
+        -- so update_list() can rediscover the physical contract_payment_mode addon
+        -- (which still exists in v18 addons path) without conflicting on
+        -- (base, module_contract_payment_mode). The orphaned xmlid pointed to
+        -- the deleted ir.module.module row and has no other references.
+        UPDATE ir_model_data
+        SET name = 'module_contract_payment_mode_removed'
+        WHERE module = 'base' AND name = 'module_contract_payment_mode';
+
+        RAISE NOTICE 'Removed contract_payment_mode module (depends on obsolete account_payment_partner)';
+    ELSE
+        RAISE NOTICE 'contract_payment_mode not found, skipping';
+    END IF;
+END $$;
+EOF
+)
+echo "Removing contract_payment_mode module..."
+query_postgres_container "$contract_payment_mode_sql" ou18 || exit 1
+
 # ============================================================================
 # BANK-PAYMENT -> BANK-PAYMENT-ALTERNATIVE MODULE RENAMING
 # Migration from OCA/bank-payment to OCA/bank-payment-alternative